On 2015å¹´10æ02æ¥ 22:33, Heiko Stübner wrote:
> Hi Mark,
>
> Am Freitag, 26. Juni 2015, 09:27:18 schrieb Mark Yao:
>> We want to display a buffer allocated by other driver, need import
>> the buffer to gem.
>>
>> Signed-off-by: Mark Yao
> This looks inte
Hi Sjoerd
We double check this problem, yes, board will hang if aclk is disabled
when setting vop register.
Acked-by: Mark Yao
Thanks for this fix.
On 2015å¹´09æ29æ¥ 17:28, Sjoerd Simons wrote:
> When doing the initial setup both the hclk and the aclk need to be
> e
of_node_put(ep);
> - return ret ?: endpoint.id;
> - }
> - }
> -
> - return -EINVAL;
> -}
> -EXPORT_SYMBOL_GPL(rockchip_drm_encoder_get_mux_id);
> -
Dw-hdmi driver can reuse this fuction, so
Acked-by: Mark Yao
>
6:26 +0800)
--------
Mark Yao (6):
drm/rockchip: vop: Fix virtual stride calculation
drm/rockchip: vop: Fix window dest start point
drm/rockchip: vop: Add yuv plane support
drm/rockchip: vop: Default enable win2/3 area0 bit
dr
Win_full support 1/8 to 8 scale down/up engine, support
all format scale.
Signed-off-by: Mark Yao
---
Changes in v4:
Adviced by Tomasz Figa
- calcaute min/max scale with readable macro.
Changes in v3:
Adviced by Tomasz Figa
- remove unused code and unnecessary scale path.
- use static inline
The registers will be reset to default values when whole
power domain off, so restore registers from regsbak.
Signed-off-by: Mark Yao
---
Changes in v4: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip
Win2/3 support multiple area function, but we haven't found
a suitable way to use it yet, so let's just use them as other windows
with only area 0 enabled.
Signed-off-by: Mark Yao
---
Changes in v4: None
Changes in v3:
Adviced by Tomasz Figa
- fix patch comments.
Changes in v2: None
drivers
vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
Signed-off-by: Mark Yao
---
Changes in v4: rebase to drm-next, fix conflict
Changes in v3:
Adviced by Tomasz Figa
- separate dest calculate to another patch
- fix src x1,x2 when do align, and remove unnecessary src.y1 align.
Changes
Dest start point use crtc_x/y is wrong, crtc_x/y is not equal
to dest.x1/y1 at plane scale.
Signed-off-by: Mark Yao
---
Changes in v4: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip
vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.
Signed-off-by: Mark Yao
---
Changes in v4: None
Changes in v3:
Adviced by Tomasz Figa
- use more suitable tile for this patch.
Changes in v2: None
drivers/gpu/
Changes in v2:
- Uv buffer not support odd offset, align it.
- Fix error display when move yuv image.
- Fix scale dest info.
Mark Yao (6):
drm/rockchip: vop: Fix virtual stride calculation
drm/rockchip: vop: Fix window dest start point
drm/rockchip: vop: Add yuv plane support
drm/rockchip
On 2015å¹´07æ23æ¥ 05:51, Heiko Stübner wrote:
> Am Dienstag, 21. Juli 2015, 16:20:04 schrieb Mark Yao:
>> vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
>>
>> Signed-off-by: Mark Yao
>> ---
>> Changes in v3:
>> Adviced by Tomasz Figa
>&g
Win_full support 1/8 to 8 scale down/up engine, support
all format scale.
Signed-off-by: Mark Yao
---
Changes in v3:
Adviced by Tomasz Figa
- remove unused code and unnecessary scale path.
- use static inline funcion instead "#define", let gcc check the cast
- move same call into he
The registers will be reset to default values when whole
power domain off, so restore registers from regsbak.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu
Win2/3 support multiple area function, but we haven't found
a suitable way to use it yet, so let's just use them as other windows
with only area 0 enabled.
Signed-off-by: Mark Yao
---
Changes in v3:
Adviced by Tomasz Figa
- fix patch comments.
Changes in v2: None
drivers/gpu/drm/rockchip
vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
Signed-off-by: Mark Yao
---
Changes in v3:
Adviced by Tomasz Figa
- separate dest calculate to another patch
- fix src x1,x2 when do align, and remove unnecessary src.y1 align.
Changes in v2:
- Uv buffer not support odd offset, align
Dest start point use crtc_x/y is wrong, crtc_x/y is not equal
to dest.x1/y1 at plane scale.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers
vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.
Signed-off-by: Mark Yao
---
Changes in v3:
Adviced by Tomasz Figa
- use more suitable tile for this patch.
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vo
move yuv image.
- Fix scale dest info.
Mark Yao (6):
drm/rockchip: vop: Fix virtual stride calculation
drm/rockchip: vop: Fix window dest start point
drm/rockchip: vop: Add yuv plane support
drm/rockchip: vop: Default enable win2/3 area0 bit
drm/rockchip: vop: restore vop registers when
nd replace deprecated hooker
> Adviced by Daniel Vetter
> - Replace drm_platform_init with drm_dev_alloc/register
> Adviced by Daniel Vetter
>
> Changed in V6
>
> - Add NEC nl4827hc19_05b panel to panel-simple.c
> Adviced by Mark Yao
> - Add DRIVER_ATOMIC for driver_features
Hi Dave
Here is some fixes for rockchip drm, can you land them?
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power
(2015-06-26 10:26:37 +1000)
are available in the git repository at:
On 2015å¹´07æ10æ¥ 18:37, Krzysztof Kozlowski wrote:
> platform_driver does not need to set an owner because
> platform_driver_register() will set it.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
> Changes since v1:
> 1. Split owner removal from rockchip to separat
On 2015å¹´07æ10æ¥ 15:01, Krzysztof Kozlowski wrote:
> On 10.07.2015 15:50, Mark yao wrote:
>> On 2015å¹´07æ10æ¥ 13:36, Krzysztof Kozlowski wrote:
>>> i2c_driver does not need to set an owner because i2c_register_driver()
>>> will set it.
>>>
&g
On 2015å¹´07æ10æ¥ 13:36, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
>
> The coccinelle script which generated the patch was sent here:
>
On 2015å¹´07æ07æ¥ 20:04, Daniel Vetter wrote:
> On Tue, Jul 07, 2015 at 05:03:36PM +0800, Daniel Kurtz wrote:
>> Rather than (incompletely [0]) re-implementing drm_gem_mmap() and
>> drm_gem_mmap_obj() helpers, call them directly from the rockchip mmap
>> routines.
>>
>> Once the core functions
On 2015å¹´07æ03æ¥ 17:58, Tomasz Figa wrote:
>>> >>Aren't the scl_modes for CbCr planes always the same as for Y plane?
>> >
>> >
>> >No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12.
>> >so Y plane horizontal and vertical is scale down.
>> >
>> >but src_w = 1920 / 2 = 960 <
On 2015å¹´07æ03æ¥ 17:24, Tomasz Figa wrote:
> On Fri, Jul 3, 2015 at 5:19 PM, Mark yao wrote:
>> On 2015å¹´07æ03æ¥ 16:02, Tomasz Figa wrote:
>>> Hi Mark,
>>>
>>> Please see my comments inline.
>>>
>>> On Fri, Jun 26, 2015 at 7:10 PM, Ma
On 2015å¹´07æ03æ¥ 15:46, Tomasz Figa wrote:
> Hi Mark,
>
> Please see my comments inline.
>
> On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote:
>> Win_full support 1/8 to 8 scale down/up engine, support
>> all format scale.
> [snip]
>
>>
On 2015å¹´07æ03æ¥ 16:02, Tomasz Figa wrote:
> Hi Mark,
>
> Please see my comments inline.
>
> On Fri, Jun 26, 2015 at 7:10 PM, Mark Yao wrote:
>> Win2/3 support 4 area display, but now havn't found a suitable
>> way to use it, and it enable by win gate and area gate,
remove the hardware cursor window
Signed-off-by: Mark Yao
---
Changes in v2:
remove unused cursor_data struct.
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
On 2015å¹´07æ01æ¥ 19:52, Heiko Stübner wrote:
> Hi Mark,
>
> Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao:
>> hardware cursor windows only have some fixed size, and not support
>> width virtual, when move hardware cursor windows outside of left,
>> the
Hi Tomasz
Thanks for your review, I will fix it soon.
On 2015å¹´07æ02æ¥ 14:00, Tomasz Figa wrote:
> Hi Mark,
>
> Please see my comments inline.
>
> On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote:
>> vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
>>
On 2015å¹´07æ02æ¥ 12:59, Tomasz Figa wrote:
> On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote:
>> vir_stride need number words of the virtual width, and fb->pitches
>> save bytes_per_pixel, so just div 4 switch to stride.
>>
>> Signed-off-by: Mark Yao
remove the hardware cursor window
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 4603412..7373ba1 100644
--- a/drivers
On 2015å¹´07æ01æ¥ 16:42, Tomasz Figa wrote:
> On Wed, Jul 1, 2015 at 5:32 PM, Mark yao wrote:
>> On 2015å¹´07æ01æ¥ 16:03, Tomasz Figa wrote:
>>> Hi Mark,
>>>
>>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao
>>> wrote:
>>>> Hi Dave.
&
On 2015å¹´07æ01æ¥ 16:32, Tomasz Figa wrote:
> On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter wrote:
>> On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote:
>>> Hi Mark,
>>>
>>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao
>>> wrote:
>>
On 2015å¹´07æ01æ¥ 16:32, Mark yao wrote:
> On 2015å¹´07æ01æ¥ 16:03, Tomasz Figa wrote:
>> Hi Mark,
>>
>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao
>> wrote:
>>> Hi Dave.
>>>
>>> Some fixes and some new features. I'd like you can
On 2015å¹´07æ01æ¥ 16:03, Tomasz Figa wrote:
> Hi Mark,
>
> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote:
>> Hi Dave.
>>
>> Some fixes and some new features. I'd like you can pull them.
>>
>> The following changes since commit c5fd936e992dd28
On 2015å¹´06æ30æ¥ 18:01, Wang J.W. wrote:
> From: Jianwei Wang
>
> This patch add support for Two Dimensional Animation and Compositing Engine
> (2D-ACE) on the Freescale SoCs.
>
> 2D-ACE is a Freescale display controller. 2D-ACE describes the functionality
> of the module extremely well its
)
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
present
Mark Yao (6):
drm/rockchip: import dma_buf to gem
drm/rockchip: vop: optimize virtual stride calculate
drm/rockchip: vop: fix yuv plane support
drm/rockchip: vop: support
Win2/3 support 4 area display, but now havn't found a suitable
way to use it, and it enable by win gate and area gate,
so default enable area0 gate, so that its behaviour just like a
win.
Signed-off-by: Mark Yao
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |6
Window 1 support scale and yuv format, it's waste use it for a
cursor, use window 3 is enough.
Signed-off-by: Mark Yao
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip
Win_full support 1/8 to 8 scale down/up engine, support
all format scale.
Signed-off-by: Mark Yao
---
Changes in v2:
- Fix scale dest info.
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 389 ++-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 96 +++
2 files
vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
Signed-off-by: Mark Yao
Changes in v2:
- Uv buffer not support odd offset, align it.
- Fix error display when move yuv image.
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 63 ---
1 file changed, 57
vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.
Signed-off-by: Mark Yao
---
Changes in v2: None
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
This series patches are used for yuv image overlay display.
Rockchip vop support NV11, NV16, NV24 yuv format,
and can scale the image scale 1/8 to 8.
Changes in v2:
- Uv buffer not support odd offset, align it.
- Fix error display when move yuv image.
- Fix scale dest info.
Mark Yao (5
We want to display a buffer allocated by other driver, need import
the buffer to gem.
Signed-off-by: Mark Yao
---
Changes in v2:
Adviced by Russell King
- check sgt-nents == 1 when get iova from scatterlist
- remove unused dma_map_sg/dma_unmap_sg, dma_buf_map_attachment->map_dma_buf
should
Thanks Russell
On 2015å¹´06æ18æ¥ 18:57, Russell King - ARM Linux wrote:
> This is wrong.
>
> First, if you can only cope with a single scatterlist entry, you need to
> enforce that. You can do that in your gem_prime_import_sg_table() method
> by checking sgt->nents.
I'm confuse that how to get
Win2/3 support 4 area display, but now havn't found a suitable
way to use it, and it enable by win gate and area gate,
so default enable area0 gate, so that its behaviour just like a
win.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |6 ++
1 file changed, 6
Window 1 support scale and yuv format, it's waste use it for a
cursor, use window 3 is enough.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b
Win_full support 1/8 to 8 scale down/up engine, support
all format scale.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 390 ++-
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 96 +++
2 files changed, 483 insertions(+), 3 deletions
vop support yuv with NV12, NV16 and NV24, only 2 plane yuv.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 ++-
1 file changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm
vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockc
We want to display a buffer allocated by other driver, need import
the buffer to gem.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c |1 +
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 45 +--
drivers/gpu/drm/rockchip/rockchip_drm_gem.h
This series patches are used for yuv image overlay display.
Rockchip vop support NV11, NV16, NV24 yuv format,
and can scale the image scale 1/8 to 8.
Mark Yao (6):
drm/rockchip: import dma_buf to gem
drm/rockchip: vop: optimize virtual stride calculate
drm/rockchip: vop: fix yuv plane
On 2015å¹´06æ02æ¥ 22:41, Heiko Stübner wrote:
> Add a check for the presence of fb_helper to
> rockchip_drm_output_poll_changed()
> to only call drm_fb_helper_hotplug_event if there is actually a fb_helper
> available. Without this check I see NULL pointer dereferences when the
> hdmi hotplug
ttps://patchwork.kernel.org/patch/6369531/)
>> - Fixed register addresses for win2/3 and hwc (reported by Mark Yao).
> Gentle ping.
Applied to my drm-next:-)
> Best regards,
> Tomasz
>
>
>
--
ï¼ark Yao
On 2015å¹´05æ08æ¥ 16:49, Tomasz Figa wrote:
> Hi Mark,
>
> Thanks for review.
>
> On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote:
>>> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = {
>>> .nformats = ARRAY_SIZE(formats_234),
>>
Hi Tomasz
Thanks for the fix, but some register is wrong.
On 2015å¹´05æ08æ¥ 16:16, Tomasz Figa wrote:
> VOP can support BGR formats in all windows thanks to red/blue swap option
> provided in WINx_CTRL0 registers. This patch enables support for
> ABGR, XBGR, BGR888 and BGR565
On 2015å¹´04æ20æ¥ 13:34, Mark yao wrote:
> On 2015å¹´04æ19æ¥ 00:55, Heiko Stübner wrote:
>> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ãrjan Eide:
>>> Set vm_pgoff to 0 after using it to look up the GEM node, before
>>> passing
>>> it on rockchip_
>
> Tested-by: Heiko Stuebner
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>
>
>
On 2015å¹´04æ20æ¥ 07:00, Heiko Stübner wrote:
> platform_get_irq() can return negative error values and we already test for
> these. Therefore the variable holding this value should be signed to not
> loose possible error values.
>
> Reported-by: David Binderman
> Signed-off-by: Heiko
Hi Dave
I'm interesting to maintain the rockchip drm, so add entry for
Rockchip drm.
and some fixes.
Can you land them?
The following changes since commit aa219a0dd7774e2454a5687e7d38e947a131cdee:
Merge tag 'drm-intel-next-fixes-2015-04-15' of
):
drm: rockchip: Turn off VT switching on suspend
Daniel Kurtz (1):
drm/rockchip: register all connectors after bind
Heiko Stuebner (1):
drm/rockchip: fix clk enable disable mismatch in vop_crtc_mode_set
Mark Yao (1):
drm/rockchip: vop: add vop power domain support
From: Mark Yao <y...@rock-chips.com>
Reference the power domain incase vop power down when
in use.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drive
(1):
drm/rockchip: Only alloc a kmap for fbdev gem object
Mark Yao (4):
drm/rockchip: vop: fix vop vsync/hsync polarity
drm/rockchip: vop use is_enabled instead of dpms mode
drm/rockchip: vop: set vop enabled after enable iommu
drm/rockchip: vop: power off until
Vop standby will take effect at end of current frame,
if dsp_hold_valid_irq happen, it means vop standby complete.
we must wait standby complete when we want to disable aclk,
if not, memory bus maybe dead.
Reviewed-by: Heiko Stuebner
Reviewed-by: Daniel Kurtz
Signed-off-by: Mark Yao
On 2015å¹´02æ04æ¥ 11:48, Daniel Kurtz wrote:
> On Feb 4, 2015 11:38 AM, "Mark yao" wrote:
>> On 2015å¹´02æ02æ¥ 15:53, Daniel Vetter wrote:
>>> On Mon, Feb 02, 2015 at 10:30:09AM +0800, Mark yao wrote:
>>>> On 2015å¹´02æ02æ¥ 10:07,
Vop standby will take effect at end of current frame,
if dsp_hold_valid_irq happen, it means vop standby complete.
we must wait standby complete when we want to disable aclk,
if not, memory bus maybe dead.
Reviewed-by: Heiko Stuebner
Reviewed-by: Daniel Kurtz
Signed-off-by: Mark Yao
On 2015å¹´02æ02æ¥ 15:53, Daniel Vetter wrote:
> On Mon, Feb 02, 2015 at 10:30:09AM +0800, Mark yao wrote:
>> On 2015å¹´02æ02æ¥ 10:07, Daniel Kurtz wrote:
>>> Hi Mark, Heiko,
>>>
>>> On Sat, Jan 31, 2015 at 4:41 PM, Mark Yao
>>> wrote:
>>&
Vop standby will take effect at end of current frame,
if dsp_hold_valid_irq happen, it means vop standby complete.
we must wait standby complete when we want to disable aclk,
if not, memory bus maybe dead.
Reviewed-by: Heiko Stuebner
Reviewed-by: Daniel Kurtz
Signed-off-by: Mark Yao
On 2015å¹´02æ02æ¥ 10:07, Daniel Kurtz wrote:
> Hi Mark, Heiko,
>
> On Sat, Jan 31, 2015 at 4:41 PM, Mark Yao wrote:
>> Vop standby will take effect end of current frame,
>> if dsp_hold_valid_irq happen, it means vop standby complete.
>>
>> we must wait standby
Vop standby will take effect end of current frame,
if dsp_hold_valid_irq happen, it means vop standby complete.
we must wait standby complete when we want to disable aclk,
if not, memory bus maybe dead.
Reviewed-by: Heiko Stuebner
Signed-off-by: Mark Yao
---
Changes in v2:
- use WARN_ON
On 2015å¹´01æ31æ¥ 20:49, Heiko Stübner wrote:
> Hi Mark,
>
> Am Samstag, 31. Januar 2015, 16:41:38 schrieb Mark Yao:
>> Vop standby will take effect end of current frame,
>> if dsp_hold_valid_irq happen, it means vop standby complete.
>>
>> we must wait standby
Vop standby will take effect end of current frame,
if dsp_hold_valid_irq happen, it means vop standby complete.
we must wait standby complete when we want to disable aclk,
if not, memory bus maybe dead.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 76
do vop plane flip is safe, so place
is_enabled = true after enable iommu is suitable.
Signed-off-by: Mark Yao
---
Changes in v2:
- fix mistake that set is_enabled wrong.
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --
igned-off-by: Mark Yao
---
Changes in v2:
- fix mistake that set is_enabled wrong.
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 34 ++-
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm
r problem at vop_crtc_dpms:
vop_enable()->drm_vblank_on, drm_vblank_on may call vop
enable vblank. if it happen, vblank enable would failed,
then cause irq status error. because is_enabled value is set
after drm_vblank_on.
Changes in v2:
- fix mistake that set is_enabled wrong.
Mark Yao (2):
On 2015å¹´01æ22æ¥ 15:33, Daniel Vetter wrote:
> On Thu, Jan 22, 2015 at 03:05:32PM +0800, Mark Yao wrote:
>> drm dpms have many power modes: ON,OFF,SUSPEND,STANDBY, etc.
>> but vop only have enable/disable mode, maybe case such bug:
>> --> DRM_DPMS_ON: power on vop
&
do vop plane flip is safe, so place
is_enabled = true after enable iommu is suitable.
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/
igned-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 34 ++-
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 9a5c571..f278c09 100644
--- a/driver
r problem at vop_crtc_dpms:
vop_enable()->drm_vblank_on, drm_vblank_on may call vop
enable vblank. if it happen, vblank enable would failed,
then cause irq status error. because is_enabled value is set
after drm_vblank_on.
Mark Yao (2):
drm/rockchip: vop use is_enabled instead of dpms mode
Hi Dave
I'd like this patch, some gem object need not be mapped into kernel
address space.
The following changes since commit 281d1bbd34b734e4f22b30b6f3b673dda46a7470:
Merge remote-tracking branch 'origin/master' into drm-next
(2015-01-22 10:44:41 +1000)
are available in the git
dsp_hsync_pol
HSYNC polarity
1'b0 : negative
1'b1 : positive
Signed-off-by: Mark Yao
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip
Hi Dave
fix that: dma_alloc_attrs() returns NULL if it cannot allocate a
dma buffer (or mapping), not a negative error code.
The following changes since commit c93546a5e32bd788c22aefa072385f3784551c13:
Merge tag 'topic/atomic-core-2015-01-05' of
git://anongit.freedesktop.org/drm-intel
Hello Dan,
Thanks for your review, I will fix it soon.
Do you use a script to find out these issues? I was interested in this
script.
Can you teach me how to find this script and use it?
regards,
Mark Yao
On 2014å¹´12æ16æ¥ 19:51, Dan Carpenter wrote:
> Hello Mark Yao,
>
>
to fetch changes up to 5ac4837b12f533de5d9f8f66b45494c58e805536:
dt-bindings: video: Add documentation for rockchip vop (2014-12-02
17:29:33 +0800)
Mark Yao (3):
drm: rockchip: Add basic drm driver
dt-bindings: video
This adds binding documentation for Rockchip SoC VOP driver.
Signed-off-by: Mark Yao
---
Changes in v2:
- rename "lcdc" to "vop"
- add vop reset
- add iommu node
- add port for display-subsystem
Changes in v3: None
Changes in v4: None
Changes in v5: None
Changes in v6:
This add a display subsystem comprise the all display interface nodes.
Signed-off-by: Mark Yao
---
Changes in v2:
- add DRM master device node to list all display nodes that comprise
the graphics subsystem.
Changes in v3: None
Changes in v4: None
Changes in v5: None
Changes in v6: None
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark Yao
Signed-off-by: Daniel Kurtz
Acked-by: Daniel Vetter
Reviewed-by: Rob Clark
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP devices have been probed
e
recursive dependency problem
- fix compile problems when build as a module.
Mark yao (3):
drm: rockchip: Add basic drm driver
dt-bindings: video: Add for rockchip display subsytem
dt-bindings: video: Add documentation for rockchip vop
.../devicetree/bindings/video/rockchip-drm.txt
On 2014å¹´11æ27æ¥ 10:12, Dave Airlie wrote:
>>>
>> Hi Dave
>> Do you mean that I need send you a branch, based on drm-next, merge with
>> iommu tree and rockchip drm?
> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's
> tree, put rockchip drm
> patches on top, send me pull
)
Mark Yao (3):
drm: rockchip: Add basic drm driver
dt-bindings: video: Add for rockchip display subsytem
dt-bindings: video: Add documentation for rockchip vop
.../devicetree/bindings/video/rockchip-drm.txt | 19 +
.../devicetree/bindings/video/rockchip-vop.txt
On 2014å¹´11æ27æ¥ 06:53, Dave Airlie wrote:
> On 26 November 2014 at 17:34, Joerg Roedel wrote:
>> On Wed, Nov 26, 2014 at 01:37:51AM +0100, Heiko Stübner wrote:
>>> Joerg, is your arm/rockchip branch [0] considered stable?
>>>
>>> [0]
>>>
This adds binding documentation for Rockchip SoC VOP driver.
Signed-off-by: Mark Yao
---
Changes in v2:
- rename "lcdc" to "vop"
- add vop reset
- add iommu node
- add port for display-subsystem
Changes in v3: None
Changes in v4: None
Changes in v5: None
Changes in v6:
This add a display subsystem comprise the all display interface nodes.
Signed-off-by: Mark Yao
---
Changes in v2:
- add DRM master device node to list all display nodes that comprise
the graphics subsystem.
Changes in v3: None
Changes in v4: None
Changes in v5: None
Changes in v6: None
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark Yao
Signed-off-by: Daniel Kurtz
Acked-by: Daniel Vetter
Reviewed-by: Rob Clark
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP devices have been probed
tc _init should before dev-node kms object lookup idr and
conector sysfs need below minor node register, I don't like
split the connector init and register, so just call ->load at
the midile of drm register.
Mark yao (3):
drm: rockchip: Add basic drm driver
dt-bindings: video: Add for
On 2014å¹´11æ19æ¥ 09:09, Mark yao wrote:
> On 2014å¹´11æ18æ¥ 22:24, Daniel Vetter wrote:
>> On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote:
>>> Hi Daniel,
>>>
>>> On Tue, 18 Nov 2014 09:32:34 +0100
>>> Daniel Vetter wrote:
>
On 2014å¹´11æ18æ¥ 22:24, Daniel Vetter wrote:
> On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote:
>> Hi Daniel,
>>
>> On Tue, 18 Nov 2014 09:32:34 +0100
>> Daniel Vetter wrote:
>>
>>> On Tue, Nov 18, 2014 at 04:00:29PM
401 - 500 of 594 matches
Mail list logo
