From: Markus Elfring
Date: Mon, 1 May 2017 17:15:43 +0200
Some data were put into a sequence by two separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm
From: Markus Elfring
Date: Mon, 1 May 2017 18:38:08 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use seq_putc() in drm_dp_mst_dump_topology()
Combine two seq_printf() calls into one call in drm_dp_mst_dump_topology()
Replace
From: Markus Elfring
Date: Mon, 1 May 2017 18:22:52 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Mon, 1 May 2017 17:23:24 +0200
Strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Mark
From: Markus Elfring
Date: Mon, 1 May 2017 17:08:56 +0200
A few single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drive
inux coding style convention.
>>
>> Signed-off-by: Markus Elfring
>
> Not sure this is worth it, I'll pass. Patch 1 merged.
Unfortunately, it seems that this selection of only one update step
from this small patch series has got unwanted consequences.
Will the update sugges
> A recent cleanup changed the kmalloc() + copy_from_user() to
> memdup_user() but the error handling wasn't updated so we might call
> kfree(-EFAULT) and crash.
>
> Fixes: a6e3918bcdb1 ('GPU-DRM-Savage: Use memdup_user() rather than
> duplicating')
> Signed-off-by: Dan Carpenter
>
> diff --git
From: Markus Elfring
Date: Fri, 23 Sep 2016 17:53:49 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script "checkpatch.pl" can point information out like the following.
Comparison to NULL could be written !â¦
Thus fix the affec
From: Markus Elfring
Date: Fri, 23 Sep 2016 17:26:02 +0200
* Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
* Try this copy operation before allocating memory for the data structure
member "offsets".
* Delete the local variable "us
From: Markus Elfring
Date: Thu, 22 Sep 2016 21:54:33 +0200
Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Fri, 23 Sep 2016 18:24:32 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use kmalloc_array() in vmw_surface_define_ioctl()
Use memdup_user() rather than duplicating its implementation
Adjust checks
>> I am trying to improve various open issues also in Linux source files.
>>
> That the fact that you see issues (in these particular cases) while
> others do not
I guess that the discussed "story" affects more challenges in communication
and different opinions about where to invest software devel
>> Do other identifiers fit better to a specification from the document
>> "CodingStyle"
>> like the following?
>>
>> "â¦
>> Choose label names which say what the goto does or why the goto exists.
>> â¦"
>>
>>
>> Does this wording need any more adjustments?
>
> No.
I have got an other impressi
>> I see a need to improve not only correctness there but also a bit of
>> software efficiency.
>
> If you can measure any performance difference and present some results
> (esp. considering that this is something that just happens when the
> driver is loaded), then we'll talk.
Are you really int
> Calling the label "unlock" instead of "out" is arguable a little better,
Thanks that you can follow a renaming for this direction in principle.
> but nothing I would call a major improvement either.
This was not my intention for such an use case.
I am proposing some small software updates ac
> iirc, there are Coccinelle rules that find code with unnecessary null
> checks and removes them.
This kind of software change is not needed here.
I find that a corresponding return value check happens one function call
too late.
> Although you probably made this complex enough that cocinelle
> It's just the names like "out" or "restart" perfectly explain why the labels
> exists.
I have got an other impression.
> So they fulfill this requirement from the coding style as far as I can see.
Short identifiers might look more convenient in some cases because
they are quicker to type.
>> A special view on software simplicity can also lead to questionable
>> intermediate
>> function implementation, can't it?
>
> I don't really follow. But in any case I do not see anything
> questionable in the current tilcdc_convert_slave_node() implementation.
I identified update candidates t
> Additional to that I don't really see the point in renaming some of the jump
> labels,
I am suggesting changes for another collateral software evolution.
> if you call it "restart" or "lock_restart" doesn't make much difference.
Do other identifiers fit better to a specification from the doc
> Markus, please contact the list in advance in future before posting a bunch
> of patches that don't fix any problems.
I am trying to improve various open issues also in Linux source files.
Unfortunately, some of the proposed changes might not fit to your software
development attention at the mo
> I will refrain from merging any more style/checkpatch/"code cleanup"
> patches from Markus until we start getting real, tested, bug fixes.
Can such a kind of feedback be also interpreted in the way that you insist
to keep some weaknesses which I tried to point in the Linux source code out
for an
>> Would you like to discuss the statistics for my failure (or success) rate
>> a bit more so that involved issues can be clarified in a constructive way?
>
> It should be that you target 20 bug fixes for each new regression
> that you add.
How do you think about to clarify any concrete "regressi
> I think the "if (node)" in the of_node_put() is there on purpose,
Yes, of course.
Does such an implementation detail correspond to a general software design
pattern?
> because it potentially saves the caller one extra if()-statement
This can occasionally happen.
> and keeps the caller cod
>> The of_node_put() function was called in some cases
>> by the tilcdc_convert_slave_node() function during error handling
>> even if the passed variable contained a null pointer.
>>
>> * Adjust jump targets according to the Linux coding style convention.
>>
>> * Split a condition check for resour
> I'll pick this up, but with your permission I change
> the commit subject to follow the current convention.
I guess that I can accept the integration of this update suggestion
also with an adjusted prefix in the commit title. ;-)
Regards,
Markus
From: Markus Elfring
Date: Thu, 22 Sep 2016 18:46:01 +0200
The local variable "n" was not modified after it was initialized with
a few text strings.
Thus express this detail also by the data type qualifier "const".
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_
From: Markus Elfring
Date: Thu, 22 Sep 2016 17:37:24 +0200
Two local variables will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation which became unnecessary with
a previous update step.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm
From: Markus Elfring
Date: Thu, 22 Sep 2016 17:30:52 +0200
The kfree() function was called in up to two cases
by the ttm_dma_pool_init() function during error handling
even if the passed variable contained a null pointer.
Adjust jump targets according to the Linux coding style convention
From: Markus Elfring
Date: Thu, 22 Sep 2016 17:17:19 +0200
* Return an error code without storing it in a local variable.
* Delete the local variable "ret" which became unnecessary with
this refactoring.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc
From: Markus Elfring
Date: Thu, 22 Sep 2016 16:24:43 +0200
* Return directly after a call of the function "kobject_init_and_add"
failed here.
* Delete the jump target "err" which became unnecessary with
this refactoring.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 22 Sep 2016 16:16:36 +0200
* Return directly after a memory allocation failed in this function
at the beginning.
* Delete the explicit initialisation for the local variable "ret"
which became unnecessary with this refactoring.
Signed-off-by: Mark
From: Markus Elfring
Date: Thu, 22 Sep 2016 16:02:36 +0200
Adjust a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
From: Markus Elfring
Date: Thu, 22 Sep 2016 15:32:32 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:54:12 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:48:39 +0200
* Multiplications for the size determination of memory allocations
indicated that array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:36:47 +0200
Adjust a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:30:12 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:16:05 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
From: Markus Elfring
Date: Thu, 22 Sep 2016 14:00:31 +0200
* Multiplications for the size determination of memory allocations
indicated that array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Thu, 22 Sep 2016 19:00:01 +0200
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (14):
Use kmalloc_array() in two functions
Rename a jump label in ttm_alloc_new_pages()
Rename jump labels in ttm_page_pool_free
> For starters make sure the patches land actually on the list.
How do you think about to take another look at this update suggestion
also by the usual archive interfaces?
* https://patchwork.kernel.org/patch/9344521/
* https://lkml.kernel.org/r/
> Only the cover letter arrived here.
Would yo
> Guys, please stop accepting patches from Markus!
I would appreciate a bit more explanation for this request.
> Markus, you always introduce bugs.
I find the wording "always" exaggerated.
It can also happen that I make another programming mistake occasionally.
> I have asked you over and ov
>> For the next pile of driver patches _please_ talk with driver maintainers
>> before starting to create&submit patches.
Did the software development discussion start a bit here?
Would you like to support an other "talking style" on a conference
like in Berlin next month?
>> Like I said I won'
From: Markus Elfring
Date: Thu, 22 Sep 2016 10:15:36 +0200
Four local variables will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation which became unnecessary with
a previous update step.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/tilcdc
From: Markus Elfring
Date: Thu, 22 Sep 2016 10:06:50 +0200
The of_node_put() function was called in some cases
by the tilcdc_convert_slave_node() function during error handling
even if the passed variable contained a null pointer.
* Adjust jump targets according to the Linux coding style
From: Markus Elfring
Date: Thu, 22 Sep 2016 09:29:23 +0200
Return directly after a memory allocation failed in this function
at the beginning.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: Markus Elfring
Date: Thu, 22 Sep 2016 09:05:14 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Thu, 22 Sep 2016 10:25:43 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use kmalloc_array()
Return directly after a failed kfree_table_init() in
tilcdc_convert_slave_node()
Less function calls in
From: Markus Elfring
Date: Thu, 22 Sep 2016 08:00:08 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script "checkpatch.pl" can point information out like the following.
Comparison to NULL could be written !â¦
Thus fix the affec
From: Markus Elfring
Date: Wed, 21 Sep 2016 22:48:34 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Wed, 21 Sep 2016 22:33:54 +0200
Move the assignments for three data structure members to the end
so that they will only be performed if the desired resource allocations
succeeded by this function.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/qxl/qxl_kms.c | 9
From: Markus Elfring
Date: Wed, 21 Sep 2016 22:26:08 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Thu, 22 Sep 2016 08:08:08 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use kmalloc_array() in qxl_device_init()
Move three assignments in qxl_device_init()
Improve a size determination in
From: Markus Elfring
Date: Wed, 21 Sep 2016 18:00:23 +0200
Adjust jump labels according to the current Linux coding style convention.
Thus replace the identifier "fail" by "unlock" for this refactoring.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/oma
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:45:04 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_gem.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:42:28 +0200
Move one assignment for the local variable "npages" so that its setting
will only be performed after a call of the function "drm_gem_get_pages"
succeeded by this function.
Signed-off-by: Markus Elfring
---
dri
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:40:20 +0200
The script "checkpatch.pl" can point information out like the following.
WARNING: Prefer kcalloc over kzalloc with multiply
Thus fix the affected source code place.
Signed-off-by: Markus Elfring
---
drivers/gpu/d
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:37:04 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:34:40 +0200
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +-
1 file
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:32:42 +0200
Adjust a jump target so that redundant checks can be avoided at the end.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:30:25 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 25 -
1 file changed, 12 insertions(+), 13 deletions
From: Markus Elfring
Date: Wed, 21 Sep 2016 17:21:57 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Wed, 21 Sep 2016 13:53:11 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Wed, 21 Sep 2016 13:31:45 +0200
The local variable "map" will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +-
1 file
From: Markus Elfring
Date: Wed, 21 Sep 2016 13:31:45 +0200
The local variable "map" will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +-
1 file
From: Markus Elfring
Date: Wed, 21 Sep 2016 13:16:20 +0200
The kfree() function was called in up to two cases
by the tiler_map_show() function during error handling even if
the passed variable contained a null pointer.
* Adjust jump targets according to the Linux coding style convention
From: Markus Elfring
Date: Wed, 21 Sep 2016 12:54:07 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array" at another place.
Signed-off-by: Mark
From: Markus Elfring
Date: Wed, 21 Sep 2016 12:23:46 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Wed, 21 Sep 2016 18:28:38 +0200
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (14):
Use kmalloc_array() in tiler_map_show()
Replace another kmalloc() call by kmalloc_array() in tiler_map_show()
Less function
> The original style was correct, the new style is wrong.
I find your feedback interesting for further clarifications.
> Multi-line indents get curly braces for readability.
How do you think about to transform such an information
into an official specification for the the document "CodingStyle"
From: Markus Elfring
Date: Wed, 21 Sep 2016 08:58:41 +0200
Use another space character behind the keyword "if" according to
the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 2 +-
1 file changed, 1 insertion(+),
From: Markus Elfring
Date: Wed, 21 Sep 2016 08:44:38 +0200
The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move the assignment for one local variable to a separate statement
in this function.
Signed-off-by: Mark
From: Markus Elfring
Date: Wed, 21 Sep 2016 08:28:08 +0200
Do not use curly brackets at four source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 14 +-
1 file changed, 5 insertions
From: Markus Elfring
Date: Tue, 20 Sep 2016 22:32:14 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Tue, 20 Sep 2016 22:22:14 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the
From: Markus Elfring
Date: Wed, 21 Sep 2016 09:09:09 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Use kmalloc_array() in nvbios_iccsense_parse()
Use kmalloc_array() in gt215_link_train()
Delete unnecessary braces
Adjust a
> If you restricted yourself to only sending bug fixes and not sending
> any more cleanups that would be good.
Thanks for another bit of constructive feedback.
> Please stop sending clean up patches.
This will not happen for a while.
I am in the process of informing various developers about so
>>> A single error message should be sufficient to inform about
>>> the detection of an unknown GCT revision at the end.
>>> Thus return after the logging call in this case directly.
>>
>> Did you test this?
>>
>
> Don't be a dummy... This is easy to review an it fixes a bug.
Thanks for this kin
>> A single error message should be sufficient to inform about
>> the detection of an unknown GCT revision at the end.
>> Thus return after the logging call in this case directly.
>
> Did you test this?
What is your software development opinion for this update suggestion?
Regards,
Markus
>> A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kmalloc_array".
>>
>> This issue was detected by using the Coccinelle software.
>
> Did you test this running on the hardware
From: Markus Elfring
Date: Tue, 20 Sep 2016 10:40:22 +0200
* Adjust a jump target.
* Delete the explicit initialisation for the local variable "ret"
which became unnecessary with this refactoring.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/gma500/mid_bios.c | 11 +
From: Markus Elfring
Date: Tue, 20 Sep 2016 10:36:19 +0200
A single error message should be sufficient to inform about
the detection of an unknown GCT revision at the end.
Thus return after the logging call in this case directly.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/gma500
From: Markus Elfring
Date: Tue, 20 Sep 2016 10:34:28 +0200
Adjust the indentation for a single function call parameter here.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/gma500/mid_bios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500
From: Markus Elfring
Date: Tue, 20 Sep 2016 10:32:12 +0200
One local variable was set to an error code before a concrete
error situation was detected. Thus move the corresponding assignment into
an if branch to indicate a software failure there.
Signed-off-by: Markus Elfring
---
drivers/gpu
From: Markus Elfring
Date: Tue, 20 Sep 2016 09:09:10 +0200
Adjust a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/gma500/mid_bios.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
From: Markus Elfring
Date: Tue, 20 Sep 2016 08:54:07 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Tue, 20 Sep 2016 10:48:04 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
Use kmalloc_array() in mid_get_vbt_data_r10()
Rename a jump label in mid_get_vbt_data_r10()
Move a variable assignment in
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:37:27 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/drm_bufs.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:30:31 +0200
The script "checkpatch.pl" can point information out like the following.
WARNING: Prefer kcalloc over kzalloc with multiply
Thus fix the affected source code place.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/drm_
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:24:20 +0200
The script "checkpatch.pl" can point information out like the following.
WARNING: Prefer kcalloc over kzalloc with multiply
Thus fix the affected source code place.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/drm_
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:17:34 +0200
The script "checkpatch.pl" can point information out like the following.
WARNING: Prefer kcalloc over kzalloc with multiply
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/drm_
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:07:06 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Mon, 19 Sep 2016 17:47:37 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Use kmalloc_array() in drm_legacy_addbufs_pci()
Replace two kzalloc() calls by kcalloc() in drm_legacy_addbufs_pci()
Replace a
From: Markus Elfring
Date: Sun, 18 Sep 2016 18:32:28 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* The script "checkpatch.pl" can point information out like the following.
Comparison to NULL could be written !â¦
Thus fix th
From: Markus Elfring
Date: Sun, 18 Sep 2016 17:50:09 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions
From: Markus Elfring
Date: Sun, 18 Sep 2016 17:35:24 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
From: Markus Elfring
Date: Sun, 18 Sep 2016 17:24:47 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Sun, 18 Sep 2016 17:00:52 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinell
From: Markus Elfring
Date: Sun, 18 Sep 2016 18:38:48 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Use kmalloc_array() in amdgpu_debugfs_gca_config_read()
Improve determination of sizes in two functions
Rename a jump label in
From: Markus Elfring
Date: Thu, 18 Aug 2016 22:35:14 +0200
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 13
501 - 600 of 687 matches
Mail list logo
