Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Martyn Welch
.probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König FWIW: Reviewed-by: Martyn Welch --- Hello, I didn't get feedback for (implicit) v1 that was sent with Message-Id: <20230427175954.666464-1-u.kleine-koe...@pengutronix.de>

Re: [PATCH] drm/bridge: megachips: Fix a null pointer dereference bug

2022-07-20 Thread Martyn Welch
en initialized. > > Fix this by checking whether both the bridges are probed. > > Signed-off-by: Zheyu Ma Good catch! Acked-by: Martyn Welch Would be worth adding: Fixes: 11632d4aa2b3 ("drm/bridge: megachips: Ensure both bridges are probed before registration") > ---

Re: [PATCH 1/4] drm/lcdif: Clean up headers

2022-07-08 Thread Martyn Welch
hes, tree found here: https://gitlab.collabora.com/martyn/linux/-/tree/6a4cccf50ea793d9e608ccda13468f8645aff6ad Tested-by: Martyn Welch > Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF > variant") > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc

Re: [PATCH v7 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-07-08 Thread Martyn Welch
sted in combination with other patches, tree found here: https://gitlab.collabora.com/martyn/linux/-/tree/6a4cccf50ea793d9e608ccda13468f8645aff6ad Tested-by: Martyn Welch > Tested-by: Alexander Stein > Tested-by: Martyn Welch > Signed-off-by: Marek Vasut > Cc: Alexander Stein >

Re: [PATCH v4 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-05-27 Thread Martyn Welch
c: Peng Fan > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner Tested along with related patches, driving InnoLux G150XNE LVDS panel attached to NXP i.MX 8M Plus EVK. Tree: https://gitlab.collabora.com/martyn/linux/-/tree/imx8mp Tested-by: Martyn Welch > --- > V2: - Drop the pit

[PATCH v2] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-25 Thread Martyn Welch
4.814279] r10:0000 r9: r8: r7: r6:0000 r5:801499a8 [4.822120] r4:817efa40 [4.824664] Code: e3a02080 e593001c e3a01d33 e3a05000 (e5979018) Split the registration from the STDP4028 probe routine and only perform registration once both the STDP4028 and STD

Re: [PATCH] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-24 Thread Martyn Welch
On Tue, 2021-11-23 at 16:18 +0100, Robert Foss wrote: > Hey Martyn, > > On Tue, 16 Nov 2021 at 13:28, Martyn Welch > wrote: > > > > In the configuration used by the b850v3, the STDP2690 is used to read > > EDID > > data whilst it's the STDP4028 which c

[PATCH] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-16 Thread Martyn Welch
4.814279] r10:0000 r9: r8: r7: r6: r5:801499a8 [ 4.822120] r4:817efa40 [4.824664] Code: e3a02080 e593001c e3a01d33 e3a05000 (e5979018) Split the registration from the STDP4028 probe routine and only perform registration once both the STDP4028 and

Re: [CRTC:24] vblank wait timed out

2017-03-29 Thread Martyn Welch
On Wed, Mar 29, 2017 at 10:07:45AM +0200, Philipp Zabel wrote: > On Tue, 2017-03-28 at 18:52 +0100, Martyn Welch wrote: > > On Tue, Mar 28, 2017 at 06:44:50PM +0200, Philipp Zabel wrote: > [...] > > > It is the ipu1_di0_pre_sel and ipu2_di0_pre_sel setup that is important >

Re: [CRTC:24] vblank wait timed out

2017-03-28 Thread Martyn Welch
On Tue, Mar 28, 2017 at 06:44:50PM +0200, Philipp Zabel wrote: > Hi Martyn, > > On Tue, 2017-03-28 at 11:49 +0100, Martyn Welch wrote: > > On Mon, Mar 27, 2017 at 12:11:12PM +0100, Martyn Welch wrote: > > > On Fri, Mar 24, 2017 at 11:42:53AM +0100, Philipp Zabel wrote: &g

Re: [CRTC:24] vblank wait timed out

2017-03-28 Thread Martyn Welch
On Mon, Mar 27, 2017 at 12:11:12PM +0100, Martyn Welch wrote: > On Fri, Mar 24, 2017 at 11:42:53AM +0100, Philipp Zabel wrote: > > On Fri, 2017-03-24 at 10:24 +0000, Martyn Welch wrote: > > [...] > > > > Could you move to v4.9 or v4.10 and check if the fo

Re: [CRTC:24] vblank wait timed out

2017-03-27 Thread Martyn Welch
On Fri, Mar 24, 2017 at 11:42:53AM +0100, Philipp Zabel wrote: > On Fri, 2017-03-24 at 10:24 +0000, Martyn Welch wrote: > [...] > > > Could you move to v4.9 or v4.10 and check if the four patches in > > > https://git.pengutronix.de/cgit/pza/linux/tag/?id=v4.9-ipu-dp-plane-

Re: [CRTC:24] vblank wait timed out

2017-03-24 Thread Martyn Welch
On Tue, Mar 21, 2017 at 06:18:44PM +0100, Philipp Zabel wrote: > Hi Martyn, > > On Tue, 2017-03-21 at 09:50 +0000, Martyn Welch wrote: > > I have an i.MX6 platform with 2 display port interfaces, one driven by the > > HDMI interface, the other by LVDS, both via brid

[CRTC:24] vblank wait timed out

2017-03-21 Thread Martyn Welch
I have an i.MX6 platform with 2 display port interfaces, one driven by the HDMI interface, the other by LVDS, both via bridges. We are currently experiencing the following error when we boot with the monitor connected to the LVDS backed interface and then connect a monitor to the HDMI backed interf

[PATCH V4 2/4] Documentation/devicetree/bindings: b850v3_lvds_dp

2016-08-16 Thread Martyn Welch
ff-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- > Changes from V3: > - 2/4 instead of 3/5 > > Unchanged from V2 > > Changes from V1: > - Replaced '_' by '-' in node names or compatible strings > - Added missing @73 t

[PATCH V4 1/4] drm/imx-ldb: Add support to drm-bridge

2016-08-16 Thread Martyn Welch
Thierry Reding > Signed-off-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- > Changes from V3: > - The connector is created when there is no bridge instead of only when >there is a pannel > - Tested on next-20160804 > > Changes from V2: > - Updated to be a

Radeon drivers on PowerPC (e500)

2014-06-26 Thread Martyn Welch
ngs the chip up in 32-bit mode and modified the DTS to suit. Seemed like the easiest way to see whether it would work. It does. I have a Radeon E6460 showing an X display, at the moment using the fbdev driver. Baby steps... > (Or use a 64-bit e5500 based chip ? :-) > Yeah, haven't got a

Radeon drivers on PowerPC (e500)

2014-06-18 Thread Martyn Welch
uite "completed". I can dig internally if > I can put my hand onto something. > Thanks Ben, that would be much appreciated. > If possible at all, can you try to configure your SoC to bring the MMIO > space of the PCIe within the bottom 32-bit of the chip address space ?

Radeon drivers on PowerPC (e500)

2014-06-18 Thread Martyn Welch
On 18/06/14 02:05, Dave Airlie wrote: > On 18 June 2014 05:14, Martyn Welch wrote: >> Hi, >> >> I've been asked to try and get a r600 based (E6460) graphics card running on >> a machine powered by a Freescale p4080 (e500 core). I've run into a bit of a >

Radeon drivers on PowerPC (e500)

2014-06-17 Thread Martyn Welch
of ideas, any pointers or suggestions on how I might get this working? Has this ever been attempted before? Martyn -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748