Hi there,
Could someone please comment on the following hard-lock (*). Staring
at the code, I see `nvkm_rd32` calls are enclosed in a timeout
detection, except one.
drivers/gpu/drm/nouveau/nvkm/engine/gr/g84.c#L171
...
nvkm_msec(device, 2000,
if (!(nvkm_rd32(device, 0x100c80) & 0x0001))
b
ev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -2307,7 +2307,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev,
>
> ret = radeon_kick_out_firmware_fb(pdev);
> if (ret)
> - return ret;
> + goto err_release_fb;
G
On Wed, May 13, 2020 at 1:21 PM Christian König
wrote:
>
> Always use the PCI GART instead.
Reviewed-by: Mathieu Malaterre
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git
On Thu, Jan 17, 2019 at 9:40 PM Mathieu Malaterre wrote:
>
> In commit dd220a00e8bd ("drm/radeon/kms: add support for streamout v7")
> case statements were added without a terminating break statement. This
> commit adds the missing break. This was discovered during a
ret = 0;
> of_node_put(dp);
>
> @@ -683,8 +683,8 @@ static int __init control_of_init(struct device_node *dp)
> return -ENXIO;
> }
> p = kzalloc(sizeof(*p), GFP_KERNEL);
> - if (p == 0)
> - return -ENXIO;
> +
On Sat, Jun 1, 2019 at 5:39 PM Shobhit Kukreti wrote:
>
> drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0
> drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0
> drivers/video/fbdev/controlfb.c: WARNING comparing pointer to 0
>
> Signed-off-by: Shobhit Kukreti
> ---
>
On Wed, Mar 27, 2019 at 10:37 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 26.03.19 um 14:33 schrieb Mathieu Malaterre:
> >
> > ...
> > ../drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c:174:2: note: in expansion
> > of macro 'do_div'
> > do_div(width,
On Tue, Mar 26, 2019 at 10:18 AM Thomas Zimmermann wrote:
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/fbdevdrm/Makefile | 1 +
> drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c | 42 ++
> drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.h | 7 +
> drivers/gpu/drm/fbdevdrm/fb
On Fri, Jan 18, 2019 at 8:51 PM Joe Perches wrote:
>
> On Fri, 2019-01-18 at 20:32 +0100, Mathieu Malaterre wrote:
> > Using strncpy() is less than perfect since the destination buffers do not
> > need to be NUL terminated. Replace strncpy() with memcpy() to address a
> >
: 'strncpy' specified bound 8 equals
destination size [-Wstringop-truncation]
drivers/video/hdmi.c:235:2: warning: 'strncpy' specified bound 16 equals
destination size [-Wstringop-truncation]
Signed-off-by: Mathieu Malaterre
---
drivers/video/hdmi.c | 4 ++--
1 file changed
drm/radeon/evergreen_cs.c:1301:11: warning: this statement may
fall through [-Wimplicit-fallthrough=]
Suggested-by: Alex Deucher
Fixes: dd220a00e8bd ("drm/radeon/kms: add support for streamout v7")
Signed-off-by: Mathieu Malaterre
---
v2: Add missing break statement, instead of markin
n expansion of macro 'unlikely'
drivers/gpu/drm/drm_dp_helper.c:173:3: note: in expansion of macro 'WARN'
drivers/gpu/drm/drm_dp_helper.c:547:3: warning: this statement may fall
through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre
---
drivers/gpu/drm/drm_dp_helper
/fbdev/offb.c:142:3: warning: this statement may fall through
[-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre
---
drivers/video/fbdev/offb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 31f769d67195..e0f0c5351306
: Mathieu Malaterre
---
drivers/gpu/drm/radeon/evergreen_cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c
b/drivers/gpu/drm/radeon/evergreen_cs.c
index f471537c852f..fbf346185790 100644
--- a/drivers/gpu/drm/radeon/evergreen_cs.c
+++ b/drivers/gpu/drm
5.0.0-rc1+ (ma...@debian.org) (gcc
version 6.3.0 20170516 (Debian 6.3.0-18)) #21 Mon Jan 7 21:03:53 CET
2019
...
So here is my :
Tested-by: Mathieu Malaterre
Thanks
> Reported-by: Mathieu Malaterre
> Cc: sta...@vger.kernel.org # v4.19+
> Cc: Bartlomiej Zolnierkiewicz
> Cc: dri-devel
Hi Rob,
On Mon, Jan 7, 2019 at 9:11 PM Mathieu Malaterre wrote:
>
> On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote:
> >
> > Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of
> > device_node.name") changed how the OF FB driver handles the OF n
hanks
On Thu, Dec 20, 2018 at 5:10 PM Mathieu Malaterre wrote:
>
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre wrote:
> >
> > This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> > using %pOFn instead of device_node.n
Patch is far from perfect but was tested also by: Elimar Riesebieter
riese...@lxtec.de
Le jeu. 20 déc. 2018 17:10, Mathieu Malaterre a écrit :
> Rob, any comment ?
>
> On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre wrote:
> >
> > This is a partial revert of commit
Rob, any comment ?
On Fri, Dec 7, 2018 at 1:59 PM Mathieu Malaterre wrote:
>
> This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to
> using %pOFn instead of device_node.name"). This is the minimal work to
> get a Mac Mini G4 back to a bootab
.
Cc: Rob Herring
Fixes: 5c63e407aaab ("fbdev: Convert to using %pOFn instead of
device_node.name")
Cc: sta...@vger.kernel.org # v4.19+
Signed-off-by: Mathieu Malaterre
---
drivers/video/fbdev/offb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/of
On Fri, Apr 13, 2018 at 9:59 AM Huang Rui wrote:
> On Thu, Apr 12, 2018 at 09:33:33PM +0200, Mathieu Malaterre wrote:
> > In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against
> > 255 is done. Since it is always false, change the signature of this
> > fu
nfirm component which causes the issue.
> 3. try to update the last VBIOS to adapt new driver.
>
> Thanks
> JimQu
>
>
> 发件人: amd-gfx 代表 Christian König
>
> 发送时间: 2018年4月30日 1:16:14
> 收件人: Mathieu Malaterre; Deucher, Alexander
&
For reference:
https://lists.freedesktop.org/archives/mesa-dev/2016-May/115453.html
2018-04-24 21:55 GMT+02:00 Mathieu Malaterre :
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
>
> [ 1228.795711] radeon :00:10.0: ring 0 stalled for more than 10240msec
>
&
AGP mode is unstable on PowerPC. Symptoms are generally of the form:
[ 1228.795711] radeon :00:10.0: ring 0 stalled for more than 10240msec
Reviewed-by: Christian König
Signed-off-by: Mathieu Malaterre
---
drivers/gpu/drm/radeon/radeon_drv.c | 5 +
1 file changed, 5 insertions
Hi there,
I am pretty sure I was able to run kodi on an old Mac Mini G4 (big
endian) with AMD RV280. Today it is failing to start with:
[ 162.971551] radeon :00:10.0: ring 0 stalled for more than 10240msec
[ 162.971568] radeon :00:10.0: GPU lockup (current fence id
0x01d6 la
EAD) {
^
Signed-off-by: Mathieu Malaterre
---
drivers/gpu/drm/radeon/atombios_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/atombios_i2c.c
b/drivers/gpu/drm/radeon/atombios_i2c.c
index 4157780585a0..9022e9af11a0 100644
--- a/drivers/gpu/drm/rad
duce the behavior of the module radeon, so as to make it
possible to load radeonfb when offb is first loaded, see
commit a56f7428d753 ("drm/radeon: Add early unregister of firmware fb's").
Signed-off-by: Mathieu Malaterre
Link: https://bugs.debian.org/826629#57
Link: http
On Tue, Feb 13, 2018 at 1:05 PM, Bartlomiej Zolnierkiewicz
wrote:
> On Saturday, February 10, 2018 01:48:55 PM Mathieu Malaterre wrote:
>> Hi,
>>
>> On Thu, Feb 8, 2018 at 2:28 PM, Bartlomiej Zolnierkiewicz
>> wrote:
>> > On Wednesday, January 31, 2018
x178
[] kernel_init_freeable+0x138/0x1cc
[<2a17fa0e>] kernel_init+0x24/0x118
[<4079749a>] ret_from_kernel_thread+0x5c/0x64
Signed-off-by: Mathieu Malaterre
---
drivers/video/fbdev/offb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/offb.c b/drivers/v
Hi,
On Thu, Feb 8, 2018 at 2:28 PM, Bartlomiej Zolnierkiewicz
wrote:
> On Wednesday, January 31, 2018 08:51:23 PM Mathieu Malaterre wrote:
>> Bartlomiej,
>>
>> On Wed, Jan 31, 2018 at 12:57 PM, Bartlomiej Zolnierkiewicz
>> wrote:
>> > On Tuesday, January 30
rove the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Mathieu-Malaterre/Fix-loading-of-module-radeonfb-on-PowerMac/20180203-085907
> config: x86_64-randconfig-x009-201804 (attached as .config)
> compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> reproduce:
> #
r *ublue;
> struct fb_cmap *cmap = &info->cmap;
> - int index, count, i;
> + unsigned int index, count, i;
> u8 red, green, blue;
>
> if (get_user(index, &c->index) ||
> --
> 2.14.3
>
By just looking at the code and commit message:
Acked-by: Mathieu Malaterre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Bartlomiej,
On Wed, Jan 31, 2018 at 12:57 PM, Bartlomiej Zolnierkiewicz
wrote:
> On Tuesday, January 30, 2018 02:14:10 PM Mathieu Malaterre wrote:
>> Bartlomiej,
>>
>> On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz
>> wrote:
>> >
>> &g
tion on the radeon side.
Signed-off-by: Mathieu Malaterre
Link: https://bugs.debian.org/826629#57
Link: https://bugzilla.kernel.org/show_bug.cgi?id=119741
Suggested-by: Lennart Sorensen
Cc: Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt
Cc: Tomi Valkeinen
---
v2: Only fails when CONFIG_PCC is
Bartlomiej,
On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz
wrote:
>
> On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote:
>> When the linux kernel is build with (typical kernel ship with Debian
>> installer):
>>
>> CONFIG_FB_OF=y
>
Hi Bartlomiej,
On Wed, Jan 3, 2018 at 4:23 PM, Lennart Sorensen
wrote:
> On Wed, Jan 03, 2018 at 03:47:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote:
>> > When the linux kernel is build with (typical kerne
avior of the module radeon, so as to make it
possible to load radeonfb when offb is first loaded.
It should be noticed that `offb_destroy` is never called which explain the
need to skip error detection on the radeon side.
Signed-off-by: Mathieu Malaterre
Link: https://bugs.debian.org/826629
consideration.
2016-05-13 8:29 GMT+02:00 Mathieu Malaterre :
> AGP mode is unstable on PowerPC
>
> Signed-off-by: Mathieu Malaterre
> Reviewed-by: Christian König
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --g
ping ?
2016-05-13 8:29 GMT+02:00 Mathieu Malaterre :
> AGP mode is unstable on PowerPC
>
> Signed-off-by: Mathieu Malaterre
> Reviewed-by: Christian König
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --g
On Tue, Jun 7, 2016 at 8:05 AM, Mathieu Malaterre wrote:
> Hi Alex,
>
> On Mon, Jun 6, 2016 at 7:20 PM, Alex Deucher wrote:
>> On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote:
>>> [+ dri-devel]
>>>
>>> On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malate
Hi Alex,
On Mon, Jun 6, 2016 at 7:20 PM, Alex Deucher wrote:
> On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote:
>> [+ dri-devel]
>>
>> On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre
>> wrote:
>>> Hi,
>>>
>>> Before reportin
Dear all,
I've tested a patch against radeon_drc.c so that the default mode is
now PCI on PowerPC arch.
This is the result of the discussion on the following bug report:
https://bugs.freedesktop.org/show_bug.cgi?id=95017
Thanks for your comments,
--
Mathieu
AGP mode is unstable on PowerPC
Signed-off-by: Mathieu Malaterre
Reviewed-by: Christian König
---
drivers/gpu/drm/radeon/radeon_drv.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
b/drivers/gpu/drm/radeon/radeon_drv.c
index ccd4ad4..402cf85
43 matches
Mail list logo