Re: [Intel-gfx] [PATCH 1/2] drm/fourcc: define Intel Meteorlake related ccs modifiers

2023-05-11 Thread Matt Atwood
On Thu, May 11, 2023 at 01:37:13PM +0300, Juha-Pekka Heikkila wrote: > Add Tile4 type ccs modifiers with aux buffer needed for MTL > Bspec: 49251, 49252, 49253 > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula Reviewed-by: Matt Atwood > Signed-off-by: Juha-Pekka Heikkila &

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Return Wa_22012654132 to just specific steppings

2022-12-14 Thread Matt Atwood
has now been removed from the tuning guide, and > the guidance is to only program it in the specific steppings associated > with the workaround. > > Bspec: 68331 Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2

Re: [Intel-gfx] [PATCH] Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709"

2022-08-29 Thread Matt Atwood
_SLICE_CS_CHICKEN1[14] is once again set by the > kernel. > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915/ats-m: Add thread execution tuning setting

2022-08-29 Thread Matt Atwood
> better performance. We'll add a new "tuning" feature flag to the ATS-M > device info to enable/disable this setting. > > Bspec: 68331 > Cc: Lucas De Marchi Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr

2022-07-08 Thread Matt Atwood
ave some additional features coming in > the future that will also need to loop over each DSS and steer some > register accesses accordingly. > Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 34 ++- >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pvc: Add initial PVC workarounds

2022-05-31 Thread Matt Atwood
On Fri, May 27, 2022 at 09:33:48AM -0700, Matt Roper wrote: > From: Stuart Summers > > Bspec: 64027 Reviewed-by: Matt Atwood > Signed-off-by: Stuart Summers > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 5 +- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pvc: Extract stepping information from PCI revid

2022-05-31 Thread Matt Atwood
gt; Unlike past platforms, steppings for these components are represented by > specific bitfields within the PCI revision ID, and we shouldn't make > assumptions about the non-CT, non-BD bits staying 0. Let's update our > stepping code accordingly. > > Bspec: 44484 Reviewed-by: Matt Atwoo

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/guc: XEHPSDV and PVC do not use HuC

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:28PM -0700, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Disable HuC loading since it is not used on these platforms. > > Cc: Stuart Summers Reviewed-by: Matt Atwood > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Ro

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/pvc: Add new BCS engines to GuC engine list

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:27PM -0700, Matt Roper wrote: > Intialize ADS system info to reflect the availablity of new BCS engines > > Original-author: CQ Tang > Cc: Stuart Summers > Cc: John Harrison Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > dr

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

2022-05-24 Thread Matt Atwood
a whole > lacks a 3D pipeline. Add those restrictions here. > > v2: > - Replace LACKS_3D_PIPELINE checks with !HAS_3D_PIPELINE and add >has_3d_pipeline to all platforms except PVC. (Lucas) > > Bspec: 47112 > Cc: Lucas De Marchi Reviewed-by: Matt Atwood > S

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/pvc: Add forcewake support

2022-05-24 Thread Matt Atwood
On Tue, May 10, 2022 at 11:02:25PM -0700, Matt Roper wrote: > Add PVC's forcewake ranges. > > v2: > - Drop replicated comment completely; move general cleanup of the >documentation to a separate patch. > > Bspec: 67609 > Cc: Daniele Ceraolo Spurio > Cc: Stuart

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/uncore: Reorganize and document shadow and forcewake tables

2022-05-24 Thread Matt Atwood
handling to its own dedicated file in the > near future and further enhance this with true kerneldoc. But this is a > good intermediate step to help clarify the behavior a bit. > > Cc: Stuart Summers Reviewed-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drive

[PATCH v4 RFC] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-30 Thread Matt Atwood
flags from hosting 2 8 bit numbers to holding a i915_engine_class_instance struct v4: add error if non rcs engine passed. Cc: Ashutosh Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu

[PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-16 Thread Matt Atwood
flags from hosting 2 8 bit numbers to holding a i915_engine_class_instance struct Cc: Ashutosh Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-11 Thread Matt Atwood
On Thu, Mar 10, 2022 at 12:26:12PM +, Tvrtko Ursulin wrote: > > On 10/03/2022 05:18, Matt Atwood wrote: > > Newer platforms have DSS that aren't necessarily available for both > > geometry and compute, two queries will need to exist. This introduces > > the first, whe

[PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-09 Thread Matt Atwood
Dixit Cc: Matt Roper Cc: Joonas Lahtinen UMD (mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68 ++- include/uapi/drm/i915_drm.h | 24 +++ 2 files changed, 65

[PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-09 Thread Matt Atwood
(mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/i915_query.c | 68 ++- include/uapi/drm/i915_drm.h | 24 +++ 2 files changed, 65 insertions(+), 27 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH v2 08/18] drm/i915/guc: Convert engine record to iosys_map

2022-02-15 Thread Matt Atwood
hew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 14 ++ > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h | 3 ++- > .../gpu/drm/i915/gt/uc/intel_guc_submission.c

Re: [Intel-gfx] [PATCH v2 07/18] drm/i915/guc: Convert policies update to iosys_map

2022-02-10 Thread Matt Atwood
t > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 41 -- > 1 file changed, 23 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/in

Re: [Intel-gfx] [PATCH v2 05/18] drm/i915/guc: Add read/write helpers for ADS blob

2022-02-10 Thread Matt Atwood
el Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v2 04/18] drm/i915/guc: Keep iosys_map of ads_blob around

2022-02-10 Thread Matt Atwood
itialization by abstracting the IO vs system memory. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 03/18] drm/i915/gt: Add helper for shmem copy to iosys_map

2022-02-08 Thread Matt Atwood
; Cc: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/shmem_utils.c | 32 +++ > drivers/gpu/drm/i915/gt/shmem_utils.h | 3 +++ > 2 files changed, 35 inse

Re: [Intel-gfx] [PATCH v2 02/18] iosys-map: Add a few more helpers

2022-02-08 Thread Matt Atwood
> Cc: Thomas Zimmermann > Cc: Mauro Carvalho Chehab > Cc: dri-devel@lists.freedesktop.org > Cc: linux-ker...@vger.kernel.org Reviewed-by: Matt Atwood > Signed-off-by: Lucas De Marchi > --- > include/linux/iosys-map.h | 202 ++ >