Hi Nick,
On 24/05/2023 20:56, Nick Desaulniers wrote:
> On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor wrote:
>>
>> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulniers wrote:
>>> On Wed, May 24, 2023 at 8:38 AM Nathan Chancellor wrote:
Clang warns:
Hi Thorsten,
Thank you for this review.
On 04/04/2023 10:09, Thorsten Leemhuis wrote:
>
> On 03.04.23 18:23, Matthieu Baerts wrote:
>> [...]
>> diff --git a/Documentation/process/submitting-patches.rst
>> b/Documentation/process/submitting-patches.rst
>> index 828
gs is now
used.
Two variables are created from it: one to search for such tags and one
to print all tags in a warning message.
Suggested-by: Joe Perches
Signed-off-by: Matthieu Baerts
---
v4:
- "Reported-by:" should be followed by a "Closes:" tag. (Thorsten
Leemhuis)
v3:
t;link" tags are followed by a URL, we can relax
the check linked to "Reported-by being followed by a link tag" to only
verify if a "link" tag is present after the "Reported-by" one.
Link:
https://lore.kernel.org/linux-doc/CAHk-=wh0v1EeDV3v8TzK81nDC40=xutdy2mcr0xy3m
n tags are used for links")
... or after the "Reported-by:" tag:
commit d7f1d71e5ef6 ("checkpatch: warn when Reported-by: is not followed by
Link:")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Signed-off-by: Matthieu Baerts
---
v4:
- remove the &q
he code is now similar to what is done above when
checking if the Co-developed-by tag is properly used.
Fixes: d7f1d71e5ef6 ("checkpatch: warn when Reported-by: is not followed by
Link:")
Signed-off-by: Matthieu Baerts
---
v4:
- Add new patch.
---
scripts/checkpatch.pl | 2 +-
1 file chan
vkvzjpm3vfu1zobp37fwd_h9iad...@mail.gmail.com/
[4]
Link:
https://lore.kernel.org/all/688cd6cb-90ab-6834-a6f5-97080e39c...@leemhuis.info/
[5]
Link:
https://lore.kernel.org/linux-doc/2194d19d-f195-1a1e-41fc-7827ae569...@leemhuis.info/
[6]
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Sug
..@leemhuis.info/
[2]
https://lore.kernel.org/all/bb5dfd55ea2026303ab2296f4a6df3da7dd64006.1674217480.git.li...@leemhuis.info/
[3]
https://lore.kernel.org/linux-doc/20230315181205.f3av7h6owqzzw64p@meerkat.local/
Signed-off-by: Matthieu Baerts
---
Note: After having re-read the comments from the v
Hi Thorsten,
On 31/03/2023 12:09, Thorsten Leemhuis wrote:
>
>
> On 31.03.23 11:44, Matthieu Baerts wrote:
>> Hi Thorsten,
>>
>> On 31/03/2023 10:57, Thorsten Leemhuis wrote:
>>> On 30.03.23 20:13, Matthieu Baerts wrote:
>>>> "Link:
Hi Thorsten,
On 31/03/2023 11:39, Thorsten Leemhuis wrote:
> On 30.03.23 20:13, Matthieu Baerts wrote:
>> Since v6.3, checkpatch.pl now complains about the use of "Closes:" tags
>> followed by a link [1]. It also complains if a "Reported-by:" tag i
Hi Thorsten,
On 31/03/2023 10:57, Thorsten Leemhuis wrote:
> On 30.03.23 20:13, Matthieu Baerts wrote:
>> "Link:" and "Closes:" tags have to be used with public URLs.
>>
>> It is difficult to make sure the link is public but at least we can
Hi Joe,
Thank you for this review.
On 31/03/2023 00:43, Joe Perches wrote:
> On Thu, 2023-03-30 at 20:13 +0200, Matthieu Baerts wrote:
>> As a follow-up of a previous patch modifying the documentation to
>> allow using the "Closes:" tag, checkpatch.pl is updated accordi
gs is now
used.
Two variables are created from it: one to search for such tags and one
to print all tags in a warning message.
Suggested-by: Joe Perches
Signed-off-by: Matthieu Baerts
---
scripts/checkpatch.pl | 32
1 file changed, 24 insertions(+), 8 deletions(-)
l.org/linux-doc/CAHk-=wh0v1EeDV3v8TzK81nDC40=xutdy2mcr0xy3m3fibv...@mail.gmail.com/
[1]
Signed-off-by: Matthieu Baerts
---
v3:
- new patch addressing Linus' concerns.
---
scripts/checkpatch.pl | 11 +++
1 file changed, 11 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.p
tipath-tcp/mptcp_net-next/issues/373
Suggested-by: Thorsten Leemhuis
Acked-by: Konstantin Ryabitsev
Signed-off-by: Matthieu Baerts
---
v3:
- Allow using the "Closes" tag with any bug reports, not only the ones
supporting automations, useful for regzbot, etc. (Thorsten Leemhuis)
bb77a0 ("checkpatch: warn when unknown tags are used for links")
Fixes: d7f1d71e5ef6 ("checkpatch: warn when Reported-by: is not followed by
Link:")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Signed-off-by: Matthieu Baerts
---
v3:
- split into 2 patches:
..@leemhuis.info/
[2]
https://lore.kernel.org/all/bb5dfd55ea2026303ab2296f4a6df3da7dd64006.1674217480.git.li...@leemhuis.info/
[3]
https://lore.kernel.org/linux-doc/20230315181205.f3av7h6owqzzw64p@meerkat.local/
Signed-off-by: Matthieu Baerts
---
Note: After having re-read the comments from the v
Hi Thorsten,
On 25/03/2023 07:25, Thorsten Leemhuis wrote:
> On 24.03.23 19:52, Matthieu Baerts wrote:
>> As a follow-up of the previous patch modifying the documentation to
>> allow using the "Closes:" tag, checkpatch.pl is updated accordingly.
>>
>> checkpa
Hi Thorsten,
Thank you for your reply!
On 26/03/2023 13:28, Thorsten Leemhuis wrote:
> On 24.03.23 19:52, Matthieu Baerts wrote:
>> Making sure a bug tracker is up to date is not an easy task. For
>> example, a first version of a patch fixing a tracked issue can be sent a
>
Hi Joe,
Thank you for the review!
On 24/03/2023 20:13, Joe Perches wrote:
> On Fri, 2023-03-24 at 19:52 +0100, Matthieu Baerts wrote:
>> As a follow-up of the previous patch modifying the documentation to
>> allow using the "Closes:" tag, checkpatch.pl is updated accordi
ported-by: is not followed by
Link:")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Signed-off-by: Matthieu Baerts
---
scripts/checkpatch.pl | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
ind
/
[3]
Link:
https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nowvkvzjpm3vfu1zobp37fwd_h9iad...@mail.gmail.com/
[4]
Link:
https://lore.kernel.org/all/688cd6cb-90ab-6834-a6f5-97080e39c...@leemhuis.info/
[5]
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Suggested-by: Thorsten Leemhuis
..@leemhuis.info/
[2]
https://lore.kernel.org/all/bb5dfd55ea2026303ab2296f4a6df3da7dd64006.1674217480.git.li...@leemhuis.info/
[3]
https://lore.kernel.org/linux-doc/20230315181205.f3av7h6owqzzw64p@meerkat.local/
Signed-off-by: Matthieu Baerts
---
Note: After having re-read the comments from the v
Hi Bagas,
On 17/03/2023 09:00, Bagas Sanjaya wrote:
> On 3/16/23 00:44, Matthieu Baerts wrote:
>> +In the same category as linking web pages, a special tag is also used to
>> close
>> +issues but only when the mentioned ticketing system can do this operat
Mar 16, 2023 at 4:43 AM Matthieu Baerts
>> wrote:
>>>
>>> @Linus: in short, we would like to continue using the "Closes:" tag (or
>>> similar, see below) with a URL in commit messages. They are useful to
>>> have public bug trackers doing automat
ull thread is visible there:
https://lore.kernel.org/linux-doc/20230314-doc-checkpatch-closes-tag-v1-0-1b83072e9...@tessares.net/T/
@Thorsten: thank you for your reply!
On 16/03/2023 10:22, Thorsten Leemhuis wrote:
> On 15.03.23 18:44, Matthieu Baerts wrote:
>> Since v6.3, checkpatch.pl
Hi Jon,
On 15/03/2023 19:19, Jonathan Corbet wrote:
> Matthieu Baerts writes:
>
>> +In the same category as linking web pages, a special tag is also used to
>> close
>> +issues but only when the mentioned ticketing system can do this operation
>> +automatically::
Hi Konstantin,
On 15/03/2023 19:12, Konstantin Ryabitsev wrote:
> On Wed, Mar 15, 2023 at 06:44:56PM +0100, Matthieu Baerts wrote:
>> Note that thanks to this "Closes" tag, the mentioned bug trackers can
>> also locate where a patch has been applied in different bra
ing-keywords-in-issues-and-pull-requests
[2]
Link:
https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nowvkvzjpm3vfu1zobp37fwd_h9iad...@mail.gmail.com/
[3]
Link:
https://lore.kernel.org/all/688cd6cb-90ab-6834-a6f5-97080e39c...@leemhuis.info/
[4]
Link: https://github.com/multipath-tcp/mptcp_net
ea2026303ab2296f4a6df3da7dd64006.1674217480.git.li...@leemhuis.info/
Signed-off-by: Matthieu Baerts
---
Matthieu Baerts (2):
docs: process: allow Closes tags with links
checkpatch: allow Closes tags with links
Documentation/process/5.Posting.rst | 9 +
Documentation/pr
ported-by: is not followed by
Link:")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373
Signed-off-by: Matthieu Baerts
---
scripts/checkpatch.pl | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
ind
31 matches
Mail list logo
