[PATCH] fbdev/core: Avoid uninitialized read in aperture_remove_conflicting_pci_device()

t;) Signed-off-by: Michał Mirosław --- drivers/video/aperture.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c index 9e6bcc03a1a4..41e77de1ea82 100644 --- a/drivers/video/aperture.c +++ b/drivers/video/aperture.c @@ -340

Re: [PATCH 1/6] lib/scatterlist: Add contiguous DMA chunks helpers

ntiguous memory. [...] Is the counting of all blocks necessary if all to be checked is whether there is more than one continuous block? Best Regards Michał Mirosław

Re: [PATCH libdrm 19/25] tests: tegra: Add VIC 3.0 support

lkHeight = 0; > + > +c->fetchControl0Struct.TargetRectLeft = 0; > +c->fetchControl0Struct.TargetRectTop = 0; > +c->fetchControl0Struct.TargetRectRight = output->width - 1; > +c->fetchControl0Struct.TargetRectBottom = output->height - 1; > + > +drm_tegra_bo_unmap(vic->config.bo); > + > +return 0; > +} [...] It does look exactly like: return vic30_fill(v, output, 0, 0, output->width - 1, output->height - 1, alpha, red, green, blue); Best Regards Michał Mirosław

Re: [PATCH v7 05/15] gpu: host1x: Add option to skip firewall for a job

REWALL) && > !skip_firewall; [...] Why negatively name a parameter just to invert it right away? Best Regards Michał Mirosław

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

On Thu, Apr 08, 2021 at 06:13:44AM +0200, Michał Mirosław wrote: > On Fri, Apr 02, 2021 at 07:02:32PM +0300, Dmitry Osipenko wrote: > > 02.04.2021 00:19, Michał Mirosław пишет: > > > On Fri, Mar 26, 2021 at 04:34:13PM +0200, Mikko Perttunen wrote: > > >> On 3/23/21

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

On Fri, Apr 02, 2021 at 07:02:32PM +0300, Dmitry Osipenko wrote: > 02.04.2021 00:19, Michał Mirosław пишет: > > On Fri, Mar 26, 2021 at 04:34:13PM +0200, Mikko Perttunen wrote: > >> On 3/23/21 12:16 PM, Thierry Reding wrote: > >>> On Mon, Jan 11, 2021 at 03:00:01P

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

ach(pos, &m->syncpt[i].intr.wait_head) > > > + waiters++; > > > + spin_unlock(&m->syncpt[i].intr.lock); > > > > Would it make sense to keep a running count so that we don't have to > > compute it here? > > Considerin

Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = true, > }; > > static const struct tegra_dc_soc_info tegra124_dc_soc_info = { > @@ -2314,7 +2660,9 @@ static const struct tegra_dc_soc_info > tegra124_dc_soc_info = { > .overlay_formats = tegra124_overlay_formats, > .modifiers = tegra124_modifiers, > .has_win_a_without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_dc_soc_info tegra210_dc_soc_info = { > @@ -2333,7 +2681,9 @@ static const struct tegra_dc_soc_info > tegra210_dc_soc_info = { > .overlay_formats = tegra114_overlay_formats, > .modifiers = tegra124_modifiers, > .has_win_a_without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_windowgroup_soc tegra186_dc_wgrps[] = { > @@ -2382,6 +2732,7 @@ static const struct tegra_dc_soc_info > tegra186_dc_soc_info = { > .has_nvdisplay = true, > .wgrps = tegra186_dc_wgrps, > .num_wgrps = ARRAY_SIZE(tegra186_dc_wgrps), > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = { > @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info > tegra194_dc_soc_info = { > .has_nvdisplay = true, > .wgrps = tegra194_dc_wgrps, > .num_wgrps = ARRAY_SIZE(tegra194_dc_wgrps), > + .plane_tiled_memory_bandwidth_x2 = false, > }; For globals you will have .x = false by default; I'm not sure those entries add much value. Reviewed-by: Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

mul = 1; [...] One point is unexplained yet: why is the multiplier proportional to a *difference* between src and dst widths? Also, I would expect max (worst case) is pixclock * read_size when src_w/dst_w >= read_size. BTW, you could move this below and : if (src > dst_w) peak_bandwidth *= ... > +

Re: [PATCH v15 2/2] drm/tegra: dc: Extend debug stats with total number of events

reset. [...] Looks good. It seems independent from the other patch. Reviewed-by: Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

On Fri, Mar 05, 2021 at 12:45:51AM +0300, Dmitry Osipenko wrote: > 04.03.2021 02:08, Michał Mirosław пишет: > > On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: > >> Display controller (DC) performs isochronous memory transfers, and thus, > >> has a requi

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

t; + > + tegra_state->peak_memory_bandwidth = peak_bandwidth; > + tegra_state->avg_memory_bandwidth = avg_bandwidth; > + > + return 0; > +} [...] > +static const char * const tegra_plane_icc_names[] = { > + "wina", "winb", "winc&

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

? Best Regards Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback

number of modes added, -EOPNOTSUPP if callback > + * is missing, -EINVAL if panel is NULL. >*/ > int (*get_modes)(struct drm_panel *panel); > Hi! If .get_modes is mandatory, then panel->func != NULL checks can be removed if panel->func and .get_modes presence

Re: [PATCH 0/3] drm/tegra: Remove space after parenthesis

est Regards, Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/tegra: Do not use ->load() and ->unload() callbacks

able to check during the weekend. Is this patch alone enough for v5.3? Best Regards, Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/nouveau: avoid client name truncation

If TASK_COMM_LEN is made bigger DRM client name will be truncated. Avoid that. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau

[PATCH] fbdev: fix kerneldoc

As noticed by kbuild test robot , remove_conflicting_pci_framebuffers()'s second argument is called res_id not resource_id. Fix this. Signed-off-by: Michał Mirosław --- * Against drm-misc-next, as this is the branch original patchset was applied to. --- drivers/video/fbdev/core/fbmem.

[PATCH] drm/fb-helper: document remove*_conflicting_framebuffers()

Copy remove*_conflicting_framebuffers() kerneldocs from fbdev code to make DRM developers' life easier. Signed-off-by: Michał Mirosław --- * Against drm-misc-next. --- include/drm/drm_fb_helper.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/includ

[PATCH v2] fbdev: fix kerneldoc

As noticed by kbuild test robot , remove_conflicting_pci_framebuffers()'s second argument is called res_id not resource_id. Fix this. Signed-off-by: Michał Mirosław --- * Against drm-misc-next, as that's where original patchset went to. v2: include second occurrence of @r

[PATCH v3 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of duplicating it. Signed-off-by: Michał Mirosław Acked-by: Maxime Ripard Acked-by: Daniel Vetter --- drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3 13/13] drm/tegra: kick out simplefb

Kick out firmware fb when loading Tegra driver. Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/tegra/drm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 7afe2f635f74..b51ec138fed2 100644 --- a

[PATCH v3 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of open-coding it. Signed-off-by: Michał Mirosław Acked-by: Eric Anholt Acked-by: Daniel Vetter --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v3 07/13] drm/cirrus: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd78..85ed8657c862

[PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

docs for DRM helpers v3: - move kerneldoc to fbdev, where functions are implemented - split kerneldoc for remove_conflicting_framebuffers() - propagate return value in remove_conflicting_pci_framebuffers() --- Michał Mirosław (13): fbdev: show fbdev number for debugging fbdev: allow apertures

[PATCH v3 01/13] fbdev: show fbdev number for debugging

Signed-off-by: Michał Mirosław Acked-by: Bartlomiej Zolnierkiewicz Acked-by: Daniel Vetter --- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index f741ba8df01b

[PATCH v3 05/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Alex Deucher Acked-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu

Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup

nting to (partially?) freed or corrupted fb_info, but I can't see how this could be an effect of remove_conflicting_framebuffers(). Best Regards, Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers()

Almost all PCI drivers using remove_conflicting_framebuffers() wrap it with the same code. --- v2: add kerneldoc for DRM helper v3: propagate remove_conflicting_framebuffers() return value + move kerneldoc to where function is implemented Signed-off-by: Michał Mirosław --- drivers/video

[PATCH v3 06/13] drm/bochs: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/bochs/bochs_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index 7b20318483e4..c61b40c72b62 100644

[PATCH v3 02/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

Interpret (otherwise-invalid) NULL apertures argument to mean all-memory range. This will allow to remove several duplicates of this code from drivers in following patches. Signed-off-by: Michał Mirosław Acked-by: Bartlomiej Zolnierkiewicz --- v2: added kerneldoc to corresponding DRM helper v3

[PATCH v3 10/13] drm/virtio: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index

[PATCH v3 09/13] drm/radeon: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Alex Deucher Acked-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index

[PATCH v3 03/13] fbdev: add kerneldoc do remove_conflicting_framebuffers()

Document remove_conflicting_framebuffers() behaviour. Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 0df148eb4699..2de93b5014e3 100644

[PATCH v3 08/13] drm/mgag200: use simpler remove_conflicting_pci_framebuffers()

Remove duplicated call, while at it. Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/mgag200/mgag200_drv.c | 21 + drivers/gpu/drm/mgag200/mgag200_main.c | 9 - 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu

[PATCH v2 11/12] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of duplicating it. Signed-off-by: Michał Mirosław Acked-by: Maxime Ripard Acked-by: Daniel Vetter --- drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 06/12] drm/cirrus: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd78..85ed8657c862

[PATCH v2 12/12] drm/tegra: kick out simplefb

Kick out firmware fb when loading Tegra driver. Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/tegra/drm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 7afe2f635f74..b51ec138fed2 100644 --- a

[PATCH v2 07/12] drm/mgag200: use simpler remove_conflicting_pci_framebuffers()

Remove duplicated call, while at it. Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/mgag200/mgag200_drv.c | 21 + drivers/gpu/drm/mgag200/mgag200_main.c | 9 - 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu

[PATCH v2 01/12] fbdev: show fbdev number for debugging

Signed-off-by: Michał Mirosław Acked-by: Bartlomiej Zolnierkiewicz Acked-by: Daniel Vetter --- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index f741ba8df01b

[PATCH v2 09/12] drm/virtio: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index

[PATCH v2 04/12] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Alex Deucher Acked-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu

[PATCH v2 03/12] fbdev: add remove_conflicting_pci_framebuffers()

Almost all PCI drivers using remove_conflicting_framebuffers() wrap it with the same code. Signed-off-by: Michał Mirosław [for v1] Acked-by: Bartlomiej Zolnierkiewicz --- v2: add kerneldoc for DRM helper --- drivers/video/fbdev/core/fbmem.c | 22 ++ include/drm

[PATCH v2 00/12] remove_conflicting_framebuffers() cleanup

for DRM helpers Michał Mirosław (12): fbdev: show fbdev number for debugging fbdev: allow apertures == NULL in remove_conflicting_framebuffers() fbdev: add remove_conflicting_pci_framebuffers() drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() drm/bochs: use simpler

[PATCH v2 10/12] drm/vc4: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of open-coding it. Signed-off-by: Michał Mirosław Acked-by: Eric Anholt Acked-by: Daniel Vetter --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v2 08/12] drm/radeon: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Alex Deucher Acked-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index

[PATCH v2 05/12] drm/bochs: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław Acked-by: Daniel Vetter --- drivers/gpu/drm/bochs/bochs_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index 7b20318483e4..c61b40c72b62 100644

[PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

Interpret (otherwise-invalid) NULL apertures argument to mean all-memory range. This will allow to remove several duplicates of this code from drivers in following patches. Signed-off-by: Michał Mirosław [for v1] Acked-by: Bartlomiej Zolnierkiewicz --- v2: added kerneldoc to corresponding DRM

[PATCH 07/13] drm/radeon: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/gpu/drm/radeon/radeon_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 31dd04f6baa1..49f51b17ae81 100644 --- a/drivers/gpu

[PATCH 09/13] staging: sm750fb: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/staging/sm750fb/sm750.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 67207b0554cd..0590fc45c493 100644 --- a/drivers/staging/sm750fb

[PATCH 00/13] remove_conflicting_framebuffers() cleanup

. --- Michał Mirosław (13): fbdev: show fbdev number for debugging fbdev: add remove_conflicting_pci_framebuffers() drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() drm/bochs: use simpler remove_conflicting_pci_framebuffers() drm/cirrus: use simpler

[PATCH 10/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

Interpret (otherwise-invalid) NULL apertures argument to mean all-memory range. This will allow to remove several duplicates of this code from drivers in following patches. Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 14 ++ 1 file changed, 14 insertions

[PATCH 06/13] drm/mgag200: use simpler remove_conflicting_pci_framebuffers()

Remove duplicated call, while at it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/mgag200/mgag200_drv.c | 21 + drivers/gpu/drm/mgag200/mgag200_main.c | 9 - 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c

[PATCH 13/13] drm/tegra: kick out simplefb

Kick out firmware fb when loading tegra driver. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/tegra/drm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 943bdf88c4a2..1ec66ae29839 100644 --- a/drivers/gpu/drm/tegra

[PATCH 08/13] drm/virtio: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index 7df8d0c9026a..115ed546ca4e 100644

[PATCH 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of duplicating it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c

Re: [PATCH 13/13] drm/tegra: kick out simplefb

On Fri, Nov 24, 2017 at 09:50:50PM +0100, Thierry Reding wrote: > On Fri, Nov 24, 2017 at 06:53:34PM +0100, Michał Mirosław wrote: > > Kick out firmware fb when loading tegra driver. > Cool. Can you provide some background on how you tested this? What is > your firmware FB? T

[PATCH 05/13] drm/cirrus: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd78..85ed8657c862 100644 --- a/drivers/gpu

[PATCH 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL)

Use remove_conflicting_framebuffers(NULL) instead of open-coding it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index

[PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

Almost all drivers using remove_conflicting_framebuffers() wrap it with the same code. Extract common part from PCI drivers into separate remove_conflicting_pci_framebuffers(). Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 22 ++ include/drm

[PATCH 03/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index dd2f060d62a8..b726222b7dd4 100644 --- a

[PATCH 04/13] drm/bochs: use simpler remove_conflicting_pci_framebuffers()

Signed-off-by: Michał Mirosław --- drivers/gpu/drm/bochs/bochs_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index 7b20318483e4..c61b40c72b62 100644 --- a/drivers/gpu/drm/bochs

[PATCH 01/13] fbdev: show fbdev number for debugging

Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index f741ba8df01b..30a18d4c9de4 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b

[PATCH] virtgpu: remove redundant task_comm copying

Remove redundant task name copying because: 1. task->comm is already NUL-terminated 2. virtio_gpu_context_create() trims passed dbgname anyway Signed-off-by: Michał Mirosław --- drivers/gpu/drm/virtio/virtgpu_kms.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --gi

[PATCH] drm: nouveau: replace magic constant for TASK_COMM_LEN

Client's name is task_comm + pid: use constant for clarity and prepare for changed TASK_COMM_LEN. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gp

[PATCH] drm: tegra: fix NULL deref in debugfs/iova

When IOMMU is off, ->mm_lock is not initialized and ->mm is NULL. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/tegra/drm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 8b7842548b9f..f859c0

[PATCH] drm: make DRM_STM default n

Default config value for all other drivers is N. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/stm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig index 4b88223f9aed..5071df28532f 100644 --- a/drivers/gpu/drm/stm/Kconfig

Re: [PATCH 4/5] DRM: Add support for the sii902x HDMI/DVI encoder

+ > + > +static int sii902x_remove(struct i2c_client *client) > +{ > +       struct sii902x_priv *priv; > +       int ret; > + > +       priv = i2c_get_clientdata(client); > + > +       ret = drm_encon_unregister(&priv->encon); > +       if (ret) > +               return ret; Leaks priv on error. > + > +       kfree(priv); > + > +       return 0; > +} [...] Best Regards, Michał Mirosław ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 4/5] DRM: Add support for the sii902x HDMI/DVI encoder

2011/6/7 Sascha Hauer : [...] > --- /dev/null > +++ b/drivers/gpu/drm/i2c/sii902x.c > @@ -0,0 +1,334 @@ [...] > +static int sii902x_write(struct i2c_client *client, uint8_t addr, uint8_t > val) > +{ > + ? ? ? int ret; > + > + ? ? ? ret = i2c_smbus_write_byte_data(client, addr, val); > + ? ? ? if (