Re: [PATCH v2 05/13] mtd: devices: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
i, char *name, int nr_pages, /* name must be usable with cmdlinepart */ sprintf(priv->name, "spi%d.%d-%s", - spi->master->bus_num, spi->chip_select, + spi->master->bus_num, spi_get_chipselect(spi, 0),

Re: [PATCH v2 01/13] spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod

2023-01-23 Thread Michal Simek
ruct spi_device *spi, u8 idx) +{ + return spi->chip_select; +} + +static inline void spi_set_chipselect(struct spi_device *spi, u8 idx, u8 chipselect) +{ + spi->chip_select = chipselect; +} + +static inline struct gpio_desc *spi_get_csgpiod(struct spi_device *spi, u8 idx) +{ + return spi->cs_gpiod; +} + +static inline void spi_set_csgpiod(struct spi_device *spi, u8 idx, struct gpio_desc *csgpiod) +{ + spi->cs_gpiod = csgpiod; +} + struct spi_message; /** Lars suggested this style in v1 version of this patch here. https://lore.kernel.org/all/12fe1b84-1981-bf56-9323-b7f5b698c...@metafoo.de/ That's why let me also add his Suggested-by: Lars-Peter Clausen And Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 07/13] platform/x86: serial-multi-instantiate: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
t %u", name, + spi_get_chipselect(spi_dev, 0)); smi->spi_devs[i] = spi_dev; smi->spi_num++; Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
| 4 ++-- drivers/spi/spi-zynq-qspi.c | 2 +- drivers/spi/spi-zynqmp-gqspi.c| 2 +- drivers/spi/spidev.c | 6 +++--- include/trace/events/spi.h| 10 +- 92 files changed, 315 insertions(+), 310 deletions(-) Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 10/13] mtd: spi-nor: Add stacked memories support in spi-nor

2023-01-23 Thread Michal Simek
On 1/19/23 19:53, Amit Kumar Mahapatra wrote: Each flash that is connected in stacked mode should have a separate parameter structure. So, the flash parameter member(*params) of the spi_nor structure is changed to an array (*params[2]). The array is used to store the parameters of each flash

Re: [PATCH v2 06/13] staging: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
(struct gb_spilib *spi, request = operation->request->payload; request->count = cpu_to_le16(count); request->mode = dev->mode; - request->chip_select = dev->chip_select; + request->chip_select = spi_get_chipselect(dev, 0); gb_xfer = >transfers[0]; tx_data = gb_xfer + count; /* place tx data after last gb_xfer */ Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 04/13] iio: imu: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
igh spi speed if possible */ if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) { Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 03/13] net: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Michal Simek
82c0688b549 100644 --- a/drivers/net/wireless/st/cw1200/cw1200_spi.c +++ b/drivers/net/wireless/st/cw1200/cw1200_spi.c @@ -378,7 +378,7 @@ static int cw1200_spi_probe(struct spi_device *func) func->mode = SPI_MODE_0; pr_info("cw1200_wlan_spi: Probe called (CS %d M %d BPW %d CLK %d)\n", - func->chip_select, func->mode, func->bits_per_word, + spi_get_chipselect(func, 0), func->mode, func->bits_per_word, func->max_speed_hz); if (cw1200_spi_on(plat_data)) { Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH v2 36/37] arm64: dts: zynqmp: Add ports for the DisplayPort subsystem

2022-10-20 Thread Michal Simek
if you want to take them via DRM tree (which is the easiest way for me). In that case feel free to add my Acked-by: Michal Simek to both of that patches. If you want me to queue it via my tree I will cherry pick that two patches. Thanks, Michal

[PATCH] dt-bindings: display: xilinx: Fix example with psgtr

2021-10-18 Thread Michal Simek
: Add ZynqMP DP subsystem bindings") Signed-off-by: Michal Simek --- .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation

Re: [V2][PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers

2021-08-06 Thread Michal Simek
Hi, st 24. 3. 2021 v 4:15 odesílatel Laurent Pinchart napsal: > > Hi Quanyang, > > Thank you for the patch. > > On Tue, Mar 23, 2021 at 10:55:01AM +0800, quanyang.w...@windriver.com wrote: > > From: Quanyang Wang > > > > When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the > >

Re: [PATCH] drm/lima: Convert to clk_bulk API

2021-07-19 Thread Michal Simek
On 7/18/21 4:56 AM, Qiang Yu wrote: > On Sat, Jul 17, 2021 at 10:52 PM Marek Vasut wrote: >> >> On 7/17/21 4:21 PM, Qiang Yu wrote: >>> On Sat, Jul 17, 2021 at 9:08 PM Marek Vasut wrote: On 7/17/21 2:34 PM, Qiang Yu wrote: > On Sat, Jul 17, 2021 at 2:20 AM Marek Vasut wrote:

Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()

2021-04-07 Thread Michal Simek
LE, 1); > - memset(dp->train_set, 0, 4); > + memset(dp->train_set, 0, sizeof(dp->train_set)); > ret = zynqmp_dp_link_train_cr(dp); > if (ret) > return ret; > Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH] drm: xlnx: call pm_runtime_get_sync before setting pixel clock

2021-03-17 Thread Michal Simek
+Rohit On 3/17/21 4:00 AM, quanyang.wang wrote: > Hi Laurent, > > On 3/17/21 4:32 AM, Laurent Pinchart wrote: >> Hi Quanyang, >> >> Thank you for the patch. >> >> On Wed, Mar 10, 2021 at 12:59:45PM +0800, quanyang.w...@windriver.com >> wrote: >>> From: Quanyang Wang >>> >>> The Runtime PM

Re: [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples

2020-09-30 Thread Michal Simek
On 29. 09. 20 16:55, Rob Herring wrote: > On Tue, Sep 29, 2020 at 1:55 AM Michal Simek wrote: >> >> Hi Rob, >> >> On 28. 09. 20 17:59, Rob Herring wrote: >>> The default sizes in examples for 'reg' are 1 cell each. Fix the >>> incorrect si

Re: [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples

2020-09-29 Thread Michal Simek
tschema/schemas/reg.yaml > Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: > example-0: display@fd4a:reg:3: [0, 4249534464, 0, 4096] is too long > From schema: > /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml > > Cc: Hyun

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-04 Thread Michal Simek
On 03. 06. 20 10:13, Christophe Leroy wrote: > Hi, > > Le 03/06/2020 à 10:10, Michal Simek a écrit : >> Hi Michael, >> >> On 26. 05. 20 15:44, Michael Ellerman wrote: >>> Michal Simek writes: >>>> Hi Michael, >>>> >>>> On

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-04 Thread Michal Simek
Hi Michael, On 26. 05. 20 15:44, Michael Ellerman wrote: > Michal Simek writes: >> Hi Michael, >> >> On 01. 04. 20 13:30, Michal Simek wrote: >>> On 01. 04. 20 12:38, Takashi Iwai wrote: >>>> On Wed, 01 Apr 2020 12:35:16 +0200, >>>> Mi

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-26 Thread Michal Simek
Hi Michael, On 01. 04. 20 13:30, Michal Simek wrote: > On 01. 04. 20 12:38, Takashi Iwai wrote: >> On Wed, 01 Apr 2020 12:35:16 +0200, >> Michael Ellerman wrote: >>> >>> Michal Simek writes: >>>> On 01. 04. 20 4:07, Michael Ellerman

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-22 Thread Michal Simek
On 21. 05. 20 15:53, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >>> Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: > Benjamin Herrenschmidt writes: >> On Fri, 2020-04-03 at 15:59

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-02 Thread Michal Simek
On 01. 04. 20 12:38, Takashi Iwai wrote: > On Wed, 01 Apr 2020 12:35:16 +0200, > Michael Ellerman wrote: >> >> Michal Simek writes: >>> On 01. 04. 20 4:07, Michael Ellerman wrote: >>>> Michal Simek writes: >>>>> Hi, >>>>&g

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Michal Simek
On 01. 04. 20 4:07, Michael Ellerman wrote: > Michal Simek writes: >> Hi, >> >> recently we wanted to update xilinx intc driver and we found that function >> which we wanted to remove is still wired by ancient Xilinx PowerPC >> platforms. Here is the thread abo

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Michal Simek
On 31. 03. 20 11:49, Christophe Leroy wrote: > > > Le 31/03/2020 à 09:19, Christophe Leroy a écrit : >> >> >> Le 31/03/2020 à 08:59, Michal Simek a écrit : >>> On 31. 03. 20 8:56, Christophe Leroy wrote: >>>> >>>> >>>>

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Michal Simek
t;>>> On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko >>>>> wrote: >>>>>> On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy Shevchenko wrote: >>>>>>> On Fri, Mar 27, 2020 at 01:54:33PM +0100, Arnd Bergmann wrote: >>>>>>>&

[PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-31 Thread Michal Simek
Reported-by: Takashi Iwai - Based on my chat with Arnd I removed arch/powerpc/xmon/ changes done in v1 to keep them the same as before. (kbuild reported some issues with it too) Michal Simek (2): sound: ac97: Remove sound driver for ancient platform powerpc: Remove Xilinx PPC405/PPC440 support

[PATCH v2 2/2] powerpc: Remove Xilinx PPC405/PPC440 support

2020-03-31 Thread Michal Simek
s tag") and commit 19624236cce1 ("MAINTAINERS: Update Grant's email address and maintainership") that's why it is time to remove the support fot these platforms. Signed-off-by: Michal Simek Acked-by: Arnd Bergmann --- Changes in v2: - Based on my chat with Arnd I removed arch/p

[PATCH 2/2] powerpc: Remove Xilinx PPC405/PPC440 support

2020-03-30 Thread Michal Simek
s tag") and commit 19624236cce1 ("MAINTAINERS: Update Grant's email address and maintainership") that's why it is time to remove the support fot these platforms. Signed-off-by: Michal Simek --- Documentation/devicetree/bindings/xilinx.txt | 143 -- Documentation/pow

[PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-30 Thread Michal Simek
without anybody complain about it https://github.com/Xilinx/u-boot-xlnx/commit/98f705c9cefdfdba62c069821bbba10273a0a8ed Based on current ppc/next. If anyone has any objection about it, please let me know. Thanks, Michal Michal Simek (2): sound: ac97: Remove sound driver for ancient platform

Re: [PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-03-19 Thread Michal Simek
On 19. 03. 20 2:08, Hyun Kwon wrote: > Hi Sam, > > On Wed, 2020-03-18 at 12:26:51 -0700, Sam Ravnborg wrote: >> On Wed, Mar 18, 2020 at 05:37:24PM +0200, Laurent Pinchart wrote: >>> From: Hyun Kwon >>> >>> The bindings describe the ZynqMP DP subsystem. They don't support the >>> interface with

Re: [PATCH v10 4/4] arm64: dts: zynqmp: zcu106-revA: Wire up the DisplayPort subsystem

2019-11-15 Thread Michal Simek
On 08. 11. 19 18:59, Laurent Pinchart wrote: > Enable the dpsub device and wire it up to the PS-GTR PHY lanes routed to > the DisplayPort connector. > > Signed-off-by: Laurent Pinchart > --- > .../arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 16 > 1 file changed, 16

Re: [PATCH 00/21] DT cpu node iterator

2018-09-10 Thread Michal Simek
Hi Rob, 2018-09-05 21:37 GMT+02:00 Rob Herring : > This series adds an iterator for cpu nodes and converts users over to use > it or of_get_cpu_node in some cases. This allows us to remove the > dependency on device_type property for cpu nodes though removing that > from DTS files will have to

Re: [PATCH 00/10] Xilinx ZynqMP DisplayPort subsystem DRM KMS driver

2018-01-12 Thread Michal Simek
Tuesday, January 09, 2018 1:57 AM >>> To: Hyun Kwon <hy...@xilinx.com> >>> Cc: dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; Michal >>> Simek <michal.si...@xilinx.com> >>> Subject: Re: [PATCH 00/10] Xilinx ZynqMP DisplayPort subs