[PATCH 1/2] drm/fourcc: Introduce format modifier for DG2 clear color

2022-05-05 Thread Mika Kahola
rate patch. Clarify the modifier layout description. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Mika Kahola cc: Anshuman Gupta Signed-off-by: Juha-Pekka Heikkilä Signed-off-by: Ramalingam C Signed-off-by: Imre Deak Acked-by: Nanley Chery Reviewed-by: Juha-Pekka Heikkila Acked-by: Maa

[PATCH v2] uapi/drm/drm_fourcc.h: Note on platform specificity for format modifiers

2020-05-06 Thread Mika Kahola
a more effective address swizzling algorithm. v2: Rephrase comment (Daniel) Signed-off-by: Mika Kahola --- include/uapi/drm/drm_fourcc.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index

[PATCH] uapi/drm/drm_fourcc.h: Note on platform specificity for format modifiers

2020-05-04 Thread Mika Kahola
a more effective address swizzling algorithm. Signed-off-by: Mika Kahola --- include/uapi/drm/drm_fourcc.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 8bc0b31597d8..3e56c24cabb6 100644 --- a/include/uapi

[PATCH libdrm] intel/i915_pciids: Add missing device ID for ICL

2019-06-17 Thread Mika Kahola
We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per BSPec. BSpec: 19092 Signed-off-by: Mika Kahola --- intel/i915_pciids.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/intel/i915_pciids.h b/intel/i915_pciids.h index c7cdbfc4..0adce335 100644

Re: [igt-dev] [PATCH v2 2/3] lib/kms: Remove special enum handling and replace with call to igt_plane_set_prop_enum, v2.

2018-08-28 Thread Mika Kahola
ersion by accident. > Reviewed-by: Mika Kahola > Signed-off-by: Maarten Lankhorst > --- >  lib/igt_color_encoding.c | 20 +++ >  lib/igt_color_encoding.h |  3 ++ >  lib/igt_kms.c| 77 +- > -- >  3 files changed, 32 insertions

Re: [igt-dev] [PATCH v2 1/3] lib/igt_kms: Add try_prop_enum and set_prop_enum for mode objects, v2.

2018-08-24 Thread Mika Kahola
Looks ok to me. Reviewed-by: Mika Kahola On Wed, 2018-08-15 at 12:08 +0200, Maarten Lankhorst wrote: > This adds the possibility to test arbitrary enumerations in IGT > without > having to define mappings for each and every one. > > Changes since v1: > - Add commit de

Re: [Intel-gfx] [v3] drm/i915: Add detection of changing of edid on between suspend and resume

2018-08-13 Thread Mika Kahola
@@ -552,7 +634,7 @@ static void i915_hpd_poll_init_work(struct > > work_struct *work) > >    * in the middle of disabling polling > >    */ > >   if (!enabled) > > - drm_helper_hpd_irq_event(dev); > > + intel_hpd_irq_event(dev); > >  } > Just wondering, as I saw previously drm_helper_hpd_irq_event function > was used, which basically does the same thing, except doing memcmp > for detecting the edid change. Is it only Intel specific change? As > we > could just add this modification to existing helper function or add > another helper function to the drm (drm_probe_helper.c), so that it > is > also usable elsewhere.. I second Stanislav's proposal to add this feature as part of drm. This edid check could be part of existing drm_helper_hpd_irq_event() function. Other drivers might find this change useful. > > > > >   > >  /** > --  > Best Regards, > > Lisovskiy Stanislav > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

2017-08-18 Thread Mika Kahola
On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote: > Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested also with APL + MIPI/DSI setup. > > Tested-by: Mika Kahola <mika.kah...@intel.com> > > On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote

Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

2017-08-17 Thread Mika Kahola
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote: > The commit 213e08ad60ba > ("drm/i915/bxt: add bxt dsi gpio element support") > enables GPIO

[PATCH] drm: Fix DisplayPort branch device ID

2016-09-16 Thread Mika Kahola
Fix missing parameter description for DisplayPort branch device ID. This fixes warning of "No description found for parameter 'id[6]'" when creating documentation by 'make htmldocs'. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+)

[drm-intel:for-linux-next 6/12] htmldocs: drivers/gpu/drm/drm_dp_helper.c:523: warning: No description found for parameter 'id[6]'

2016-09-16 Thread Mika Kahola
I'll fix this. Cheers, Mika On Fri, 2016-09-16 at 10:53 +0300, Jani Nikula wrote: > Mika, please send in the documentation fix. > > BR, > Jani. > > > On Fri, 16 Sep 2016, kbuild test robot > wrote: > > > > tree:   git://anongit.freedesktop.org/drm-intel for-linux-next > > head:   

[PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
On Fri, 2016-09-09 at 12:09 +0300, Ville Syrjälä wrote: > On Fri, Sep 09, 2016 at 10:45:27AM +0300, Mika Kahola wrote: > > > > On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > > > > > > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote:

[PATCH v9 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git

[PATCH v9 11/12] drm: Add DP branch device info on debugfs

2016-09-09 Thread Mika Kahola
to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines v7: indentation fixes (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 85 + drivers/gpu

[PATCH v9 10/12] drm/i915: Update bits per component for display info

2016-09-09 Thread Mika Kahola
(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config v5: Indentation fixes (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 16 +++- 1 file

[PATCH v9 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-09-09 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH v9 08/12] drm/i915: Read DP branch device SW revision

2016-09-09 Thread Mika Kahola
info to dmesg (Ville) v4: commit message fix (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[PATCH v9 07/12] drm/i915: Read DP branch device HW revision

2016-09-09 Thread Mika Kahola
(Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index c69ad13

[PATCH v9 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-09-09 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v9 05/12] drm: Read DP branch device id

2016-09-09 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[PATCH v9 04/12] drm: Helper to read max bits per component

2016-09-09 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[PATCH v9 03/12] drm: Helper to read max clock rate

2016-09-09 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[PATCH v9 02/12] drm: Drop VGA from bpc definitions

2016-09-09 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[PATCH v9 01/12] drm: Add missing DP downstream port types

2016-09-09 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH v9 00/12] drm/i915: DP branch devices

2016-09-09 Thread Mika Kahola
: Indentation fixes (Jim Bride) Mika Kahola (12): drm: Add missing DP downstream port types drm: Drop VGA from bpc definitions drm: Helper to read max clock rate drm: Helper to read max bits per component drm: Read DP branch device id drm/i915: Cleanup DisplayPort AUX channel initialization drm

[PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: > > > > Respect max TMDS clock frequency from DPCD for active > > DP to HDMI adapters. > > > > Signed-off-by: Mika Kahola > > --- >

[PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-08-17 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH v8 11/12] drm: Add DP branch device info on debugfs

2016-08-17 Thread Mika Kahola
to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/drm/i915/i915_debugfs.c | 3

[PATCH v8 10/12] drm/i915: Update bits per component for display info

2016-08-17 Thread Mika Kahola
(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion

[PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[PATCH v8 09/12] Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[PATCH v8 08/12] drm/i915: Read DP branch device SW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9aebdf6..91ffb79 100644 --- a/drivers

[PATCH v8 07/12] drm/i915: Read DP branch device HW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3dab3bf..9aebdf6 100644 --- a/drivers

[PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-08-17 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/in

[PATCH v8 05/12] drm: Read DP branch device id

2016-08-17 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[PATCH v8 04/12] drm: Helper to read max bits per component

2016-08-17 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[PATCH v8 03/12] drm: Helper to read max clock rate

2016-08-17 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[PATCH v8 02/12] drm: Drop VGA from bpc definitions

2016-08-17 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[PATCH v8 01/12] drm: Add missing DP downstream port types

2016-08-17 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH v8 00/12] drm/i915: DP branch devices

2016-08-17 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

[PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-08-17 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH v8 11/12] drm: Add DP branch device info on debugfs

2016-08-17 Thread Mika Kahola
to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/drm/i915/i915_debugfs.c | 3

[PATCH v8 10/12] drm/i915: Update bits per component for display info

2016-08-17 Thread Mika Kahola
(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion

[PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[PATCH v8 09/12] Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[PATCH v8 08/12] drm/i915: Read DP branch device SW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9aebdf6..91ffb79 100644 --- a/drivers

[PATCH v8 07/12] drm/i915: Read DP branch device HW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3dab3bf..9aebdf6 100644 --- a/drivers

[PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-08-17 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/in

[PATCH v8 05/12] drm: Read DP branch device id

2016-08-17 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[PATCH v8 04/12] drm: Helper to read max bits per component

2016-08-17 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[PATCH v8 03/12] drm: Helper to read max clock rate

2016-08-17 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[PATCH v8 02/12] drm: Drop VGA from bpc definitions

2016-08-17 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[PATCH v8 01/12] drm: Add missing DP downstream port types

2016-08-17 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH v8 00/12] drm/i915: DP branch devices

2016-08-17 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

[PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 12:56 +0200, Daniel Vetter wrote: > On Thu, Aug 11, 2016 at 01:51:42PM +0300, Ville Syrjälä wrote: > > On Thu, Aug 11, 2016 at 12:43:39PM +0300, Mika Kahola wrote: > > > On Thu, 2016-08-11 at 10:18 +0300, Ville Syrjälä wrote: > > > > On M

[PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 10:18 +0300, Ville Syrjälä wrote: > On Mon, Aug 08, 2016 at 04:00:28PM +0300, Mika Kahola wrote: > > Filter out a mode that exceeds the max pixel rate setting > > for DP to VGA dongle. This is defined in DPCD register 0x81 > > if detailed cap info i.e.

[PATCH v7 1/5] drm: Read DP branch device HW revision

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 10:10 +0300, Ville Syrjälä wrote: > On Mon, Aug 08, 2016 at 04:00:26PM +0300, Mika Kahola wrote: > > HW revision is mandatory field for DisplayPort branch > > devices. This is defined in DPCD register field 0x509. > > But what do we want to do wit

[PATCH v7 5/5] drm: Add DP branch device info on debugfs

2016-08-08 Thread Mika Kahola
to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 80 + drivers/gpu/drm/i915/i915_debugfs.c | 2 + include/drm/drm_dp_helper.h | 2 + 3 files changed, 84 insertions

[PATCH v7 4/5] drm: Update bits per component for display info

2016-08-08 Thread Mika Kahola
(Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 24 drivers/gpu/drm/i915/intel_dp.c | 3 +++ include/drm/drm_dp_helper.h | 4 3 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-08 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c in

[PATCH v7 2/5] drm: Read DP branch device SW revision

2016-08-08 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. v2: move drm_dp_ds_revision structure to be part of drm_dp_link structure (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 27

[PATCH v7 1/5] drm: Read DP branch device HW revision

2016-08-08 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. v2: move drm_dp_ds_revision structure to be part of drm_dp_link structure (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 27

[PATCH v7 0/5] drm/i915: DP branch devices

2016-08-08 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers Mika Kahola (5): drm: Read DP branch device HW revision drm: Read DP

[PATCH v6 09/10] drm/i915: Update bits per component for display info

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:51 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:53PM +0300, Mika Kahola wrote: > > DisplayPort branch device may define max supported bits per > > component. Update display info based on this value if bpc > > is defined. > >

[PATCH v6 08/10] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:50 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:52PM +0300, Mika Kahola wrote: > > Filter out a mode that exceeds the max pixel rate setting > > for DP to VGA dongle. This is defined in DPCD register 0x81 > > if detailed cap info i.e.

[PATCH v6 06/10] drm: Read DP branch device HW revision

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:54 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:50PM +0300, Mika Kahola wrote: > > HW revision is mandatory field for DisplayPort branch > > devices. This is defined in DPCD register field 0x509. > > > > Signed-off-by: Mika Kahol

[PATCH v6 10/10] drm/i915: Add DP branch device info on debugfs

2016-07-06 Thread Mika Kahola
Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data v3: cleanup to match the drm_dp_helper.c patches introduced earlier in this series v4: move DP branch device info to function 'intel_dp_branch_device_info()' Signed-off-by: Mika

[PATCH v6 09/10] drm/i915: Update bits per component for display info

2016-07-06 Thread Mika Kahola
DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. v2: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 9

[PATCH v6 08/10] drm/i915: Check pixel rate for DP to VGA dongle

2016-07-06 Thread Mika Kahola
lle) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index ffa43ec..76a654e 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/

[PATCH v6 07/10] drm: Read DP branch device SW revision

2016-07-06 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 23 insertions(+) diff --git

[PATCH v6 06/10] drm: Read DP branch device HW revision

2016-07-06 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git

[PATCH v6 05/10] drm: Read DP branch device id

2016-07-06 Thread Mika Kahola
Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 95d624a

[PATCH v6 04/10] drm: Helper to read max bits per component

2016-07-06 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 42

[PATCH v6 03/10] drm: Helper to read max clock rate

2016-07-06 Thread Mika Kahola
) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 091053e..0d4117c 100644

[PATCH v6 02/10] drm: Drop VGA from bpc definitions

2016-07-06 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/i

[PATCH v6 01/10] drm: Add missing DP downstream port types

2016-07-06 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 4d85cf2..6e8b92e

[PATCH v6 00/10] drm/i915: DP branch devices

2016-07-06 Thread Mika Kahola
computation moved to drm (Daniel) v4: Use of drm_dp_helper routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup Mika Kahola (10): drm: Add missing DP downstream port types drm: Drop VGA from bpc

[PATCH v5 10/10] drm/i915: Add DP branch device info on debugfs

2016-06-10 Thread Mika Kahola
Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data v3: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_debugfs.c | 72

[PATCH v5 09/10] drm/i915: Update bits per component for display info

2016-06-10 Thread Mika Kahola
DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. v2: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 9

[PATCH v5 08/10] drm/i915: Check pixel rate for DP to VGA dongle

2016-06-10 Thread Mika Kahola
lle) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f97cd53..3b09230 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/

[PATCH v5 07/10] drm: Read DP branch device SW revision

2016-06-10 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 23 insertions(+) diff --git

[PATCH v5 06/10] drm: Read DP branch device HW revision

2016-06-10 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git

[PATCH v5 05/10] drm: Read DP branch device id

2016-06-10 Thread Mika Kahola
Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 3dab8a4

[PATCH v5 04/10] drm: Helper to read max bits per component

2016-06-10 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 42

[PATCH v5 03/10] drm: Helper to read max clock rate

2016-06-10 Thread Mika Kahola
) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index eeaf5a7..1199a02 100644

[PATCH v5 02/10] drm: Drop VGA from bpc definitions

2016-06-10 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/i

[PATCH v5 01/10] drm: Add missing DP downstream port types

2016-06-10 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5a848e7..e384c7f

[PATCH v5 00/10] drm/i915: DP branch devices

2016-06-10 Thread Mika Kahola
) v4: Use of drm_dp_helper routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) Mika Kahola (10): drm: Add missing DP downstream port types drm: Drop VGA from bpc definitions drm: Helper to read max clock rate drm: Helper to read

[PATCH v4 05/11] drm: Helper to read max bits per component

2016-06-09 Thread Mika Kahola
On Thu, 2016-06-09 at 11:02 +0300, Ville Syrjälä wrote: > On Mon, Jun 06, 2016 at 04:29:07PM +0300, Mika Kahola wrote: > > Helper routine to read out maximum supported bits per > > component for DisplayPort legay converters. > > > > Signed-off-by: Mika Kahola &

[PATCH v4 11/11] drm/i915: Add DP branch device info on debugfs

2016-06-06 Thread Mika Kahola
Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_debugfs.c | 66 + 1 file changed, 66 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH v4 10/11] drm/i915: Update bits per component for display info

2016-06-06 Thread Mika Kahola
DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b

[PATCH v4 09/11] drm/i915: Check pixel rate for DP to VGA dongle

2016-06-06 Thread Mika Kahola
and computation moved to drm (Ville, Daniel) v3: Sink pixel rate computation moved to drm_dp_max_sink_dotclock() function (Daniel) v4: Use of drm_dp_helper.c routines to compute max pixel clock (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 17 + 1 file

[PATCH v4 08/11] drm: Read DP branch device SW revision

2016-06-06 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 22 ++ include/drm/drm_dp_helper.h | 4 +++- 2 files changed, 25 insertions(+), 1 deletion

[PATCH v4 07/11] drm: Read DP branch device HW revision

2016-06-06 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git

[PATCH v4 06/11] drm: Read DP branch device id

2016-06-06 Thread Mika Kahola
Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index bac0ccc

[PATCH v4 05/11] drm: Helper to read max bits per component

2016-06-06 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 31 +++ include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers

[PATCH v4 04/11] drm: Helper to read max clock rate

2016-06-06 Thread Mika Kahola
Helper routine to read out maximum supported pixel rate for DisplayPort legay VGA converter or TMDS clock rate for other digital legacy converters. The helper returns clock rate in kHz. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 28 include/drm

[PATCH v4 03/11] drm: Helper to read DP branch device type

2016-06-06 Thread Mika Kahola
-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 14 ++ include/drm/drm_dp_helper.h | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c4149fd..7d3b245 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b

[PATCH v4 02/11] drm: Read DP downstream port capabilities

2016-06-06 Thread Mika Kahola
Read DisplayPort downstream port capabilities. Depending on the DP port the capabilities are defined in length of 1 byte or 4 bytes depending if the detailed capability information is available. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 27

[PATCH v4 01/11] drm: Add missing DP downstream port types

2016-06-06 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5a848e7..e384c7f

  1   2   >