Re: [PATCH v3 06/15] drm/rockchip: vop2: include rockchip_drm_drv.h

2024-09-22 Thread Min-Hua Chen
Hi, > Maybe ``From: Min-Hua Chen ``? > > It's very minor and Min-Hua gave their 'Reviewed-by' tag to your patch, > but they found the problem and I thought it was just for practical > reasons you made it part of this patch set. Yes, you're right. The reason

[PATCH v3 06/15] drm/rockchip: vop2: include rockchip_drm_drv.h

2024-09-22 Thread Min-Hua Chen
bol 'vop2_platform_driver' was not declared. Should it >be static? > >It is also beneficial for the upcoming support for rk3576. > >Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") >Signed-off-by: Andy Yan >Signed-off-by: Min-Hua Chen Reviewed-by: Min-Hua Chen

[PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static

2024-09-08 Thread Min-Hua Chen
be static? drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static? No functional changes intended. Signed-off-by: Min-Hua Chen --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++-- 1 file changed

Re:Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-08 Thread Min-Hua Chen
>> DTC arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb >> DTC arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-wifi.dtbo >> DTC arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb >> DTC arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb >> DTC arch/arm6

[PATCH for-next] drm/ttm: make ttm_swap_ops static

2024-09-06 Thread Min-Hua Chen
make ttm_swap_ops static to fix the following sparse warning: drivers/gpu/drm/ttm/ttm_bo.c:1142:31: sparse: warning: symbol 'ttm_swap_ops' was not declared. Should it be static? Fixes: 10efe34dae79 ("drm/ttm: Use the LRU walker helper for swapping") Signed-off-by: Min-Hua Ch

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
>FWIW: I didn't see it either, but I assumed I was missing the right >context (i.e. patches) needed to trigger that warning. > FYI I triggered the warning by the following step: install 'sparse' first git clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd linux ARCH=arm6

Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
Hi, >Hi Min Hua, > Thanks for your work > >At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: >>Include rockchip_drm_drv.h to fix the follow sparse warning: >> >>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >>warning: symbol 'vop

[PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
Include rockchip_drm_drv.h to fix the follow sparse warning: drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: warning: symbol 'vop2_platform_driver' was not declared. Should it be static? No functional change intended. Signed-off-by: Min-Hua Chen --- drivers/gpu/dr

[PATCH v2] fbcon: mark fbcon_registered_fb static

2023-08-06 Thread Min-Hua Chen
ng: symbol 'fbcon_num_registered_fb' was not declared. Should it be static? No functional change intended. Cc: Helge Deller Signed-off-by: Min-Hua Chen --- change since v1: 1. registered_fb and num_registered_fb are still used in drivers/staging/olpc_dcon, so do keep them as-is. 2. change

Re: [PATCH] fbdev: fbmem: mark registered_fb static

2023-08-02 Thread Min-Hua Chen
>Hi Helge, > >>num_registered_fb is still used in: >>drivers/staging/olpc_dcon/olpc_dcon.c: if (num_registered_fb < 1) { >> >>Helge > >Thanks, you're right, num_registered_fb is still being used. >I'll check this patch and submit v2. Update: num_registered_fb and registered_fb are used by olpc

Re: [PATCH] fbdev: fbmem: mark registered_fb static

2023-08-01 Thread Min-Hua Chen
Hi Helge, >num_registered_fb is still used in: >drivers/staging/olpc_dcon/olpc_dcon.c: if (num_registered_fb < 1) { > >Helge Thanks, you're right, num_registered_fb is still being used. I'll check this patch and submit v2. thanks, Min-Hua

[PATCH] fbdev: fbmem: mark registered_fb static

2023-07-14 Thread Min-Hua Chen
'fbcon_num_registered_fb' was not declared. Should it be static? No functional change intended. Signed-off-by: Min-Hua Chen --- drivers/video/fbdev/core/fbcon.c | 4 ++-- drivers/video/fbdev/core/fbmem.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/