[PATCH] drm/omap: Mark dispc_save_context() with noinline_for_stack

2025-09-11 Thread Nathan Chancellor
649 [1] Link: https://llvm.org/pr143908 [2] Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c index cf055815077cffad554a

[PATCH] drm/pixpaper: Fix return type of pixpaper_mode_valid()

2025-09-08 Thread Nathan Chancellor
d indirectly. Update the return type of pixpaper_mode_valid() to be 'enum drm_mode_status' to clear up the warning and kCFI violation. Fixes: c9e70639f591 ("drm: tiny: Add support for Mayqueen Pixpaper e-ink panel") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/tiny/pixpaper.c | 4

Re: [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS

2025-09-04 Thread Nathan Chancellor
Gentle ping, this seems fairly obvious and it continues to break out builds in -next. On Thu, Aug 21, 2025 at 01:52:12PM -0700, Nathan Chancellor wrote: > When no other driver selects CONFIG_VIDEOMODE_HELPERS but > CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error: >

[PATCH] drm/tidss: dispc: Explicitly include bitfield.h

2025-09-02 Thread Nathan Chancellor
ations [-Wimplicit-function-declaration] 1203 |FIELD_PREP(DISPC_VP_TIMING_H_SYNC_PULSE_MASK, hsw - 1) | |^ ... Explicitly include bitfield.h to resolve the errors. Fixes: 9accc8b10de8 ("drm/tidss: dispc: Get rid of FLD_VAL") Signed-off-by: N

[PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS

2025-08-21 Thread Nathan Chancellor
unction is available to the driver. Fixes: ce4bc5ca7c1d ("drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg()") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/bridge/cadence/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridg

Re: [PATCH] drm/msm/dpu: avoid uninitialized variable use

2025-08-09 Thread Nathan Chancellor
On Sat, Aug 09, 2025 at 11:20:34AM +0300, Dmitry Baryshkov wrote: > On Thu, Aug 07, 2025 at 07:34:44AM -0700, Nathan Chancellor wrote: > > On Thu, Aug 07, 2025 at 11:09:38AM +0300, Dmitry Baryshkov wrote: > > > Having no plane->crtc is a valid setting and

Re: [PATCH] drm/msm/dpu: avoid uninitialized variable use

2025-08-07 Thread Nathan Chancellor
On Thu, Aug 07, 2025 at 11:09:38AM +0300, Dmitry Baryshkov wrote: > Having no plane->crtc is a valid setting and it is handled inside > drm_atomic_helper_check_plane_state() by setting plane_state->visible = > false and returning early. Setting crtc_state to NULL is a correct fix. > Could you pleas

Re: [PATCH] drm/i915/pmu: Fix build error with GCOV and AutoFDO enabled

2025-06-02 Thread Nathan Chancellor
r because the condition cannot be proven false at that point. Marking config_bit(), is_engine_config(), engine_config_sample(), other_bit(), config_counter(), and config_gt_id() all as __always_inline might resolve this as well but I cannot say if that is worth it. I guess it depends on how o

Re: clang and drm issue: objtool warnings from clang build

2025-04-26 Thread Nathan Chancellor
On Sat, Apr 26, 2025 at 01:56:59PM -0700, Linus Torvalds wrote: > IOW, there's a *big* difference between "the programmer told me this > is unreachable, so I won't generate code past this point" and "I have > decided this is undefined behavior, so now I won't generate code past > this point". > >

Re: clang and drm issue: objtool warnings from clang build

2025-04-26 Thread Nathan Chancellor
Hi Linus, On Sat, Apr 26, 2025 at 10:42:40AM -0700, Linus Torvalds wrote: > But I *really* think that clang silently just generating known bad > code for invalida operations like this is very very dangerous, and is > a bug in clang. > > Can we *please* get a flag for clang that it doesn't just st

Re: [PATCH] drm/panel: himax-hx8279: Initialize goa_{even, odd}_valid in hx8279_check_goa_config()

2025-04-23 Thread Nathan Chancellor
On Wed, Apr 23, 2025 at 04:01:20PM +0200, AngeloGioacchino Del Regno wrote: > or the shorter form: > > goa_odd_valid = (num_zero != ARRAY_SIZE(desc->goa_odd_timing)); > > /* Up to 3 zeroes is a valid config. Check them all. */ > num_zero = 1; > for (i = 0; i < ARRAY_SIZE(d

[PATCH v2] drm/panel: himax-hx8279: Always initialize goa_{even,odd}_valid in hx8279_check_goa_config()

2025-04-23 Thread Nathan Chancellor
the configuration is valid when there are not all zeros, clearing up the warning since the variable will always be initialized. Fixes: 38d42c261389 ("drm: panel: Add driver for Himax HX8279 DDIC panels") Suggested-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Reg

[PATCH] drm/panel: himax-hx8279: Initialize goa_{even,odd}_valid in hx8279_check_goa_config()

2025-04-22 Thread Nathan Chancellor
undefined behavior. Fixes: 38d42c261389 ("drm: panel: Add driver for Himax HX8279 DDIC panels") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/panel/panel-himax-hx8279.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-himax-hx82

[PATCH] drm/sysfb: efidrm: Avoid clang -Wsometimes-uninitialized in efidrm_device_create()

2025-04-10 Thread Nathan Chancellor
ble but clang's static analysis runs before inlining so it cannot know that. Initialize screen_base to NULL and add a defensive print in case mem_flags were ever returned without one of the four valid values. Fixes: 32ae90c66fb6 ("drm/sysfb: Add efidrm for EFI displays") Signed-o

[PATCH v2] drm/sysfb: efidrm: Avoid clang -Wsometimes-uninitialized in efidrm_device_create()

2025-04-10 Thread Nathan Chancellor
ble but clang's static analysis runs before inlining so it cannot know that. Initialize screen_base to NULL and add a defensive error message in case mem_flags were ever returned without one of the four valid values. Fixes: 32ae90c66fb6 ("drm/sysfb: Add efidrm for EFI displays") Revi

[PATCH] drm/appletbdrm: Fix format specifier for size_t variables

2025-03-04 Thread Nathan Chancellor
ormat] 211 | drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", | ~~~ | %zu 212 | actual_size, size); | ^~~~ Use '%zu' as suggested, clearing up the warnings. Fix

Re: [PATCH] drm/amd/display: Disable -Wenum-float-conversion for dml2_dpmm_dcn4.c

2025-02-14 Thread Nathan Chancellor
On Thu, Dec 19, 2024 at 05:21:41PM -0500, Alex Deucher wrote: > On Thu, Dec 19, 2024 at 12:23 PM Nathan Chancellor wrote: > > > > Commit be4e3509314a ("drm/amd/display: DML21 Reintegration For Various > > Fixes") blew away commit fdedd77b0eb3 ("drm/amd/displa

[PATCH] drm/amd/display: Respect user's CONFIG_FRAME_WARN more for dml files

2025-01-31 Thread Nathan Chancellor
sted value from CONFIG_FRAME_WARN if it is higher. Suggested-by: Harry Wentland Reported-by: Greg Kroah-Hartman Closes: https://lore.kernel.org/2025013003-audience-opposing-7f95@gregkh/ Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 14 +- drivers/g

Re: [PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

2025-01-30 Thread Nathan Chancellor
Hey Greg and Harry, On Thu, Jan 30, 2025 at 11:02:37AM -0500, Harry Wentland wrote: > On 2025-01-30 02:04, Greg KH wrote: > > On Thu, Jan 30, 2025 at 07:47:59AM +0100, Greg KH wrote: > > > Thanks, but I am still getting this error on Linus's current tree right > > > now, with this commit applied:

Re: [PATCH] drm/amd/display: mark static functions noinline_for_stack

2025-01-16 Thread Nathan Chancellor
Hi Tzung-Bi, First of all, thanks for the patch! On Thu, Jan 09, 2025 at 05:35:04AM +, Tzung-Bi Shih wrote: > When compiling allmodconfig (CONFIG_WERROR=y) with clang-19, see the > following errors: > > .../display/dc/dml2/display_mode_core.c:6268:13: warning: stack frame size > (3128) exce

[PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

2024-12-19 Thread Nathan Chancellor
rrent build. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412121748.chux4sap-...@intel.com/ Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/d

Re: [PATCH] drm/amd/display: Disable -Wenum-float-conversion for dml2_dpmm_dcn4.c

2024-12-19 Thread Nathan Chancellor
On Thu, Dec 19, 2024 at 05:21:41PM -0500, Alex Deucher wrote: > On Thu, Dec 19, 2024 at 12:23 PM Nathan Chancellor wrote: > > If you would prefer reapplying the local fix, feel free to do so, but I > > would like for it to be in the upstream source so it does not have to > &g

[PATCH] drm/amd/display: Disable -Wenum-float-conversion for dml2_dpmm_dcn4.c

2024-12-19 Thread Nathan Chancellor
intained. Fixes: be4e3509314a ("drm/amd/display: DML21 Reintegration For Various Fixes") Signed-off-by: Nathan Chancellor --- If you would prefer reapplying the local fix, feel free to do so, but I would like for it to be in the upstream source so it does not have to keep being applied.

Re: [PULL] drm-misc-next

2024-11-19 Thread Nathan Chancellor
On Tue, Nov 19, 2024 at 04:29:53PM +, Liviu Dudau wrote: > On Mon, Nov 18, 2024 at 08:08:16AM -0700, Nathan Chancellor wrote: > > On Thu, Oct 31, 2024 at 02:41:38PM +0100, Maarten Lankhorst wrote: > > > Cristian Ciocaltea (3): > > > drm/rockchip: Add basic

Re: [PULL] drm-misc-next

2024-11-18 Thread Nathan Chancellor
On Thu, Oct 31, 2024 at 02:41:38PM +0100, Maarten Lankhorst wrote: > Cristian Ciocaltea (3): > drm/rockchip: Add basic RK3588 HDMI output support Can someone please apply [1] to resolve a link time failure seen with 32-bit clang builds? I am still seeing it in -next and my ping on the patch

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-04 Thread Nathan Chancellor
s this function is not performance criticial, just Use the div_u64() helper. > > Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output support") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Can someone please pick this up? It is still broken in

Re: [PATCH 0/8] drm: fix and enable warnings on unused static inlines

2024-09-11 Thread Nathan Chancellor
across subsystem. I merged drm-misc-next into next-20240910 and applied this series on top of the result and it looks like all of the instances are fixed. Tested-by: Nathan Chancellor # build Cheers, Nathan

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Nathan Chancellor
On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > Are these just warnings introduced by recent versions of the toolchains? > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Nathan Chancellor
On Wed, Sep 04, 2024 at 12:16:48PM +0100, Mark Brown wrote: > [01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document > commit: ceb3ca2876243e3ea02f78b3d488b1f2d734de49 > [02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card > document > commit: 76d

Re: [PATCH] drm: enable warnings on unused static inlines

2024-09-04 Thread Nathan Chancellor
gt; inline functions for W=1 build"). > > Cc: Nathan Chancellor > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index 784229d4504d..

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Nathan Chancellor
On Thu, Aug 29, 2024 at 09:37:34PM +0300, Jani Nikula wrote: > On Thu, 29 Aug 2024, Nathan Chancellor wrote: > > Since commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). clang warns about unused static inline > > fu

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Nathan Chancellor
On Thu, Aug 29, 2024 at 09:10:41PM +0300, Andy Shevchenko wrote: > On Thu, Aug 29, 2024 at 07:53:25PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote: > > > On Thu, 29 Aug 2024, Andy Shevchenko > > > wrote: > > > > With CONFIG_WERROR=y and `make W=1`

[PATCH] drm/xe: Fix total initialization in xe_ggtt_print_holes()

2024-08-23 Thread Nathan Chancellor
gtt_print_holes() to resolve the warning. Fixes: 136367290ea5 ("drm/xe: Introduce xe_ggtt_print_holes") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/xe/xe_ggtt.c | 2 +- drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] drm/amd/display: Reapply 2fde4fdddc1f

2024-07-24 Thread Nathan Chancellor
CALE_FACTOR * (vco_freq_khz / clock_khz)); | ~~ ^ ~~ 1 error generated. Apply the fix again to resolve the warning. Fixes: 2563391e57b5 ("drm/amd/display: DML2.1 resynchronization") Signed-off-b

Re: linux-next: build failure after merge of the drm tree

2024-07-01 Thread Nathan Chancellor
On Mon, Jul 01, 2024 at 07:13:19PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from arch/powerpc/include/asm/mmu.h:144, > from arch/powerpc/include/asm/paca.h:18,

[PATCH] drm/omap: Restrict compile testing to PAGE_SIZE less than 64KB

2024-06-20 Thread Nathan Chancellor
and it will only ever be run on hardware that has a 4KB page size, just restrict compile testing to when the page size is less than 64KB (as no other issues have been discussed and it keeps compile testing relatively more available). Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/omapdrm/K

[PATCH] drm/amd/display: Disable CONFIG_DRM_AMD_DC_FP for RISC-V with clang

2024-06-14 Thread Nathan Chancellor
ake the condition a little more readable naturally. Fixes: a28e4b672f04 ("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") Reported-by: Palmer Dabbelt Closes: https://lore.kernel.org/20240530145741.7506-2-pal...@rivosinc.com/ Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/d

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-13 Thread Nathan Chancellor
Hi Palmer (and AMD folks), On Tue, Jun 04, 2024 at 09:04:23AM -0700, Palmer Dabbelt wrote: > On Mon, 03 Jun 2024 15:29:48 PDT (-0700), nat...@kernel.org wrote: > > On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > > > From: Palmer Dabbelt > > > > > > I get a handful of build erro

Re: [PATCH v3] drm/msm/a6xx: use __unused__ to fix compiler warnings for gen7_* includes

2024-06-05 Thread Nathan Chancellor
Hi Abhinav, Just a drive by style comment. On Tue, Jun 04, 2024 at 05:38:28PM -0700, Abhinav Kumar wrote: > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > index 0a7717a4fc2f..a958e2b3c025 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_g

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-03 Thread Nathan Chancellor
Hi Palmer, On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > I get a handful of build errors along the lines of > > > linux/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:58:13: > error: stack frame size (2352) exceeds lim

[PATCH] drm/radeon: Remove __counted_by from StateArray.states[]

2024-05-29 Thread Nathan Chancellor
e to support this in future compiler releases. Cc: sta...@vger.kernel.org Closes: https://github.com/ClangBuiltLinux/linux/issues/2028 Fixes: efade6fe50e7 ("drm/radeon: silence UBSAN warning (v3)") Signed-off-by: Bill Wendling Co-developed-by: Nathan Chancellor Signed-off-by: Nathan Chan

Re: [PATCH] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Nathan Chancellor
Hi Dmitry, On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote: > We don't need to run the validation of the XML files if we are just > compiling the kernel. Skip the validation unless the user enables > corresponding Kconfig option. This removes a warning from gen_header.py > about l

Re: [PATCH v3 0/2] Fix Kernel CI issues

2024-05-03 Thread Nathan Chancellor
Hi Tomi, On Sat, Apr 27, 2024 at 10:48:16AM +0300, Tomi Valkeinen wrote: > On 26/04/2024 22:27, Anatoliy Klymenko wrote: > > Fix number of CI reported W=1 build issues. > > > > Patch 1/2: Fix function arguments description. > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202404260616.kfgdp

[PATCH 2/2] drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o

2024-04-24 Thread Nathan Chancellor
: d546a39c6b10 ("drm/amd/display: Add misc DC changes for DCN401") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/Makefile b/drivers/gpu/drm/amd/displ

[PATCH 1/2] drm/amd/display: Add frame_warn_flag to dml2_core_shared.o

2024-04-24 Thread Nathan Chancellor
drm/amd/display: Add misc DC changes for DCN401") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/Makefile b/drivers/gpu/drm/amd/display/dc/dml2/Makefile

[PATCH 0/2] drm/amd/display: Use frame_warn_flag consistently in dml2 Makefile

2024-04-24 Thread Nathan Chancellor
Hi all, This series resolves a couple instances of -Wframe-larger-than from the new display code that appear with newer versions of clang along without another inconsistency I noticed while fixing this, which have been accounted for with the $(frame_warn_flag) variable. --- Nathan Chancellor (2

[PATCH] drm/amd/display: Avoid -Wenum-float-conversion in add_margin_and_round_to_dfs_grainularity()

2024-04-24 Thread Nathan Chancellor
lear to the compiler. Fixes: 3df48ddedee4 ("drm/amd/display: Add new DCN401 sources") Signed-off-by: Nathan Chancellor --- Alternatively, perhaps the potential truncation could happen before the multiplication? divider = DFS_DIVIDER_RANGE_SCALE_FACTOR * (unsigned int)(vco_freq_khz / clo

[PATCH] drm/xe: Add xe_guc_ads.c to uses_generated_oob

2024-04-10 Thread Nathan Chancellor
LINK resolve_btfids HOSTCC drivers/gpu/drm/xe/xe_gen_wa_oob GEN xe_wa_oob.c xe_wa_oob.h CC [M] drivers/gpu/drm/xe/xe_guc_ads.o Fixes: c151ff5c9053 ("drm/xe/lnl: Enable GuC Wa_14019882105") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/xe/Makefile | 1

[PATCH] drm/panthor: Fix clang -Wunused-but-set-variable in tick_ctx_apply()

2024-03-28 Thread Nathan Chancellor
e variable is an artifact left over from refactoring that occurred during the development of the initial series for this driver. Remove it to resolve the warning. Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Signed-off-by: Nathan Chancellor --- dri

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-03-28 Thread Nathan Chancellor
Hi Boris, On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > --- > drivers/gpu/drm/panthor/panthor_sched.c | 3502 +++ > drivers/gpu/drm/panthor/panthor_sched.h | 50 + > 2 files changed, 3552 insertions(+) > create mode 100644 drivers/gpu/drm/panthor/panth

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-27 Thread Nathan Chancellor
On Wed, Mar 27, 2024 at 09:59:01AM +0200, Jani Nikula wrote: > On Wed, 27 Mar 2024, Maxime Ripard wrote: > > On Tue, Mar 26, 2024 at 03:56:50PM -0700, Nathan Chancellor wrote: > >> On Tue, Mar 05, 2024 at 11:07:36AM +0200, Jani Nikula wrote: > >> > Add kconfig to

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-26 Thread Nathan Chancellor
On Tue, Mar 05, 2024 at 11:07:36AM +0200, Jani Nikula wrote: > Add kconfig to enable -Werror subsystem wide. This is useful for > development and CI to keep the subsystem warning free, while avoiding > issues outside of the subsystem that kernel wide CONFIG_WERROR=y might > hit. > > v2: Don't depe

Re: [PATCH V8 08/12] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-02-06 Thread Nathan Chancellor
On Tue, Feb 06, 2024 at 12:50:16PM -0600, Adam Ford wrote: > On Tue, Feb 6, 2024 at 11:06 AM Nathan Chancellor wrote: > > > > Hi all, > > > > On Sat, Feb 03, 2024 at 10:52:48AM -0600, Adam Ford wrote: > > > From: Lucas Stach > > > > > > This

Re: [PATCH V8 08/12] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-02-06 Thread Nathan Chancellor
Hi all, On Sat, Feb 03, 2024 at 10:52:48AM -0600, Adam Ford wrote: > From: Lucas Stach > > This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a > full timing generator and can switch between different video sources. On > the i.MX8MP however the only supported source is the L

[PATCH] drm/amd/display: Increase frame-larger-than for all display_mode_vba files

2024-02-05 Thread Nathan Chancellor
es: https://github.com/ClangBuiltLinux/linux/issue/1990 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Make

Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-11 Thread Nathan Chancellor
Hi Alexei, On Thu, Jan 11, 2024 at 12:00:50PM -0800, Alexei Starovoitov wrote: > On Thu, Jan 11, 2024 at 11:40 AM Nathan Chancellor wrote: > > > > Hi Yonghong, > > > > On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > > > > &g

Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-11 Thread Nathan Chancellor
Hi Yonghong, On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > On 1/9/24 2:16 PM, Nathan Chancellor wrote: > > reviews.llvm.org was LLVM's Phabricator instances for code review. It > > has been abandoned in favor of GitHub pull requests. While the major

[PATCH] drm/amd/display: Avoid enum conversion warning

2024-01-10 Thread Nathan Chancellor
Request usb4 bw for mst streams") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c b/drivers/gpu/drm/a

[PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-09 Thread Nathan Chancellor
ation. Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while in the area. Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 Signed-off-by: Nathan Chancellor --- Cc: a...@kernel.org Cc: dan...@iogearbox.net Cc: and...@kernel.

[PATCH 2/3] arch and include: Update LLVM Phabricator links

2024-01-09 Thread Nathan Chancellor
Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 Signed-off-by: Nathan Chancellor --- arch/arm64/Kconfig | 4 ++-- arch/riscv/Kconfig | 2 +- arch/riscv/include/asm/ftrace.h | 2 +- include/linux/compiler-clang.h | 2 +- 4 files changed, 5 inser

[PATCH 3/3] treewide: Update LLVM Bugzilla links

2024-01-09 Thread Nathan Chancellor
gs.llvm.org/show_bug.cgi?id=" links to the "https://llvm.org/pr" shortlink so that the links show the most up to date information. Each migrated issue links back to the Bugzilla entry, so there should be no loss of fidelity of information here. Signed-off-by: Nathan Chancellor

[PATCH 0/3] Update LLVM Phabricator and Bugzilla links

2024-01-09 Thread Nathan Chancellor
al (famous last words...). --- Nathan Chancellor (3): selftests/bpf: Update LLVM Phabricator links arch and include: Update LLVM Phabricator links treewide: Update LLVM Bugzilla links arch/arm64/Kconfig | 4 +-- arch/powerp

[PATCH 3/3] drm/bridge: Return NULL instead of plain 0 in drm_dp_hpd_bridge_register() stub

2023-12-05 Thread Nathan Chancellor
-kbuild-all/202312060025.bdeqzrwx-...@intel.com/ Fixes: e560518a6c2e ("drm/bridge: implement generic DP HPD bridge") Signed-off-by: Nathan Chancellor --- include/drm/bridge/aux-bridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/bridge/aux-bridge.h b/i

[PATCH 2/3] usb: typec: qcom-pmic-typec: Only select DRM_AUX_HPD_BRIDGE with OF

2023-12-05 Thread Nathan Chancellor
HPD_BRIDGE with both CONFIG_DRM_BRIDGE and CONFIG_OF to clear up the warning. Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") Signed-off-by: Nathan Chancellor --- drivers/usb/typec/tcpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 0/3] A few fixes for transparent bridge support

2023-12-05 Thread Nathan Chancellor
Hi all, This series fixes two Kconfig issues that I noticed with the selection of CONFIG_DRM_AUX{,_HPD}_BRIDGE along with a fix for a sparse report that I noticed while seeing if these had already been resolved. --- Nathan Chancellor (3): usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE

[PATCH 1/3] usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF

2023-12-05 Thread Nathan Chancellor
clear up the warning. Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") Signed-off-by: Nathan Chancellor --- drivers/usb/typec/mux/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux

Re: [RFC] drm: enable W=1 warnings by default across the subsystem

2023-12-01 Thread Nathan Chancellor
On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > Cc: Nathan Chancellor > > > > On 11/29/23 13:12, Jani Nikula wrote: > >> At least the i915 and amd drivers enable a bunch more compiler warnings

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-11-29 Thread Nathan Chancellor
On Thu, Nov 23, 2023 at 02:23:01PM +, Conor Dooley wrote: > On Tue, Nov 21, 2023 at 07:05:15PM -0800, Samuel Holland wrote: > > RISC-V uses kernel_fpu_begin()/kernel_fpu_end() like several other > > architectures. Enabling hardware FP requires overriding the ISA string > > for the relevant comp

Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action function

2023-11-15 Thread Nathan Chancellor
ction_free+0x18/0x20 ... With this series applied with https://lore.kernel.org/20231106172557.2963-1...@opensource.cirrus.com/, all the tests pass for arm64 and x86_64 on my machine. I see no remaining casts in the tree in this state. It seems like the documentation in Documentation/dev-tools/

Re: [PATCH 02/22] fb: atmel_lcdfb: Stop using platform_driver_probe()

2023-11-08 Thread Nathan Chancellor
On Tue, Nov 07, 2023 at 10:17:43AM +0100, Uwe Kleine-König wrote: > On today's platforms the benefit of platform_driver_probe() isn't that > relevant any more. It allows to drop some code after booting (or module > loading) for .probe() and discard the .remove() function completely if > the driver

Re: [PATCH] drm/amd/display: Increase frame warning limit for clang in dml2

2023-11-02 Thread Nathan Chancellor
On Thu, Nov 02, 2023 at 12:59:00PM -0400, Hamza Mahfooz wrote: > On 11/2/23 12:24, Nathan Chancellor wrote: > > When building ARCH=x86_64 allmodconfig with clang, which have sanitizers > > enabled, there is a warning about a large stack frame. > > > > > > driv

[PATCH v2] drm/amd/display: Increase frame warning limit with KASAN or KCSAN in dml2

2023-11-02 Thread Nathan Chancellor
ady set to zero when it is enabled, which is accounted for by the check for CONFIG_FRAME_WARN=0 in the dml2 Makefile. Signed-off-by: Nathan Chancellor --- If there is another DRM pull before 6.7-rc1, it would be much appreciated if this could make that so that other trees are not potentially broken

[PATCH] drm/amd/display: Increase frame warning limit for clang in dml2

2023-11-02 Thread Nathan Chancellor
ves, the limit increase can be restricted to older clang versions. Signed-off-by: Nathan Chancellor --- If there is another DRM pull before 6.7-rc1, it would be much appreciated if this could make that so that other trees are not potentially broken by this. If not, no worries, as it was my fau

[PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2

2023-10-18 Thread Nathan Chancellor
t;drm/amd/display: Respect CONFIG_FRAME_WARN=0 in dml Makefile") but for DML2. Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dml2/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] drm/debugfs: Fix drm_debugfs_remove_files() stub

2023-09-13 Thread Nathan Chancellor
bugfs_create_files implementation v2") Signed-off-by: Nathan Chancellor --- include/drm/drm_debugfs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_debugfs.h b/include/drm/drm_debugfs.h index 7213ce15e4ff..3bba169f9bae 100644 --- a/include/drm/drm_debugfs.h +++ b/in

[PATCH] drm/amd/display: Fix -Wuninitialized in dm_helpers_dp_mst_send_payload_allocation()

2023-09-13 Thread Nathan Chancellor
of this function so allocate old_payload on the stack and pass it by reference to dm_helpers_construct_old_payload(), resolving the warning. Closes: https://github.com/ClangBuiltLinux/linux/issues/1931 Fixes: 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") Si

Re: [PATCH] backlight: lp855x: Drop ret variable in brightness change function

2023-08-15 Thread Nathan Chancellor
t; Signed-off-by: Artur Weber > Fixes: 5145531be5fb ("backlight: lp855x: Catch errors when changing > brightness") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202308091728.nejhgupp-...@intel.com/ Reviewed-by: Nathan Chancellor >

Re: [PATCH 1/2] drm/exec: use unique instead of local label

2023-08-10 Thread Nathan Chancellor
On Thu, Aug 10, 2023 at 08:48:05AM +0200, Christian König wrote: > Am 10.08.23 um 08:40 schrieb Boris Brezillon: > > On Wed, 9 Aug 2023 08:37:55 -0700 > > Nathan Chancellor wrote: > > > > > Hi Christian, > > > > > > Can this be applied to

Re: [PATCH 1/2] drm/exec: use unique instead of local label

2023-08-09 Thread Nathan Chancellor
c.gnu.org/onlinedocs/gcc/Statement-Exprs.html > Link: https://github.com/ClangBuiltLinux/linux/issues/1890 > Link: > https://github.com/llvm/llvm-project/commit/20219106060208f0c2f5d096eb3aed7b712f5067 > Reported-by: Nathan Chancellor > Reported-by: Naresh Kamboju > CC: Boris Brezillon

Re: [PATCH 1/2] drm/exec: use unique instead of local label

2023-07-31 Thread Nathan Chancellor
it 09593216bff1 ("drm: execution context for GEM buffers v7") > Link: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html > Link: https://github.com/ClangBuiltLinux/linux/issues/1890 > Link: > https://github.com/llvm/llvm-project/commit/20219106060208f0c2f5d096eb3aed

Re: [PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'

2023-07-29 Thread Nathan Chancellor
On Sat, Jul 29, 2023 at 09:12:05PM +0700, Bagas Sanjaya wrote: > On Fri, Jul 28, 2023 at 10:35:19PM +0800, 孙冉 wrote: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > > > Signed-off-by: Ran Sun > > Your From: address != SoB identity While the comment below is a completely valid c

Re: [PATCH v2] drm: fix indirect goto into statement expression UB

2023-07-28 Thread Nathan Chancellor
> case in the codebase. > > Fixes: commit 09593216bff1 ("drm: execution context for GEM buffers v7") > Link: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html > Link: https://github.com/ClangBuiltLinux/linux/issues/1890 > Link: > https://github.com/llvm/llvm-proj

Re: [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-27 Thread Nathan Chancellor
Hi Maira, On Thu, Jul 27, 2023 at 11:01:27AM -0300, Maira Canal wrote: > Hi Nathan, > > On 7/18/23 18:44, Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > > left hand side is a constant shows

Re: [PATCH 1/6] drm: execution context for GEM buffers v7

2023-07-22 Thread Nathan Chancellor
Hi Christian, On Tue, Jul 11, 2023 at 03:31:17PM +0200, Christian König wrote: > This adds the infrastructure for an execution context for GEM buffers > which is similar to the existing TTMs execbuf util and intended to replace > it in the long term. > > The basic functionality is that we abstrac

Re: [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-20 Thread Nathan Chancellor
On Thu, Jul 20, 2023 at 09:43:05AM +0100, Tvrtko Ursulin wrote: > > On 18/07/2023 22:44, Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > > left hand side is a constant shows the following instance in > > ns

[PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-18 Thread Nathan Chancellor
r to avoid breaking builds that can hit this with CONFIG_WERROR, that would be nice, but I won't insist since I don't think our own CI has builds that has those conditions, but others might. --- Nathan Chancellor (2): drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiff

[PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-18 Thread Nathan Chancellor
ake the expression a boolean to make it clear this should be a logical check, not a bitwise one. Link: https://reviews.llvm.org/D142609 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-18 Thread Nathan Chancellor
comparison against zero to make the expression a boolean to make it clear this should be a logical check, not a bitwise one. Link: https://reviews.llvm.org/D142609 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/v3d/v3d_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH] drm/amd/display: Allow building DC with clang on RISC-V

2023-07-18 Thread Nathan Chancellor
ed for, so I agree. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > > drivers/gpu/drm/amd/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/Kconfig > b/drivers/gpu/drm/amd/display/Kconfig >

Re: [PATCH v4 18/21] compiler.h: RFC - s/__LINE__/__COUNTER__/ in __UNIQUE_ID fallback

2023-07-13 Thread Nathan Chancellor
; Lets see what lkp-robot says about this. > > CC: Luc Van Oostenryck (maintainer:SPARSE > CHECKER) > CC: Nathan Chancellor (supporter:CLANG/LLVM BUILD SUPPORT) > CC: Nick Desaulniers (supporter:CLANG/LLVM BUILD > SUPPORT) > CC: Tom Rix (reviewer:CLANG/LLVM BUILD SUP

[PATCH 0/2] drm/amdgpu: Fix instances of -Wunused-const-variable with CONFIG_DEBUG_FS=n

2023-06-15 Thread Nathan Chancellor
Hi all, After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), I see a few instances of -Wunused-const-variable with configurations that do not enable CONFIG_DEBUG_FS, such as Alpine Linux's. This series includes two patches to resolve each warning I see. --- Natha

[PATCH 2/2] drm/amdgpu: Move clocks closer to its only usage in amdgpu_parse_cg_state()

2023-06-15 Thread Nathan Chancellor
38 | static const struct cg_flag_name clocks[] = { | ^ 1 error generated. clocks is only used when CONFIG_DEBUG_FS is set, so move the definition into the CONFIG_DEBUG_FS block right above its only usage to clear up the warning. Signed-off-by: Nathan Chan

[PATCH 1/2] drm/amdgpu: Remove CONFIG_DEBUG_FS guard around body of amdgpu_rap_debugfs_init()

2023-06-15 Thread Nathan Chancellor
an error pointer in that situation. Remove the preprocessor guards so that the variable never appears unused, while not changing anything at run time. Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

Re: [PATCH] drm/amdgpu: Wrap -Wunused-but-set-variable in cc-option

2023-06-12 Thread Nathan Chancellor
On Sat, Jun 10, 2023 at 10:14:05AM +0300, Jani Nikula wrote: > On Thu, 08 Jun 2023, Nathan Chancellor wrote: > > -Wunused-but-set-variable was only supported in clang starting with > > 13.0.0, so earlier versions will emit a warning, which is turned into a > > hard error for

Re: [PATCH] drm/amd/amdgpu: enable W=1 for amdgpu

2023-06-09 Thread Nathan Chancellor
;s enable > these checks unconditionally for the entire module to catch these errors > during development. > > Cc: Alex Deucher > Cc: Nathan Chancellor > Signed-off-by: Hamza Mahfooz I think this is fine, especially since it will help catch issues in amdgpu quickly and hopefully

[PATCH] drm/amdgpu: Wrap -Wunused-but-set-variable in cc-option

2023-06-08 Thread Nathan Chancellor
ltLinux/linux/issues/1869 Fixes: a0fd5a5f676c ("drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu

[PATCH] drm/i915/pxp: Fix size_t format specifier in gsccs_send_message()

2023-05-30 Thread Nathan Chancellor
->drm, "caller with insufficient PXP reply size %u (%ld)\n", | ^~~~ cc1: all warnings being treated as errors Use the '%zu' format specifier, as the variable is a 'size_t'. Fixes: dc9ac125d81f ("drm/i915/pxp: Add GSC-CS backend

[PATCH 2/2] drm/i915/gt: Fix parameter in gmch_ggtt_insert_{entries,page}()

2023-05-30 Thread Nathan Chancellor
k's signature does not exactly match the prototype's signature. To fix this, replace the cache_level parameter with pat_index, as was done in other places within i915 where there is no difference between cache_level and pat_index on certain generations. Fixes: 9275277d5324 ("dr

[PATCH 1/2] drm/i915/gt: Fix second parameter type of pre-gen8 pte_encode callbacks

2023-05-30 Thread Nathan Chancellor
t i915_address_space' expects a second parameter type of 'unsigned int'. Update the second parameter of the callbacks and the comment above them noting that these statements are still valid, which matches other functions and files, to clear up the kCFI failures at run time. Fixes: 92

[PATCH 0/2] drm/i915/gt: Fix recent kCFI violations

2023-05-30 Thread Nathan Chancellor
on-pointer-types-strict (which is not yet enabled for the kernel but I build with it locally to catch new instances). If there are any problems or questions, please let me know. --- Nathan Chancellor (2): drm/i915/gt: Fix second parameter type of pre-gen8 pte_encode callbacks drm/i9

  1   2   3   4   >