by: Stanislav Lisovskiy
Looks good now,
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 50 +
> drivers/gpu/drm/i915/display/intel_dp.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 -
> 3 files changed
Thanks Stan for the explanation,
With that
Reviewed-by: Manasi Navare
Manasi
-Original Message-
From: Lisovskiy, Stanislav
Sent: Tuesday, November 22, 2022 2:40 AM
To: Navare, Manasi D
Cc: intel-...@lists.freedesktop.org; Saarinen, Jani ;
Nikula, Jani ; dri-devel
On Thu, Nov 03, 2022 at 03:23:00PM +0200, Stanislav Lisovskiy wrote:
> Fix intel_dp_dsc_compute_config, previously timeslots parameter
> was used in fact not as a timeslots, but more like a ratio
> timeslots/64, which of course didn't have any effect for SST DSC,
> but causes now issues for MST DSC
On Thu, Nov 03, 2022 at 03:21:46PM +0200, Stanislav Lisovskiy wrote:
> We might to use that function separately from intel_dp_dsc_compute_config
> for DP DSC over MST case, because allocating bandwidth in that
> case can be a bit more tricky. So in order to avoid code copy-pasta
> lets extract this
dmi_info struct and not combine
with DP VRR info struct in display info since hdmi info has other HDMI
cap info stored here.
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/drm_edid.c | 26 --
> include/drm/drm_connector.h | 27 ++
On Sat, Aug 27, 2022 at 12:34:53AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename info->monitor_range to info->vrr_range to actually
> reflect its usage.
Okay makes sense.
Reviewed-by: Manasi Navare
Manasi
>
> Cc: Manasi Navare
> Cc: Nicholas Kazla
adding this description for monitor_range
Reviewed-by: Manasi Navare
Manasi
> Cc: Manasi Navare
> Cc: Nicholas Kazlauskas
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Rodrigo Siqueira
> Cc: amd-...@lists.freedesktop.org
> Signed-off-by: Ville Syrjälä
> ---
> drivers/g
RM_EDID_RANGE_OFFSET_MIN_VFREQ)
> + monitor_range->min_vfreq += 255;
> + if (data->pad2 & DRM_EDID_RANGE_OFFSET_MAX_VFREQ)
> + monitor_range->max_vfreq += 255;
Yes this makes sense. This looks like added for supportin
On Thu, Aug 11, 2022 at 10:33:51AM +0300, Lisovskiy, Stanislav wrote:
> On Wed, Aug 10, 2022 at 04:02:08PM -0400, Lyude Paul wrote:
> > Btw, what's the plan for this? Figured I'd ask since I noticed this on the
> > ML,
> > nd I'm now finishing up getting the atomic only MST patches I've been
> >
On Tue, May 17, 2022 at 12:56:36PM +0530, Bhanuprakash Modem wrote:
> This function sets the vrr_enabled property for crtc based
> on the platform support and the request from userspace.
>
> V2: Check for platform support before updating the prop.
> V3: Don't attach vrr_enabled prop, as it is alre
On Tue, May 17, 2022 at 12:56:35PM +0530, Bhanuprakash Modem wrote:
> Modern display hardware is capable of supporting variable refresh rates.
> This patch introduces helpers to attach and set "vrr_enabled" property
> on the crtc to allow userspace to query VRR enabled status on that crtc.
>
> Ato
On Mon, Apr 25, 2022 at 12:16:11PM +0530, Bhanuprakash Modem wrote:
> Modern display hardware is capable of supporting variable refresh rates.
> This patch introduces helpers to attach and set "vrr_enabled" property
> on the crtc to allow userspace to query VRR enabled status on that crtc.
>
> Ato
Yes I agree that this data parsed from EDID/Display ID should be stored in
structs defined in drm_display_info.
Like for the VRR range that we parse from EDID, we store that in a struct
monitor_range in drm_display_info.
Manasi
-Original Message-
From: dri-devel On Behalf Of Jani
Niku
On Tue, Jan 18, 2022 at 06:34:20PM +0200, Ville Syrjälä wrote:
> On Fri, Oct 22, 2021 at 12:51:12PM -0700, Navare, Manasi wrote:
> >
> > Hi Ville,
> >
> > Could you take a look at this, this addresses teh review comments from prev
> > version
>
> I
Hi Ville,
Could you take a look at this, this addresses teh review comments from prev
version
Manasi
On Mon, Oct 04, 2021 at 04:59:13AM -0700, Manasi Navare wrote:
> In case of a modeset where a mode gets split across mutiple CRTCs
> in the driver specific implementation (bigjoiner in i915) w
We have merged such DRM definition dependencies previously through a topic
branch in order to avoid redefining inside the driver.
But yes guarding this with ifdef is good.
Reviewed-by: Manasi Navare
Manasi
-Original Message-
From: Zuo, Jerry
Sent: Tuesday, September 28, 2021 11:11
joiner-slave. This code path related to mpll is done on dg2
> and need this fix to avoid null pointer dereference issue.
>
> Cc: Manasi Navare
> Signed-off-by: Animesh Manna
> Signed-off-by: Matt Roper
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/di
On Fri, Mar 26, 2021 at 06:15:22PM +0200, Ville Syrjälä wrote:
> On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote:
> > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote:
> > > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote:
> > >
On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote:
> > On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote:
> > > On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote:
> > >
On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 19, 2021 at 01:54:13PM -0700, Navare, Manasi wrote:
> > On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote:
> > > On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote:
> > >
On Fri, Mar 19, 2021 at 04:56:24PM +0200, Ville Syrjälä wrote:
> On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote:
> > So basically we see this warning only in case of bigjoiner when
> > drm_atomic_check gets called without setting the state->allow_modeset flag.
&g
eck there then the affected crtc wont count the slave crtc
and we wont get this warning.
Ville, Danvet?
Manasi
On Tue, Mar 16, 2021 at 10:35:09PM +0100, Daniel Vetter wrote:
> On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen wrote:
> >
> > On Mon, 8 Mar 2021 16:52:58 -0800
> >
On Tue, Mar 16, 2021 at 11:46:38PM +, Daniel Stone wrote:
> On Tue, 16 Mar 2021 at 21:35, Daniel Vetter wrote:
>
> > On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen
> > wrote:
> > > On Mon, 8 Mar 2021 16:52:58 -0800
> > > "Navare, Manasi" wrote:
On Thu, Mar 04, 2021 at 10:42:23AM +0200, Pekka Paalanen wrote:
> On Wed, 3 Mar 2021 12:44:33 -0800
> "Navare, Manasi" wrote:
>
> > On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote:
> > > On Tue, 2 Mar 2021 12:41:32 -0800
> > > Manasi N
On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote:
> On Tue, 2 Mar 2021 12:41:32 -0800
> Manasi Navare wrote:
>
> > In case of a modeset where a mode gets split across mutiple CRTCs
> > in the driver specific implementation (bigjoiner in i915) we wrongly count
> > the affected CRTCs
On Wed, Feb 10, 2021 at 05:07:03PM +0200, Ville Syrjälä wrote:
> On Wed, Feb 10, 2021 at 01:38:45PM +, Simon Ser wrote:
> > On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter
> > wrote:
> >
> > > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote:
> > >
> > > > These addi
On Fri, Feb 05, 2021 at 10:06:48PM +0200, Ville Syrjälä wrote:
> On Fri, Feb 05, 2021 at 12:07:41PM -0800, Navare, Manasi wrote:
> > On Fri, Feb 05, 2021 at 09:58:07PM +0200, Ville Syrjälä wrote:
> > > On Thu, Feb 04, 2021 at 12:18:40PM +0530, Ankit Nautiyal wrote:
> > >
> > + if (intel_dp->dpcd[DP_DPCD_REV] < 0x14)
> > + return;
> > +
>
> Can't check the spec, but makes sense that this stuff is only valid
> for recent DCPD revisions.
>
> Acked-by: Ville Syrjälä
Yes checked the DP
On Tue, Dec 08, 2020 at 02:33:54PM +0200, Jani Nikula wrote:
> The VBT fields match the DPCD data, so use the same helper.
>
> Cc: Manasi Navare
> Cc: Vandita Kulkarni
> Signed-off-by: Jani Nikula
Only for DSI so far right?
In that case looks good
Reviewed-by: Manasi
make this a non-functional change.
>
> Cc: Manasi Navare
> Cc: Vandita Kulkarni
> Signed-off-by: Jani Nikula
So still using the hardcoded value since thats in the DSC C model, Looks good
to me
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/i915/display/icl_d
below DP 2.0 DPCD registers from the DP 2.0 spec
Reviewed-by: Manasi Navare
Manasi
> ---
> include/drm/drm_dp_helper.h | 52 -
> 1 file changed, 45 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm
On Fri, Sep 18, 2020 at 02:40:16PM +0300, Jani Nikula wrote:
> Add the subheadings from the DP spec. No functional changes.
>
> Signed-off-by: Jani Nikula
Looks good to me
Reviewed-by: Manasi Navare
Manasi
> ---
> include/drm/drm_dp_helper.h | 22 ++
&g
On Tue, Sep 15, 2020 at 03:47:01PM -0400, Lyude Paul wrote:
> On Tue, 2020-09-15 at 15:06 -0400, Rodrigo Vivi wrote:
> > On Tue, Sep 15, 2020 at 01:29:35PM -0400, Lyude Paul wrote:
> > > Since we're about to start adding support for Intel's magic HDR
> > > backlight interface over DPCD, we need to
On Wed, Jul 22, 2020 at 05:36:27PM -0700, Khaled Almahallawy wrote:
> Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests.
>
> v2: uniform bit names TP4a/b/c (Manasi)
>
> Signed-off-by: Khaled Almahallawy
Looks good to me,
Reviewed-by: Manasi Navare
Khaled, could you also giv
Hi Lorrany,
Its great to hear that you are interested in VKMS project.
Is this your first time in the DRM subsystem or the Linux kernel? First of all,
welcome!
In order to improve your experience, we selected a set of tutorials that may
help you to get into the DRM subsystem:
1. This project is
Thank you so much for giving me this opportunity to be on the X.org board. I
look forward to active participation in the upcoming conferences as well as
mentorship for Google SOC.
I am currently on vacation till May 16th with limited email access and will
resume attending the board meetings aft
Hi Luc,
I have submitted a proposal for a talk in Graphics Dev Room, but haven’t heard
anything regarding the selection. Is there a timeline by which the
notifications will be sent so that the travel can be planned accordingly?
Has anyone else heard about the submissions?
Regards
Manasi
Hi,
On Fri, Feb 24, 2017 at 12:09:51PM -0800, Manasi Navare wrote:
> Hi Daniel,
>
> We have ACKs on the userspace design from both Adams and Eric.
> Is this enough to merge the kernel patches?
>
> I spoke to Eric briefly about this and he gave me a verbal r-b as well.
> He said the userspace patches
On Fri, 17 Feb 2017, Manasi Navare wrote:
> Display stream compression is supported on DP 1.4 DP devices. This
> patch adds the corersponding DPCD register definitions for DSC.
>
> v2:
> * Rebased on drm-tip
>
> Signed-off-by: Manasi Navare
> Cc: Jani Nikula
> Cc: Paulo Zanoni
> Cc: dri-devel
39 matches
Mail list logo
