Re: [PATCH v2] drm/simpledrm: Add support for multiple "power-domains"

2023-09-18 Thread Neal Gompa
sdev->dev, "failed to link power-domain > %d\n", i); > + } > + > + return devm_add_action_or_reset(dev, simpledrm_device_detach_genpd, > sdev); > +} > +#else > +static int simpledrm_device_attach_genpd(struct simpledrm_device *sdev) > +{ > + return 0; > +} > +#endif > + > /* > * Modesetting > */ > @@ -651,6 +753,9 @@ static struct simpledrm_device > *simpledrm_device_create(struct drm_driver *drv, > if (ret) > return ERR_PTR(ret); > ret = simpledrm_device_init_regulators(sdev); > + if (ret) > + return ERR_PTR(ret); > + ret = simpledrm_device_attach_genpd(sdev); > if (ret) > return ERR_PTR(ret); > > > --- > base-commit: 15d30b46573d75f5cb58cfacded8ebab9c76a2b0 > change-id: 20230910-simpledrm-multiple-power-domains-f41efa6ad9bc > > Best regards, > -- > Janne Grunau > > Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-25 Thread Neal Gompa
On Mon, Oct 25, 2021 at 8:28 AM Javier Martinez Canillas wrote: > > Hello Michel, > > On 10/25/21 12:45, Michel Dänzer wrote: > > On 2021-10-24 22:32, Javier Martinez Canillas wrote: > >> Hello Ville, > >> > >> On 10/22/21 21:12, Ville Syrjälä wrote: > >>> On Fri, Oct 22, 2021 at 04:40:40PM +0200,

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-24 Thread Neal Gompa
On Sun, Oct 24, 2021 at 4:40 PM Javier Martinez Canillas wrote: > > Hello Thomas, > > Thanks a lot for your feedback. > > On 10/22/21 21:05, Thomas Zimmermann wrote: > > > There's still the question of the semantics of this parameter. It's a > > bit fuzzy. > > > > If you use 'disable_handover' (as

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Neal Gompa
On Fri, Oct 22, 2021 at 11:16 AM Javier Martinez Canillas wrote: > > Hello Neal, > > Thanks for your feedback. > > On 10/22/21 16:56, Neal Gompa wrote: > > On Fri, Oct 22, 2021 at 10:40 AM Javier Martinez Canillas > > wrote: > >> > >> The simpledr

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Neal Gompa
obe callback, this will cause the drivers' probe to fail. > > Thanks to Neal Gompa for the suggestion and Thomas Zimmermann for the idea > on how this could be implemented. > > Suggested-by: Neal Gompa > Signed-off-by: Javier Martinez Canillas > --- > Hello, > >