Some VOP's (such as px30) dclk_pol bit is at the last.
So it is necessary to distinguish dclk_pol and pin_pol.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 12 +++---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 8 +++-
drivers/gpu/drm/roc
Nickey Yang (1):
drm/rockchip: vop: add the definition of dclk_pol
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 12 +++---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 8 +++-
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 45 ++---
3 files changed, 43 insertions(+), 22
Hi Brian,
On 2017年12月07日 05:52, Brian Norris wrote:
Hi Nickey, others,
I just want to highlight a thing or two here. Otherwise, my
'Reviewed-by' still basically stands (FWIW).
On Wed, Dec 06, 2017 at 05:08:21PM +0800, Nickey Yang wrote:
Add the ROCKCHIP DSI controller driver tha
From: Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
Signed-off-by: Brian Norris
Signed-off-by: Nic
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
Signed-off-by: Brian Norris
Reviewed-by: Brian Norris
Reviewed-by: Sean Paul
---
changes:
v2:
add err_pllref, remove unnecessary encoder.enable & dis
v6:
3/3: just change func dw_mipi_encoder_disable name to
dw_mipi_dsi_encoder_disable
v7:
1/3: add missing platform_set_drvdata in stm part.
Nickey Yang (3):
drm/bridge/synopsys: dsi: stop clobbering drvdata
dt-bindings: display: rockchip: update DSI controller
drm/rockchip: Add ROCKCHIP DW MIPI DSI contro
This patch update describe panel/port links, including
unit addresses in documentation of device tree bindings
for the rockchip DSI controller based on the Synopsys
DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
Reviewed-by: Brian Norris
---
.../display/rockchip
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
Signed-off-by: Brian Norris
Reviewed-by: Brian Norris
Reviewed-by: Sean Paul
---
change:
v2:
add err_pllref, remove unnecessary encoder.enable & dis
This patch update describe panel/port links, including
unit addresses in documentation of device tree bindings
for the rockchip DSI controller based on the Synopsys
DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
Reviewed-by: Brian Norris
---
.../display/rockchip
v6:
3/3: just change func dw_mipi_encoder_disable name to
dw_mipi_dsi_encoder_disable
Nickey Yang (3):
drm/bridge/synopsys: dsi: stop clobbering drvdata
dt-bindings: display: rockchip: update DSI controller
drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver
.../display/rockchip/dw_mipi_dsi_rockchip.
From: Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
Signed-off-by: Brian Norris
Signed-off-by: Nic
This patch update describe panel/port links, including
unit addresses in documentation of device tree bindings
for the rockchip DSI controller based on the Synopsys
DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
Reviewed-by: Brian Norris
---
Changes
v5:
- add review tag
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
Signed-off-by: Brian Norris
Reviewed-by: Brian Norris
Reviewed-by: Sean Paul
---
Changes:
v2:
add err_pllref, remove unnecessary encoder.enable & dis
remove"
into Brians "drm/bridge/synopsys: stop clobbering drvdata"
add review tag and add some comments
v5:
1/3: fix stm part remove() directly referencing the static
dw_mipi_dsi_stm_plat_data struct.
3/3: keep our power domain enabled while touching GRF
Nickey Ya
From: Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
Signed-off-by: Brian Norris
Signed-off-by: Nic
Hi Brian,
On 2017年12月06日 02:56, Brian Norris wrote:
Hi Nickey,
On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote:
On 2017年12月01日 18:07, Philippe CORNU wrote:
On 12/01/2017 10:11 AM, Nickey Yang wrote:
On 2017年12月01日 16:32, Philippe CORNU wrote:
I am sorry to say that but you can
Hi Philippe,
On 2017年12月01日 18:07, Philippe CORNU wrote:
Hi Nickey,
On 12/01/2017 10:11 AM, Nickey Yang wrote:
Hi Philippe,
On 2017年12月01日 16:32, Philippe CORNU wrote:
Dear Nickey,
Many thanks for your patch.
I am sorry to say that but you can not add my "Acked-by" to this pat
d you please go back to the original code or propose me an updated
version of this code.
Could you help update new version of this code(stm part) and then test on
stm platform?
Thanks,
Nickey.
Many thanks,
Philippe :-)
On 12/01/2017 04:58 AM, Nickey Yang wrote:
From: Brian Norris
Bridge
Hi Matthias,
On 2017年11月29日 04:48, Matthias Kaehlcke wrote:
El Tue, Nov 28, 2017 at 07:20:05PM +0800 Nickey Yang ha dit:
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
v2:
add err_pllref, remove unnecessary encoder.enable
remove"
into Brians "drm/bridge/synopsys: stop clobbering drvdata"
add review tag and add some comments
Nickey Yang (3):
drm/bridge/synopsys: dsi: stop clobbering drvdata
dt-bindings: display: rockchip: update DSI controller
drm/rockchip: Add ROCKCHIP DW MIPI DSI contro
From: Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
Signed-off-by: Brian Norris
Signed-off-by: Nick
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
Reviewed-by: Brian Norris
Reviewed-by: Sean Paul
---
Changes log:
v2:
add err_pllref, remove unnecessary encoder.enable & disable
correct spelling mist
This patch update describe panel/port links, including
unit addresses in documentation of device tree bindings
for the rockchip DSI controller based on the Synopsys
DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
Changes in v4:
- keep the -cells properties
.../display
Hi Archit,
On 2017年10月26日 12:53, Archit Taneja wrote:
On 10/25/2017 09:21 AM, Nickey Yang wrote:
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file
Hi Archit,
On 2017年11月28日 14:27, Archit Taneja wrote:
Hi,
Thanks a lot for working on this. Some comments below.
Those comments have fixed in patch_v3
https://patchwork.kernel.org/patch/10079857/
Thanks for review.
On 11/28/2017 07:25 AM, Nickey Yang wrote:
Add the ROCKCHIP DSI
This patch update mipi node for RK3399 DSI controller
based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip
use of_device_get_match_data(),
change some ‘bind()’ logic into 'probe()'
add 'dev_set_drvdata()'
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/Kconfig|2 +-
drivers/gpu/drm/rockchip/Makefile |2 +-
drivers/gpu/drm/rockchip/dw-mi
This patch update documentation of device tree bindings for the rockchip
DSI controller based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
.../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++
1 file changed, 19 insertions(+), 4
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
So adjust it.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/stm/d
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
parent driver might need to own this. Instead, let's return our
'dw_mipi_dsi' object and have callers pass that back to us for removal.
Signed-off-by: Brian Norris
Reviewed-by: Matthias Kaehlcke
Reviewed-by: Archit Taneja
Acked
MIPI DSI controller driver:
call dw_mipi_dsi_unbind() in dw_mipi_dsi_rockchip_unbind()
fix typo, use of_device_get_match_data(),
change some ‘bind()’ logic into 'probe()'
add 'dev_set_drvdata()'
Nickey Yang (5):
drm/bridge/synopsys: stop cl
on't think you've caught them all here yet. I'll
repeat a few. Not sure if I've caught them all.
[1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/780120
On Tue, Nov 28, 2017 at 09:13:35AM +0800, Nickey Yang wrote:
Add the ROCKCHIP DSI controller
This patch update mipi node for RK3399 DSI controller
based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/Kconfig|2 +-
drivers/gpu/drm/rockchip/Makefile |2 +-
drivers/gpu/drm/rockchip/dw-mipi-dsi.c
This patch update documentation of device tree bindings for the rockchip
DSI controller based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
.../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++
1 file changed, 19 insertions(+), 4
err_pllref???remove unnecessary encoder.enable & disable
correct spelling mistakes
Nickey Yang (3):
dt-bindings: display: rockchip: update DSI controller
drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver
arm64: dts: rockchip: update mipi node for RK3399
.../display/rock
This patch update mipi node for RK3399 DSI controller
based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip
This patch update documentation of device tree bindings for the rockchip
DSI controller based on the Synopsys DesignWare MIPI DSI host controller.
Signed-off-by: Nickey Yang
---
.../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++
1 file changed, 19 insertions(+), 4
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
MIPI DSI host controller bridge.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/Kconfig|2 +-
drivers/gpu/drm/rockchip/Makefile |2 +-
drivers/gpu/drm/rockchip/dw-mipi-dsi.c
We now have a generic dw-mipi-dsi bridge driver.So we send
this patchs to moving rockchip dw-mipi-dsi driver to that
in order to add new features(dual mipi support).
Update ROCKCHIP DSI controller driver that uses the Synopsys
DesignWare MIPI DSI host controller bridge.
Nickey Yang (3):
dt
This patch adds the mipi_dsi1 related needed information.
e.g.: interrupts, grf, clocks, ports and so on.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip
This patch add dual mipi channel support:
1.add definition of dsi1 register and grf operation.
2.dsi0 and dsi1 will work in master and slave mode
when driving dual mipi panel.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377
drivers
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip
an 1000.
3、Make the previously configured Feedback divider(LSB)
factors effective
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 93 ++
1 file changed, 62 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
b/d
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0>
should depend on frequency,so fix it.
Reviewed-by: Sean Paul
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 --
1 file changed, 7
Replace the hardcoded register address numerical values with macros to
clarify the code.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++---
1 file changed, 85 insertions(+), 44 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw
The clk of grf must be enabled before writing grf
register for rk3399.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch/arm64/boot/dts/rockchip/rk3399
Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399.
clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll
So correct it.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0>
should depend on frequency,so fix it.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 --
1 file changed, 70 insertions(+), 28 deletions(-)
diff --git a/dri
This patch adds the mipi_dsi1 related needed information.
e.g.: interrupts, grf, clocks, ports and so on.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip
This patch add dual mipi channel support:
1.add definition of dsi1 register and grf operation.
2.dsi0 and dsi1 will work in master and slave mode
when driving dual mipi panel.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390
drivers
Rockchip driver has been moved to using the
DRM_DEV_ERROR log messages, so change all
instances of dev_err.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 62 +-
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu
an 1000.
3、Make the previously configured Feedback divider(LSB)
factors effective
4、Add the definition of the MIPI PHY register.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 219 ++---
1 file changed, 146 insertions(+), 73 deletions(-)
di
Hi Heiko,
On 2017年09月18日 19:31, Heiko Stübner wrote:
Hi Nickey,
Am Montag, 18. September 2017, 17:05:37 CEST schrieb Nickey Yang:
clk_24m --> Gate11[14] --> clk_mipidphy_ref --> Gate21[0] --> clk_dphy_pll
please try to be a bit more verbose in your commit messages :-) .
It
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 353
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +
4 files changed, 257
an 1000.
3、Make the previously configured Feedback divider(LSB)
factors effective
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 83 ++
1 file changed, 54 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
b/d
Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel,
it is a MIPI DSI panel.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/panel/Kconfig | 11 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
The KINGDISPLAY KD097D04 is a 9.7" panel with a 1536x2048
resolution and connected to DSI using 8 lanes.
Signed-off-by: Nickey Yang
---
.../display/panel/kingdisplay,kd097d04.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644
Documentation/devic
clk_24m --> Gate11[14] --> clk_mipidphy_ref --> Gate21[0] --> clk_dphy_pll
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch/arm64/boot/dts/roc
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0>
should depend on frequency,so fix it.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 70 +++---
1 file changed, 40 insertions(+), 30 deletions(-)
diff --git a/dri
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip
mtk_hdmi_setup_vendor_specific_infoframe will return before handle
mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack
returns the number of bytes packed into the binary buffer or
a negative error code on failure.
So correct it.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/mediatek
Vendor specific infoframe is mandatory for 4K2K resolution.
Without this, the HDMI protocol compliance fails.
Signed-off-by: Nickey Yang
Reviewed-by: Jose Abreu
---
drivers/gpu/drm/bridge/dw-hdmi.c | 53
drivers/gpu/drm/bridge/dw-hdmi.h | 4 +++
2
Vendor specific infoframe is mandatory for 4K2K resolution.
Without this, the HDMI protocol compliance fails.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/bridge/dw-hdmi.c | 50
drivers/gpu/drm/bridge/dw-hdmi.h | 4
2 files changed, 54 insertions
Vendor specific infoframe is mandatory for 4K2K resolution.
Without this, the HDMI protocol compliance fails.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/bridge/dw-hdmi.c | 47
drivers/gpu/drm/bridge/dw-hdmi.h | 4
2 files changed, 51 insertions
d Read Mode" to read data addressed by non-zero segment
pointer, this means that if EDID has more than 1 extension blocks"
With this patch,dw-hdmi can read EDID data with 1/2/4 blocks.
Signed-off-by: Nickey Yang
Reviewed-by: Douglas Anderson
---
drivers
d Read Mode" to read data addressed by non-zero segment
pointer, this means that if EDID has more than 1 extension blocks"
With this patch,dw-hdmi can read EDID data with 1/2/4 blocks.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/bridge/dw-hdmi.c | 38
68 matches
Mail list logo
