Re: [PATCH v3 0/3] drm/rockchip: dw_hdmi: Add 4k@30 support

2023-01-18 Thread Nicolas Frattaroli
hievable pixelclocks > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 40 - > 1 file changed, 32 insertions(+), 8 deletions(-) For the whole series: Tested-by: Nicolas Frattaroli Tested on two monitors: Monitor 1 was an Iiyama ProLite G2773HS, which only does 1080p60

Re: [PATCH 2/3] ASoC: dt-bindings: Reference common DAI properties

2022-12-04 Thread Nicolas Frattaroli
On Sonntag, 4. Dezember 2022 17:47:05 CET Krzysztof Kozlowski wrote: > On 04/12/2022 17:09, Nicolas Frattaroli wrote: > > On Samstag, 3. Dezember 2022 17:04:41 CET Krzysztof Kozlowski wrote: > >> Reference in all sound components which have '#sound-dai-cells' the > >> da

Re: [PATCH 2/3] ASoC: dt-bindings: Reference common DAI properties

2022-12-04 Thread Nicolas Frattaroli
i2s2 on this hardware. Should we add 'm' to the allowed reset-names for this case? Cheers, Nicolas Frattaroli

Re: [RFC PATCH 00/16] drm/rockchip: Rockchip EBC ("E-Book Controller") display driver

2022-04-21 Thread Nicolas Frattaroli
ld agreed on not making the name of data structures imply some way they are to be processed, but humanity hasn't gotten there yet. > > Regards, > Andreas > Regards, Nicolas Frattaroli

Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name

2021-12-22 Thread Nicolas Frattaroli
On Mittwoch, 22. Dezember 2021 20:39:58 CET Heiko Stübner wrote: > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer wrote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at

Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

2021-12-22 Thread Nicolas Frattaroli
On Dienstag, 21. Dezember 2021 14:44:39 CET Nicolas Frattaroli wrote: > On Montag, 20. Dezember 2021 12:06:30 CET Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found

Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

2021-12-21 Thread Nicolas Frattaroli
state->bus_format)) > + dsp_ctrl |= RK3568_VP_DSP_CTRL__POST_DSP_OUT_R2Y; > + > + vop2_dither_setup(crtc, _ctrl); > + > + vop2_vp_write(vp, RK3568_VP_DSP_HTOTAL_HS_END, (htotal << 16) | > hs

Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

2021-12-20 Thread Nicolas Frattaroli
On Montag, 20. Dezember 2021 15:16:55 CET Nicolas Frattaroli wrote: > On Montag, 20. Dezember 2021 12:06:30 CET Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found

Re: [PATCH 22/22] drm: rockchip: Add VOP2 driver

2021-12-20 Thread Nicolas Frattaroli
if (!res) { > + drm_err(vop2->drm, "failed to get vop2 register byname\n"); > + return -EINVAL; > + } This seems to be the code that triggers it. Any ideas as to what could be causing this? Regards, Nicolas Frattaroli

Re: [PATCH v3 00/22] drm/rockchip: RK356x VOP2 support

2021-12-20 Thread Nicolas Frattaroli
12] clock handling, no longer hacks needed > - Complete regmap conversion Hi Sascha, for future reference, you can add `-v 3` to your git format-patch command line to mark the whole patch series as PATCH v3 and not just the cover letter. Thanks for your continued work on this, Nicolas Frattaroli

Re: [PATCH 12/12] drm: rockchip: Add VOP2 driver

2021-11-17 Thread Nicolas Frattaroli
he monitor. For example, on an old 720p monitor I had laying around: [ 225.732342] rockchip-drm display-subsystem: [drm] Update mode to 1920x1080p60, type: 11 for vp0, output 0x0800 HDMI0 This results in a broken picture (all white with occasional glitches). Somebody else observed the same behaviour on a 1440p monitor. Thanks, Nicolas Frattaroli

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies

2021-10-19 Thread Nicolas Frattaroli
y missed checking for that. Did you review all other > > conversions you've pushed for this kind of bug? > > Yeah, currently double checking that. > > > Reviewed-by: Daniel Vetter > > > > Also > > > > Reported-by: Nicolas Frattaroli > > References: https://

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies

2021-10-19 Thread Nicolas Frattaroli
ce); > if (ret) > return ret; > + > + /* Make sure to grab an additional ref on the added fence */ > + dma_fence_get(fence); > } > return 0; > } > Tested-by: Nicolas Frattaroli Fixes it, thank you!

Re: [PATCH 16/28] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-10-17 Thread Nicolas Frattaroli
atch just uncovers a bug in lima, so I've added the lima list as a recipient to this reply as well. Since I doubt AMD has many Rockchip SoCs laying about, I'll gladly test any prospective fixes for this. Regards, Nicolas Frattaroli

Re: [PATCH] drm/rockchip: fix a -Werror fail on !CONFIG_PM_SLEEP

2021-09-13 Thread Nicolas Frattaroli
n_dp_device *dp = dev_get_drvdata(dev); > @@ -1135,6 +1136,7 @@ static int cdn_dp_resume(struct device *dev) > > return 0; > } > +#endif > > static int cdn_dp_probe(struct platform_device *pdev) > { Regards, Nicolas Frattaroli