* Greg Dietsche :
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/
>
> Signed-off-by: Greg Dietsche
Reviewed-by: Nicolas Kaiser
Best regards,
Nicolas Kaiser
> ---
> drivers/gpu/drm/savage/savage_bci.c |3 ---
>
Forwarding to Keith Packard.
Sorry, initially sent to the previous maintainer instead.
Start weitergeleitete Nachricht:
Datum: Fri, 20 May 2011 18:58:53 +0200
Von: Nicolas Kaiser
An: Chris Wilson
Cc: David Airlie , dri-devel at lists.freedesktop.org,
linux-kernel at vger.kernel.org
Betreff
Forwarding to Keith Packard.
Sorry, initially sent to the previous maintainer instead.
Start weitergeleitete Nachricht:
Datum: Fri, 20 May 2011 18:58:53 +0200
Von: Nicolas Kaiser ni...@nikai.net
An: Chris Wilson ch...@chris-wilson.co.uk
Cc: David Airlie airl...@linux.ie, dri-devel
Signed-off-by: Nicolas Kaiser
---
Untested: just looks to me like the intention might be
to return MODE_CLOCK_LOW here, is that correct?
drivers/gpu/drm/i915/intel_hdmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
Untested: just looks to me like the intention might be
to return MODE_CLOCK_LOW here, is that correct?
drivers/gpu/drm/i915/intel_hdmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
Merge list_del() + list_add_tail() to list_move_tail().
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/radeon/radeon_fence.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fence.c
b/drivers/gpu/drm/radeon/radeon_fence.c
index
Merge list_del() + list_add_tail() to list_move_tail().
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
drivers/gpu/drm/radeon/radeon_fence.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fence.c
b/drivers/gpu/drm/radeon
Fixed some brace, spacing and whitespace, printk, and
initialisation of statics and globals coding style issues.
Signed-off-by: Nicolas Kaiser
---
Against drm-core-next.
Supersedes "drm: fixed brace, spacing and whitespace
coding style issues"
drivers/gpu/drm/ati
Fixed some brace, spacing and whitespace, printk, and
initialisation of statics and globals coding style issues.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
Against drm-core-next.
Supersedes drm: fixed brace, spacing and whitespace
coding style issues
drivers/gpu/drm
Fixed brace and spacing coding style issues.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/i830/i830_dma.c | 95 ++-
drivers/gpu/drm/i830/i830_drv.h | 48 ++-
drivers/gpu/drm/i830/i830_irq.c | 10 ++--
3 files changed, 74 insertions
Fixed brace, macro and spacing coding style issues, and a C99 comment.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/i810/i810_dma.c | 81 ++
drivers/gpu/drm/i810/i810_drv.h | 64 ---
2 files changed, 71 insertions(+), 74
Fixed brace, spacing and whitespace coding style issues.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
drivers/gpu/drm/ati_pcigart.c |9 ++--
drivers/gpu/drm/drm_agpsupport.c| 15 +++
drivers/gpu/drm/drm_bufs.c | 49
drivers/gpu/drm
Fixed brace, macro and spacing coding style issues, and a C99 comment.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
drivers/gpu/drm/i810/i810_dma.c | 81 ++
drivers/gpu/drm/i810/i810_drv.h | 64 ---
2 files changed, 71
Fixed brace and spacing coding style issues.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/r128/r128_cce.c | 52 +++-
drivers/gpu/drm/r128/r128_drv.c |2 +-
drivers/gpu/drm/r128/r128_drv.h | 122 ++---
drivers/gpu/drm/r128/r128_irq.c
Fixed brace, macro and spacing coding style issues.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/mga/mga_dma.c | 99 +
drivers/gpu/drm/mga/mga_drv.c |4 +-
drivers/gpu/drm/mga/mga_drv.h | 187 +++
drivers/gpu/drm/mga
Fixed brace, macro and spacing coding style issues.
Simplified
-if (ret) return ret;
-return 0;
+return ret;
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/via/via_dma.c | 120
drivers/gpu/drm/via/via_dmablit.c | 71
Fixed brace, macro and spacing coding style issues.
Signed-off-by: Nicolas Kaiser
---
Supersedes patch "drm/savage: fixed brace coding style issues".
drivers/gpu/drm/savage/savage_bci.c | 48 +++
drivers/gpu/drm/savage/savage_drv.
Fixed brace, macro and spacing coding style issues.
Simplified
-if (ret) return ret;
-return 0;
+return ret;
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
drivers/gpu/drm/via/via_dma.c | 120
drivers/gpu/drm/via/via_dmablit.c | 71
Fixed brace, macro and spacing coding style issues.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
Supersedes patch drm/savage: fixed brace coding style issues.
drivers/gpu/drm/savage/savage_bci.c | 48 +++
drivers/gpu/drm/savage/savage_drv.h | 109
Fixed brace and spacing coding style issues.
Signed-off-by: Nicolas Kaiser
---
Supersedes patch "drm/sis: fixed brace coding style issues".
drivers/gpu/drm/sis/sis_drv.c |3 +--
drivers/gpu/drm/sis/sis_mm.c | 14 ++
2 files changed, 7 insertions(+), 10 deletion
Fixed brace and spacing coding style issues.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
---
Supersedes patch drm/sis: fixed brace coding style issues.
drivers/gpu/drm/sis/sis_drv.c |3 +--
drivers/gpu/drm/sis/sis_mm.c | 14 ++
2 files changed, 7 insertions(+), 10 deletions
Fixed brace coding style issues.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/sis/sis_drv.c |3 +--
drivers/gpu/drm/sis/sis_mm.c |6 ++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/sis/sis_drv.c b/drivers/gpu/drm/sis/sis_drv.c
index 4fd1f06
Fixed brace coding style issues.
Signed-off-by: Nicolas Kaiser
---
drivers/gpu/drm/savage/savage_bci.c | 16 ++--
drivers/gpu/drm/savage/savage_state.c |3 +--
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/savage/savage_bci.c
b/drivers/gpu
checkpatch complains about this define:
WARNING: space prohibited between function name and open parenthesis '('
#377: FILE: gpu/drm/i915/i915_reg.h:377:
+#define GEN6_RENDER TIMEOUT_COUNTER_EXPIRED (1 << 6)
Signed-off-by: Nicolas Kaiser
---
--- a/drivers/gpu/drm/i915/i915
A few typos in the DRM Developer's Guide.
Signed-off-by: Nicolas Kaiser
Acked-by: Jesse Barnes
---
--- Documentation-DocBook-drm.tmpl.orig 2010-05-06 15:15:31.759974209 +0200
+++ Documentation-DocBook-drm.tmpl 2010-05-06 15:36:41.111221911 +0200
@@ -389,7 +389,7
A few typos in the DRM Developer's Guide.
Signed-off-by: Nicolas Kaiser ni...@nikai.net
Acked-by: Jesse Barnes jesse.bar...@intel.com
---
--- Documentation-DocBook-drm.tmpl.orig 2010-05-06 15:15:31.759974209 +0200
+++ Documentation-DocBook-drm.tmpl 2010-05-06 15:36:41.111221911 +0200
26 matches
Mail list logo
