Re: [PATCH] backlight: ipaq_micro: Make structure micro_bl_props constant

On Tue, 3 Sep 2019 at 21:49, Daniel Thompson wrote: > > On Tue, Aug 13, 2019 at 10:12:51AM +0100, Daniel Thompson wrote: > > On Tue, Aug 13, 2019 at 02:28:55PM +0530, Nishka Dasgupta wrote: > > > Static structure micro_bl_props, having type backlight_properties, is > >

[PATCH] udlfb: Make dlfb_ops constant

Static structure dlfb_ops, of type fb_ops, is not used except to be copied into another variable. Hence make dlfb_ops constant to protect it from unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/video/fbdev/udlfb.c | 2 +- 1 file changed, 1

[PATCH] drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant

The static structure aspeed_gfx_funcs, of type drm_simple_display_pipe_funcs, is used only as an argument to drm_simple_display_pipe_init(), which does not modify it. Hence make it constant to protect it from unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta

[PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

: Nishka Dasgupta --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c index 02537ab9cc08..2b57ea3195f2 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_drv.c +++ b/drivers

[PATCH] drm: dw-hdmi-i2s: Make structure dw_hdmi_i2s_ops constant

-off-by: Nishka Dasgupta --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c index 5cbb71a866d5..35daf9a21708 100644

[PATCH] drm/tilcdc: plane: Make structure tilcdc_plane_funcs constant

-off-by: Nishka Dasgupta --- drivers/gpu/drm/tilcdc/tilcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_plane.c b/drivers/gpu/drm/tilcdc/tilcdc_plane.c index 8c2776acdf99..bfd5dccca709 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_plane.c

[PATCH] backlight: ipaq_micro: Make structure micro_bl_props constant

constant as well. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/video/backlight/ipaq_micro_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c index 1123f67c12b3

[PATCH] drm/xen-front: Make structure fb_funcs constant

protect it from further modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c index

[PATCH] gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop there is no put, thus causing a memory leak. Hence add an of_node_put before the break. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/gpu

[PATCH] gpu: drm: mediatek: mtk_drm_drv.c: Add of_node_put() before goto

Each iteration of for_each_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

On 03/07/19 2:07 PM, Greg KH wrote: On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig

[PATCH 2/2] staging: android: ion: Remove file ion_chunk_heap.c

Remove file ion_chunk_heap.c as its functions and definitions are not used anywhere else. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - drivers/staging/android/ion

[PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - .../staging/android/ion