Re: [PATCH net-next v10 11/14] tcp: RX path for devmem TCP

On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote: > @@ -2317,6 +2318,213 @@ static int tcp_inq_hint(struct sock *sk) > return inq; > } > > +/* batch __xa_alloc() calls and reduce xa_lock()/xa_unlock() overhead. */ > +struct tcp_xa_pool { > + u8 max; /* max <=

Re: [PATCH net-next v10 10/14] net: add support for skbs with unreadable frags

On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote: > diff --git a/net/core/gro.c b/net/core/gro.c > index 26f09c3e830b7..7b9d018f552bd 100644 > --- a/net/core/gro.c > +++ b/net/core/gro.c > @@ -422,6 +422,9 @@ static void gro_pull_from_frag0(struct sk_buff *skb, int > grow) > { >

Re: [PATCH net-next v10 06/14] page_pool: convert to use netmem

On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote: > diff --git a/include/trace/events/page_pool.h > b/include/trace/events/page_pool.h > index 6834356b2d2ae..c5b6383ff2760 100644 > --- a/include/trace/events/page_pool.h > +++ b/include/trace/events/page_pool.h > @@ -42,51 +42,52 @@

Re: [PATCH net-next v10 05/14] netdev: netdevice devmem allocator

On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote: > diff --git a/net/core/devmem.c b/net/core/devmem.c > index d82f92d7cf9ce..d5fac8edf621d 100644 > --- a/net/core/devmem.c > +++ b/net/core/devmem.c > @@ -32,6 +32,14 @@ static void net_devmem_dmabuf_free_chunk_owner(struct > gen_pool

Re: [PATCH net-next v6 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

On Tue, 2024-04-02 at 12:33 +0200, Julien Panis wrote: [...] > +static int am65_cpsw_run_xdp(struct am65_cpsw_common *common, struct > am65_cpsw_port *port, > + struct xdp_buff *xdp, int desc_idx, int cpu, int > *len) > +{ > + struct am65_cpsw_rx_chn *rx_chn =

Re: [RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h > index 6fc5134095ed..d4bea053bb7e 100644 > --- a/include/net/page_pool/types.h > +++ b/include/net/page_pool/types.h > @@ -60,6 +60,8 @@ struct page_pool_params { >

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

On Mon, 2023-11-06 at 14:55 -0800, Willem de Bruijn wrote: > On Mon, Nov 6, 2023 at 2:34 PM Stanislav Fomichev wrote: > > > > On 11/06, Willem de Bruijn wrote: > > > > > IMHO, we need a better UAPI to receive the tokens and give them back > > > > > to > > > > > the kernel. CMSG +

Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: > @@ -91,6 +95,7 @@ TEST_PROGS += test_bridge_neigh_suppress.sh > TEST_PROGS += test_vxlan_nolocalbypass.sh > TEST_PROGS += test_bridge_backup_port.sh > TEST_PROGS += fdb_flush.sh > +TEST_GEN_FILES += ncdevmem I guess we want something

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: [...] > +/* On error, returns the -errno. On success, returns number of bytes sent to > the > + * user. May not consume all of @remaining_len. > + */ > +static int tcp_recvmsg_devmem(const struct sock *sk, const struct sk_buff > *skb, > +

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: [...] > @@ -3421,7 +3446,7 @@ static inline struct page *skb_frag_page(const > skb_frag_t *frag) > */ > static inline void __skb_frag_ref(skb_frag_t *frag) > { > - get_page(skb_frag_page(frag)); > +

Re: [RFC PATCH v3 07/12] page-pool: device memory support

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: > Overload the LSB of struct page* to indicate that it's a page_pool_iov. > > Refactor mm calls on struct page* into helpers, and add page_pool_iov > handling on those helpers. Modify callers of these mm APIs with calls to > these helpers

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: [...] > +void netdev_free_devmem(struct page_pool_iov *ppiov) > +{ > + struct netdev_dmabuf_binding *binding = page_pool_iov_binding(ppiov); > + > + refcount_set(>refcount, 1); > + > + if (gen_pool_has_addr(binding->chunk_pool, > +

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: [...] > +int netdev_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd, > +struct netdev_dmabuf_binding **out) > +{ > + struct netdev_dmabuf_binding *binding; > + struct scatterlist *sg; > + struct

Re: [PATCH v2 net-next 0/6] Brcm ASP 2.0 Ethernet controller

On Wed, 2023-04-26 at 11:54 -0700, Justin Chen wrote: > v2 > - Updates to yaml dt documentation > - Replace a couple functions with helper functions > - Minor formatting fixes > - Fix a few WoL issues > > Add support for the Broadcom ASP 2.0 Ethernet controller which is

Re: [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

| 2 +- > net/netfilter/ipvs/ip_vs_lblc.c | 2 +- > net/netfilter/ipvs/ip_vs_lblcr.c | 2 +- > net/netfilter/xt_IDLETIMER.c | 4 ++-- > net/netfilter/xt_LED.c | 2 +- > net/sched/cls_flow.c | 2 +- > net/sunrpc/svc.c | 2 +- > net/tipc/discover.c | 2 +- > net/tipc/monitor.c | 2 +- Acked-by: Paolo Abeni

Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size

; be removed. However, just in case there is something still depending > on this behavior, issue a WARN and fall back to as before to ksize() > which means we'll also potentially get KASAN warnings. > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc