NULL, >connector);
> + if (ret)
> + return ret;
> +
> + drm_plane_enable_fb_damage_clips(>pipe.plane);
> + drm_mode_config_reset(drm);
> +
> + ret = drm_dev_register(drm, 0);
> + if (ret)
> + return ret;
> +
> + drm_fbdev_generic_setup(drm, 0);
> +
> + return 0;
> +}
> +
> +static void sharp_ls027b7dh01_remove(struct spi_device *spi)
> +{
> + struct sharp_ls027b7dh01 *priv = spi_get_drvdata(spi);
> +
> + drm_dev_unplug(>drm);
> + drm_atomic_helper_shutdown(>drm);
> +}
> +
> +static void sharp_ls027b7dh01_shutdown(struct spi_device *spi)
> +{
> + struct sharp_ls027b7dh01 *priv = spi_get_drvdata(spi);
> +
> + drm_atomic_helper_shutdown(>drm);
> +}
> +
> +static const struct spi_device_id sharp_ls027b7dh01_ids[] = {
> + { "ls027b7dh01" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(spi, sharp_ls027b7dh01_ids);
> +
> +static const struct of_device_id sharp_ls027b7dh01_of_match[] = {
> + { .compatible = "sharp,ls027b7dh01", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, sharp_ls027b7dh01_of_match);
> +
> +static struct spi_driver sharp_ls027b7dh01_spi_driver = {
> + .probe = sharp_ls027b7dh01_probe,
> + .remove = sharp_ls027b7dh01_remove,
> + .shutdown = sharp_ls027b7dh01_shutdown,
> + .id_table = sharp_ls027b7dh01_ids,
> + .driver = {
> + .name = "sharp-ls027b7dh01",
> + .of_match_table = sharp_ls027b7dh01_of_match,
> + },
> +};
> +module_spi_driver(sharp_ls027b7dh01_spi_driver);
> +
> +MODULE_AUTHOR("Andrew D'Angelo");
> +MODULE_AUTHOR("Mehdi Djait ");
> +MODULE_DESCRIPTION("Sharp LS027B7DH01 Driver");
> +MODULE_LICENSE("GPL");
> --
> 2.41.0
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
Hi folks,
On Wed 25 Oct 23, 15:09, Paul Kocialkowski wrote:
> The buffer_sel, voffset and hoffset values are calculated from u32
> values and might overflow under certain conditions.
>
> Move them to u32 definitions instead of u8/u16 to avoid the issue.
Any chance to get a
Use the existing macro instead of redefining it.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/logicvc/logicvc_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_regs.h
b/drivers/gpu/drm/logicvc/logicvc_regs.h
index 4aae27e9ba2b
The buffer_sel, voffset and hoffset values are calculated from u32
values and might overflow under certain conditions.
Move them to u32 definitions instead of u8/u16 to avoid the issue.
Signed-off-by: Paul Kocialkowski
Reported-by: Dan Carpenter
Fixes: efeeaefe9be5 ("drm: Add su
Hi,
On Tue 20 Jun 23, 11:56, Sui Jingfeng wrote:
> Hi,
>
> On 2023/6/8 15:15, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
> > > drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
> >
> to the idea to get rid of struct drm_device *dev. Most discussion was
> > > about splitting the series and the right name to use instead of "dev".
> >
> > And then you have a former and current maintainers that tell you that
> > they'd prefer not to me
he subsystem-specific dev in some
subsystem-specific object kind of implies that it would make sense to have
a struct device called dev in that structure, which adds more confusion as this
is generally not the case.
So I would also be happier without this change.
Cheers,
Paul
--
Paul Koci
6 +-
> drivers/gpu/drm/tiny/repaper.c| 8 +-
> drivers/gpu/drm/tiny/simpledrm.c | 2 +-
> drivers/gpu/drm/tiny/st7586.c | 6 +-
> drivers/gpu/drm/tiny/st7735r.c| 4 +-
> drivers/gpu/drm/tve200/tve200_display.c
clk"
> [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> Signed-off-by: Sui Jingfeng
Thanks for the fix, looks good to me!
Acked-by: Paul Kocialkowski
t; Before applying the patch I displayed a color pattern with modetest
> before suspend and it appeared correctly. Then I suspended and resumed
> the device, attempted to display the same color pattern, and only got
> a single pixel on an otherwise blank display. After applying the patch
>
TEST as an alternative is no longer needed.
>
> Signed-off-by: Jean Delvare
> Cc: Paul Kocialkowski
> Cc: David Airlie
> Cc: Daniel Vetter
Sounds good to me!
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/gpu/drm/logicvc/Kconfig |2 +-
> 1 file changed
Hi Dan,
On Mon 27 Jun 22, 08:26, Dan Carpenter wrote:
> On Fri, Jun 24, 2022 at 04:53:25PM +0200, Paul Kocialkowski wrote:
> > Hello Dan,
> >
> > On Tue 14 Jun 22, 15:07, Dan Carpenter wrote:
> > > Hello Paul Kocialkowski,
> > >
> > > The patch
Hello Dan,
On Tue 14 Jun 22, 15:07, Dan Carpenter wrote:
> Hello Paul Kocialkowski,
>
> The patch efeeaefe9be5: "drm: Add support for the LogiCVC display
> controller" from May 20, 2022, leads to the following Smatch static
> checker warning:
>
> drivers/
tails and mode flags.
No difference needed in the binding at all then, I suppose.
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> ---
> .../devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml | 1 +
> 1 file chan
tails and mode flags.
>
> Cc: Quentin Schulz
> Signed-off-by: Klaus Goger
> Signed-off-by: Quentin Schulz
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> ---
> .../drm/panel/panel-leadtek-ltk050h3146w.c| 87 +++
> 1 file changed, 87 insertions(+)
>
> d
the .data field of of_device_id
> structure.
>
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
LGTM:
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 151 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 155 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/logicvc
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
There are lots of different versions of the logicvc block and it
makes little sense to list them all in compatibles since all versions
with the same major are found to be register-compatible.
Introduce a new compatible with the major version only.
Signed-off-by: Paul Kocialkowski
There are lots of different versions of the logicvc block and it
makes little sense to list them all in compatibles since all versions
with the same major are found to be register-compatible.
Add common compatibles that only list the major version instead.
Signed-off-by: Paul Kocialkowski
t property and count layers child nodes instead.
Paul Kocialkowski (6):
dt-bindings: mfd: logicvc: Add a compatible with the major version
only
dt-bindings: gpio: logicvc: Add a compatible with major version only
gpio: logicvc: Support compatible with major version only
dt-bindings: di
There are lots of different versions of the logicvc block and it
makes little sense to list them all in compatibles since all versions
with the same major are found to be register-compatible.
Introduce a new compatible with the major version only.
Signed-off-by: Paul Kocialkowski
Support the newly-introduced common compatible for version 3.
Signed-off-by: Paul Kocialkowski
---
drivers/gpio/gpio-logicvc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
index 992cc958a43f..9b27343f5242
Hi,
On Tue 14 Sep 21, 22:05, Paul Kocialkowski wrote:
> This series introduces support for the LogiCVC display controller.
> The controller is a bit unusual since it is usually loaded as
> programmable logic on Xilinx FPGAs or Zynq-7000 SoCs.
> More details are presented on the
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 151 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 155 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/logicvc
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
The LogiCVC multi-function device has a display part which is now
described in its binding. Add a patternProperties match for it.
Signed-off-by: Paul Kocialkowski
---
Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
Acked-by: Rob Herring
---
.../display/xylon,logicvc-display.yaml| 302 ++
1 file changed, 302 insertions(+)
create mode 100644
Documentation
ribed more possible dt parameters;
- Added support for the lvds-3bit interface;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Paul Kocialkowski (4):
dt-bindings: display: Document the Xylon LogiCVC display contr
Hi Rob,
I just found out as I'm about to send a new revision that I had not yet
responded to your concerns here.
On Tue 12 Jan 21, 09:17, Rob Herring wrote:
> On Wed, Dec 23, 2020 at 10:29:44PM +0100, Paul Kocialkowski wrote:
> > The Xylon LogiCVC is a display controller im
orkey:
> > https://drmdb.emersion.fr/properties/4008636142/colorkey
> >
> > I know this is marked "not for merge", but it would be nice to discuss
> > with them and come up with a standardized property.
--
Paul Kocialkowski, Bootlin
Embedded
Hi,
On Thu 24 Dec 20, 10:01, Rob Herring wrote:
> On Wed, 23 Dec 2020 22:29:44 +0100, Paul Kocialkowski wrote:
> > The Xylon LogiCVC is a display controller implemented as programmable
> > logic in Xilinx FPGAs.
> >
> > Signed-off-by: Paul Kocialkowski
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 150 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 154 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/logicvc
The LogiCVC multi-function device has a display part which is now
described in its binding. Add a patternProperties match for it.
Signed-off-by: Paul Kocialkowski
---
Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
Acked-by: Rob Herring
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation
t bindings documentation to dt schema;
- Described more possible dt parameters;
- Added support for the lvds-3bit interface;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Paul Kocialkowski (4):
dt-bindings: display
Hi,
On Mon 07 Dec 20, 11:42, Maxime Ripard wrote:
> On Wed, Dec 02, 2020 at 05:06:40PM +0100, Paul Kocialkowski wrote:
> > > > +static void logicvc_crtc_atomic_begin(struct drm_crtc *drm_crtc,
> > > > + str
Hi,
On Tue 03 Nov 20, 10:46, Maxime Ripard wrote:
> On Mon, Nov 02, 2020 at 04:53:07PM +0100, Paul Kocialkowski wrote:
> > Introduces a driver for the LogiCVC display controller, a programmable
> > logic controller optimized for use in Xilinx Zynq-7000 SoCs and other
&
Hi Sam,
On Wed 04 Nov 20, 22:22, Sam Ravnborg wrote:
> Hi Paul.
>
> A few comments in the following. I did not find time to read all of the
> driver.
Thanks for taking a look at the driver!
>
> Sam
>
> On Mon, Nov 02, 2020 at 04:53:07PM +0100, Paul Kocialkows
in that case.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c
b/drive
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
Acked-by: Rob Herring
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 143 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 149 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.h
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
more possible dt parameters;
- Added support for the lvds-3bit interface;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Cheers!
Paul Kocialkowski (3):
dt-bindings: display: Document the Xylon LogiCVC display
Hi,
On Mon 04 May 20, 13:45, Daniel Vetter wrote:
> On Thu, Apr 30, 2020 at 09:10:07PM +0200, Paul Kocialkowski wrote:
> > Hi Daniel,
> >
> > On Fri 03 Apr 20, 13:04, Daniel Vetter wrote:
> > > On Fri, Apr 03, 2020 at 11:36:17AM +0200, Paul Kocialkowski wrot
suggestions - if you agree, feel free to
> keep them as follow-up patches.
>
> On Thu, 30 Apr 2020 at 20:28, Paul Kocialkowski
> wrote:
>
> > +int logicvc_of_property_parse_u32(struct device_node *of_node,
> > + const char *name,
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
parameters;
- Added support for the lvds-3bit interface;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Cheers!
Paul Kocialkowski (3):
dt-bindings: display: Document the Xylon LogiCVC display controller
drm: Add
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 143 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 149 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.h
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
Acked-by: Rob Herring
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation
Hi Daniel,
On Fri 03 Apr 20, 13:04, Daniel Vetter wrote:
> On Fri, Apr 03, 2020 at 11:36:17AM +0200, Paul Kocialkowski wrote:
> > Introduces a driver for the LogiCVC display controller, a programmable
> > logic controller optimized for use in Xilinx Zynq-7000 SoCs and other
&
avoid this.
Looks good to me:
Reviewed-by: Paul Kocialkowski
But maybe use the drm/sun4i: dsi: prefix instead (granted, it wasn't used in
the commit being fixed).
Cheers,
Paul
> Fixes: bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling")
> Signed-off-by: Arnd Bergma
for the required fields to the PX30 VOP window descriptions,
which makes per-pixel-alpha formats behave correctly.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +++
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 9
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
MAINTAINERS | 6 +
drivers
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
Acked-by: Rob Herring
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation
documentation to dt schema;
- Described more possible dt parameters;
- Added support for the lvds-3bit interface;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Cheers!
Paul Kocialkowski (2):
dt-bindings: display: Document
can call drm_dev_alloc() instead.
In my case, I like the fact that drm_dev_alloc correctly wraps drm_dev_init
and drmm_add_final_kfree (and I'd rather not add & all around unless I'm
obliged to ;)
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bo
ense and it's apparently the norm to not report any modifier blob
when only linear is supported, so let's stick to that.
Note that when the reverted patch was applied, the core didn't set
allow_fb_modifiers on its own yet. But it does now so let's rely on it instead.
Reviewed-by: Paul Kocialkowski
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/logicvc/logicvc_drm.h | 3 +
drivers/gpu/drm/logicvc/logicvc_layer.c | 147 +++-
drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++
3 files changed, 153 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/logicvc
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Maxime Ripard
---
drivers/gpu/drm/Kconfig | 2 +
drivers
.
Cheers!
Paul Kocialkowski (3):
dt-bindings: display: Document the Xylon LogiCVC display controller
drm: Add support for the LogiCVC display controller
WIP: drm/logicvc: Add plane colorkey support
.../display/xylon,logicvc-display.yaml| 313
drivers/gpu/drm/Kconfig
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Hi,
On Wed 20 Nov 19, 10:02, Rob Herring wrote:
> On Wed, Nov 20, 2019 at 8:50 AM Paul Kocialkowski
> wrote:
> >
> > Hi,
> >
> > Circling back to this thread now, sorry for the delay.
> >
> > On Tue 24 Sep 19, 09:58, Rob Herring wrote:
> > >
Hi,
On Fri 27 Sep 19, 17:20, Rob Herring wrote:
> On Fri, Sep 27, 2019 at 12:07:37PM +0200, Paul Kocialkowski wrote:
> > The Xylon LogiCVC is a display controller implemented as programmable
> > logic in Xilinx FPGAs.
> >
> > Signed-off-by: Paul Kocialkowski
>
Hi,
Circling back to this thread now, sorry for the delay.
On Tue 24 Sep 19, 09:58, Rob Herring wrote:
> On Mon, Sep 23, 2019 at 10:33 AM Paul Kocialkowski
> wrote:
> >
> > Hi,
> >
> > On Fri 13 Sep 19, 20:16, Rob Herring wrote:
> > > On Fri, Se
Hi,
On Wed 13 Nov 19, 11:04, Patrik Jakobsson wrote:
> On Tue, Nov 12, 2019 at 4:50 PM Paul Kocialkowski
> wrote:
> >
> > Hi,
> >
> > On Tue 12 Nov 19, 16:11, Paul Kocialkowski wrote:
> > > Hi,
> > >
> > > On Tue 12 Nov 19, 11:20, Patri
Hi,
On Tue 12 Nov 19, 16:11, Paul Kocialkowski wrote:
> Hi,
>
> On Tue 12 Nov 19, 11:20, Patrik Jakobsson wrote:
> > On Thu, Nov 7, 2019 at 4:30 PM Paul Kocialkowski
> > wrote:
> > >
> > > psbfb_probe performs an evaluation of the required size fro
Hi,
On Tue 12 Nov 19, 11:20, Patrik Jakobsson wrote:
> On Thu, Nov 7, 2019 at 4:30 PM Paul Kocialkowski
> wrote:
> >
> > psbfb_probe performs an evaluation of the required size from the stolen
> > GTT memory, but gets it wrong in two distinct ways:
> > - The re
switching to 16bpp when one connector is e.g. 1920x1080
and the other is 1024x768.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/gma500/framebuffer.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c
b/drivers/gpu/drm/gma500
Hi,
On Wed 06 Nov 19, 16:23, Patrik Jakobsson wrote:
> On Wed, Nov 6, 2019 at 10:44 AM Paul Kocialkowski
> wrote:
> >
> > This adds a missing call to drm_crtc_vblank_on to the common DPMS helper
> > (used by poulsbo and cedartrail), which is called in the CRTC enable path
platforms (oaktrail and medfield) use a dedicated DPMS helper that
does not have the proper vblank on/off hooks. They are not added in this
commit due to lack of hardware to test it with.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/gma500/gma_display.c | 2 ++
1 file changed, 2 insertions
-by: Paul Kocialkowski
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
drivers/gpu/drm/gma500/gma_display.c | 46 ++
drivers/gpu/drm/gma500/gma_display.h | 6 +++
drivers/gpu/drm/gma500/psb_intel_display.c | 1 +
drivers/gpu/drm/gma500/psb_intel_drv.h | 3
This series brings-in the required bits to implement page flip support
on poulsbo and cedartrail. Page flip support is required to run weston
with the GMA500 driver.
This is only legacy page flip support, not a conversion of the driver to
atomic DRM.
Paul Kocialkowski (2):
drm/gma500: Add
;
- Added support for grabbing syscon regmap from parent node;
- Removed layers count property and count layers child nodes instead.
Cheers!
Paul Kocialkowski (2):
dt-bindings: display: Document the Xylon LogiCVC display controller
drm: Add support for the LogiCVC display controller
.../display
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
---
.../display/xylon,logicvc-display.yaml| 313 ++
1 file changed, 313 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Hi,
On Wed 25 Sep 19, 08:07, Rob Herring wrote:
> On Wed, Sep 25, 2019 at 3:49 AM Paul Kocialkowski
> wrote:
> >
> > The Xylon LogiCVC is a display controller implemented as programmable
> > logic in Xilinx FPGAs.
> >
> > Signed-off-by: Paul Kocialkowski
&g
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile
;
- Removed layers count property and count layers child nodes instead.
Cheers!
Paul Kocialkowski (2):
dt-bindings: display: Document the Xylon LogiCVC display controller
drm: Add support for the LogiCVC display controller
.../display/xylon,logicvc-display.yaml| 314 +
drivers/gpu
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
---
.../display/xylon,logicvc-display.yaml| 314 ++
1 file changed, 314 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Hi,
On Fri 13 Sep 19, 20:16, Rob Herring wrote:
> On Fri, Sep 13, 2019 at 4:58 PM Paul Kocialkowski
> wrote:
> >
> > Hi Rob and thanks for the review!
> >
> > On Fri 13 Sep 19, 15:35, Rob Herring wrote:
> > > On Tue, Sep 10, 2019 at 05:34:08PM +0200, Pau
Hi Rob and thanks for the review!
On Fri 13 Sep 19, 15:35, Rob Herring wrote:
> On Tue, Sep 10, 2019 at 05:34:08PM +0200, Paul Kocialkowski wrote:
> > The Xylon LogiCVC is a display controller implemented as programmable
> > logic in Xilinx FPGAs.
> >
> > Signe
on the dedicated
web page: https://www.logicbricks.com/Products/logiCVC-ML.aspx
Cheers!
Paul Kocialkowski (2):
dt-bindings: display: Add xylon logicvc bindings documentation
drm: Add support for the LogiCVC display controller
.../bindings/display/xylon,logicvc.txt| 188 ++
drivers
The Xylon LogiCVC is a display controller implemented as programmable
logic in Xilinx FPGAs.
Signed-off-by: Paul Kocialkowski
---
.../bindings/display/xylon,logicvc.txt| 188 ++
1 file changed, 188 insertions(+)
create mode 100644 Documentation/devicetree/bindings
the implementation of
logicvc_layer_buffer_find_setup for specifics.
Version 4 allows configuring each buffer address directly, which
guarantees that any buffer can be configured.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile
Hi,
On Fri, 2019-05-17 at 17:05 +0200, Paul Kocialkowski wrote:
> On a trivial gpio-backlight setup with a panel using the backlight but
> no boot software to enable it beforehand, we fall in a case where the
> backlight is disabled (not just blanked) and thus remains disabled when
&g
Hi,
On Thu, 2019-05-23 at 16:26 +0200, Noralf Trønnes wrote:
> Ease entry for anyone wanting to pick up the bootsplash work by providing
> a couple of pointers.
>
> Signed-off-by: Noralf Trønnes
I think a native DRM bootsplash would be a great thing to have!
Reviewed-by: Paul
Le lundi 20 mai 2019 à 18:11 +0200, Daniel Vetter a écrit :
> On Fri, May 17, 2019 at 01:08:24PM +0300, Pekka Paalanen wrote:
> > On Thu, 16 May 2019 14:24:55 +0200
> > Daniel Vetter wrote:
> >
> > > On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote:
> > > > On Wed, 15 May 2019
to match the
> other functions prototype.
Same comment about plane being int instead of unsigned int, but I think we
can fix that later.
Another thing that I find odd is that the division by vsub/hsub is not
rounded up, but again, it's something independent from your patch.
Reviewed-by: Paul Kocial
paddr_reg += 4;
> }
> diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
> index 4ef8ccb5d236..405466692bd2 100644
> --- a/include/drm/drm_fourcc.h
> +++ b/include/drm/drm_fourcc.h
> @@ -261,23 +261,6 @@ drm_format_info_is_yuv_sampling_444(const struct
> drm_format_info *info)
> }
>
> /**
> - * drm_format_info_plane_cpp - determine the bytes per pixel value
> - * @format: pixel format info
> - * @plane: plane index
> - *
> - * Returns:
> - * The bytes per pixel value for the specified plane.
> - */
> -static inline
> -int drm_format_info_plane_cpp(const struct drm_format_info *info, int plane)
> -{
> - if (!info || plane >= info->num_planes)
> - return 0;
> -
> - return info->cpp[plane];
> -}
> -
> -/**
> * drm_format_info_plane_width - width of the plane given the first plane
> * @format: pixel format info
> * @width: width of the first plane
> --
> git-series 0.9.1
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
have an
unsigned plane index wherever it's used. We're only checking for
plane >= info->num_planes but seldom for plane < 0.
Either way, this is:
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> Reviewed-by: Emil Velikov
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/
_info structure
> it has access to to retrieve that fourcc. Change the prototype of that
> function to pass the drm_format_info structure directly, removing the need
> for an extra lookup.
>
> Suggested-by: Philipp Zabel
> Signed-off-by: Maxime Ripard
Reviewed-by:
ion by setting the brightness to 1 at probe and
managing the power state accordingly, a bit like it's done in
pwm-backlight.
Fixes: 8b770e3c9824 ("backlight: Add GPIO-based backlight driver")
Signed-off-by: Paul Kocialkowski
---
drivers/video/backlight/gpio_backlight.c | 19 ++
sentence about fristopen;
* Added collected Reviewed-By tags.
Changes since v1:
* Squashed the two final patches into one.
Paul Kocialkowski (4):
drm/vc4: Reformat and the binner bo allocation helper
drm/vc4: Check for V3D before binner bo alloc
drm/vc4: Check for the binner bo before handling
Check that we have a V3D device registered before attempting to
allocate a binner buffer object.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_v3d.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm
In preparation for wrapping the binner bo allocation helper with
put/get helpers, pass the vc4 dev directly and drop the vc4 prefix.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_v3d.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions
Since the OOM interrupt directly deals with the binner bo, it doesn't
make sense to try and handle it without a binner buffer registered.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_irq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
runtime suspend/resume to avoid
failing to allocate it at resume. This happens when the CMA pool is
full at that point and results in a hard crash.
Signed-off-by: Paul Kocialkowski
Reviewed-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_bo.c | 31 +-
drivers/gpu/drm/vc4/vc4_drv.c
ed me as
> > > an event is a device. Squashing together would make sense if the
> > > uevent were just updating a device attribute list. Previously when we
> > > had just a single kind of uevent, that would not have made a
> > > difference, but if we gain differ
1 - 100 of 535 matches
Mail list logo
