Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)

Hi Alex, I think it's not a valid report from kernel test robot, for __le16 ought to be the right type for cpu_to_le16. The sparse warnings seems not right so I did't try effort to reproduce it. otherwise, when I take a carful look at this patch, an unconditional braces exists and I'm not

[PATCH 2/3] drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 5e570373c015 ("drm/rockchip: vop: Enable pm domain before vop_initial") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/v3d: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Fixes: 935f3d88434b ("drm/v3d: Make sure the GPU is on when measuring clocks.") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao ---

[PATCH] drm/tegra: fix reference leak when pm_runtime_get_sync fails

usage counter balanced. Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/tegra/dc.c | 2 +- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/drm/tegra/hdmi.c | 2 +- drivers/gpu/drm/tegra/hub.c | 2 +

[PATCH 3/3] drm/rockchip: lvds: fix reference leak when pm_runtime_get_sync fails

it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 0/3] drm/rockchip: fix reference leak when pm_runtime_get_sync fails

ot;PM: runtime: Add pm_runtime_resume_and_get to dealwith usage counter") Qinglang Miao (3): drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails drm/rockchip: lvds: fix reference

[PATCH 1/3] drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails

counter balanced. Fixes: efe0220fc2d2 ("drm/rockchip: cdn-dp: Fix error handling") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c

[PATCH 3/3] drm/rockchip: lvds: fix reference leak when pm_runtime_get_sync fails

Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f292c6a6e..c3b1ac484 100644 --- a/drivers/gpu/dr

Re: [PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit

在 2020/11/27 18:06, Steven Price 写道: On 27/11/2020 09:44, Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage

[PATCH 0/3] drm/rockchip: fix reference leak of pm_runtime_get_sync

Replace pm_runtime_get_sync with pm_runtime_resume_and_get to keep usage counter balanced. Qinglang Miao (3): drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails drm/rockchip: lvds: fix reference

[PATCH 1/3] drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails

d-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index a4a45daf9..9b4406191 100644 --- a/drivers/gpu/drm/rockc

[PATCH 2/3] drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails

) Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index c80f7d9fd..006988

[PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- 1 file change

[PATCH] drm/mediatek: fix reference leak in mtk_crtc_ddp_hw_init

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +

[PATCH] drm/lima: fix reference leak in lima_pm_busy

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 50de2e9ebbc0 ("drm/lima: enable runtime pm") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/lima/lima_sched.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] drm: rcar-du: fix reference leak in amdgpu_debugfs_gfxoff_read

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file change

[PATCH] drm/bridge: cdns: fix reference leak in cdns_dsi_transfer

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 inse

[PATCH] drm/dev: Fix NULL pointer dereference in drm_minor_alloc

92b ("drm: manage drm_minor cleanup with drmm_") Signed-off-by: Qinglang Miao --- drivers/gpu/drm/drm_drv.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index cd162d406..c253d3cd4 100644 --- a/driver

[PATCH] drm: bridge: cdns-mhdp8546: fix reference leak in cdns_mhdp_probe

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8

[PATCH] drm: rcar-du: fix reference leak in rcar_cmm_enable

. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/gpu/drm/rcar-du/rcar_cmm.c | 2 +- 1 file changed, 1 inse

[PATCH] drm: panel: simple: add missing platform_driver_unregister() in panel_simple_init

Add the missing platform_driver_unregister() before return from panel_simple_init in the error handling case when failed to register panel_simple_dsi_driver with CONFIG_DRM_MIPI_DSI enabled. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panel/panel-simple.c | 4 +++- 1 file changed, 3

[PATCH] drm/tegra: sor: fix missing clk_disable_unprepare() on error in tegra_sor_init

Fix the missing clk_disable_unprepare() before return from tegra_sor_init() in the error handling case. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/tegra/sor.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra

[PATCH -next] drm/panel: simplify the return expression of td028ttec1_prepare

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c index 037c14fd6

[PATCH -next] drm/panfrost: simplify the return expression of panfrost_devfreq_target()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 8ab025d00

[PATCH -next] omapfb: connector-analog-tv: simplify the return expression of tvc_connect()

Simplify the return expression. Signed-off-by: Qinglang Miao --- .../fbdev/omap2/omapfb/displays/connector-analog-tv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c b/drivers/video/fbdev/omap2

[PATCH -next] omapfb: connector-hdmi: simplify the return expression of hdmic_connect

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpio/gpio-cs5535.c | 6 +- drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c | 7 +-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH -next] omapdrm: panel: td028ttec1: simplify the return expression of td028ttec1_panel_connect()

Simplify the return expression. Signed-off-by: Qinglang Miao --- .../fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b/drivers/video/fbdev/omap2

[PATCH -next] drm: omapdrm: dss: simplify the return expression of hdmi_init_pll_data

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c index cf2b000f3..c3e85b636 100644

[PATCH -next] drm/amdgpu: simplify the return expression

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/amd/amdgpu/cik_ih.c | 7 +-- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 10 ++ 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/cik_ih.c b/drivers/gpu/drm/amd

[PATCH -next] drm/vc4: simplify the return expression of vc4_v3d_bin_bo_get()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/vc4/vc4_bo.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index 74ceebd62..dfd214386 100644 --- a/drivers/gpu/drm/vc4

[PATCH -next] drm/omap: dss: simplify the return expression of dss_setup_default_clock()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/omapdrm/dss/dss.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 6ccbc29c4..b74579270 100644 --- a/drivers/gpu

[PATCH -next] omapfb: panel-sony-acx565akm: simplify the return expression of acx565akm_connect()

Simplify the return expression. Signed-off-by: Qinglang Miao --- .../fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2

[PATCH -next] drm/qxl: simplify the return expression of qxl_plane_prepare_fb()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/qxl/qxl_display.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 6063f3a15..65de1f69a 100644 --- a/drivers/gpu

[PATCH -next] video: omapfb: simplify the return expression of hdmi_pll_enable

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c index

[PATCH -next] drm/i915: simplify the return expression of i915_driver_release()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/i915/i915_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index acc32066c..a594bb4aa 100644 --- a/drivers/gpu/drm

[PATCH -next] gpu/drm: simplify the return expression of drm_agp_info_ioctl()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/drm_agpsupport.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 4c7ad46fd..2405785ae 100644 --- a/drivers/gpu/drm

[PATCH -next] drm/amdgpu/mes: simplify the return expression of mes_v10_1_ring_init

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c index 4b746584a..1c22d8393 100644

[PATCH -next] gpu: host1x: simplify the return expression of host1x_cdma_init()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/host1x/cdma.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index e8d3fda91..08a0f9e10 100644 --- a/drivers/gpu/host1x/cdma.c +++ b

[PATCH -next] vga_switcheroo: simplify the return expression of vga_switcheroo_runtime_resume

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/vga/vga_switcheroo.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c index 087304b1a..1401fd52f 100644 --- a/drivers/gpu/vga

[PATCH -next] drm/panfrost: simplify the return expression of cz_ih_hw_init()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panfrost/panfrost_device.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index e68967338

[PATCH -next] drm/tidss: simplify the return expression of tidss_pm_runtime_resume()

Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/tidss/tidss_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c index 9179ea18f..96568695a 100644 --- a/drivers/gpu

[PATCH -next v2] drm/msm/dpu: Convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 15 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 29

[PATCH -next v2] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

[PATCH -next v2] gpu: host1x: debug: Convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/host1x/debug.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git

[PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro

Use for_each_child_of_node() macro instead of open coding it. Signed-off-by: Qinglang Miao --- drivers/video/fbdev/nvidia/nv_of.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_of.c b/drivers/video/fbdev/nvidia/nv_of.c index 5f3e5179c

[PATCH] drm/v3d: convert to use module_platform_driver

Get rid of boilerplate code by using module_platform_driver macro for v3d_drm. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/v3d/v3d_drv.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index

[PATCH] drm/amd/display: convert to use le16_add_cpu()

Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu(). Signed-off-by: Qinglang Miao --- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 +--- drivers/gpu/drm/amd/display/dc/bios/command_table2.c | 5 + 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH] drm/vkms: add missing platform_device_unregister() in vkms_init()

When vkms_init() get into out_put, the unregister call of vkms_device->platform is missing. So add it before return. Fixes: c27f0cc4d43a "drm/vkms: enable cursor by default" Signed-off-by: Qinglang Miao --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+

[PATCH] drm/vgem: add missing platform_device_unregister() in vgem_init()

When vgem_init() get into out_put, the unregister call of vgem_device->platform is missing. So add it before return. Fixes: 363de9e7d4f6 "drm/vgem: Use drmm_add_final_kfree" Signed-off-by: Qinglang Miao --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+

[PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE

From: Liu Shixin Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Liu Shixin --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c

[PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE

From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu --- drivers/gpu/host1x/debug.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c index