Re: [PATCH] drm/amd: Document device reset methods

2023-11-10 Thread Randy Dunlap
Hi-- On 11/10/23 07:55, André Almeida wrote: > Document what each amdgpu driver reset method does. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
by: Hunter Chasens Acked-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index 517b9fb462

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
On 11/6/23 11:06, Hunter Chasens wrote: > First, apologies to Jani Nikula. I accedently top posted on the other thread. > My email client is giving me a hard time. The following works and, if > everyone agrees, I'll send out a v2. > > * E.g.:: > * > * S: 19Mhz * > * 0: 615Mhz > * 1:

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-05 Thread Randy Dunlap
On 11/5/23 21:15, Bagas Sanjaya wrote: > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> index 517b9fb4624c..703fe2542258 100644 >> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> +++

Re: [PATCH] drm/tiny: print 'struct resource *' correctly

2023-10-15 Thread Randy Dunlap
On 10/15/23 06:11, Yussef Dalton wrote: > Since format specifier %pr refers to a 'struct resource *', there is no > need to take the address of the 'res' variable since it is already of > type 'struct resource *'. > > Signed-off-by: Yussef Dalton Reviewed-by: Randy

Re: linux-next: Tree for Oct 12 (drivers/gpu/drm/msm/adreno/a6xx_gmu.o)

2023-10-12 Thread Randy Dunlap
On 10/11/23 22:43, Stephen Rothwell wrote: > Hi all, > > Changes since 20231011: > on powerpc 64BIT: powerpc64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': a6xx_gmu.c:(.text+0x6afc): undefined reference to `qmp_send' powerpc64-linux-ld:

[PATCH v2] drm/i915/uapi: fix doc typos

2023-10-08 Thread Randy Dunlap
Correct typo of "its". Add commas for clarity. Capitalize L3. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Ville Syrjäl

Re: [PATCH] drm/nouveau: fix kernel-doc warning

2023-10-08 Thread Randy Dunlap
Hi, On 10/8/23 00:06, Bragatheswaran Manickavel wrote: > Identified below document warning in latest linux-next. > ./include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand > * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX: on line 49 - I thought it was a doc line > > Also, on running checkpatch.pl to

[PATCH v2] drm/nouveau: exec: fix ioctl kernel-doc warning

2023-10-08 Thread Randy Dunlap
and format the comment more like a kernel-doc comment for consistency. Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich Cc: Karol Herbst Cc: Lyude Paul Cc: dri-devel@lists.free

[PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning

2023-10-06 Thread Randy Dunlap
include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX on line 49 - I thought it was a doc line Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich

[PATCH 2/3] drm/fourcc: fix doc typos

2023-10-02 Thread Randy Dunlap
Correct spelling and remove an extraneous word. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_fourcc.h | 12 ++-- 1 file changed, 6

[PATCH 1/3] drm/uapi: drm_mode: fix doc typos

2023-10-02 Thread Randy Dunlap
Correct grammar (add s for plural, insert "the"). Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_mode.h |6 +++--- 1 file changed, 3

[PATCH 3/3] drm/rect: fix kernel-doc typos

2023-10-02 Thread Randy Dunlap
Correct typos of "translated". Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/drm/drm_rect.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH] drm/i915/uapi: fix doc typos

2023-10-02 Thread Randy Dunlap
Hi-- On 10/1/23 23:47, Ville Syrjälä wrote: > On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: >> Correct typo of "its". >> Add a comma for clarity. >> >> Signed-off-by: Randy Dunlap >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >>

Re: [PATCH] drm/amd/display: add kernel docs for dc_dmub_caps

2023-10-02 Thread Randy Dunlap
On 10/1/23 21:41, Sagar Vashnav wrote: > Add kernel documentation for the dc_dmub_caps structure. > > Signed-off-by: Sagar Vashnav Reviewed-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/amd/display/dc/dc.h | 10 ++ > 1 file changed, 10 insertions(+) > &

[PATCH] drm/i915/uapi: fix doc typos

2023-10-01 Thread Randy Dunlap
Correct typo of "its". Add a comma for clarity. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: dri-devel@lists.freed

[PATCH] iosys-map: fix kernel-doc typos

2023-09-30 Thread Randy Dunlap
Correct spelling of "beginning". Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- include/linux/iosys-map.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h --- a/inc

Re: [PATCH] add kernel docs for dc_dmub_caps

2023-09-29 Thread Randy Dunlap
Hi, The $Subject could be improved, e.g.: [PATCH] drm/amd/display: add kernel docs for dc_dmub_caps On 9/29/23 03:00, Sagar Vashnav wrote: > Add kernel documentation for the dc_dmub_caps structure. > > Signed-off-by: Sagar Vashnav Reviewed-by: Randy Dunlap Thanks. > --- &g

Re: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-22 Thread Randy Dunlap
Hi Geert, On 9/22/23 00:23, Geert Uytterhoeven wrote: > Hi Randy, > > On Thu, Sep 21, 2023 at 10:43 PM Randy Dunlap wrote: >> Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: >> >> sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe':

[PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-21 Thread Randy Dunlap
LCDC framebuffer driver") Signed-off-by: Randy Dunlap Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: John Paul Adrian Glaubitz Cc: linux...@vger.kernel.org --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] gpu: drm: amd: display: fix kernel-doc warnings

2023-09-19 Thread Randy Dunlap
ember 'bottom_inside_gain' > not described in 'mpcc_blnd_cfg'. > > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:110: > warning: Function parameter or member 'bottom_outside_gain' > not described in 'mpcc_blnd_cfg'. > > Signed-off-by: Swarup Laxman Kotiaklapudi Thanks for f

Re: linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-12 Thread Randy Dunlap
Hi Jani, On 9/12/23 07:52, Randy Dunlap wrote: > > > On 9/12/23 00:47, Jani Nikula wrote: >> On Mon, 11 Sep 2023, Randy Dunlap wrote: >>> On 9/10/23 19:11, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Please do *not* include

Re: linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-12 Thread Randy Dunlap
On 9/12/23 00:47, Jani Nikula wrote: > On Mon, 11 Sep 2023, Randy Dunlap wrote: >> On 9/10/23 19:11, Stephen Rothwell wrote: >>> Hi all, >>> >>> Please do *not* include material destined for v6.7 in your linux-next >>> included branches until *aft

Re: linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-11 Thread Randy Dunlap
On 9/10/23 19:11, Stephen Rothwell wrote: > Hi all, > > Please do *not* include material destined for v6.7 in your linux-next > included branches until *after* v6.6-rc1 has been released. Also, > do *not* rebase your linu-next included branches onto v6.5. > > Changes since 20230908: > >

Re: (subset) [PATCH v2] drm/connector: document DRM_MODE_COLORIMETRY_COUNT

2023-09-11 Thread Randy Dunlap
On 9/11/23 03:23, Jani Nikula wrote: > On Thu, 07 Sep 2023, Maxime Ripard wrote: >> On Wed, 06 Sep 2023 22:47:38 +0200, Javier Carrasco wrote: >>> The drm_colorspace enum member DRM_MODE_COLORIMETRY_COUNT has been >>> properly documented by moving the description out of the enum to the >>>

[PATCH] drm/amd/display: fix replay_mode kernel-doc warning

2023-09-10 Thread Randy Dunlap
parameter or member 'replay_mode' not described in 'amdgpu_hdmi_vsdb_info' Fixes: ec8e59cb4e0c ("drm/amd/display: Get replay info from VSDB") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Bhawanpreet Lakha Cc: Harry Wentland Cc: Alex Deucher Cc: Leo Li Cc: Rodrig

Re: [PATCH] drm: fix doc warnings related to drm connector

2023-09-10 Thread Randy Dunlap
On 9/9/23 23:37, Bragatheswaran Manickavel wrote: >>On Sun, 10 Sept 2023 at 09:29, Randy Dunlap ><mailto:rdun...@infradead.org>> wrote: >>On 9/9/23 20:54, Bagas Sanjaya wrote: >>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote: >

Re: [PATCH] drm: fix doc warnings related to drm connector

2023-09-09 Thread Randy Dunlap
On 9/9/23 20:54, Bagas Sanjaya wrote: > On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote: >> Addressing drm dp/hdmi connector related kernel documentation >> warning and add more information about these values. > > What are these? > There are already patches for

Re: [PATCH] drm/connector: document supported_colorspaces and DRM_MODE_COLORIMETRY_COUNT

2023-09-06 Thread Randy Dunlap
/drm/drm_connector.h b/include/drm/drm_connector.h > index d300fde6c1a4..18cf46e3478b 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h This one still needs to be fixed/applied. You can add: Reviewed-by: Randy Dunlap Thanks. > @@ -498,6 +498,8 @@ enum drm_p

Re: [PATCH] drm/connector: mark enum counter value as private

2023-08-29 Thread Randy Dunlap
Hi, On 7/15/23 17:46, Randy Dunlap wrote: > Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in > kernel-doc to prevent a build warning: > > include/drm/drm_connector.h:527: warning: Enum value > 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorsp

Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

2023-08-28 Thread Randy Dunlap
Hi-- On 8/28/23 09:39, Laurent Pinchart wrote: > Hi Lee, > > Thank you for the patch. > > On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote: >> Fixes the following W=1 kernel build warning(s): >> >> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or >> member

Re: linux-next: Tree for Aug 17 (DRM_TTM KUNIT tests)

2023-08-17 Thread Randy Dunlap
On 8/16/23 21:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20230816: > on risc-v 32-bit: when # CONFIG_MMU is not set WARNING: unmet direct dependencies detected for DRM_TTM Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n] Selected by [y]: - DRM_TTM_KUNIT_TEST [=y]

Re: [PATCH v6] drm/doc: Document DRM device reset expectations

2023-08-11 Thread Randy Dunlap
Hi, On 8/11/23 11:55, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > > --- > > Changes: > - Due to substantial changes in the content, dropped Pekka's Acked-by > - Grammar fixes

Re: [PATCH V8 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-10 Thread Randy Dunlap
On 8/10/23 00:37, Evan Quan wrote: > diff --git a/Documentation/admin-guide/kernel-parameters.txt > b/Documentation/admin-guide/kernel-parameters.txt > index a1457995fd41..21f73a0bbd0b 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++

[PATCH] drm/amd/display: dmub_replay: don't use kernel-doc markers

2023-08-08 Thread Randy Dunlap
xt values to firmware. and 10 more similar warnings. Fixes: c7ddc0a800bc ("drm/amd/display: Add Functions to enable Freesync Panel Replay") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: lore.kernel.org/r/202308081459.us5rlyay-...@intel.com Cc: Bhawanpreet Lakha Cc: Harr

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Randy Dunlap
230726220325.278976-1-arthurgri...@riseup.net > Suggested-by: Arnd Bergmann > Signed-off-by: Javier Martinez Canillas Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > di

[PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY

2023-08-03 Thread Randy Dunlap
henever selecting GENERIC_PHY_MIPI_DPHY. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support") Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY") Si

Re: drivers/gpu/drm/bridge/samsung-dsim.c link error

2023-08-03 Thread Randy Dunlap
On 8/3/23 19:42, Adam Ford wrote: > On Thu, Aug 3, 2023 at 9:37 PM Randy Dunlap wrote: >> >> >> >> On 8/3/23 19:26, Adam Ford wrote: >>> On Thu, Aug 3, 2023 at 9:01 PM Randy Dunlap wrote: >>>> >>>> Hi-- >>>> >>>&

Re: drivers/gpu/drm/bridge/samsung-dsim.c link error

2023-08-03 Thread Randy Dunlap
On 8/3/23 19:26, Adam Ford wrote: > On Thu, Aug 3, 2023 at 9:01 PM Randy Dunlap wrote: >> >> Hi-- >> >> On 8/3/23 08:24, Adam Ford wrote: >>> On Thu, Aug 3, 2023 at 9:42 AM Aleksandr Nogikh wrote: >>>> >>>> Hello, >>>> &g

Re: drivers/gpu/drm/bridge/samsung-dsim.c link error

2023-08-03 Thread Randy Dunlap
Hi-- On 8/3/23 08:24, Adam Ford wrote: > On Thu, Aug 3, 2023 at 9:42 AM Aleksandr Nogikh wrote: >> >> Hello, >> >> We've been seing the following linker error on arm64 syzbot instances: >> >> ld.lld: error: undefined symbol: phy_mipi_dphy_get_default_config_for_hsclk > referenced by

Re: [PATCH -next] drm/tests: Fix one kernel-doc comment

2023-08-01 Thread Randy Dunlap
oc(). Prototype was for > drm_kunit_helper_acquire_ctx_alloc() instead > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6073 > Signed-off-by: Yang Li Reviewed-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +- > 1 f

Re: [PATCH v1 v1 1/7] MAINTAINERS: Update starfive maintainers

2023-08-01 Thread Randy Dunlap
On 8/1/23 03:10, Keith Zhao wrote: > update starfive maintainers > > Signed-off-by: Keith Zhao > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3be1bdfe8..daadd1707 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@

Re: [PATCH v1 v1 5/7] drm/vs: Register DRM device

2023-08-01 Thread Randy Dunlap
On 8/1/23 03:10, Keith Zhao wrote: > diff --git a/drivers/gpu/drm/verisilicon/Kconfig > b/drivers/gpu/drm/verisilicon/Kconfig > new file mode 100644 > index 0..fcc39dded > --- /dev/null > +++ b/drivers/gpu/drm/verisilicon/Kconfig > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: GPL-2.0

Re: [PATCH] fbdev/ps3fb: Build without kernel device

2023-07-31 Thread Randy Dunlap
> | ^~~ > ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info' > 1171 | dev_info(info->device, "%s %s, using %u KiB of video > memory\n", > | ^~~~ > > Reporte

Re: [PATCH] dma-buf/sync_file: Fix missing colon in kernel-doc for num_fences

2023-07-26 Thread Randy Dunlap
Hi-- On 7/26/23 18:19, David Reaver wrote: > The struct sync_fence_info member num_fences was missing a colon in the > kernel-doc, causing this warning when running make htmldocs: > > ./include/uapi/linux/sync_file.h:77: warning: Function parameter or member > 'num_fences' not described in

Re: [PATCH] dma-buf/sync_file: Fix docs syntax

2023-07-24 Thread Randy Dunlap
IOCTLs") > Signed-off-by: Rob Clark Reviewed-by: Randy Dunlap Thanks. > --- > include/uapi/linux/sync_file.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/sync_file.h b/include/uapi/linux/sync_file.h > index 7e42a

Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-19 Thread Randy Dunlap
> > Signed-off-by: Yang Li Reviewed-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_

Re: [PATCH] TinyDRM display driver for Philips PCD8544 display controller

2023-07-19 Thread Randy Dunlap
On 7/18/23 01:07, Viktar Simanenka wrote: > Support for common monochrome LCD displays based on PCD8544 (such as Nokia > 5110/3310 LCD) SPI controlled displays. > > Signed-off-by: Viktar Simanenka > --- > .../bindings/display/philips,pcd8544.yaml | 92 > drivers/gpu/drm/tiny/Kconfig

[PATCH] drm/connector: mark enum counter value as private

2023-07-15 Thread Randy Dunlap
array") Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org Cc: Harry Wentland Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org --- include/drm/drm_connector.h |2 +- 1 file

Re: [PATCH v4 21/21] dyndbg-doc: add classmap info to howto

2023-07-13 Thread Randy Dunlap
On 7/13/23 09:36, Jim Cromie wrote: > Add some basic info on classmap usage and api > > Signed-off-by: Jim Cromie > --- > .../admin-guide/dynamic-debug-howto.rst | 64 ++- > 1 file changed, 63 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m

2023-07-13 Thread Randy Dunlap
Hi Jim, On 7/13/23 09:36, Jim Cromie wrote: > Signed-off-by: Jim Cromie > --- > lib/Kconfig.debug | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d4fbbcc395d2..82d11ac63758 100644 > --- a/lib/Kconfig.debug > +++

Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data

2023-07-13 Thread Randy Dunlap
On 7/13/23 06:21, Miguel Ojeda wrote: > On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann wrote: >> >> Most fbdev drivers depend on framebuffer_alloc() to initialize the >> allocated memory to 0. Document this guarantee. >> >> Suggested-by: Miguel Ojeda >> Signed-off-by: Thomas Zimmermann >>

Re: scripts/kernel-doc does not handle duplicate struct & function names (e.g., in amdgpu)

2023-07-11 Thread Randy Dunlap
On 7/11/23 20:32, Akira Yokosawa wrote: > Hi Randy, > >> [just documenting this for posterity or in case someone wants to fix it.] >> >> In drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c, one can find both >> >> struct amdgpu_vm_tlb_seq_cb {...}; >> >> and >> static void amdgpu_vm_tlb_seq_cb(...) >>

scripts/kernel-doc does not handle duplicate struct & function names (e.g., in amdgpu)

2023-07-11 Thread Randy Dunlap
[just documenting this for posterity or in case someone wants to fix it.] In drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c, one can find both struct amdgpu_vm_tlb_seq_cb {...}; and static void amdgpu_vm_tlb_seq_cb(...) Of course C has no problem with this, but kernel-doc reports:

Re: linux-next: build warnings after merge of the amdgpu tree

2023-07-11 Thread Randy Dunlap
On 7/11/23 16:15, Stephen Rothwell wrote: > Hi all, > > On Fri, 18 Nov 2022 17:55:45 +1100 Stephen Rothwell > wrote: >> >> After merging the amdgpu tree, today's linux-next build (htmldocs) >> produced these warnings: >> >> drivers/gpu/drm/amd/display/dc/dc.h:548: warning: Function parameter

[PATCH] drm/amd/display: dc.h: eliminate kernel-doc warnings

2023-07-11 Thread Randy Dunlap
ment pipe split policy") Fixes: f6ae69f49fcf ("drm/amd/display: Include surface of unaffected streams") Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org Cc: Alex Deucher Cc: Chr

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Randy Dunlap
On 7/3/23 19:44, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 22:38 Randy Dunlap <mailto:rdun...@infradead.org>> wrote: > > > > On 7/3/23 19:34, Marek Olšák wrote: > > > > > > On Mon, Jul 3, 2023, 03:12 M

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Randy Dunlap
On 7/3/23 19:34, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > Marek, Please stop sending html emails to the mailing lists. The mailing list software drops them. Please set your email interface to use plain text mode

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Randy Dunlap
Hi, Does this series apply on top of the previous series or on what? On 7/1/23 14:44, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Randy Dunlap
so apps can recover, it's > +really useful for driver developers to learn more about what caused the > reset in > +first place. DRM devices should make use of devcoredump to store relevant the first place. > +information about the reset, so this information can be added to user bug > +reports. > + > .. _drm_driver_ioctl: > > IOCTL Support on Device Nodes and with those addressed: Reviewed-by: Randy Dunlap Thanks for adding the documentation. -- ~Randy

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-27 Thread Randy Dunlap
borg > Cc: sparcli...@vger.kernel.org > Signed-off-by: Thomas Zimmermann Reviewed-by: Randy Dunlap Thanks. > --- > arch/sparc/video/fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c > index 25837f1

Re: [PATCH v4 1/1] drm/doc: Document DRM device reset expectations

2023-06-26 Thread Randy Dunlap
Hi, On 6/26/23 11:33, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > --- > Documentation/gpu/drm-uapi.rst | 68 ++ > 1 file changed, 68

Re: [PATCH 1/2] docs: module: start adding some docs for MODULE_ macros.

2023-06-22 Thread Randy Dunlap
ction. > > Cc: linux-...@vger.kernel.org > Cc: Jonathan Corbet > Cc: Luis Chamberlain > Cc: linux-modu...@vger.kernel.org > Signed-off-by: Dave Airlie Tested-by: Randy Dunlap # for the kernel-doc Thanks. > --- > Documentation/core-api/kernel-api.rst | 3 ++ > Documentation/

Re: [PATCH 2/2] modules/firmware: add a new option to denote a firmware group to choose one.

2023-06-22 Thread Randy Dunlap
; + * > + * ``MODULE_FIRMWARE("firmwarev1")`` > + * > + * ``MODULE_FIRMWARE("firmwarev2")`` > + * > + * ``MODULE_FIRMWARE_GROUP_ONLY_ONE("mygroup")`` > + */ > +#define MODULE_FIRMWARE_GROUP_ONLY_ONE(_grpname) > MODULE_INFO(firmware_group_only_one, _grp

Re: [PATCH] drm/i915: make i915_drm_client_fdinfo() reference conditional again

2023-06-16 Thread Randy Dunlap
drm/i915/i915_driver.o:(i915_drm_driver) in >>>> archive vmlinux.a > > Use the PTR_IF() helper to make the reference NULL otherwise. > > Fixes: e894b724c316d ("drm/i915: Use the fdinfo helper") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tes

Re: linux-next: Tree for Jun 13 (drivers/gpu/drm/i915/display/)

2023-06-13 Thread Randy Dunlap
On 6/12/23 23:59, Stephen Rothwell wrote: > Hi all, > > Changes since 20230609: > In file included from : ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration

[PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

2023-05-25 Thread Randy Dunlap
d JSM messages") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/all/202305221206.1taugdkp-...@intel.com/ Cc: Oded Gabbay Cc: dri-devel@lists.freedesktop.org Cc: Jacek Lawrynowicz Cc: Stanislaw Gruszka Cc: Andrzej Kacprowski Cc: Krystian Pradzynski C

Re: [PATCH] dma-buf/sync_file: Fix doc build warning

2023-04-12 Thread Randy Dunlap
t;staging/android: refactor SYNC IOCTLs") > Signed-off-by: Rob Clark Reviewed-by: Randy Dunlap Thanks. > --- > include/uapi/linux/sync_file.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/sync_file.h b/include/uapi/linu

Re: [PATCH] drm/vblank: Simplify drm_dev_has_vblank()

2023-04-03 Thread Randy Dunlap
On 4/3/23 09:23, Ville Syrjälä wrote: > On Mon, Apr 03, 2023 at 09:07:35AM -0700, Rob Clark wrote: >> From: Rob Clark >> >> What does vblank have to do with num_crtcs? Well, this was technically >> correct, but you'd have to go look at where num_crtcs is initialized to >> understand why.

[PATCH] linux/vt_buffer.h: allow either builtin or modular for macros

2023-03-28 Thread Randy Dunlap
) |^~ ../arch/alpha/include/asm/vga.h:25:29: error: expected identifier or '(' before 'volatile' 25 | static inline u16 scr_readw(volatile const u16 *addr) | ^~~~ Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off

Re: [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-28 Thread Randy Dunlap
; drivers/base/power/domain.c:853:26: error: no member named 'ignore_children' > in 'struct dev_pm_info' > if (!dev || dev->power.ignore_children) > ~~ ^ > > Fixes: c11fa1204fe9 ("drm/msm/a6xx: Use genpd notifier to ensure

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-21 Thread Randy Dunlap
Hiya, On 3/21/23 00:34, Geert Uytterhoeven wrote: > Hi Randy, > > On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap wrote: >> On 3/20/23 01:21, Geert Uytterhoeven wrote: >>> Below is the list of build error/warning regressions/improvements in >>> v6.3-rc3[1] compar

Re: [PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-21 Thread Randy Dunlap
ed int. > > Fixes: efcd0107727c4f04 ("drm/msm/dpu: add support for SM8550") > Fixes: 4a352c2fc15aec1e ("drm/msm/dpu: Introduce SC8280XP") > Fixes: 100d7ef6995d1f86 ("drm/msm/dpu: add support for SM8450") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Ra

Re: [PATCH 06/37] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting

2023-03-21 Thread Randy Dunlap
On 3/21/23 02:49, Melissa Wen wrote: > O 03/20, Randy Dunlap wrote: >> >> >> On 3/20/23 16:46, Melissa Wen wrote: >>> On 03/17, Lee Jones wrote: >>>> Fixes the following W=1 kernel build warning(s): >>>> >>>> drivers/gpu/drm/vk

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-20 Thread Randy Dunlap
Hi-- On 3/20/23 01:21, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v6.3-rc3[1] compared to v6.2[2]. > > Summarized: > - build errors: +9/-14 > - build warnings: +4/-1447 > > JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries

Re: [PATCH 06/37] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting

2023-03-20 Thread Randy Dunlap
On 3/20/23 16:46, Melissa Wen wrote: > On 03/17, Lee Jones wrote: >> Fixes the following W=1 kernel build warning(s): >> >> drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or >> member 'frame_info' not described in 'pre_mul_alpha_blend' >>

[PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

2023-03-07 Thread Randy Dunlap
M [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n) Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: lore.kernel.org/r/202303071922.wjqdwqpe-...@intel.

Re: [PATCH 01/99] lib: Add option iterator

2023-03-06 Thread Randy Dunlap
Hi, On 3/6/23 07:58, Thomas Zimmermann wrote: > Add struct option_iter and helpers that walk over individual options > of an option string. Add documentation. > > Kernel parameters often have the format of > > param=opt1,opt2:val,opt3 > > where the option string contains a number of

[PATCH v2] drm/msm: DEVFREQ_GOV_SIMPLE_ONDEMAND is no longer needed

2023-02-19 Thread Randy Dunlap
DRM_MSM no longer needs DEVFREQ_GOV_SIMPLE_ONDEMAND (since dbd7a2a941b8 in linux-next: PM / devfreq: Fix build issues with devfreq disabled), so remove that select from the DRM_MSM Kconfig file. Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") Signed-off-by: Randy Dunla

Re: [PATCH] drm/msm: fix new Konfig dependency warning

2023-02-19 Thread Randy Dunlap
On 2/19/23 15:09, Rob Clark wrote: > On Sun, Feb 19, 2023 at 10:54 AM Randy Dunlap wrote: >> >> DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, so in order to >> select the former safely, this symbol should also depend on >> PM_DEVFREQ to avoid a Kconfig depend

[PATCH] drm/msm: fix new Konfig dependency warning

2023-02-19 Thread Randy Dunlap
p;& (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") Signed-off-by: Randy Dunlap Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-...@vger.kernel.o

[PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-14 Thread Randy Dunlap
t;drm/i915/gvt: move the gvt code into kvmgt.ko") Signed-off-by: Randy Dunlap Cc: Christoph Hellwig Cc: Zhi Wang Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Zhenyu Wang Cc: intel-...@lists.freedesktop.org Cc: intel-gvt-...@lists.freedesktop.org Cc:

error: 'const struct dc_dsc_config' has no member named 'is_frl'

2023-02-09 Thread Randy Dunlap
Hi, The 'is_frl' struct field is conditional: #if defined(CONFIG_DRM_AMD_DC_DCN) bool is_frl; /* indicate if DSC is applied based on HDMI FRL sink's capability */ #endif so code that uses it should be careful, otherwise build errors may happen:

[PATCH 00/24 v2] Documentation: correct lots of spelling errors (series 1)

2023-02-08 Thread Randy Dunlap
Correct many spelling errors in Documentation/ as reported by codespell. Maintainers of specific kernel subsystems are only Cc-ed on their respective patches, not the entire series. These patches are based on linux-next-20230209. [PATCH 01/24] Documentation: arm: correct spelling [PATCH

[PATCH 05/24] Documentation: fb: correct spelling

2023-02-08 Thread Randy Dunlap
Correct spelling problems for Documentation/fb/ as reported by codespell. Signed-off-by: Randy Dunlap Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/fb/sm712fb.rst |2

Re: remove arch/sh

2023-02-07 Thread Randy Dunlap
On 2/7/23 01:06, John Paul Adrian Glaubitz wrote: > Hello Christoph! > > On Fri, 2023-02-03 at 08:14 +0100, Christoph Hellwig wrote: >> On Mon, Jan 16, 2023 at 09:52:10AM +0100, John Paul Adrian Glaubitz wrote: >>> We have had a discussion between multiple people invested in the SuperH >>>

[PATCH] drm/amd/amdgpu: add complete header search path

2023-02-03 Thread Randy Dunlap
/display: Enable Freesync over PCon") Signed-off-by: Randy Dunlap Cc: Signed-off-by: Sung Joon Kim Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/amdgpu/Makefile |1

Re: remove arch/sh

2023-02-03 Thread Randy Dunlap
Hi-- On 2/3/23 02:33, Geert Uytterhoeven wrote: > Hi Adrian, > > On Fri, Feb 3, 2023 at 11:29 AM John Paul Adrian Glaubitz > wrote: >> On Fri, 2023-02-03 at 09:30 +0100, Christoph Hellwig wrote: >>> On Fri, Feb 03, 2023 at 09:24:46AM +0100, John Paul Adrian Glaubitz wrote: Since this is my

[PATCH -next] drm/client: fix kernel-doc warning in drm_client.h

2023-01-30 Thread Randy Dunlap
scripts/kernel-doc complains about the comment for hotplug_failed, so fix it: include/drm/drm_client.h:111: warning: Incorrect use of kernel-doc format: * @hotplug failed: Fixes: 6a9d5ad3af65 ("drm/client: Add hotplug_failed flag") Signed-off-by: Randy Dunlap Cc: Thomas Zimm

[PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-01-27 Thread Randy Dunlap
Correct many spelling errors in Documentation/ as reported by codespell. Maintainers of specific kernel subsystems are only Cc-ed on their respective patches, not the entire series. [if all goes well] These patches are based on linux-next-20230125. [PATCH 01/35] Documentation: arm64: correct

[PATCH 07/35] Documentation: fb: correct spelling

2023-01-26 Thread Randy Dunlap
Correct spelling problems for Documentation/fb/ as reported by codespell. Signed-off-by: Randy Dunlap Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/fb/sm712fb.rst |2

[PATCH] drm/bridge: Kconfig: fix a spelling mistake

2023-01-24 Thread Randy Dunlap
Correct a spelling mistake (reported by codespell). Signed-off-by: Randy Dunlap Cc: Jagan Teki Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org -- drivers/gpu/drm/bridge/Kconfig |2 +- 1 file changed, 1

[PATCH] drm/connector: fix a kernel-doc bad line warning

2023-01-16 Thread Randy Dunlap
Building the kernel documentation causes this warning 7 times. Fix it by adding a " *" line instead of a blank line. drivers/gpu/drm/drm_connector.c:1849: warning: bad line: Fixes: 7d63cd8526f1 ("drm/connector: Add TV standard property") Signed-off-by: Randy Dunlap C

[PATCH] drm/atomic-helper: fix kernel-doc problems

2023-01-16 Thread Randy Dunlap
Fixes: 5a28cefda3a9 ("drm/atomic-helper: Add an analog TV atomic_check implementation") Signed-off-by: Randy Dunlap Cc: Maxime Ripard Cc: Maarten Lankhorst CC: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org --- drive

[PATCH] backlight: sky81452: fix sky81452_bl_platform_data kernel-doc

2023-01-12 Thread Randy Dunlap
instead Signed-off-by: Randy Dunlap Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Helge Deller Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org --- drivers/video/backlight/sky81452-backlight.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers

[PATCH] backlight: ili922x: fix kernel-doc warnings

2023-01-12 Thread Randy Dunlap
, rs, rw) drivers/video/backlight/ili922x.c:118: warning: expecting prototype for CHECK_FREQ_REG(spi_device s, spi_transfer x)(). Prototype was for CHECK_FREQ_REG() instead Signed-off-by: Randy Dunlap Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Helge Deller Cc: dri-devel

[PATCH] fbdev: fbmon: fix function name in kernel-doc

2023-01-12 Thread Randy Dunlap
Fix a kernel-doc warning by correcting the function name in the kernel-doc comment: drivers/video/fbdev/core/fbmon.c:1073: warning: expecting prototype for fb_get_hblank_by_freq(). Prototype was for fb_get_hblank_by_hfreq() instead Signed-off-by: Randy Dunlap Cc: Daniel Vetter Cc: Helge

[PATCH] drm: amd: display: fix dc/core/dc.c kernel-doc

2022-12-28 Thread Randy Dunlap
in 'dc_process_dmub_dpia_hpd_int_enable' dc.c:4926: warning: Function parameter or member 'hpd_int_enable' not described in 'dc_process_dmub_dpia_hpd_int_enable' 12 warnings Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: Hamza Mahfooz Cc: Harry Wentland Cc: Leo Li Cc

[PATCH 2/2] fbdev: uvesafb: don't build on UML

2022-11-30 Thread Randy Dunlap
d3f3b654 ("um: add PCI over virtio emulation driver") Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Richard Weinberger Cc: linux...@lists.infradead.org Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Michal Januszewski

[PATCH 1/2] fbdev: geode: don't build on UML

2022-11-30 Thread Randy Dunlap
(boot_cpu_data.x86 == 5) && ../arch/x86/include/asm/geode.h:25:17: error: ‘struct cpuinfo_um’ has no member named ‘x86_model’ (boot_cpu_data.x86_model == 10)); Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver") Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Richa

<    1   2   3   4   5   6   7   8   9   >