Re: [PATCH] drm/stm: add COMMON_CLK dependency

2024-07-19 Thread Raphael Gallais-Pou
On 7/19/24 09:54, Arnd Bergmann wrote: > From: Arnd Bergmann > > The added lvds driver and a change in the dsi driver resulted in failed > builds when COMMON_CLK is disabled: > > x86_64-linux-ld: drivers/gpu/drm/stm/dw_mipi_dsi-stm.o: in function > `dw_mipi_dsi_stm_remove': >

Re: [PATCH] drm/stm: ltdc: reset plane transparency after plane disable

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:13, Yannick Fertre wrote: > The plane's opacity should be reseted while the plane > is disabled. It prevents from seeing a possible global > or layer background color set earlier. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next. Thanks, Raphaël

Re: [PATCH] drm/stm: ltdc: add mask for lxcr register

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:14, Yannick Fertre wrote: > The purpose of this mask is to simplify writing to the lxcr > register and not to forget any fields. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next. Thanks, Raphaël

Re: [PATCH] drm/stm: ltdc: remove reload interrupt

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:14, Yannick Fertre wrote: > The reload interrupt is not used by the driver. To avoid > unnecessary calls of the interrupt routine, don't enable it. > Solve small typo and add mask to simplify the driver. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next.

Re: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-07-15 Thread Raphael Gallais-Pou
On 2/16/24 13:50, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes(), > drm_universal_plane_init() and drm_encoder_init(). These functions > should not be called with parameters allocated with devm_kzalloc() > to avoid use-after-free issues [1]. > > Use allocations

Re: [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc

2024-07-15 Thread Raphael Gallais-Pou
On 6/24/24 04:41, Jiapeng Chong wrote: > The function are defined in the ltdc.c file, but not called > anywhere, so delete the unused function. > > drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'. > > Reported-by: Abaci Robot > Closes:

Re: [PATCH] drm/stm: ltdc: check memory returned by devm_kzalloc()

2024-07-15 Thread Raphael Gallais-Pou
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea > --- > > Hi, > >

[PATCH] MAINTAINERS: add myself to DRM/STi maintainers

2024-07-09 Thread Raphael Gallais-Pou
In lights of recent events and my will to participate in the Linux kernel development I see this opportunity to add myself, and help Alain as maintainer for the DRM/STi drivers. Signed-off-by: Raphael Gallais-Pou --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

Re: [PATCH] drm/stm: Fix an error handling path in stm_drm_platform_probe()

2024-07-09 Thread Raphael Gallais-Pou
On 1/6/24 17:54, Christophe JAILLET wrote: > If drm_dev_register() fails, a call to drv_load() must be undone, as > already done in the remove function. > > Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") > Signed-off-by: Christophe JAILLET Hi Christophe, After some delay: applied on

Re: [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform_driver

2024-07-02 Thread Raphael Gallais-Pou
> .of_match_table = lvds_dt_ids, > }, > }; Indeed, platform_driver_register() overrides the value of the owner. Acked-by: Raphael Gallais-Pou Thanks, Raphaël

Re: [PATCH 21/21] drm/stm: Allow build with COMPILE_TEST=y

2024-04-10 Thread Raphael Gallais-Pou
Hi Ville On 4/8/24 19:04, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow stm to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Yannick Fertre > Cc: Raphael Gallais-Pou > Cc: Philippe Cornu > Signed-off-by

Re: STM32 DSI controller driver: mode_valid clock tolerance

2024-03-20 Thread Raphael Gallais-Pou
On 3/8/24 09:35, Sean Nyekjaer wrote: > Hi, Hi Sean, Sorry for not responding earlier. I've also added Antonio Borneo, which is the author of the implementation of the mode_valid() hook. > I’m using a stm32mp157 with a sn65dsi83 DSI2LVDS bridge. > The LVDS display is having a minimum clock

Re: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-02-26 Thread Raphael Gallais-Pou
On 2/16/24 13:50, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes(), > drm_universal_plane_init() and drm_encoder_init(). These functions > should not be called with parameters allocated with devm_kzalloc() > to avoid use-after-free issues [1]. > > Use allocations

[PATCH v6 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-26 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v6: - Fixes sparse symbols detected by kernel test robot Changes in v5: - Align compatible Changes in v4: - Explicitly include linux/platform_device.h, dependency introduced

[PATCH v6 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-26 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v6 0/3] Introduce STM32 LVDS driver

2024-02-26 Thread Raphael Gallais-Pou
rd to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add STM32 LVDS device drm/stm: lvds: add new STM32 LV

[PATCH v6 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-26 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou Reviewed-by: Conor Dooley --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v6: - Added Conor's Review

[PATCH v3 2/4] ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family

2024-02-23 Thread Raphael Gallais-Pou
Adds LTDC pinctrl support and assigns dedicated GPIO pins. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 + 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi b/arch/arm/boot/dts/st

[PATCH v3 4/4] dt-bindings: display: simple: allow panel-common properties

2024-02-23 Thread Raphael Gallais-Pou
This device inherits properties from panel-common. Those should be allowed to use, instead of specifying properties to true for each specific use. Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - Allow every properties instead of adding each properties to true as Rob suggested

[PATCH v3 3/4] ARM: dts: stm32: enable display support on stm32mp135f-dk board

2024-02-23 Thread Raphael Gallais-Pou
Link panel and display controller. Enable panel, backlight and display controller. Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Fixed dtbs_check warnings : arch/arm/boot/dts/st/stm32mp135f-dk.dtb: panel-backlight: 'default-brightness-level' does not match any of the regexes

[PATCH v3 0/4] Add display support for stm32mp135f-dk board

2024-02-23 Thread Raphael Gallais-Pou
l.org/lkml/17072972.1647630.4818786052103823648.b4...@linaro.org/ https://lore.kernel.org/lkml/170729755662.1647630.425379349649657352.b4...@linaro.org/ - Fixed CHECK_DTBS warnings - Added missing properties in panel-simple.yaml Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (4):

[PATCH v3 1/4] ARM: dts: stm32: add LTDC support for STM32MP13x SoC family

2024-02-23 Thread Raphael Gallais-Pou
and additional interrupt set * Interrupts based on 7 different events * AXI master interface with long efficient bursts (64 or 128 bytes) Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- arch/arm/boot/dts/st/stm32mp135.dtsi | 11 +++ 1 file changed, 11 insertions

Re: [PATCH v2 4/4] dt-bindings: display: simple: hardware can use several properties

2024-02-23 Thread Raphael Gallais-Pou
On 2/23/24 01:09, Rob Herring wrote: > On Sat, Feb 17, 2024 at 12:02:58PM +0100, Raphael Gallais-Pou wrote: >> Setting a panel-timing in the device-tree overwrite the one specified in >> the driver and set it as preferred. In that case 'height-mm', >> 'width-

[PATCH v2 0/4] Add display support for stm32mp135f-dk board

2024-02-17 Thread Raphael Gallais-Pou
linaro.org/ - Fixed CHECK_DTBS warnings - Added missing properties in panel-simple.yaml Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (4): ARM: dts: stm32: add LTDC support for STM32MP13x SoC family ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family ARM:

[PATCH v2 3/4] ARM: dts: stm32: enable display support on stm32mp135f-dk board

2024-02-17 Thread Raphael Gallais-Pou
Link panel and display controller. Enable panel, backlight and display controller. Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Fixed dtbs_check warnings : arch/arm/boot/dts/st/stm32mp135f-dk.dtb: panel-backlight: 'default-brightness-level' does not match any of the regexes

[PATCH v2 2/4] ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family

2024-02-17 Thread Raphael Gallais-Pou
Adds LTDC pinctrl support and assigns dedicated GPIO pins. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 + 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi b/arch/arm/boot/dts/st

[PATCH v2 1/4] ARM: dts: stm32: add LTDC support for STM32MP13x SoC family

2024-02-17 Thread Raphael Gallais-Pou
and additional interrupt set * Interrupts based on 7 different events * AXI master interface with long efficient bursts (64 or 128 bytes) Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- arch/arm/boot/dts/st/stm32mp135.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v2 4/4] dt-bindings: display: simple: hardware can use several properties

2024-02-17 Thread Raphael Gallais-Pou
/stm32mp135f-dk.dtb: panel-rgb: 'height-mm', 'panel-timing', 'width-mm' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/panel-simple.yaml# Signed-off-by: Raphael Gallais-Pou --- Documentation/devicetree/bindings/display/panel

Re: [PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-15 Thread Raphael Gallais-Pou
Hi Alex On 2/14/24 14:40, Alexandre TORGUE wrote: > Hi Raphael > > On 2/5/24 10:06, Raphael Gallais-Pou wrote: >> This serie aims to enable display support for the stm32mp135f-dk board >> >> Those are only patches of the device-tree since the driver support h

[PATCH v5 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-06 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v5: - Align compatible Changes in v4: - Explicitly include linux/platform_device.h, dependency introduced by ef175b29a242 of: Stop circularly including of_device.h and of_platform.h Changes in v3

[PATCH v5 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-06 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v5: - Fixed path in MAINTAINERS Changes in v4:

[PATCH v5 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-06 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v5 0/3] Introduce STM32 LVDS driver

2024-02-06 Thread Raphael Gallais-Pou
Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add STM32 LVDS device drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver drm/stm: ltdc: add lvds pixel clock .../bindings/display/st,stm32mp25-lvds.yaml| 119 ++ M

[PATCH v4 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-06 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v4: - Explicitly include linux/platform_device.h, dependency introduced by ef175b29a242 of: Stop circularly including of_device.h and of_platform.h Changes in v3: - s/regroups/is composed

[PATCH v4 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-06 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v4: - Align filename to compatible - Fix compa

[PATCH v4 0/3] Introduce STM32 LVDS driver

2024-02-06 Thread Raphael Gallais-Pou
- [2/6]: Removed CamelCase macros - [2/6]: Removed hard to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add

[PATCH v4 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-06 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-05 Thread Raphael Gallais-Pou
Push horizontal front porch and vertical back porch blanking limit. This allows to get a 60 fps sharp. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/panel/panel-simple.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b

[PATCH 2/5] ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family

2024-02-05 Thread Raphael Gallais-Pou
Adds LTDC pinctrl support and assigns dedicated GPIO pins. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 + 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi b/arch/arm/boot/dts/st

[PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-05 Thread Raphael Gallais-Pou
] commit 1726cee3d053 ("drm/stm: ltdc: support of new hardware version") Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (5): ARM: dts: stm32: add LTDC support for STM32MP13x SoC family ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family ARM: dts: stm

[PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H

2024-02-05 Thread Raphael Gallais-Pou
. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 2214cb09678c..7b286382ffb4 100644 --- a/drivers/gpu/drm/panel/panel

[PATCH 3/5] ARM: dts: stm32: enable display support on stm32mp135f-dk board

2024-02-05 Thread Raphael Gallais-Pou
Link panel and display controller. Enable panel, backlight and display controller. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp135f-dk.dts | 55 + 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b

[PATCH 1/5] ARM: dts: stm32: add LTDC support for STM32MP13x SoC family

2024-02-05 Thread Raphael Gallais-Pou
and additional interrupt set * Interrupts based on 7 different events * AXI master interface with long efficient bursts (64 or 128 bytes) Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- arch/arm/boot/dts/st/stm32mp135.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-01-29 Thread Raphael Gallais-Pou
OPS to RUNTIME_PM_OPS Raphael Gallais-Pou (3): drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro drm/stm: dsi: expose DSI PHY internal clock Yannick Fertre (1): drm/stm: dsi: add pm runtime ops drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 279 ++ 1 file changed, 238 inserti

[PATCH RESEND v3 3/3] drm/stm: dsi: expose DSI PHY internal clock

2024-01-29 Thread Raphael Gallais-Pou
si_phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-off-by: Raphael Galla

[PATCH RESEND v3 2/3] drm/stm: dsi: add pm runtime ops

2024-01-29 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS and removed

[PATCH RESEND v3 1/3] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2024-01-29 Thread Raphael Gallais-Pou
Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-18 Thread Raphael Gallais-Pou
On 1/16/24 08:42, Krzysztof Kozlowski wrote: > On 15/01/2024 17:51, Raphael Gallais-Pou wrote: >> On 1/15/24 16:46, Rob Herring wrote: >>> On Mon, Jan 15, 2024 at 02:20:04PM +0100, Raphael Gallais-Pou wrote: >>>> Add "st,stm32mp25-lvds" compatible.

Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-15 Thread Raphael Gallais-Pou
On 1/15/24 16:46, Rob Herring wrote: > On Mon, Jan 15, 2024 at 02:20:04PM +0100, Raphael Gallais-Pou wrote: >> Add "st,stm32mp25-lvds" compatible. >> >> Signed-off-by: Raphael Gallais-Pou >> --- >> Depends on: "dt-bindings: stm32: add clocks and

[PATCH v3 4/6] arm64: dts: st: add ltdc support on stm32mp251

2024-01-15 Thread Raphael Gallais-Pou
The LCD-TFT Display Controller (LTDC) handles display composition, scaling and rotation. It provides a parallel digital RGB flow to be used by display interfaces. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp251.dtsi | 12 1 file changed, 12 insertions

[PATCH v3 5/6] arm64: dts: st: add lvds support on stm32mp255

2024-01-15 Thread Raphael Gallais-Pou
This patch adds LVDS support on stm32mp255. The LVDS is used on STM32MP2 as a display interface. LVDS PLL clock is binded to the LTDC input clock. Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - Change the compatible to show SoC specificity Changes in v2: - Move patch

[PATCH v3 6/6] arm64: dts: st: add display support on stm32mp257f-ev

2024-01-15 Thread Raphael Gallais-Pou
This patch enables the following IPs on stm32mp257f-ev : * LTDC * LVDS * WSVGA LVDS panel (1024x600) * Panel backlight * Ilitek touchescreen Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 79 ++ 1 file changed, 79 insertions

[PATCH v3 2/6] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-01-15 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - s/regroups/is composed of/ in commit log - Change the compatible to show SoC specificity Changes in v2: - Fixed Camel Case macros - Removed debug log --- drivers/gpu/drm/stm/Kconfig

[PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-15 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v3: - Clarify commit dependency - Fix inc

[PATCH v3 0/6] Introduce STM32 LVDS driver

2024-01-15 Thread Raphael Gallais-Pou
moved hard to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Raphael Gallais-Pou (6): dt-bindings: display: add dt-bindings for STM32 LVDS device drm/stm: lvds: add new STM32 LVDS Display Interface Transmit

[PATCH v3 3/6] drm/stm: ltdc: add lvds pixel clock

2024-01-15 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v2 4/6] arm64: dts: st: add ltdc support on stm32mp251

2024-01-11 Thread Raphael Gallais-Pou
The LCD-TFT Display Controller (LTDC) handles display composition, scaling and rotation. It provides a parallel digital RGB flow to be used by display interfaces. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp251.dtsi | 12 1 file changed, 12 insertions

[PATCH v2 6/6] arm64: dts: st: add display support on stm32mp257f-ev

2024-01-11 Thread Raphael Gallais-Pou
This patch enables the following IPs on stm32mp257f-ev : * LTDC * LVDS * WSVGA LVDS panel (1024x600) * Panel backlight * Ilitek touchescreen Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 79 ++ 1 file changed, 79 insertions

[PATCH v2 5/6] arm64: dts: st: add lvds support on stm32mp255

2024-01-11 Thread Raphael Gallais-Pou
This patch adds LVDS support on stm32mp255. The LVDS is used on STM32MP2 as a display interface. LVDS PLL clock is binded to the LTDC input clock. Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Move patch to stm32mp255.dtsi after internal discussions --- arch/arm64/boot/dts

[PATCH v2 2/6] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-01-11 Thread Raphael Gallais-Pou
pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Fixed Camel Case macros - Removed debug log --- drivers/gpu/drm/stm/Kconfig | 11 + drivers/gpu/drm/stm/Makefile |2 + drivers/gpu/drm/stm/lvds.c | 1225 ++ 3 files

[PATCH v2 3/6] drm/stm: ltdc: add lvds pixel clock

2024-01-11 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v2 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-11 Thread Raphael Gallais-Pou
Add "st,stm32-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Switch compatible and clock-cells related areas - Remove faulty #include in the example. - Add entry in MAINTAINERS --- .../bindings/display/st,stm32-lvds.yaml

[PATCH v2 0/6] Introduce STM32 LVDS driver

2024-01-11 Thread Raphael Gallais-Pou
in MAINTAINERS - [2/6]: Removed CamelCase macros - [2/6]: Removed hard to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Raphael Gallais-Pou (6): dt-bindings: display: add dt-bindings for STM32 LVDS

Re: [PATCH RESEND v1 4/8] drm/stm: ltdc: implement bus clock

2024-01-10 Thread Raphael Gallais-Pou
On 12/21/23 14:17, Dmitry Baryshkov wrote: > On Thu, 21 Dec 2023 at 14:45, Raphael Gallais-Pou > wrote: >> From: Yannick Fertre >> >> The latest hardware version of the LTDC presents the addition of a bus >> clock, which contains the global configuration registers

Re: [PATCH] drm/stm: Fix an error handling path in stm_drm_platform_probe()

2024-01-10 Thread Raphael Gallais-Pou
--- > drivers/gpu/drm/stm/drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > I tested it against stm32mp157c-dk2.dts. Thanks for your submission. Acked-by: Raphael Gallais-Pou Regards, Raphaël Gallais-Pou

Re: [PATCH v2] drm/stm: Avoid use-after-free issues with crtc and plane

2024-01-05 Thread Raphael Gallais-Pou
t; Use allocations managed by the DRM framework. > > Found by Linux Verification Center (linuxtesting.org). > > [1] > https://lore.kernel.org/lkml/u366i76e3qhh3ra5oxrtngjtm2u5lterkekcz6y2jkndhuxzli@diujon4h7qwb/ > > Signed-off-by: Katya Orlova > --- > v2: use allocation

Re: [PATCH v2 3/4] drm/stm: dsi: expose DSI PHY internal clock

2024-01-04 Thread Raphael Gallais-Pou
On 12/8/23 17:58, Simon Horman wrote: > On Mon, Dec 04, 2023 at 11:11:12AM +0100, Raphael Gallais-Pou wrote: > > ... > >> @@ -514,18 +675,40 @@ static int dw_mipi_dsi_stm_probe(struct >> platform_device *pdev) >>

[PATCH v3 4/4] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2024-01-04 Thread Raphael Gallais-Pou
In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent clock, which means that it is an APB peripheral clock. Swap the clocks in the DSI peripheral clock reference. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp157.dtsi | 2 +- arch/arm/boot/dts

[PATCH v3 1/4] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2024-01-04 Thread Raphael Gallais-Pou
Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3 2/4] drm/stm: dsi: add pm runtime ops

2024-01-04 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS and removed

[PATCH v3 3/4] drm/stm: dsi: expose DSI PHY internal clock

2024-01-04 Thread Raphael Gallais-Pou
si_phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-off-by: Raphael Galla

[PATCH v3 0/4] Update STM DSI PHY driver

2024-01-04 Thread Raphael Gallais-Pou
ded patch 1/4 to use SYSTEM_SLEEP_PM_OPS instead of old macro and removed __maybe_used for accordingly - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS Raphael Gallais-Pou (3): drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro drm/stm: dsi: expose DSI PHY internal clock arm: dts:

Re: [PATCH RESEND v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device

2023-12-22 Thread Raphael Gallais-Pou
On 12/21/23 21:36, Krzysztof Kozlowski wrote: > On 21/12/2023 13:43, Raphael Gallais-Pou wrote: >> Add dt-binding file for "st,stm32-lvds" compatible. >> >> Signed-off-by: Raphael Gallais-Pou >> --- > I don't know why this was resend, nothing explain

Re: [PATCH v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device

2023-12-22 Thread Raphael Gallais-Pou
Hi Krzysztof, Thanks for your review. I wall send another serie later with those modifications. Best regards, Raphaël On 12/21/23 18:27, Krzysztof Kozlowski wrote: > On 21/12/2023 13:28, Raphael Gallais-Pou wrote: >> Add dt-binding file for "st,stm32-lvds" compatible.

Re: [PATCH RESEND v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device

2023-12-22 Thread Raphael Gallais-Pou
Hi Rob On 12/21/23 15:45, Rob Herring wrote: > On Thu, 21 Dec 2023 13:43:33 +0100, Raphael Gallais-Pou wrote: >> Add dt-binding file for "st,stm32-lvds" compatible. >> >> Signed-off-by: Raphael Gallais-Pou >> --- >> .../bindings/display/st,stm32-lvd

[PATCH RESEND v1 8/8] arm64: dts: st: add display support on stm32mp257f-ev

2023-12-21 Thread Raphael Gallais-Pou
This patch enables the following IPs on stm32mp257f-ev : * LTDC * LVDS * WSVGA LVDS panel (1024x600) * Panel backlight * Ilitek touchescreen Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 79 ++ 1 file changed, 79 insertions

[PATCH RESEND v1 5/8] drm/stm: ltdc: add lvds pixel clock

2023-12-21 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 18 ++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu

[PATCH RESEND v1 6/8] arm64: dts: st: add ltdc support on stm32mp251

2023-12-21 Thread Raphael Gallais-Pou
The LCD-TFT Display Controller (LTDC) handles display composition, scaling and rotation. It provides a parallel digital RGB flow to be used by display interfaces. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp251.dtsi | 12 1 file changed, 12 insertions

[PATCH RESEND v1 7/8] arm64: dts: st: add lvds support on stm32mp253

2023-12-21 Thread Raphael Gallais-Pou
This patch adds LVDS support on stm32mp253. The LVDS is used on STM32MP2 as a display interface. LVDS PLL clock is binded to the LTDC input clock. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp253.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH RESEND v1 4/8] drm/stm: ltdc: implement bus clock

2023-12-21 Thread Raphael Gallais-Pou
From: Yannick Fertre The latest hardware version of the LTDC presents the addition of a bus clock, which contains the global configuration registers and the interrupt register. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 8 drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH RESEND v1 3/8] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2023-12-21 Thread Raphael Gallais-Pou
pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/Kconfig | 11 + drivers/gpu/drm/stm/Makefile |2 + drivers/gpu/drm/stm/lvds.c | 1226 ++ 3 files changed, 1239 insertions(+) create mode 100644 drivers/gpu/drm/stm/lvds.c diff

[PATCH RESEND v1 0/8] Introduce STM32 LVDS driver

2023-12-21 Thread Raphael Gallais-Pou
on the STM32MP257. Raphael Gallais-Pou (7): dt-bindings: panel: lvds: Append edt,etml0700z9ndha in panel-lvds dt-bindings: display: add dt-bindings for STM32 LVDS device drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver drm/stm: ltdc: add lvds pixel clock arm64: dts: st

[PATCH RESEND v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device

2023-12-21 Thread Raphael Gallais-Pou
Add dt-binding file for "st,stm32-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- .../bindings/display/st,stm32-lvds.yaml | 114 ++ 1 file changed, 114 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml

[PATCH RESEND v1 1/8] dt-bindings: panel: lvds: Append edt, etml0700z9ndha in panel-lvds

2023-12-21 Thread Raphael Gallais-Pou
List EDT ETML0700Z9NDHA in the LVDS panel enumeration. Signed-off-by: Raphael Gallais-Pou --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation

[PATCH v1 8/8] arm64: dts: st: add display support on stm32mp257f-ev

2023-12-21 Thread Raphael Gallais-Pou
This patch enables the following IPs on stm32mp257f-ev : * LTDC * LVDS * WSVGA LVDS panel (1024x600) * Panel backlight * Ilitek touchescreen Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 79 ++ 1 file changed, 79 insertions

[PATCH v1 7/8] arm64: dts: st: add lvds support on stm32mp253

2023-12-21 Thread Raphael Gallais-Pou
This patch adds LVDS support on stm32mp253. The LVDS is used on STM32MP2 as a display interface. LVDS PLL clock is binded to the LTDC input clock. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp253.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH v1 6/8] arm64: dts: st: add ltdc support on stm32mp251

2023-12-21 Thread Raphael Gallais-Pou
The LCD-TFT Display Controller (LTDC) handles display composition, scaling and rotation. It provides a parallel digital RGB flow to be used by display interfaces. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp251.dtsi | 12 1 file changed, 12 insertions

[PATCH v1 5/8] drm/stm: ltdc: add lvds pixel clock

2023-12-21 Thread Raphael Gallais-Pou
of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 18 ++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu

[PATCH v1 3/8] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2023-12-21 Thread Raphael Gallais-Pou
pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/Kconfig | 11 + drivers/gpu/drm/stm/Makefile |2 + drivers/gpu/drm/stm/lvds.c | 1226 ++ 3 files changed, 1239 insertions(+) create mode 100644 drivers/gpu/drm/stm/lvds.c diff

[PATCH v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device

2023-12-21 Thread Raphael Gallais-Pou
Add dt-binding file for "st,stm32-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- .../bindings/display/st,stm32-lvds.yaml | 114 ++ 1 file changed, 114 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml

[PATCH v1 4/8] drm/stm: ltdc: implement bus clock

2023-12-21 Thread Raphael Gallais-Pou
From: Yannick Fertre The latest hardware version of the LTDC presents the addition of a bus clock, which contains the global configuration registers and the interrupt register. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 8 drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v1 1/8] dt-bindings: panel: lvds: Append edt, etml0700z9ndha in panel-lvds

2023-12-21 Thread Raphael Gallais-Pou
List EDT ETML0700Z9NDHA in the LVDS panel enumeration. Signed-off-by: Raphael Gallais-Pou --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation

[PATCH v1 0/8] Introduce STM32 LVDS driver

2023-12-21 Thread Raphael Gallais-Pou
on the STM32MP257. Raphael Gallais-Pou (7): dt-bindings: panel: lvds: Append edt,etml0700z9ndha in panel-lvds dt-bindings: display: add dt-bindings for STM32 LVDS device drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver drm/stm: ltdc: add lvds pixel clock arm64: dts: st

[PATCH v2 4/4] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2023-12-04 Thread Raphael Gallais-Pou
In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent clock, which means that it is an APB peripheral clock. Swap the clocks in the DSI peripheral clock reference. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp157.dtsi | 2 +- arch/arm/boot/dts

[PATCH v2 3/4] drm/stm: dsi: expose DSI PHY internal clock

2023-12-04 Thread Raphael Gallais-Pou
si_phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-off-by: Raphael Galla

[PATCH v2 2/4] drm/stm: dsi: add pm runtime ops

2023-12-04 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS and removed

[PATCH v2 0/4] Update STM DSI PHY driver

2023-12-04 Thread Raphael Gallais-Pou
for accordingly - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS Raphael Gallais-Pou (3): drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro drm/stm: dsi: expose DSI PHY internal clock arm: dts: st: fix DSI peripheral clock on stm32mp15 boards Yannick Fertre (1): drm/stm: dsi: add pm

[PATCH v2 1/4] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2023-12-04 Thread Raphael Gallais-Pou
Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[PATCH RESEND 0/3] Update STM DSI PHY driver

2023-11-23 Thread Raphael Gallais-Pou
previously. Since 'dsi' and 'dsi_k' are gated by the same bit on the same register, both reference work as peripheral clock in the device-tree. Raphael Gallais-Pou (2): drm/stm: dsi: expose DSI PHY internal clock arm: dts: st: fix DSI peripheral clock on stm32mp15 boards Yannick Fertre (1): drm

[PATCH RESEND 2/3] drm/stm: dsi: expose DSI PHY internal clock

2023-11-23 Thread Raphael Gallais-Pou
si_phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-off-by: Raphael Galla

  1   2   >