Hi Marek,
On lun 09-01-2023 23:00:33, Marek Szyprowski wrote:
> devm_regulator_get_enable_optional() function returns 0 on success, so
> use it for the check if function succeded instead of the -ENODEV value.
>
> Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()")
> Sign
Hi Sandy,
Going though the KernelCI results I noticed that the v6.0-rc1
kernel introduced a number of regressions in the igt-kms-rockchip
tests:
https://groups.io/g/kernelci-results/message/34239?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cigt-kms-rockchip%2C20%2C1%2C80%2C95118839
I don't know i
bridge chain of an encoder.
This change makes these functions a bit more robust by bailing out if
the bridge has already been detached.
Tested on an Acer Chromebook R13 (Elm, MT8173) with Debian Sid.
Signed-off-by: Ricardo Cañuelo
---
drivers/gpu/drm/drm_bridge.c | 4 ++--
1 file changed, 2
book R13 (Elm, MT8173) with Debian Sid.
Signed-off-by: Ricardo Cañuelo
---
drivers/gpu/drm/bridge/parade-ps8640.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
b/drivers/gpu/drm/bridge/parade-ps8640.c
index 3f17337ee389..a92778
drm.12.auto > /sys/bus/platform/drivers/mediatek-drm/unbind
Cheers,
Ricardo
Ricardo Cañuelo (2):
drm/bridge: parade-ps8640: avoid race condition on driver unbinding
drm/bridge: Add extra checks in pre_enable and post_enable
drivers/gpu/drm/bridge/parade-ps8640.c | 6 +++---
drivers
book R13 (Elm, MT8173) with Debian Sid.
Signed-off-by: Ricardo Cañuelo
---
drivers/gpu/drm/bridge/parade-ps8640.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
b/drivers/gpu/drm/bridge/parade-ps8640.c
index 3f17337ee389..a92778
bridge chain of an encoder.
This change makes these functions a bit more robust by bailing out if
the bridge has already been detached.
Tested on an Acer Chromebook R13 (Elm, MT8173) with Debian Sid.
Signed-off-by: Ricardo Cañuelo
---
drivers/gpu/drm/drm_bridge.c | 4 ++--
1 file changed, 2
drm.12.auto > /sys/bus/platform/drivers/mediatek-drm/unbind
Cheers,
Ricardo
Ricardo Cañuelo (2):
drm/bridge: parade-ps8640: avoid race condition on driver unbinding
drm/bridge: Add extra checks in pre_enable and post_enable
drivers/gpu/drm/bridge/parade-ps8640.c | 6 +++---
drivers
This fixes a bug in the calculation of the setup and hold times based on
the deskew configuration.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI
encoder to json-schema.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
.../bindings/display/bridge/ti,tfp410.txt | 66 -
.../bindings/display/bridge/ti,tfp410.yaml| 130 ++
2
check as described by the binding (u32 from 0 to 7).
This fix results from a change in the ti,tfp410 DT binding.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
This changes how the 'ti,deskew' property is defined. It's now an
unsigned value from 0 to 7 instead of a signed value from -4 to 3.
Until the dtc carries the integer sign through to the yaml output it's
easier to define signed types as unsigned.
Signed-off-by: Ricardo
ested with:
make dt_binding_check ARCH= DT_SCHEMA_FILES=<...ti,tfp410.yaml>
make dtbs_check ARCH= DT_SCHEMA_FILES=<...ti,tfp410.yaml>
for = arm and arm64.
This uncovered a number of dts files that use the TFP410 but not through
I2C and don't define the ti,deskew property. These sho
Hi Laurent,
On Tue, 2020-06-16 at 04:51 +0300, Laurent Pinchart wrote:
> How about keeping the ports mandatory, and leaving dove-sbc-a510.dts to
> be fixed later ?
That's fine by me, I'll prepare a new version of the series.
Thanks for your input!
Cheers,
Ricardo
___
Hi Laurent,
Thanks for reviewing the patch
On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > Make the ports node optional, since there are some
Make the ports node optional, since there are some DTs that don't define
any ports for ti,tfp410.
Signed-off-by: Ricardo Cañuelo
---
Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/di
This changes how the 'ti,deskew' property is defined. It's now an
unsigned value from 0 to 7 instead of a signed value from -4 to 3.
Until the dtc carries the integer sign through to the yaml output it's
easier to define signed types as unsigned.
Signed-off-by: Ricardo
This fixes a bug in the calculation of the setup and hold times based on
the deskew configuration.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI
encoder to json-schema.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
.../bindings/display/bridge/ti,tfp410.txt | 66 -
.../bindings/display/bridge/ti,tfp410.yaml| 130 ++
2
eck ARCH= DT_SCHEMA_FILES=<...ti,tfp410.yaml>
make dtbs_check ARCH= DT_SCHEMA_FILES=<...ti,tfp410.yaml>
for = arm and arm64.
This uncovered a number of dts files that use the TFP410 but not through
I2C and don't define the ti,deskew property. These should be fixed at
some point.
R
check as described by the binding (u32 from 0 to 7).
This fix results from a change in the ti,tfp410 DT binding.
Signed-off-by: Ricardo Cañuelo
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
check as described by the binding (u32 from 0 to 7)
and fixes the calculation of the setup and hold times.
Signed-off-by: Ricardo Cañuelo
---
drivers/gpu/drm/bridge/ti-tfp410.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b
Group the port definitions of the dvi-converter in a 'ports' node to
make it compliant with the ti,tfp410 binding.
Signed-off-by: Ricardo Cañuelo
---
arch/arm/boot/dts/imx53-cx9020.dts | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/arc
Define a 'ports' node for 'dvi: video@39' and use the proper naming for
the powerdown-gpios property to make it compliant with the ti,tfp410
binding.
This fills the minimum requirements to meet the binding requirements,
port endpoints are not defined.
Signed-off-by: Ricard
ts: s/powerdown-gpio/powerdown-gpios (Sam)
- dove-sbc-a510.dts: Add dummy ports node
- imx53-cx9020.dts: Group the ports in a ports node
ti-tfp410.c (added):
- Fix setup time and hold time calculation based on the deskew value
(Laurent Pinchart)
Ricardo Cañuelo (4):
ARM: dts: dove:
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI
encoder to json-schema.
The 'ti,deskew' is now an unsigned value from 0 to 7 instead of a signed
value from -4 to 3. The rest of the binding is a direct translation from
the old one.
Signed-off-by: Ricar
This converts the Analogix ANX7814 bridge DT binding to yaml. Port
definitions and descriptions were expanded, apart from that it's a
direct translation from the original binding.
Signed-off-by: Ricardo Cañuelo
Acked-by: Sam Ravnborg
Reviewed-by: Enric Balletbo i Serra
---
Changes
Hi Laurent,
On mié 13-05-2020 17:08:32, Laurent Pinchart wrote:
> The driver doesn't apply any setting to the device :-) The ti,deskew
> property is meant to report the deskew settings selected by the chip's
> configuration pins, not to set a value to be programmed to the device.
Oh, I see, thank
Hi Laurent,
On mié 06-05-2020 18:53:20, Laurent Pinchart wrote:
> I didn't if I remember correctly, I just mapped it to the hardware
> features. The hardware register indeed takes a value between 0 and 7,
> and that is mapped to [-4,3] x t(STEP). I don't mind either option.
I was taking a look at
Hi Rob,
Thanks for reviewing the patch and I'm sorry it had so many mistakes,
this was my first attempt at converting a DT binding to schema.
On lun 11-05-2020 16:31:08, Rob Herring wrote:
> > This binding is meant to be used in conjunction with
> > Documentation/bindings/display/rockchip/analog
r negative numbers.
On mié 06-05-2020 18:53:20, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Tue, Apr 28, 2020 at 12:49:28PM +0300, Tomi Valkeinen wrote:
> > On 28/04/2020 12:20, Ricardo Cañuelo wrote:
> >
> > > 2) The definition of ti,deskew in the original binding s
Hi Tomi,
On mié 06-05-2020 11:01:07, Tomi Valkeinen wrote:
> Doesn't all this just point to a bug or missing feature in dt_binding_check?
> That's not a reason to change the ABI.
I agree and I'd vote for "missing feature", but seeing that there aren't
any other examples of this use case in the w
Hi Tomi, thanks for reviewing the patch.
On mar 28-04-2020 12:49:28, Tomi Valkeinen wrote:
> I don't quite understand this. We cannot have negative numbers in dts files?
> Or we can, but dt_binding_check doesn't handle them correctly? Or that int32
> is not supported in yaml bindings?
AFAICT, yo
On mar 28-04-2020 21:21:17, Sam Ravnborg wrote:
> Hi Ricardo.
>
> Thanks for looking into this bridge binding.
> Some comments in the following.
Thanks for reviewing it, Sam. I agree with your suggestions, some
comments below:
> Can you define it as an enum like this:
>
> enum: [-4, -3, -
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI
encoder to json-schema.
Signed-off-by: Ricardo Cañuelo
---
Hi all,
I found some issues while converting this binding and I'd like to know
your opinions on how to tackle them.
1) dtbs_check fails for arch/arm/boot/dts/dov
This converts the Analogix ANX7814 bridge DT binding to yaml. Port
definitions and descriptions were expanded, apart from that it's a
direct translation from the original binding.
Signed-off-by: Ricardo Cañuelo
Acked-by: Sam Ravnborg
---
Changes in v3 (suggested by Sam Ravnborg):
- R
On lun 27-04-2020 11:09:00, Sam Ravnborg wrote:
> Hi Ricardo.
>
> On Mon, Apr 27, 2020 at 10:46:58AM +0200, Ricardo Cañuelo wrote:
> > This converts the Analogix ANX7814 bridge DT binding to yaml. Port
> > definitions and descriptions were expanded, apart from that it'
This converts the Analogix ANX7814 bridge DT binding to yaml. Port
definitions and descriptions were expanded, apart from that it's a
direct translation from the original binding.
Signed-off-by: Ricardo Cañuelo
---
Changes in v2 (suggested by Enric Balletbo):
- File name change: use
On vie 24-04-2020 16:08:10, Enric Balletbo i Serra wrote:
> Hi Ricardo,
>
> Thank you for your patch.
Hi Enric,
Thanks for reviewing it.
> > + "#size-cells":
> > +const: 0
> > +
>
> I don't' think you need to specify this. You can drop it (better double check
> with Rob, though)
This converts the DT binding for the Analogix DP bridge used in
the Exynos 5 and Rockchip RK3288/RK3399 SoCs to yaml.
Changes from the original binding:
- phy and phy-names aren't defined as 'required' (rk3399-evb.dts doesn't
define them)
Signed-off-by: Ricardo Cañuelo
This converts the Analogix ANX7814 bridge DT binding to yaml. Port
definitions and descriptions were expanded, apart from that it's a
direct translation from the original binding.
Signed-off-by: Ricardo Cañuelo
---
Tested with:
make dt_binding_check ARCH=arm64 DT_SCHEMA_FILES=<.../anx7
41 matches
Mail list logo
