Hi Dave and Sima,
It is worth to mention that although there's a fix on xe_exec ioctl,
that should not cause any uapi change. It would only fix a potential
crash in the case that xe_ioctl failed with a bad sync array as input.
Thanks,
Rodrigo.
drm-xe-next-fixes-2024-07-18:
- Xe_exec ioctl minor
On Thu, Jul 11, 2024 at 02:29:04PM -0700, Jordan Justen wrote:
> On 2024-07-11 08:18:18, Rodrigo Vivi wrote:
> > Hi Dave and Sima,
> >
> > This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/
> >
> > v2 - Removed Thomas' write-ba
On Thu, Jul 11, 2024 at 04:28:53PM +, Cavitt, Jonathan wrote:
> -Original Message-
> From: Intel-gfx On Behalf Of Nitin
> Gote
> Sent: Thursday, July 11, 2024 9:32 AM
> To: Wilson, Chris P ; tursu...@ursulin.net;
> intel-...@lists.freedesktop.org
> Cc:
Hi Dave and Sima,
This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/
v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete
that through drm-xe-fixes towards 6.10. So we remove the amount of patch
duplication.
Again, it is important to highlight
On Wed, Jul 10, 2024 at 02:42:38PM -0500, Lucas De Marchi wrote:
> On Tue, Jul 09, 2024 at 05:31:39PM GMT, Rodrigo Vivi wrote:
> > Hi Dave and Sima,
> >
> > Here goes a very early drm-xe-next-fixes with 2 important fixes
> > that are going to impact user space
Hi Dave and Sima,
Here goes a very early drm-xe-next-fixes with 2 important fixes
that are going to impact user space.
1. The first one is the rename of the OA stuff from the bad 'perf'
name to the xe_observation. Although the rename in the uapi
header is likely inoffensive because our UMDs
On Fri, Jun 28, 2024 at 05:46:01PM +0300, Jani Nikula wrote:
>
> Hi Dave & Sima -
>
> Another feature pull towards v6.11, hopefully last. This should also fix
> the 32-bit build issue [1] seen in drm-next.
Sima, Dave,
I just noticed that we don't have this one yet in drm-next.
Anything
Hi Dave and Sima,
Here goes our actual last PR towards 6.11.
One extra to make the drm-xe-next-fixes smoother.
Mostly with fixes that would be anyway part of the
drm-xe-next-fixes, plus some more SRIOV preparation
and a BMG w/a.
Thanks,
Rodrigo.
drm-xe-next-2024-07-02:
Driver Changes:
- Fix in
a bo,
> internally use write-back caching mode for system memory on DGFX.
>
> Coherency is maintained, but user-space clients may perceive a
> difference in cpu access speeds.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Thomas Hellström
> Fixes: 622f709ca629 ("drm/xe/ua
m/xe/trace: Print device_id in xe_trace_bo events
drm/xe/trace: Print device_id in xe_trace_guc events
drm/xe/trace: Print device_id in xe_trace events
drm/xe: Add reg read/write trace
Rodrigo Vivi (2):
Merge drm/drm-next into drm-xe-next
Merge drm/drm-next into drm-xe-next
> To: David Airlie
> To: Daniel Vetter
> To: Maarten Lankhorst
> To: Maxime Ripard
> To: Thomas Zimmermann
> To: Jani Nikula
> To: Joonas Lahtinen
> To: Rodrigo Vivi
> To: Tvrtko Ursulin
> To: Rob Clark
> To: Abhinav Kumar
> To: Sean Paul
> To: Marijn Suijten
On Wed, Jun 26, 2024 at 05:36:43PM +0200, Nirmoy Das wrote:
>Hi Rodrigo,
>
>
>
>On 6/26/2024 5:24 PM, Rod
On Wed, Jun 26, 2024 at 04:33:18PM +0200, Nirmoy Das wrote:
> We report object allocation failures to userspace with ENOMEM
> so add __GFP_NOWARN to remove superfluous oom warnings.
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4936
> Cc: Andi Shyti
> Signed-off-by: Nirmoy
it got
recreated?
is there any link to any open issue or history?
Reviewed-by: Rodrigo Vivi
> } else {
> err = xe_ggtt_insert_bo(tile->mem.ggtt, bo);
> }
>
> base-commit: cffd77865f476994680892601e09bc2164179907
> --
> 2.34.1
>
lane_initial.c | 4 +-
> >
> > Lucas, can you give me an ack for the merging the xe
> > changes via drm-intel?
>
> Apparently Lucas is out. Rodrigo, can you ack this?
I wonder if we should start using some tag like
drm/{i915,xe}/display: or drm/{i915,xe}:
in cases like this,
On Fri, Jun 14, 2024 at 03:53:04PM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote:
> > Describe newly added parameter target_rr_divider in struct
> > drm_dp_as_sdp.
> >
> > -v2:
> > Remove extra line from comm
On Wed, Jun 12, 2024 at 02:12:39PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (i386
> defconfig) failed like this:
>
> x86_64-linux-gnu-ld: drivers/gpu/drm/i915/display/intel_vrr.o: in function
> `intel_vrr_compute_config':
>
On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote:
> Describe newly added parameter target_rr_divider in struct
> drm_dp_as_sdp.
>
> -v2:
> Remove extra line from commit message.(Lucas)
>
> Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing
> AS SDP")
> Cc:
On Fri, Jun 14, 2024 at 03:23:54PM +, Cavitt, Jonathan wrote:
> -Original Message-
> From: Andi Shyti
> Sent: Friday, June 14, 2024 8:22 AM
> To: Andi Shyti
> Cc: intel-gfx ; dri-devel
> ; Harrison, John C
> ; Cavitt, Jonathan
> Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in
On Fri, Jun 14, 2024 at 12:35:32PM -0300, André Almeida wrote:
> This driver can perfom async flips on primary planes, so enable it.
>
Cc: Ville Syrjälä
Cc: Naveen Kumar
c: Vandita Kulkarni
> Signed-off-by: André Almeida
> ---
> drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++
> 1 file
ead all over :(
Well, perhaps we should start from here to set the precedence and move
things to its own component... but well, I won't block or make it hard,
we do need this change and the overall uncore cleanup could be orthogonal.
Reviewed-by: Rodrigo Vivi
> +
> return 0;
> }
> DEFINE_INTEL_GT_DEBUGFS_ATTRIBUTE(fw_domains);
> --
> 2.45.1
>
Enable Coarse Power Gating
drm/xe/xe_gt_idle: use GT forcewake domain assertion
drm/xe: move disable_c6 call
Rodrigo Vivi (13):
drm/xe: make xe_pm_runtime_lockdep_map a static struct
drm/xe: Introduce a simple wedged state
drm/xe: declare wedged upon GuC load failure
*res);
> drmm_add_action_or_reset(dev, __drmm_mutex_release, lock); \
> })\
>
> +int drmm_mm_init(struct drm_device *dev, struct drm_mm *mm, u64 start, u64
> size);
Reviewed-by: Rodrigo Vivi
> +
> #endif
> --
> 2.43.0
>
On Fri, May 24, 2024 at 03:35:18PM +0200, Michal Wajdeczko wrote:
> There is not need for private release action as there are existing
> drmm_mm_init() and drmm_mutex_init() helpers that can be used.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Thomas Hellström
> Cc: Rodrigo Vivi
;adf_cfg_strings.h"
> @@ -35,8 +35,7 @@ int adf_get_service_enabled(struct adf_accel_dev *accel_dev)
> return ret;
> }
>
> - ret = match_string(adf_cfg_services, ARRAY_SIZE(adf_cfg_services),
> -services);
> + ret = match_stri
Last caller was removed with commit 078a5b498d6a ("drm/tests:
Remove slow tests").
Cc: Maxime Ripard
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_mm.c | 35 ---
include/drm/drm_mm.h | 1 -
2 files changed, 36 deletions(-)
diff --git a/d
On Fri, May 31, 2024 at 04:10:51PM +0200, Thomas Hellström wrote:
> Add Rodrigo Vivi as an Xe driver maintainer.
>
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rodrigo Vivi
Cc: Lucas De Marchi
Acked-by: Rodrigo Vivi
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-k
On Mon, May 27, 2024 at 04:00:25PM +0100, Andi Shyti wrote:
> On Mon, May 27, 2024 at 11:47:49AM +0100, Andi Shyti wrote:
> > On Fri, May 24, 2024 at 10:07:44AM -0400, Rodrigo Vivi wrote:
> > > On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote:
> > > > Follo
On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote:
> Following the guidelines it takes 3 seconds to perform an FLR
> reset. Let's give it a bit more slack because this time can
> change depending on the platform and on the firmware
But did we see any issue with that?
if that changes per
igned-off-by: Dr. David Alan Gilbert
Reviewed-by: Rodrigo Vivi
and applying it right now...
thanks for the patch
> ---
> drivers/gpu/drm/xe/xe_pci.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> i
On Mon, May 13, 2024 at 02:14:51AM -0400, Deming Wang wrote:
> The mapings should be replaced by mappings.
>
> Signed-off-by: Deming Wang
Reviewed-by: Rodrigo Vivi
and pushed to drm-intel-gt-next
thanks for the patch
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c |
On Fri, May 10, 2024 at 07:12:14PM +0100, Matthew Auld wrote:
> Hopefully make it clearer when to use devm vs drmm.
>
> Signed-off-by: Matthew Auld
> Cc: Daniel Vetter
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/drm_managed.c | 42 +++
> 1 file
Hi Dave and Sima,
Here goes our last fixes for v6.9.
drm-intel-fixes-2024-05-08:
- Automate CCS Mode setting during engine resets (Andi)
- Fix audio time stamp programming for DP (Chaitanya)
- Fix parsing backlight BDB data (Karthikeyan)
The following changes since commit
0 ]---
> > >
> > > We defer actually closing, unbinding and destroying a VMA until next idle
> > > point, or until the object is freed in the meantime. By postponing the
> > > unbind, we allow for the VMA to be reopened by the client, avoiding the
> > > work require
hat the releasing after the unprepare sounds more logical,
but if there's no actual issue with that and it is working for
everybody, let's do that.
Reviewed-by: Rodrigo Vivi
Acked-by: Rodrigo Vivi
(to get through drm-misc with everything else if you prefer)
> - kfree(fb_helper);
> -
On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote:
> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote:
> > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote:
> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced
> >> "master/s
rs of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
>
> Compile tested, no functionality changes intended
>
> [1]:
> https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/
>
> Revie
ned-off-by: Easwar Hariharan
I'm glad to see this change!
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 -
> drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +--
> drivers/gpu/drm/i915/display/dvo_ivch.c | 16 +-
Hi Dave and Sima,
Here goes one extra, and really the last one targeting 6.10.
We have decided to do this extra one so we could include the
good clean-up on i915/xe's fbdev work done by Thomas Zimmermann.
And it looks like he has more work on top of that, so it would
be good to propagate this
t; Update its location with a URL matching other fd.o GitLab kernel trees.
> > >
> > > Signed-off-by: Ryszard Knop
> >
> > Acked-by: Lucas De Marchi
> >
> > Also Cc'ing maintainers
>
> Thanks,
>
> Acked-by: Tvrtko Ursulin
Acked-by: Rodr
db31251bb26 ("drm/i915/gt: Enable only one CCS for compute workload")
> Reported-by: Gnattu OC
> Signed-off-by: Andi Shyti
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Matt Roper
> Cc: # v6.2+
Reviewed-by: Rodrigo Vivi
> ---
> Hi Gnattu,
>
> thanks ag
Hi Sima and Dave,
Here goes our last pull request towards 6.10.
drm-intel-next-2024-04-24:
Core Changes:
- Some DP/DP_MST DRM helpers (Imre)
Driver Changes (i915 Display):
- PLL refactoring (Ville)
- Limit eDP MSO pipe only for display version 20 (Luca)
- More display refactor towards
On Wed, Apr 24, 2024 at 01:49:16PM +0200, Maxime Ripard wrote:
> On Tue, Apr 23, 2024 at 01:42:22PM -0400, Rodrigo Vivi wrote:
> > On Tue, Apr 23, 2024 at 02:25:06PM +0530, Aravind Iddamsetty wrote:
> > >
> > > On 23/04/24 02:24, Rodrigo Vivi wrote:
> > >
On Tue, Apr 23, 2024 at 02:25:06PM +0530, Aravind Iddamsetty wrote:
>
> On 23/04/24 02:24, Rodrigo Vivi wrote:
> > On Mon, Apr 22, 2024 at 12:27:53PM +0530, Aravind Iddamsetty wrote:
> >> In scenarios where drm_dev_put is directly called by driver we want to
> >> rel
of introducing a
> helper (Rodrigo)
>
> v3: add kernel-doc (Maxime Ripard)
>
> Cc: Maxime Ripard
> Cc: Thomas Hellstr_m
> Cc: Rodrigo Vivi
>
please avoid these empty lines here cc, rv-b, sign-offs, links,
etc are all in the same block.
> Reviewed-by: Rodrigo
of introducing a
> helper (Rodrigo)
>
> Cc: Thomas Hellstr_m
> Cc: Rodrigo Vivi
>
> Reviewed-by: Rodrigo Vivi
Sima, Dave, or drm-misc, ack to get this through drm-xe-next?
> Signed-off-by: Aravind Iddamsetty
> ---
> drivers/gpu/drm/drm_drv.c | 6 ++
> include/d
om
drm/i915: Reuse RPLU cdclk fns for MTL+
Ravi Kumar Vodapalli (1):
drm/i915: Add new PCI IDs to DG2 platform in driver
Rodrigo Vivi (1):
Merge drm/drm-next into drm-intel-next
Shekhar Chauhan (1):
drm/i915/dp: Increase idle pattern wait timeout to 2ms
Stanislav Lis
On Thu, Apr 11, 2024 at 12:55:29PM -0400, Golani, Mitulkumar Ajitkumar wrote:
>
>
> > -Original Message-
> > From: Vivi, Rodrigo
> > Sent: Wednesday, April 10, 2024 9:49 PM
> > To: Golani, Mitulkumar Ajitkumar ;
> > tzimmerm...@suse.de; mrip...@kernel.org;
> >
On Tue, Apr 16, 2024 at 12:02:10PM -0700, Dixit, Ashutosh wrote:
> On Tue, 16 Apr 2024 11:55:20 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > > @@ -849,5 +849,26 @@ void i915_hwmon_register(struct drm_i915_private
> > > *i915)
> >
;hwmon_dev = hwmon_dev;
> }
> @@ -849,5 +849,26 @@ void i915_hwmon_register(struct drm_i915_private *i915)
>
> void i915_hwmon_unregister(struct drm_i915_private *i915)
> {
> - fetch_and_zero(>hwmon);
> + struct i915_hwmon *hwmon = fetch_and_zero(>hwmon);
>
On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote:
> Hi Rodrigo,
>
> On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote:
> > On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote:
> > > We defer actually closing, unbinding and destroyi
On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote:
> We defer actually closing, unbinding and destroying a VMA until next idle
> point, or until the object is freed in the meantime. By postponing the
> unbind, we allow for the VMA to be reopened by the client, avoiding the
> work
ies.
>
> Cc: Joonas Lahtinen
> Cc: Lucas De Marchi
> Cc: Oded Gabbay
> Cc: Rodrigo Vivi
> Cc: Thomas Hellström
> Cc: Tvrtko Ursulin
> Signed-off-by: Jani Nikula
> ---
> MAINTAINERS | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --g
Hi Dave and Sima,
Here goes drm-intel-fixes-2024-04-10:
Display fixes:
- Couple CDCLK programming fixes (Ville)
- HDCP related fix (Suraj)
- 4 Bigjoiner related fixes (Ville)
Core fix:
- Fix for a circular locking around GuC on reset+wedged case (John)
Thanks,
Rodrigo.
The following changes
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote:
> Correct struct member name to 'mode' instead of 'operation mode'
> in 'drm_dp_as_sdp' structure description.
>
> Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging")
Probably good to avoid this 'Fixes:' tag, and only use
> without the need to do unbind and rebind as the driver needs to
> reinitialize the device afresh post FLR.
>
> v2:
all the patches looks good to me here. feel free to use
Reviewed-by: Rodrigo Vivi
on them.
but I do have some concerns (below)
> 1. Directly expose the dev
Hi Dave and Sima,
Here goes drm-intel-fixes-2024-04-04:
Display fixes:
- A few DisplayPort related fixes (Imre, Arun, Ankit, Ville)
- eDP PSR fixes (Jouni)
Core/GT fixes:
- Remove some VM space restrictions on older platforms (Andi)
- Disable automatic load CCS load balancing (Andi)
Thanks,
AWS takes ages but this
> is not an issue with reporting, this is how AWS works.
I'm sorry for the noise. It was probably just a matter of time.
Everything looking good there.
Thanks,
Rodrigo.
>
> Regards,
> Ewelina
>
> -Original Message-
> From: Intel-gfx On Behalf Of
> Rodrigo V
Hi Dave and Sima,
Here goes our first PR of this round.
Our CI is not working as I would expect:
https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html?
Well, at least it caught some build failures on runds 832 and 833.
But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with
all
On Wed, Mar 20, 2024 at 04:14:25PM +0530, Aravind Iddamsetty wrote:
> In scenarios where drm_dev_put is directly called by driver we want to
> release devm_drm_dev_init_release action associated with struct
> drm_device.
>
> Cc: Thomas Hellstr_m
>
> Signed-off-by: Aravind Iddamsetty
> ---
>
> without the need to do unbind and rebind as the driver needs to
> reinitialize the device afresh post FLR.
>
> Cc: Rodrigo Vivi
> Cc: Lucas De Marchi
> Signed-off-by: Aravind Iddamsetty
> ---
> drivers/gpu/drm/xe/Makefile | 1 +
> drivers/gpu/drm/xe/xe_
s the busy wakeup. */
> - GEM_BUG_ON(engine->sched_engine->queue_priority_hint != INT_MIN);
> -
> if (engine->park)
> engine->park(engine);
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 42aade0faf2d1..b061a0a0d6b08 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -3272,6 +3272,9 @@ static void execlists_park(struct intel_engine_cs
> *engine)
> {
> cancel_timer(>execlists.timer);
> cancel_timer(>execlists.preempt);
> +
> + /* Reset upon idling, or we may delay the busy wakeup. */
> + WRITE_ONCE(engine->sched_engine->queue_priority_hint, INT_MIN);
maybe better to leave only the scheduler code touching their variables.
but no big blocker and this code seems safe and the mentioned bug,
so,
Reviewed-by: Rodrigo Vivi
> }
>
> static void add_to_engine(struct i915_request *rq)
> --
> 2.43.0
>
On Mon, Mar 11, 2024 at 07:14:09PM +0100, Janusz Krzysztofik wrote:
> On Monday, 11 March 2024 18:35:43 CET Guenter Roeck wrote:
> > On 3/11/24 09:58, Rodrigo Vivi wrote:
> > > On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote:
> > >> In i915 hwmon
On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote:
> In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
> rpm wakeref. That results in lock inversion:
>
> <4> [197.079335] ==
> <4> [197.085473] WARNING:
On Mon, Mar 11, 2024 at 10:35:20AM -0500, Lucas De Marchi wrote:
> On Mon, Mar 11, 2024 at 11:29:31AM -0400, Rodrigo Vivi wrote:
> > > @@ -2907,9 +2829,7 @@ engine_init_workarounds(struct intel_engine_cs
> > > *engine, struct i915_wa_list *wal
>
On Mon, Mar 11, 2024 at 10:29:45AM -0500, Lucas De Marchi wrote:
> On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote:
> > On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote:
> > > With no platform declaring graphics/media IP_VER(12, 50),
> >
>
On Wed, Mar 06, 2024 at 11:36:42AM -0800, Lucas De Marchi wrote:
> PCI IDs for PVC were never added and platform always marked with
> force_probe. Drop what's not used and rename some places as needed.
>
> The registers not used anymore are also removed.
>
> Signed-off-by: Lucas De Marchi
> ---
On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote:
> With no platform declaring graphics/media IP_VER(12, 50),
this is not true.
We still have
#define XE_HPM_FEATURES \
.__runtime.media.ip.ver = 12, \
.__runtime.media.ip.rel = 50
replace the
> checks throughout
a separate patch
to remove that for DG2 (and standalone CI run on that patch by itself):
Reviewed-by: Rodrigo Vivi
>
> Documentation/gpu/rfc/i915_vm_bind.h | 11 +--
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 40
> drivers/gpu/drm/i915/gt/intel_gsc.c
On Fri, Mar 01, 2024 at 02:42:54PM +0100, Thomas Zimmermann wrote:
> Export drm_client_dev_unregister() for use by the i915 driver. The
> driver does not use drm_dev_unregister(),
Perhaps we should make i915 to call for the drm_dev_unregister since it calls
for drm_dev_register?
> so it has to
On Wed, Mar 06, 2024 at 04:11:54PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 05.03.24 um 17:25 schrieb Jani Nikula:
> > On Tue, 05 Mar 2024, Rodrigo Vivi wrote:
> > > On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote:
> > > > Unregister al
ling per engine if needed (Tvrtko).
>
> v3: Minor review comments (Tvrtko)
>
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
> Cc: Sushma Venkatesh Reddy
> Acked-by: Rodrigo Vivi
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Vinay Belgaumkar
> ---
> drivers/gpu/drm/i915/ge
On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote:
> Unregister all in-kernel clients before unloading the i915 driver. For
> other drivers, drm_dev_unregister() does this automatically. As i915
> does not use this helper, it has to perform the call by itself. For xe,
> do the same
> > >
> > > The Mesa usage model for this flag is here -
> > > https://gitlab.freedesktop.org/sushmave/mesa/-/commits/compute_hint
> > >
> > > v2: Rename flags as per review suggestions (Rodrigo, Tvrtko).
> > > Also, use flag bits in int
ld emails to point to the
> main one.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Daniel Vetter
> Cc: Dave Airlie
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
Acked-by: Rodrigo Vivi
> ---
> .mailmap| 5 +
> MAINTAINERS | 2 +-
> 2 files c
On Fri, Feb 23, 2024 at 09:47:11AM -0800, Abhinav Kumar wrote:
> CC Dmitry
>
> Hi Rodrigo
>
> On 2/23/2024 9:00 AM, Rodrigo Vivi wrote:
> > On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote:
> > > With the x86_64_defconfig I see the followi
On Fri, Feb 23, 2024 at 10:31:41AM -0800, Belgaumkar, Vinay wrote:
>
> On 2/23/2024 12:51 AM, Tvrtko Ursulin wrote:
> >
> > On 22/02/2024 23:31, Belgaumkar, Vinay wrote:
> > >
> > > On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote:
> > > >
umar
Cc: Maxime Ripard
Cc: Maarten Lankhorst
Cc: Thomas Zimmermann
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
ind
On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote:
> With the x86_64_defconfig I see the following when building drm-misc-next:
>
> CC drivers/gpu/drm/i915/display/intel_crt.o
> CC drivers/gpu/drm/i915/display/intel_cx0_phy.o
> CC
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27594
>
> v2:
> * Fix whitespace alignment as per checkpatch.
> * Added warning on userspace misuse.
> * Rebase for extracting ce->default_state shadowing.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Lionel La
n
> Cc: Carlos Santa
> Cc: Rodrigo Vivi
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/gt/intel_context_types.h | 2 ++
> drivers/gpu/drm/i915/gt/intel_lrc.c | 7 ---
> drivers/gpu/drm/i915/gt/intel_ring_submission.c | 7 ---
> 3 fi
v Kumar
it looks indeed an unecessary check.
you can convert my ack to a
Reviewed-by: Rodrigo Vivi
and the ack to take this through drm-misc if needed
> ---
> drivers/gpu/drm/display/drm_dp_helper.c | 8 ++--
> drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
> include/drm/d
-by: Abhinav Kumar
> ---
> drivers/gpu/drm/display/drm_dp_helper.c | 8 ++--
> drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
Acked-by: Rodrigo Vivi
> include/drm/display/drm_dp_helper.h | 3 +--
> 3 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drive
lanning on changing the
> given effected events.
since it is not breaking builds on our side and the conflicts, if any, would
be minimal, feel free to take this trough your tree
Acked-by: Rodrigo Vivi
>
> -- Steve
r solution was to use .drirc and make
per-application
decision.
I would prefer a high level extension for a more granular and informative
decision. We need to work with that goal, but for now I don't see any
cons on this approach.
>
> > Cc: Rodrigo Vivi
> > Signed-off-by: Vina
ve to say that this approach is nice, clean and well protected.
And much simpler then I imagined when I saw the idea around.
Feel free to use:
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Lionel Landwerlin
> Cc: Carlos Santa
> ---
> drive
On Tue, Feb 20, 2024 at 11:52:04AM -0800, John Harrison wrote:
> On 2/19/2024 12:28, Rodrigo Vivi wrote:
> > On Fri, Feb 16, 2024 at 10:38:41AM -0800, john.c.harri...@intel.com wrote:
> > > From: John Harrison
> > >
> > > The above w/a is required for
On Tue, Feb 20, 2024 at 08:06:01PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 20, 2024 at 12:57:06PM -0500, Rodrigo Vivi wrote:
> > On Tue, Feb 20, 2024 at 07:52:21PM +0200, Ville Syrjälä wrote:
> > > On Tue, Feb 20, 2024 at 02:12:51PM +0100, Maxime Ripard wrote:
> > >
On Tue, Feb 20, 2024 at 07:52:21PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 20, 2024 at 02:12:51PM +0100, Maxime Ripard wrote:
> > Commit 1fd4a5a36f9f ("drm/connector: Rename legacy TV property") failed
> > to update all the users of the struct drm_tv_connector_state mode field,
> > which
ommit.
>
> Fixes: 1fd4a5a36f9f ("drm/connector: Rename legacy TV property")
> Reported-by: Ville Syrjälä
> Signed-off-by: Maxime Ripard
Reviewed-by: Rodrigo Vivi
and pushing to drm-intel-next soon...
> ---
> drivers/gpu/drm/i915/display/intel_sdvo.c | 10
ps at least adding a comment in the code?
with that
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/inte
that we need this protection. But...
I mean, feel free to use
Reviewed-by: Rodrigo Vivi
for this patch,
but I believe that if this mmu insert failed we might have other
deeper problems like when checking i915_gem_object_is_userptr() ?
No?!
> mmu_interval_notifier_remove(>userptr.notifier);
> obj->userptr.notifier.mm = NULL;
> }
> --
> 2.42.0
>
drm_debug_printer() to device
> specific drm_dbg_printer()")
> Reported-by: Dan Carpenter
> Cc: Jani Nikula
> Cc: Luca Coelho
> Cc: Maxime Ripard
> Cc: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 ++--
&g
On Wed, Feb 07, 2024 at 05:17:19PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/gpu/rfc/index.rst:35: WARNING: toctree contains reference to
> nonexisting document 'gpu/rfc/xe'
>
>
On Mon, Feb 05, 2024 at 09:44:56AM +0100, Christian König wrote:
> Am 02.02.24 um 22:58 schrieb Rodrigo Vivi:
> > On Tue, Jan 30, 2024 at 08:05:29AM +0100, Christian König wrote:
> > > Am 30.01.24 um 04:04 schrieb Matthew Brost:
> > > > Rather then loop over entit
On Tue, Jan 30, 2024 at 08:05:29AM +0100, Christian König wrote:
> Am 30.01.24 um 04:04 schrieb Matthew Brost:
> > Rather then loop over entities until one with a ready job is found,
> > re-queue the run job worker when drm_sched_entity_pop_job() returns NULL.
> >
> > Fixes: 6dbd9004a55
On Tue, Jan 23, 2024 at 11:51:15AM +0100, Janusz Krzysztofik wrote:
> Hi Rodrigo,
>
> Thank you for review.
>
> On Monday, 22 January 2024 22:09:38 CET Rodrigo Vivi wrote:
> > On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote:
> > > Object deb
On Mon, Jan 22, 2024 at 03:04:43PM +0100, Janusz Krzysztofik wrote:
> This reverts changes introduced by commit f56fe3e91787, obsoleted by
> "drm/i915/vma: Fix UAF on destroy against retire race".
I believe the good chunk of the first commit message should be moved
here instead.
But why did you
On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote:
> Object debugging tools were sporadically reporting illegal attempts to
> free a still active i915 VMA object when parking a GPU tile believed to be
> idle.
>
> [161.359441] ODEBUG: free active (active state 0) object:
On Fri, Jan 19, 2024 at 04:29:50PM +, Matthew Auld wrote:
> On 19/01/2024 16:25, Rodrigo Vivi wrote:
> > On Tue, Jan 16, 2024 at 05:03:31PM -0500, Rodrigo Vivi wrote:
> > > The file has already been deleted as the tasks were completed.
> > > However the index
1 - 100 of 1102 matches
Mail list logo
