On Wed, Apr 26, 2023 at 02:40:18PM -0700, Lucas De Marchi wrote:
> On Wed, Apr 26, 2023 at 04:57:00PM -0400, Rodrigo Vivi wrote:
> > On xe_hw_engine_print_state we were printing:
> > value_of(0x510) + 4 instead of
> > value_of(0x514) as desired.
> >
&g
The goal is to allow for a snapshot capture to be taken at the time
of the crash, while the print out can happen at a later time through
the exposed devcoredump virtual device.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
drivers/gpu/drm/xe/xe_vm.c | 137
the simple_error_capture which is still useful for some cases.
But simple_error_capture should be protected under DEBUG and
EXPERT flags, while the devcoredump has its own production config
and will be useful for bug reporting and for error replay.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_devcoredump.c
Let's continue to add our existent simple logs to devcoredump one
by one. Any format change should come on follow-up work.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_devcoredump.c | 45 +++
drivers/gpu/drm/xe/xe_devcoredump_types.h | 4 ++
2 files changed
for the devcoredump.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_vm.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index bdf82d34eb66..4cffdb84680a 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
The goal is to allow for a snapshot capture to be taken at the time
of the crash, while the print out can happen at a later time through
the exposed devcoredump virtual device.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_guc_submit.c | 212 +++
drivers/gpu
Let's start to move our existent logs to devcoredump one by
one. Any format change should come on follow-up work.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_devcoredump.c | 7 ++-
drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 ++
2 files changed, 8 insertions(+), 1 deletion
The goal is to allow for a snapshot capture to be taken at the time
of the crash, while the print out can happen at a later time through
the exposed devcoredump virtual device.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_gt_debugfs.c | 2 +-
drivers/gpu/drm/xe/xe_guc_submit.c
These structs and definitions are only used for the guc_submit
and they were added specifically for the parallel submission.
While doing that also delete the unused struct guc_wq_item.
Cc: Matthew Brost
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_guc_fwif.h | 29
Let's start to move our existent logs to devcoredump one by
one. Any format change should come on follow-up work.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_devcoredump.c | 14 ++
drivers/gpu/drm/xe/xe_devcoredump_types.h | 4
2 files changed, 18 insertions
The goal is to allow for a snapshot capture to be taken at the time
of the crash, while the print out can happen at a later time through
the exposed devcoredump virtual device.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_guc_ct.c | 132 +++
drivers/gpu
No functional change here. The goal is to have a clear split between
the mapped portions of the CTB and the static information, so we can
easily capture snapshots that will be used for later read out with
the devcoredump infrastructure.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe
callback. This callback cannot fail
anyway and we end up clearing and freeing the entire pci device.
Hence, after we removed the pci device, we shouldn't allow any
read or free operations to avoid segmentation fault.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_devcoredump.c | 19
the
dump better, the goal is to propose dev_coredump changes itself to allow
multiple files and different controls. But for now we start Xe usage of
it without any dependency on dev_coredump core changes.
Cc: Daniel Vetter
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/Kconfig
On xe_hw_engine_print_state we were printing:
value_of(0x510) + 4 instead of
value_of(0x514) as desired.
So, let's properly define a RING_EXECLIST_SQ_CONTENTS_HI
register to fix the issue and also to avoid other issues
like that.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/regs
infrastructure.
Cc: Daniel Vetter
Signed-off-by: Rodrigo Vivi
Rodrigo Vivi (14):
drm/xe: Fix print of RING_EXECLIST_SQ_CONTENTS_HI
drm/xe: Introduce the dev_coredump infrastructure.
drm/xe: Do not take any action if our device was removed.
drm/xe: Extract non mapped regions out of GuC CTB
On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote:
> In the process of renaming all instances of 'dev_priv' to 'i915',
> start using 'i915' within the 'drm_i915_file_private' structure.
The patch looks good but the commit message seems off to me...
One thing we need to take care with
On Fri, Apr 21, 2023 at 10:00:29AM -0400, Rodrigo Vivi wrote:
> On Fri, Apr 21, 2023 at 03:46:53PM +0200, Andi Shyti wrote:
> > for_each_gt() loops through engines in the GT, not in dev_priv.
>
> typo here? ^
>
> with that fixed:
oh, in the commit subject as well...
>
On Fri, Apr 21, 2023 at 03:46:53PM +0200, Andi Shyti wrote:
> for_each_gt() loops through engines in the GT, not in dev_priv.
typo here? ^
with that fixed:
Reviewed-by: Rodrigo Vivi
> Because it's misleading, call it "gt__" instead of "dev_priv__".
>
On Wed, Apr 19, 2023 at 03:13:08PM -0700, Dixit, Ashutosh wrote:
> On Wed, 19 Apr 2023 12:40:44 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > On Tue, Apr 18, 2023 at 10:23:50AM -0700, Dixit, Ashutosh wrote:
> > > On Mon, 17 Apr 2023 2
On Thu, Apr 20, 2023 at 08:57:24AM +0100, Tvrtko Ursulin wrote:
>
> On 19/04/2023 23:10, Dixit, Ashutosh wrote:
> > On Wed, 19 Apr 2023 06:21:27 -0700, Tvrtko Ursulin wrote:
> > >
> >
> > Hi Tvrtko,
> >
> > > On 10/04/2023 23:35, Ashutosh Dixit wrote:
> > > > Instead of erroring out when GuC
On Tue, Apr 18, 2023 at 10:23:50AM -0700, Dixit, Ashutosh wrote:
> On Mon, 17 Apr 2023 22:35:58 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > On Mon, Apr 10, 2023 at 03:35:09PM -0700, Ashutosh Dixit wrote:
> > > Instead of erroring out when GuC re
to incorporate Daniel's feedback on ensuring
the async vmbind consensus explicitly include Mesa, besides other kernel
drivers.
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Oded Gabbay
Signed-off-by: Rodrigo Vivi
Signed-off-by: Francois Dugast
Signed-off-by: Luis Strano
Signed-off-by: Matthew
On Tue, Apr 11, 2023 at 06:50:53PM +0200, Daniel Vetter wrote:
> On Tue, Apr 11, 2023 at 09:41:04AM -0700, John Harrison wrote:
> > On 4/11/2023 07:41, Rodrigo Vivi wrote:
> > > On Mon, Apr 10, 2023 at 12:25:21PM -0700, john.c.harri...@intel.com wrote:
> >
On Tue, Apr 18, 2023 at 11:31:30AM -0300, Gustavo Sousa wrote:
> Quoting Rodrigo Vivi (2023-04-18 10:31:33)
> > Let’s establish a merge plan for Xe, by writing down clear pre-merge goals,
> > in
> > order to avoid unnecessary delays.
> >
> > This initial
Cc: Oded Gabbay
Signed-off-by: Rodrigo Vivi
Signed-off-by: Francois Dugast
Signed-off-by: Luis Strano
Signed-off-by: Matthew Brost
Signed-off-by: Thomas Hellström
Signed-off-by: Maarten Lankhorst
Acked-by: Daniel Vetter
---
Documentation/gpu/rfc/index.rst | 4 +
Documentation/gpu/rfc
On Mon, Apr 17, 2023 at 01:06:56PM -0700, Rob Clark wrote:
> From: Rob Clark
>
> Fix a couple missing ':'s.
>
> Signed-off-by: Rob Clark
Reviewed-by: Rodrigo Vivi
> ---
> Documentation/gpu/drm-usage-stats.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
On Mon, Apr 10, 2023 at 03:35:09PM -0700, Ashutosh Dixit wrote:
> Instead of erroring out when GuC reset is in progress, block waiting for
> GuC reset to complete which is a more reasonable uapi behavior.
>
> v2: Avoid race between wake_up_all and waiting for wakeup (Rodrigo)
>
> Signed-off-by:
On Mon, Apr 17, 2023 at 12:24:45PM +0100, Tvrtko Ursulin wrote:
>
> On 14/04/2023 11:45, Zhao Liu wrote:
> > Hi Tvrtko,
> >
> > On Wed, Apr 12, 2023 at 04:45:13PM +0100, Tvrtko Ursulin wrote:
> >
> > [snip]
> >
> > > >
> > > > [snip]
> > > > > However I am unsure if disabling pagefaulting is
On Wed, Apr 12, 2023 at 12:56:26PM +0200, Andi Shyti wrote:
> Hi Rodrigo,
>
> > > > Currently, when we perform operations such as clearing or copying
> > > > large blocks of memory, we generate multiple requests that are
> > > > executed in a chain.
> > > >
> > > > However, if one of these
On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
> On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote:
> > On 11/04/2023 21:28, Rob Clark wrote:
> > > On Tue, Apr 11, 2023 at 10:36 AM Dmitry Baryshkov
> > > wrote:
> > > >
> > > > On Tue, 11 Apr 2023 at 20:13, Rob
On Mon, Apr 10, 2023 at 12:25:21PM -0700, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Sometimes, the only effective way to debug an issue is to dump all the
> interesting information at the point of failure. So add support for
> doing that.
No! Please no!
We have some of this on
On Tue, Apr 11, 2023 at 08:39:00AM +0200, Das, Nirmoy wrote:
>
> On 3/8/2023 10:41 AM, Andi Shyti wrote:
> > Currently, when we perform operations such as clearing or copying
> > large blocks of memory, we generate multiple requests that are
> > executed in a chain.
> >
> > However, if one of
> Signed-off-by: Ashutosh Dixit
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/i915_hwmon.c | 28 +++-
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_hwmon.c
> b/drivers/gpu/drm/i915/i915_hwmon.c
>
return;
> +
> + mutex_lock(>hwmon_lock);
> +
> + intel_uncore_rmw(hwmon->ddat.uncore, hwmon->rg.pkg_rapl_limit,
> + PKG_PWR_LIM_1_EN, old ? PKG_PWR_LIM_1_EN : 0);
> + hwmon->ddat.reset_in_progress = false;
> +
> +
On Wed, Apr 05, 2023 at 09:45:22PM -0700, Ashutosh Dixit wrote:
> Instead of erroring out when GuC reset is in progress, block waiting for
> GuC reset to complete which is a more reasonable uapi behavior.
>
> Signed-off-by: Ashutosh Dixit
> ---
> drivers/gpu/drm/i915/i915_hwmon.c | 13
On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote:
> On Fri, Mar 31, 2023 at 03:52:16PM -0700, john.c.harri...@intel.com wrote:
> > From: John Harrison
> >
> > First release of GuC for Meteorlake.
> >
> > NB: As this is still pre-release and likely to change, use explicit
> >
incorrectly documented function
__intel_display_power_put_async()
drm/i915/display/intel_wm: Fix a little doc-rot in
intel_update_watermarks()
Rodrigo Vivi (1):
Merge drm/drm-next into drm-intel-next
Stanislav Lisovskiy (2):
drm/i915: Use compressed bpp when calculating m/n value
On Wed, Apr 05, 2023 at 12:42:30PM -0700, Dixit, Ashutosh wrote:
> On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote:
> > > On Fri, 31 Mar 2023 19:00
Signed-off-by: Rodrigo Vivi
Signed-off-by: Francois Dugast
Signed-off-by: Luis Strano
Signed-off-by: Matthew Brost
Signed-off-by: Thomas Hellström
---
Documentation/gpu/rfc/index.rst | 4 +
Documentation/gpu/rfc/xe.rst| 216
2 files changed, 220 insertions
or vice versa, but I couldn't think of a bad case.
Or at least not as bad as the user asking to get RP0 as minimal and only
getting RPe back.
With this in mind, and having checked the code:
Reviewed-by: Rodrigo Vivi
But I won't push this immediately because I'm still open to hear ano
)
> v3: Eliminate race during PL1 disable and verify (Tvrtko)
> Change return to -ENODEV if verify fails (Tvrtko)
>
> Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8062
> Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8060
> Signed-off-by: Ashutosh Dixit
art timing out
> and gives rise the above (and even more) bugs about GuC FW load timing
> out.
I believe these 3 bullets are key information that deserves to be in
the commit message itself.
With that there,
Reviewed-by: Rodrigo Vivi
>
> * After this patch, writing 0 wou
On Thu, Mar 30, 2023 at 04:35:39PM +0200, Andrzej Hajda wrote:
> From: Chris Wilson
>
> There may be a disconnect between the GT used by the engine and the GT
> used for the VM, requiring us to hold a wakeref on both while the GPU is
> active with this request.
>
> Signed-off-by: Chris Wilson
On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote:
> On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote:
> > These two:
> > e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded")
> > b76c14c8fb2a ("drm/i915/huc: better define HuC status getparam
+Daniel
On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote:
> On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote:
> > > On Fri, 24 Mar 2023 11:15:
On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote:
> On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote:
> >
>
> Hi Vinay,
>
> Thanks for the review. Comments inline below.
>
> > On 3/15/2023 8:59 PM, Ashutosh Dixit wrote:
> > > On dGfx, the PL1 power limit being enabled
On Sat, Mar 25, 2023 at 02:19:21AM -0400, Teres Alexis, Alan Previn wrote:
> alan:snip
>
> >
> @@ -353,8 +367,20 @@ int intel_pxp_start(struct intel_pxp *pxp)
> alan:snip
> > > + if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) {
> > > + /*
> > > + * GSC-fw loading, GSC-proxy init (requiring
Hi Daniel,
Here goes drm-intel-next-2023-03-23:
Core Changes:
- drm: Add SDP Error Detection Configuration Register (Arun)
Driver Changes:
- Meteor Lake enabling and fixes (RK, Jose, Madhumitha)
- Lock the fbdev obj before vma pin (Tejas)
- DSC fixes (Stanislav)
- Fixes and clean-up on opregion
On Tue, Mar 07, 2023 at 05:00:01PM -0500, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
>
> Here goes our first pull request towards 6.3.
You know, I meant 6.4. :)
Thank you Joonas for noticing that.
>
> drm-intel-next-2023-03-07:
>
> Cross-subsystem Changes:
> - ME
mbo PHY init sequence
Mavroudis Chatzilaridis (1):
drm/i915/quirks: Add inverted backlight quirk for HP 14-r206nv
Nirmoy Das (1):
drm/i915/display: Pass drm_i915_private as param to i915 funcs
Radhakrishna Sripada (1):
drm/i915/mtl: Initialize empty clockgating hooks for MTL
On Mon, Mar 06, 2023 at 03:23:08PM +, Souza, Jose wrote:
> On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote:
> > As a fallback if we decide not to merge the frontbuffer tracking, allow
> > i915 to keep its own implementation, and do the right thing in Xe.
> >
> > The frontbuffer
On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote:
> From: Rob Clark
>
missing some wording here...
> v2: rebase
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/i915/i915_request.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --git
On Fri, Feb 17, 2023 at 09:51:37PM +0100, Daniel Vetter wrote:
> Hi all,
>
> [I thought I've sent this out earlier this week, but alas got stuck, kinda
> bad timing now since I'm out next week but oh well]
>
> So xe is a quite substantial thing, and I think we need a clear plan how to
> land
>
On Mon, Feb 27, 2023 at 02:20:04PM -0800, Rob Clark wrote:
> On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi wrote:
> >
> > On Fri, Feb 24, 2023 at 09:59:57AM -0800, Rob Clark wrote:
> > > On Fri, Feb 24, 2023 at 7:27 AM Luben Tuikov wrote:
> > > >
> > >
On Fri, Feb 24, 2023 at 09:59:57AM -0800, Rob Clark wrote:
> On Fri, Feb 24, 2023 at 7:27 AM Luben Tuikov wrote:
> >
> > On 2023-02-24 06:37, Tvrtko Ursulin wrote:
> > >
> > > On 24/02/2023 11:00, Pekka Paalanen wrote:
> > >> On Fri, 24 Feb 2023 10:50:51 +
> > >> Tvrtko Ursulin wrote:
> > >>
On Fri, Feb 24, 2023 at 12:11:40AM +0530, Badal Nilawar wrote:
> Apply Wa_14017073508 for MTL SoC die A step instead of graphics step.
> To get the SoC die stepping there is no direct interface so using
> revid as revid 0 aligns with SoC die A step.
>
> Bspec: 55420
This doesn't prove anything.
On Wed, Feb 22, 2023 at 03:17:55PM +0100, Werner Sembach wrote:
> On these Barebones PSR 2 is recognized as supported but is very buggy:
> - Upper third of screen does sometimes not updated, resulting in
> disappearing cursors or ghosts of already closed Windows saying behind.
> - Approximately 40
On Wed, Feb 22, 2023 at 12:09:04PM +0200, Pekka Paalanen wrote:
> On Tue, 21 Feb 2023 09:25:18 -0800
> Rob Clark wrote:
>
> > On Tue, Feb 21, 2023 at 12:53 AM Pekka Paalanen wrote:
> > >
> > > On Mon, 20 Feb 2023 12:18:56 -0800
> > > Rob Clark wrote:
> > >
> > > > From: Rob Clark
> > > >
>
On Fri, Feb 17, 2023 at 09:00:49AM -0800, Rob Clark wrote:
> On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin
> wrote:
> >
> >
> > On 17/02/2023 14:55, Rob Clark wrote:
> > > On Fri, Feb 17, 2023 at 4:56 AM Tvrtko Ursulin
> > > wrote:
> > >>
On Fri, Feb 17, 2023 at 01:46:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> With gcc-7 and earlier, there are lots of warnings like
>
> In file included from :0:0:
> In function '__guc_context_policy_add_priority.isra.66',
> inlined from '__guc_context_set_prio.isra.67' at
>
On Thu, Feb 16, 2023 at 08:49:42AM -0800, Ashutosh Dixit wrote:
> Previous PL1 power limit implementation assumed that the PL1 limit is
> always enabled in HW. However we now find this not to be the case on ATSM
> where the PL1 limit is disabled at power up. This requires changes in the
> previous
On Thu, Feb 16, 2023 at 11:25:50AM -0800, Guenter Roeck wrote:
> On 2/16/23 10:57, Rodrigo Vivi wrote:
> > On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote:
> > > On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote:
> > > >
> > >
> &g
On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote:
> On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote:
> >
>
> Hi Guenter,
>
> > On 2/13/23 21:33, Ashutosh Dixit wrote:
> > > On ATSM the PL1 power limit is disabled at power up. The previous uapi
> > > assumed that the PL1
On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote:
> On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin
> wrote:
> >
> > From: Tvrtko Ursulin
> >
> > In i915 we have this concept of "wait boosting" where we give a priority
> > boost
> > for instance to fences which are actively waited upon
Hi Dave and Daniel,
Only 1 gen11 workaround fix.
Here goes drm-intel-fixes-2023-02-16:
- Moving gen11 hw wa to the right place. (Matt)
Thanks,
Rodrigo.
The following changes since commit ceaa837f96adb69c0df0397937cd74991d5d821a:
Linux 6.2-rc8 (2023-02-12 14:10:17 -0800)
are available in
On Wed, Feb 15, 2023 at 08:24:51AM -0800, Dixit, Ashutosh wrote:
> On Wed, 15 Feb 2023 07:37:30 -0800, Jani Nikula wrote:
> >
> > On Wed, 08 Feb 2023, Rodrigo Vivi wrote:
> > > On Wed, Feb 08, 2023 at 11:03:12AM -0800, Ashutosh Dixit wrote:
&g
Hi Dave and Daniel,
Here goes our fixes for this week with a few patches targeting stable.
drm-intel-fixes-2023-02-09:
- Display watermark fix (Ville)
- fbdev fix for PSR, FBC, DRRS (Jouni)
- Move fd_install after last use of fence (Rob)
- Initialize the obj flags for shmem objects (Aravind)
-
On Wed, Feb 08, 2023 at 11:03:12AM -0800, Ashutosh Dixit wrote:
> This reverts commit 0349c41b05968befaffa5fbb7e73d0ee6004f610.
>
> 0349c41b0596 ("drm/i915/hwmon: Enable PL1 power limit") is incorrect and
> caused a major regression on ATSM. The change enabled the PL1 power limit
> but FW sets
the logic
> at once.
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: intel-gvt-...@lists.freedesktop.org
> Cc: intel-...@lists.freedesktop.org
>
;)
> Reported-by: Stephen Rothwell
> Signed-off-by: Bagas Sanjaya
Reviewed-by: Rodrigo Vivi
pushing this now.
thank you.
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/
Hi Dave and Daniel,
Here goes this week's fixes with couple targeting stable.
drm-intel-fixes-2023-02-02:
- Fixes for potential use-after-free and double-free (Rob)
- GuC locking and refcount fixes (John)
- Display's reference clock value fix (Chaitanya)
Thanks,
Rodrigo.
The following changes
On Wed, Feb 01, 2023 at 10:37:06AM -0800, John Harrison wrote:
> On 2/1/2023 07:31, Rodrigo Vivi wrote:
> > On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison
> >
On Wed, Feb 01, 2023 at 03:11:31PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 31 Jan 2023 10:27:29 -0800 John Harrison
> wrote:
> >
> > On 1/31/2023 04:44, Andy Shevchenko wrote:
> > > On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote:
> > >>
> > >> Today's linux-next
+Suraj
On Tue, Jan 31, 2023 at 12:16:44PM -0500, Rodrigo Vivi wrote:
>
> +Suraj who is also working on HDCP related code that even can conflict
> wit this.
>
> On Wed, Jan 18, 2023 at 07:30:12PM +, Mark Yacoub wrote:
> > From: Sean Paul
>
> First of all, Se
s;
> -
> - ret = intel_dp_hdcp_read_bcaps(dig_port, );
> - if (ret)
> - return ret;
> -
> - *hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE;
> - return 0;
> -}
> -
> struct hdcp2_dp_errata_stream_type {
> u8 msg_id;
>
On Mon, Jan 30, 2023 at 11:37:29AM -0500, Rodrigo Vivi wrote:
> On Mon, Jan 30, 2023 at 05:12:48PM +0100, Andi Shyti wrote:
> > Hi Rodrigo,
> >
> > > > > In the call flow invoked by intel_pcode_init(), I've added brief
> > > > > comments
&g
On Mon, Jan 30, 2023 at 05:12:48PM +0100, Andi Shyti wrote:
> Hi Rodrigo,
>
> > > > In the call flow invoked by intel_pcode_init(), I've added brief
> > > > comments
> > > > where further clarification is needed in this scenario, and a
> > > > description of
> > > > the suspicious scenario at
On Mon, Jan 30, 2023 at 09:48:31AM +0100, Andi Shyti wrote:
> Hi GG,
>
> thanks for the deep analysis!
>
> > Hi Andi,
> > In the call flow invoked by intel_pcode_init(), I've added brief comments
> > where further clarification is needed in this scenario, and a description of
> > the suspicious
On Fri, Jan 27, 2023 at 10:09:31AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 25, 2023 at 12:28:29PM -0500, Rodrigo Vivi wrote:
> >
> > Greg, ack on getting these 3 mei patches merged through intel-gfx?
>
> I only see 2 mei patches in this series, what am I missing?
r
Hi Dave and Daniel,
nothing major or critical this round...
Here goes drm-intel-fixes-2023-01-26:
- Fix BSC default context for Meteor Lake (Lucas)
- Fix selftest-scheduler's modify_type (Andi)
Thanks,
Rodrigo.
The following changes since commit 2241ab53cbb5cdb08a6b2d4688feb13971058f65:
On Wed, Jan 25, 2023 at 02:24:54PM +1000, Dave Airlie wrote:
> From: Dave Airlie
>
> I don't really like the symlinks, my other idea was creating new
> files which just include the original, but this idea seems to at
> least build.
Reviewed-by: Rodrigo Vivi
Tested-by: Rodrigo
Greg, ack on getting these 3 mei patches merged through intel-gfx?
On Wed, Jan 25, 2023 at 12:26:34AM -0800, Alan Previn wrote:
> From: Alexander Usyskin
>
> Client on bus have only one vtag map slot and should disregard the vtag
> value when cleaning pending read flag.
> Fixes read flow
e core function, but it doesn't do that indeed.
Maybe in the most used case, folks are sure that this won't be hit without
having running the device_link_add previously, what may or may not be our case.
Anyway better safe than sorry, so let's keep it.
Reviewed-by: Rodrigo Vivi
> +
On Tue, Jan 24, 2023 at 10:08:52AM -0800, Juston Li wrote:
> On Tue, 2023-01-24 at 10:17 -0500, Rodrigo Vivi wrote:
> > On Mon, Jan 23, 2023 at 09:31:49PM -0800, Alan Previn wrote:
> > > A driver bug was recently discovered where the security firmware
> > > was
> >
On Mon, Jan 23, 2023 at 09:31:49PM -0800, Alan Previn wrote:
> A driver bug was recently discovered where the security firmware was
> receiving internal HW signals indicating that session key expirations
> had occurred. Architecturally, the firmware was expecting a response
> from the GuC to
On Mon, Jan 23, 2023 at 09:31:46PM -0800, Alan Previn wrote:
> From: Alexander Usyskin
>
> Add device link with i915 as consumer and mei_pxp as supplier
> to ensure proper ordering of power flows.
>
> V2: condition on absence of heci_pxp to filter out DG
>
> Signed-off-by: Alexander Usyskin
>
On Sun, Jan 22, 2023 at 06:57:24AM +, Usyskin, Alexander wrote:
> > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > > index d50354bfb993..bef6d7f8ac55 100644
> > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > > +++
On Thu, Jan 19, 2023 at 01:12:22PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> In file included from drivers/gpu/drm/drm_fb_helper.c:33:
> drivers/gpu/drm/drm_fb_helper.c: In function
On Thu, Jan 19, 2023 at 09:06:54AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 18.01.23 um 20:21 schrieb Rodrigo Vivi:
> > On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote:
> > > Set the framebuffer info for drivers that support VGA switcheroo. Only
On Thu, Jan 19, 2023 at 09:26:20AM +0800, Zhenyu Wang wrote:
> On 2023.01.18 11:44:55 -0500, Rodrigo Vivi wrote:
> > On Wed, Jan 18, 2023 at 10:18:11AM +0530, Deepak R Varma wrote:
> > > On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote:
> > > > On Mon, Ja
On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion
Hi Dave and Daniel,
Couple patches targeting stable, couple DG2 w/a,
and a selftest fix.
There was a drm-tip conflict but very trivial where
keeping the new mtl function as in drm-intel-gt-next is
the right resolution.
Here goes drm-intel-fixes-2023-01-19:
- Reject display plane with height ==
m/i915/gt/intel_gt_pm.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.h
> > @@ -77,6 +77,7 @@ void intel_gt_pm_fini(struct intel_gt *gt);
> > void intel_gt_suspend_prepare(struct intel_gt *gt);
> > void intel_gt_suspend_late(struct intel_gt *gt);
> > +
>
&
On Thu, Jan 12, 2023 at 05:18:49PM -0800, Alan Previn wrote:
> A driver bug was recently discovered where the security firmware was
> receiving internal HW signals indicating that session key expirations
> had occurred. Architecturally, the firmware was expecting a response
> from the GuC to
off-by: Alan Previn
> Reviewed-by: Juston Li
Acked-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/pxp/intel_pxp.h | 1 +
> .../drm/i915/pxp/intel_pxp_cmd_interface_42.h | 15
> .../i915/pxp/intel_pxp_cmd_interface_cmn.h| 3 ++
> drivers/gpu/drm/i9
On Thu, Jan 12, 2023 at 05:18:46PM -0800, Alan Previn wrote:
> From: Alexander Usyskin
>
> Add device link with i915 as consumer and mei_pxp as supplier
> to ensure proper ordering of power flows.
>
> V2: condition on absence of heci_pxp to filter out DG
>
> Signed-off-by: Alexander Usyskin
>
On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote:
> Set the framebuffer info for drivers that support VGA switcheroo. Only
> affects the amdgpu and nouveau drivers, which use VGA switcheroo and
> generic fbdev emulation. For other drivers, this does nothing.
>
> This fixes a
On Wed, Jan 18, 2023 at 1:35 PM Rodrigo Vivi wrote:
>
> On Wed, Jan 18, 2023 at 06:06:24PM +0100, Nirmoy Das wrote:
> > Removed unused i915 var.
> >
> > Fixes: a273e95721e9 ("drm/i915: Allow switching away via vga-switcheroo if
> > uninitialized")
>
On Wed, Jan 18, 2023 at 10:18:11AM +0530, Deepak R Varma wrote:
> On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote:
> > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote:
> > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote:
> > > > On Wed, Ja
201 - 300 of 1082 matches
Mail list logo
