Re: [PATCH] drm/i915/dg2: Drop force_probe requirement

2022-11-18 Thread Rodrigo Vivi
; requirement and enable the platform by default. > > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > Cc: Jani Nikula > Signed-off-by: Matt Roper Acked-by: Rodrigo Vivi I'm going to merge this soon. Thanks to everyone involved. > --- > > The

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-18 Thread Rodrigo Vivi
On Fri, Nov 18, 2022 at 09:32:37AM -0500, Rodrigo Vivi wrote: > On Fri, Nov 18, 2022 at 09:35:41AM +0530, Nilawar, Badal wrote: > > > > > > On 18-11-2022 03:44, Rodrigo Vivi wrote: > > > On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote:

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-18 Thread Rodrigo Vivi
On Fri, Nov 18, 2022 at 09:35:41AM +0530, Nilawar, Badal wrote: > > > On 18-11-2022 03:44, Rodrigo Vivi wrote: > > On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle mesagin

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-17 Thread Rodrigo Vivi
On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar > > By defaut idle mesaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: > - Fix review comments (Vinay) > - Set GSC idle hysterisis to 5 us (Bad

Re: [Intel-gfx] [PATCH 0/5] i915: CAGF and RC6 changes for MTL

2022-11-17 Thread Rodrigo Vivi
On Mon, Nov 14, 2022 at 06:03:43PM +0530, Badal Nilawar wrote: > This series includes the code changes to get CAGF, RC State and C6 > Residency of MTL. > > v3: Included "Use GEN12 RPSTAT register" patch > > v4: > - Rebased > - Dropped "Use GEN12 RPSTAT register" patch from this series > g

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-15 Thread Rodrigo Vivi
On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar > > By defaut idle mesaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: > - Fix review comments (Vinay) > - Set GSC idle hysterisis to 5 us (Bad

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree

2022-11-14 Thread Rodrigo Vivi
On Mon, Nov 14, 2022 at 01:02:46PM +0200, Jani Nikula wrote: > On Mon, 14 Nov 2022, Hans de Goede wrote: > > Hi, > > > > On 11/14/22 11:10, Jani Nikula wrote: > >> On Mon, 14 Nov 2022, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 11/14/22 00:23, Stephen Rothwell wrote: > Hi all, > > >>

Re: [PATCH 26/26] drm/i915/gt: Remove #ifdef guards for PM related functions

2022-11-07 Thread Rodrigo Vivi
independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil > --- > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-...@lists.

Re: [PATCH v2] drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-04 Thread Rodrigo Vivi
rect workaround id (Matt) > - Fix review comments (Rodrigo) > > Cc: Rodrigo Vivi > Cc: Radhakrishna Sripada > Cc: Vinay Belgaumkar > Cc: Chris Wilson > Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/intel_gt_pm.c |

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-10-31 Thread Rodrigo Vivi
around pcode expect kmd to send mailbox message "media busy" when > components of Media tile is in use and "media not busy" when not in use. > As per workaround description gucrc need to be disabled so enabled > host based RC for Media tile. > > HSD: 14017210380 &g

[PULL] drm-intel-next

2022-10-28 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes the first chunk of drm-intel-next targeting 6.2 The highlight goes to Ville with many display related clean-up and improvement, some other MTL enabling work and many other fixes and small clean-ups. drm-intel-next-2022-10-28: - Hotplug code clean-up and organization

Re: [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Rodrigo Vivi
str_yes_no(mtl_powergate_enable & > GEN9_MEDIA_PG_ENABLE)); > + } else { > + seq_printf(m, "Render Well Gating Enabled: %s\n", > +str_yes_no(mtl_powergate_enable & > GEN9_RENDER_PG_ENABLE)); > + } > + >

Re: [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Rodrigo Vivi
On Mon, Oct 24, 2022 at 12:16:28PM -0700, Dixit, Ashutosh wrote: > On Fri, 21 Oct 2022 09:35:32 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Wed, Oct 19, 2022 at 04:37:21PM -0700, Ashutosh Dixit wrote: > > > From: Badal Nilawar > > > >

Re: [PATCH] i915/display: fix repeated words in comments

2022-10-24 Thread Rodrigo Vivi
On Sat, Oct 22, 2022 at 02:09:47PM +0800, wangjianli wrote: > Delete the redundant word 'the'. I believe we should put an end in patches like this. Please accumulate all the s/the the/the and other small comment fixes that are under drivers/gpu/drm/i915 in a single commit. > > Signed-off-by: wa

Re: [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:21PM -0700, Ashutosh Dixit wrote: > From: Badal Nilawar > > Add support for C6 residency and C state type for MTL SAMedia. Also add > mtl_drpc. I believe this patch deserves a slip between the actual support and the debugfs, but I'm late to the review, so feel free

Re: [PATCH 4/5] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-21 Thread Rodrigo Vivi
num" in function arguments > - Naming: intel_rc6_* for enum > - Use INTEL_RC6_RES_MAX and other minor changes > v3: Don't include intel_rc6_types.h in intel_rc6.h (Jani) > > Suggested-by: Rodrigo Vivi > Suggested-by: Jani Nikula > Reported-by: Jani Nikula >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-21 Thread Rodrigo Vivi
: Use REG_FIELD_GET and uncore (Rodrigo) > > > > Bspec: 66300 > > Reviewed-by: Ashutosh Dixit Acked-by: Rodrigo Vivi > > > > > Signed-off-by: Ashutosh Dixit > > Signed-off-by: Badal Nilawar > > --- > > drivers/gpu/drm/i915/gt/intel_gt_regs.

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-21 Thread Rodrigo Vivi
ead to GEN12_RPSTAT1 in > read_cagf (Ashutosh) > v4: Remove GEN12_CAGF_SHIFT and use REG_FIELD_GET (Rodrigo) > > Cc: Don Hiatt > Cc: Andi Shyti > Signed-off-by: Don Hiatt > Signed-off-by: Badal Nilawar > Signed-off-by: Ashutosh Dixit > Reviewed-by: Andi S

Re: [PATCH 1/5] drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:17PM -0700, Ashutosh Dixit wrote: > Instead of masks/shifts settle on REG_FIELD_GET as the standard way to > extract reg fields. This allows future patches touching this code to also > consistently use REG_FIELD_GET and friends. > > Suggested-b

Re: [PATCH 1/4] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-19 Thread Rodrigo Vivi
On Tue, Oct 18, 2022 at 10:20:40PM -0700, Ashutosh Dixit wrote: > From: Don Hiatt > > On GEN12+ use GEN12_RPSTAT register to get actual resolved GT > freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if > GT is in RC6. > > v2: > - Fixed review comments(Ashutosh) > - Adde

Re: [PATCH 2/4] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-19 Thread Rodrigo Vivi
On Tue, Oct 18, 2022 at 10:20:41PM -0700, Ashutosh Dixit wrote: > From: Badal Nilawar > > Update CAGF functions for MTL to get actual resolved frequency of 3D and > SAMedia. > > v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) > Move MTL branches in cagf functions to top (MattR)

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/slpc: Update the frequency debugfs

2022-10-10 Thread Rodrigo Vivi
On Thu, Oct 06, 2022 at 05:24:34PM -0400, Rodrigo Vivi wrote: > On Wed, Oct 05, 2022 at 08:59:43AM -0700, Vinay Belgaumkar wrote: > > Read the values stored in the SLPC structures. Remove the > > fields that are no longer valid (like RPS interrupts) as > > well. > > >

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/slpc: Update the frequency debugfs

2022-10-06 Thread Rodrigo Vivi
freq)); Well, my feelings with these are: 1. We have these already in sysfs and we don't need to duplicated here. But we have this already duplicated for years 2. We should probably simply remove this file when using SLPC and force folks to look to the sysfs files? 3. Maybe we should take

Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-30 Thread Rodrigo Vivi
On Tue, Sep 27, 2022 at 11:20:17AM +0530, Badal Nilawar wrote: > From: Dale B Stimson > > Use i915 HWMON to display device level energy input. > > v2: Updated the date and kernel version in feature description > v3: > - Cleaned up hwm_energy function and removed unused function > i915_hwmo

[PULL] drm-intel-fixes

2022-09-29 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-29: - Restrict forced preemption to the active context (Chris) - Restrict perf_limit_reasons to the supported platforms - gen11+ (Ashutosh) Thanks, Rodrigo. The following changes since commit f76349cf41451c5c42a99f18a9163377e4b364ff: Linu

Re: [PATCH] drm/i915/gt: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Rodrigo Vivi
On Wed, Sep 28, 2022 at 12:02:12PM -0700, Ashutosh Dixit wrote: > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > Gen11+. Therefore ensure perf_limit_reasons sysfs files are created only > for Gen11+. Otherwise on Gen < 5 accessing these files results in the > following oops: >

Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Rodrigo Vivi
On Wed, Sep 28, 2022 at 11:17:06AM -0700, Dixit, Ashutosh wrote: > On Wed, 28 Sep 2022 04:38:46 -0700, Jani Nikula wrote: > > > > On Mon, 19 Sep 2022, Ashutosh Dixit wrote: > > > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > > > Gen11+. Therefore ensure perf_limit_reasons sysf

Re: [Intel-gfx] [PATCH] drm/i915/gt: Bump the reset-failure timeout to 60s

2022-09-27 Thread Rodrigo Vivi
On Fri, Sep 16, 2022 at 01:48:23PM -0700, Ashutosh Dixit wrote: > From: Chris Wilson > > If attempting to perform a GT reset takes long than 5 seconds (including > resetting the display for gen3/4), then we declare all hope lost and > discard all user work and wedge the device to prevent furthe

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused function parameter

2022-09-23 Thread Rodrigo Vivi
On Thu, Sep 22, 2022 at 02:39:16PM -0700, Niranjana Vishwanathapura wrote: > The function parameter 'exclude' in funciton > i915_sw_fence_await_reservation() is not used. > Remove it. > > Reviewed-by: Tvrtko Ursulin > Signed-off-by: Niranjana Vishwanathapura pushed to drm-intel-next. Thanks for

[PULL] drm-intel-fixes

2022-09-21 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-21: 2 gem context related fixes: - to avoid a general protection failure when using perf/OA (Chris) - to avoid kernel warnings on driver release (Janusz) Thanks, Rodrigo. The following changes since commit 521a547ced6477c54b4b0cc206000406c22

Re: [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-20 Thread Rodrigo Vivi
gitlab.freedesktop.org/drm/intel/-/issues/6863 > Fixes: fe5979665f64 ("drm/i915/debugfs: Add perf_limit_reasons in debugfs") > Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") > Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi >

[PULL] drm-intel-fixes

2022-09-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Nothing that big for this round, but a couple targeting stable. Here goes drm-intel-fixes-2022-09-15: - Revert a display patch around max DP source rate now that the proper WaEdpLinkRateDataReload is in place. (Ville) - Fix perf limit reasons bit position. (Ashutosh) - Fix

Re: [Intel-gfx] Developing a new backlight driver for specific OLED screen

2022-09-09 Thread Rodrigo Vivi
On Fri, Sep 09, 2022 at 11:35:28AM +0200, Aurélien wrote: >Hi, >I hope this mailing-mist is the right place for this question. + dri-devel mailing list that looks more appropriated. + Hans and Lyude who were recently working to standardize some of the backlight stuff. >I would like to

Re: [PATCH v3 37/37] drm/i915: be consistent with kernel-doc function declaration

2022-09-09 Thread Rodrigo Vivi
arvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v3 00/37] at: > https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/ > > drivers/gpu/drm/i915

Re: [PATCH v3 35/37] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-09-09 Thread Rodrigo Vivi
l_wakeref.h and > intel_runtime_pm.c. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v3 00/37] at: > https://lore.kernel.org/a

Re: [Intel-gfx] [PATCH v3 32/37] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-09-09 Thread Rodrigo Vivi
les); do if [ "$(git grep $i > Documentation/)" == "" ]; then echo "$i"; fi; done >aaa > > Add them to i915.rst as well. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of peo

Re: [Intel-gfx] [PATCH v3 27/37] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-09-09 Thread Rodrigo Vivi
story here to indicate what changed from the previous submission, something like v2: re-organizing the blocks to group gtt stuff. that helps reviewers to know if their change requested was addressed or not. but anyways: Reviewed-by: Rodrigo Vivi > Signed-off-by: Mauro Carvalho Chehab > -

[PULL] drm-intel-fixes

2022-09-08 Thread Rodrigo Vivi
uC's SLPC is in use. (Rodrigo) - Implement Workaround for eDP. (Ville) - Fix has_flat_ccs selection for DG1. (Matt) Matthew Auld (1): drm/i915: consider HAS_FLAT_CCS() in needs_ccs_pages Rodrigo Vivi (1): drm/i915

[PULL] drm-intel-fixes

2022-09-01 Thread Rodrigo Vivi
5/ttm: fix CCS handling Rodrigo Vivi (1): Merge tag 'gvt-fixes-2022-08-22' of https://github.com/intel/gvt-linux into drm-intel-fixes Ville Syrjälä (1): drm/i915: Skip wm/ddb readout for disabled pipes Łukasz Bartosik (1): drm/i915: fix null pointer dereference drive

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Remove log size module parameters

2022-08-26 Thread Rodrigo Vivi
"drm/i915/guc: Make GuC log sizes runtime configurable") > Signed-off-by: Joonas Lahtinen > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: John Harrison > Cc: Alan Previn > Reviewed-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > driver

[PULL] drm-intel-fixes

2022-08-26 Thread Rodrigo Vivi
ix kernel-doc drm/i915/gvt: Fix kernel-doc drm/i915/gvt: Fix kernel-doc Jouni Högander (1): drm/i915/backlight: Disable pps power hook for aux based backlight Julia Lawall (1): drm/i915/gvt: fix typo in comment Matthew Auld (1): drm/i915/ttm: fix CCS handling Rodrig

Re: [PATCH v2] drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-24 Thread Rodrigo Vivi
read for obtaining > the correct efficient frequency for Gen9+. > > We see much better perf numbers with benchmarks like glmark2 with > efficient frequency usage enabled as expected. > > v2: Address review comments (Rodrigo) > > BugLink: https://gitlab.freedesktop.org/drm

Re: [PATCH] drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-15 Thread Rodrigo Vivi
read for obtaining > the correct efficient frequency for Gen9+. > > We see much better perf numbers with benchmarks like glmark2 with > efficient frequency usage enabled as expected. > > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/5468 > > Cc: Rodrigo Vivi Firs

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Allow SLPC to use efficient frequency

2022-08-15 Thread Rodrigo Vivi
On Tue, Aug 09, 2022 at 05:03:06PM -0700, Vinay Belgaumkar wrote: > Host Turbo operates at efficient frequency when GT is not idle unless > the user or workload has forced it to a higher level. Replicate the same > behavior in SLPC by allowing the algorithm to use efficient frequency. > We had disa

[PULL] drm-intel-next-fixes

2022-08-11 Thread Rodrigo Vivi
Hi Dave and Daniel, And here is the right one. And now including all the fixes. Here goes drm-intel-next-fixes-2022-08-11: - disable pci resize on 32-bit systems (Nirmoy) - don't leak the ccs state (Matt) - TLB invalidation fixes (Chris) [now with all fixes of fixes] Thanks, Rodrigo. The follo

Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-09 Thread Rodrigo Vivi
On Mon, Aug 08, 2022 at 04:05:55PM +0530, Anshuman Gupta wrote: > As per PCIe Spec Section 5.3, > When a Type 1 Function associated with a Switch/Root > Port (a “virtual bridge”) is in a non-D0 power state, > it will emulate the behavior of a conventional PCI bridge > in its handling of Memory, I/O

Re: [PATCH v2 11/39] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
gt; parameter or member 'flags' not described in 'i915_ttm_restore_region' > drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:199: warning: Excess > function parameter 'allow_gpu' description in 'i915_ttm_restore_region' > > Signed-off-by: Mau

Re: [Intel-gfx] [PATCH v2 35/39] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote: > There are other files with kernel-doc markups: > > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/) > >kernel-doc-files > $ for i in $(cat kernel-doc-files); do if [ "$(git grep $i > Documentatio

Re: [PATCH v2 39/39] drm/i915: add GuC functions to the documentation

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:27AM +0100, Mauro Carvalho Chehab wrote: > Currently, functions inside GuC aren't presented as part of the > GuC documentation. > > Add them. > > Signed-off-by: Mauro Carvalho Chehab could be squashed to the other guc patch, but anyways: Re

Re: [PATCH v2 31/39] docs: gpu: i915.rst: GuC: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:19AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GuC kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab Revie

Re: [Intel-gfx] [PATCH v2 38/39] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:26AM +0100, Mauro Carvalho Chehab wrote: > The intel_gt_pm.h file contains some convenient macros to be used > in GT code in order to get/put runtime PM references and for > checking them. > > Add descriptions based on the ones at intel_wakeref.h and > intel_runtime_p

Re: [PATCH v2 36/39] drm/i915 i915_gem_object_types.h: document struct i915_lut_handle

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:24AM +0100, Mauro Carvalho Chehab wrote: > commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr") > added a rbtree list to allow searching for obj/ctx. > > Document it. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by:

Re: [Intel-gfx] [PATCH v2 37/39] drm/i915: document struct drm_i915_gem_object

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:25AM +0100, Mauro Carvalho Chehab wrote: > This is a large struct used to describe gem objects. It is > currently partially documented. Finish its documentation, filling > the gaps from git logs. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-b

Re: [Intel-gfx] [PATCH v2 33/39] docs: gpu: i915.rst: PM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:21AM +0100, Mauro Carvalho Chehab wrote: > Both intel_runtime_pm.h and intel_pm.c contains kAPI for > runtime PM. So, add them to the documentation. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid m

Re: [Intel-gfx] [PATCH v2 34/39] docs: gpu: i915.rst: GEM/TTM: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:22AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GEM/TTM kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab

Re: [Intel-gfx] [PATCH v2 30/39] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote: > There are several documented GT kAPI that aren't currently part > of the docs. Add them, as this allows identifying issues with > badly-formatted tags. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing

Re: [Intel-gfx] [PATCH v2 19/39] drm/i915: i915_gem_region.h: fix i915_gem_apply_to_region_ops doc

2022-08-09 Thread Rodrigo Vivi
ill consider them to be placed at the wrong place. > > Fix (1) and change the way the parameters are described, using > a list, in order for it to be properly parsed during documentation > build time. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- &g

Re: [Intel-gfx] [PATCH v2 29/39] docs: gpu: i915.rst: display: add kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
o Chehab same here, not checked if these would be all the files, but it is reasonable Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/all/c

Re: [PATCH v2 32/39] docs: gpu: i915.rst: GVT: add more kernel-doc markups

2022-08-09 Thread Rodrigo Vivi
n't checked if these would be all the files, but the approach looks reasonable to me. Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/

Re: [Intel-gfx] [PATCH v2 18/39] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

2022-08-09 Thread Rodrigo Vivi
e. my first reaction was: "do we really need those new empty ( ) blocks?" Then I read this ;) Reviewed-by: Rodrigo Vivi > > Change the ascii artwork to be on code-blocks, starting all > lines at the same characters and not ending with a backslash. > > Signed-off-by: Ma

Re: [Intel-gfx] [PATCH v2 15/39] drm/i915: intel_dp_link_training.c: fix kernel-doc markup

2022-08-09 Thread Rodrigo Vivi
, I didn't know that Reviewed-by: Rodrigo Vivi > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/all/cover.1657699

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb()

2022-08-08 Thread Rodrigo Vivi
On Mon, Aug 08, 2022 at 06:37:58PM +0200, Andi Shyti wrote: > Hi Mauro, > > On Thu, Aug 04, 2022 at 09:37:22AM +0200, Mauro Carvalho Chehab wrote: > > WRITE_ONCE() should happen at the original var, not on a local > > copy of it. > > > > Fixes: 5d36acb7198b ("drm/i915/gt: Batch TLB invalidations"

[PULL] drm-intel-next (updated without the bad commit)

2022-08-05 Thread Rodrigo Vivi
tha Tolakanahalli Pradeep (1): drm/i915/dmc: Update DG2 DMC firmware to v2.07 Matt Roper (1): drm/i915: Add Wa_14016291713 Rodrigo Vivi (1): Merge drm/drm-next into drm-intel-next Stanislav Lisovskiy (1): drm/i915/dg2: Bump up CDCLK for DG2 Swati Sharma (1): drm/i9

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2022-08-05 Thread Rodrigo Vivi
On Fri, Aug 05, 2022 at 05:25:43PM +0200, Mauro Carvalho Chehab wrote: > On Fri, 5 Aug 2022 10:39:44 -0400 > Rodrigo Vivi wrote: > > > On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > > > Hi Rodrigo, > > > > > > On Thu, 4 Aug 202

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2022-08-05 Thread Rodrigo Vivi
On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > Hi Rodrigo, > > On Thu, 4 Aug 2022 13:33:06 -0400 > Rodrigo Vivi wrote: > > > Hi Dave and Daniel, > > > > Here goes drm-intel-next-fixes-2022-08-04: > > > > - disable pci

[PULL] drm-intel-next-fixes

2022-08-04 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2022-08-04: - disable pci resize on 32-bit systems (Nirmoy) - don't leak the ccs state (Matt) - TLB invalidation fixes (Chris) Thanks, Rodrigo. The following changes since commit 2bc7ea71a73747a77e7f83bc085b0d2393235410: Merge tag 'topic/nou

Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

2022-07-21 Thread Rodrigo Vivi
On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote: > The semicolon after the `}' in line 648 is unneeded. I removed the line mention while pushing to drm-intel-gt-next. Thanks for the patch. > > Signed-off-by: Jason Wang > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +- > 1 file

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo

2022-07-21 Thread Rodrigo Vivi
On Wed, Jul 20, 2022 at 06:56:16PM +0200, Andrzej Hajda wrote: > On 16.07.2022 06:05, Jason Wang wrote: > > Fix the double `wait' typo in comment. > > > > Signed-off-by: Jason Wang > > --- > > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(

[PULL] drm-intel-fixes

2022-07-20 Thread Rodrigo Vivi
Hi Dave and Daniel, This is basically only the guc regression fix. The other patch is just a dependency to make the important patch to apply cleanly without conflict. drm-intel-fixes-2022-07-20-1: - Fix the regression caused by the lack of GuC v70. Let's accept the fallback to v69. Thanks, Rod

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gt: Expose per gt defaults in sysfs

2022-07-19 Thread Rodrigo Vivi
On Mon, Jul 18, 2022 at 06:07:06PM -0700, Ashutosh Dixit wrote: > Create a gt/gtN/.defaults/ directory (similar to > engine//.defaults/) to expose default parameter values for each > gt in sysfs. This allows userspace to restore default parameter values > after they may have changed. > > Patch 1:

Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

2022-07-18 Thread Rodrigo Vivi
On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote: > The semicolon after the `}' in line 648 is unneeded. same here The line number changes... if you remove the "in line #" the msg gets better. With that changed: Reviewed-by: Rodrigo Vivi > > S

Re: [PATCH] drm/i915/selftests: Fix comment typo

2022-07-18 Thread Rodrigo Vivi
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote: > The double `wait' is duplicated in line 974, remove one. The line number changes... if you remove the "in line #" the msg gets better. With that changed: Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jaso

Re: [Intel-gfx] [PATCH] drm/i915/guc: support v69 in parallel to v70

2022-07-18 Thread Rodrigo Vivi
o v69 in 5.18. the team had looked to get v62 right now, but that would be too disruptive and risky for the 5.19. For now we are going with this fallback to v69 to solve the 5.19 regression. Then look to solve the v62 regressions with the -stable fixes as a next step. Dave had agreed with th

[PULL] drm-intel-fixes

2022-07-17 Thread Rodrigo Vivi
Hi Dave and Daniel (and Linus), Our 'dim' flow has a problem with fixes of fixes getting missed. We need to take a look on that later. Meanwhile, please allow me to quickly propagate this fix here upstream. Here goes drm-intel-fixes-2022-07-17: - Fix 32b build Thanks, Rodrigo. The following c

Re: [Intel-gfx] [PATCH RFC] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-07-16 Thread Rodrigo Vivi
On Fri, Jul 15, 2022 at 09:26:16AM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > On Haswell, in particular, we see an issue where resets fails because Can we then make this platform specific? Only because some older hw doesn't behave like expected we shouldn't make this a default

Re: [PATCH v2 22/39] drm/i915: stop using kernel-doc markups for something else

2022-07-16 Thread Rodrigo Vivi
markups. > > Signed-off-by: Mauro Carvalho Chehab \o/ Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/all/cover.1657699522.git.mche...@k

Re: [PATCH v2 25/39] drm/i915: i915_vma_resource.c: fix some kernel-doc markups

2022-07-16 Thread Rodrigo Vivi
.. So, replace them by a different Sphinx-compatible tag. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kern

Re: [Intel-gfx] [PATCH v2 16/39] drm/i915: intel_fb: fix a kernel-doc issue with Sphinx

2022-07-16 Thread Rodrigo Vivi
WARNING: Inline strong > start-string without end-string. > > Signed-off-by: Mauro Carvalho Chehab Just trying to understand as well on why in a few you had chosen ```foo``` and here **foo**. why? anyway, not a blocker: Reviewed-by: Rodrigo Vivi > --- > > To avoid mail

Re: [Intel-gfx] [PATCH v2 26/39] drm/i915: i915_gem.c fix a kernel-doc issue

2022-07-16 Thread Rodrigo Vivi
the data field, as expected by kernel-doc. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/a

Re: [Intel-gfx] [PATCH v2 20/39] drm/i915: i915_gem_wait.c: fix a kernel-doc markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:08AM +0100, Mauro Carvalho Chehab wrote: > The return codes for i915_gem_wait_ioctl() have identation issues, > and will be displayed on a very confusing way. Use lists to improve > its output. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-b

Re: [PATCH v2 23/39] drm/i915: dvo_ch7xxx.c: use SPDX header

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:11AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of

Re: [PATCH v2 21/39] drm/i915: fix i915_gem_ttm_move.c DOC: markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:09AM +0100, Mauro Carvalho Chehab wrote: > The doc markup should not end with ":", as it would generate a > warning on Sphinx while generating the cross-reference tag. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH v2 28/39] drm/i915: i915_deps: use a shorter title markup

2022-07-16 Thread Rodrigo Vivi
> > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/all/cover.1657699522.git.mche...@ke

Re: [Intel-gfx] [PATCH v2 13/39] drm/i915: i915_gpu_error.c: document dump_flags

2022-07-16 Thread Rodrigo Vivi
915_vma_destroy_locked one? That was also a new introduction. Should we bother with the Fixes anyway since there were many broken already? And if we do, shouldn't we add to the others? But anyway, just trying to understand the differences and reasons, because the patch is correct: Reviewed-by

Re: [Intel-gfx] [PATCH v2 14/39] drm/i915: document kernel-doc trivial issues

2022-07-16 Thread Rodrigo Vivi
pu/drm/i915/gt/intel_engine_types.h:276: warning: Function > parameter or member 'preempt_hang' not described in 'intel_engine_execlists' > > That are due undocumented parameters. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi

Re: [PATCH v2 17/39] drm/i915: skl_scaler: fix return value kernel-doc markup

2022-07-16 Thread Rodrigo Vivi
> Use list markups to suppress the warning. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://

Re: [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large n

Re: [PATCH v2 27/39] drm/i915: i915_scatterlist.h: fix some kernel-doc markups

2022-07-16 Thread Rodrigo Vivi
; That's because @foo evaluates into **foo**, and placing anything > after it without spaces cause Sphinx to warn and do the wrong > thing.. So, replace them by a different Sphinx-compatible tag. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > T

Re: [Intel-gfx] [PATCH v2 09/39] drm/i915: intel_wakeref.h: fix some kernel-doc markups

2022-07-13 Thread Rodrigo Vivi
ntel_wakeref_get_if_active(). > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the cover. > See [PATCH v2 00/39] at: > https://lore.kernel.org/all/co

Re: [PATCH v2 07/39] drm/i915: gvt: fix kernel-doc trivial warnings

2022-07-13 Thread Rodrigo Vivi
_deactivate_vgpu() > instead > drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for > intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() > instead > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- &g

Re: [Intel-gfx] [PATCH v2 06/39] drm/i915: gt: fix some Kernel-doc issues

2022-07-13 Thread Rodrigo Vivi
> struct file; > > -/** > +/* > * struct __guc_capture_bufstate > * > * Book-keeping structure used to track read and write pointers > @@ -26,7 +26,7 @@ struct __guc_capture_bufstate { > u32 wr; > }; > > -/** > +/* > * struct __guc_c

Re: [PATCH v2 05/39] drm/i915: display: fix kernel-doc markup warnings

2022-07-13 Thread Rodrigo Vivi
gt; +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -685,7 +685,7 @@ intel_display_power_put_async_work(struct work_struct > *work) > } > > /** > - * intel_display_power_put_async - release a power domain reference > asynchronously > + * __intel_display_power_

Re: [PATCH v2 03/39] drm/i915/gvt: Fix kernel-doc for intel_vgpu_*_resource()

2022-07-13 Thread Rodrigo Vivi
rture_gm.c > +++ b/drivers/gpu/drm/i915/gvt/aperture_gm.c > @@ -298,7 +298,7 @@ static int alloc_resource(struct intel_vgpu *vgpu, > } > > /** > - * inte_gvt_free_vgpu_resource - free HW resource owned by a vGPU > + * intel_vgpu_free_resource() - free HW resource owned by a vGPU

Re: [PATCH v2 04/39] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

2022-07-13 Thread Rodrigo Vivi
t described in '__wait_for' > drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or > member 'US' not described in '__wait_for' > drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or > member 

Re: [PATCH v2 01/39] drm/i915/gvt: Fix kernel-doc for intel_gvt_switch_mmio()

2022-07-13 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 05:54:44PM -0400, Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:11:49AM +0100, Mauro Carvalho Chehab wrote: > > From: Jiapeng Chong > > > > Fix the following W=1 kernel warnings: > > > > drivers/gpu/drm/i915/gvt/mmio_context.c:560: war

Re: [Intel-gfx] [PATCH v2 02/39] drm/i915/gvt: Fix kernel-doc for intel_vgpu_default_mmio_write

2022-07-13 Thread Rodrigo Vivi
Prototype was for > intel_vgpu_default_mmio_write() instead. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > Acked-by: Zhenyu Wang > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists we

Re: [PATCH v2 01/39] drm/i915/gvt: Fix kernel-doc for intel_gvt_switch_mmio()

2022-07-13 Thread Rodrigo Vivi
intel_gvt_switch_mmio() instead. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > Acked-by: Zhenyu Wang > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing lists were C

[PULL] drm-intel-fixes

2022-07-13 Thread Rodrigo Vivi
Auld (1): drm/i915/ttm: fix sg_table construction Rodrigo Vivi (1): Merge tag 'gvt-fixes-2022-07-11' of https://github.com/intel/gvt-linux into drm-intel-fixes Thomas Hellström (1): drm/i915: Fix vm use-after-free in vma destruction drivers/gpu/drm/i915/display/inte

[PULL] drm-intel-gt-next

2022-07-13 Thread Rodrigo Vivi
Hi Dave and Daniel, On behalf of Tvrtko, who is recovering from Covid, here goes the latest drm-intel-gt-next pull request targeting 5.20. Thanks, Rodrigo. Driver uAPI changes: - All related to the Small BAR support: (and all by Matt Auld) * add probed_cpu_visible_size * expose the avail memor

Re: [PATCH v5 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-07-12 Thread Rodrigo Vivi
On Tue, Jul 12, 2022 at 04:21:33PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Avoid trying to invalidate the TLB in the middle of performing an > engine reset, as this may result in the reset timing out. Currently, > the TLB invalidate is only serialised by its own mutex, forgoi

<    1   2   3   4   5   6   7   8   9   10   >