value is not checked.
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Reviewed-by: Hans Verkuil
Reviewed-by: Lyude Paul
Reported-by: kernel test robot
Signed-off-by: Sam McNally
---
Changes in v7:
- Added mutex_init() fo
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Reviewed-by: Lyude Paul
Signed-off-by: Sam McNally
---
(no changes since v4)
Changes in v4:
- Changed logging to use drm_dbg_kms()
- Added self
for the self-tests.
Add self-tests for CONNECTION_STATUS_NOTIFY and RESOURCE_STATUS_NOTIFY.
Reviewed-by: Lyude Paul
Signed-off-by: Sam McNally
---
(no changes since v5)
Changes in v5:
- Set mock device name to more clearly attribute error/debug logging to
the self-test, in particular for
value is not checked.
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Reviewed-by: Hans Verkuil
Reviewed-by: Lyude Paul
Reported-by: kernel test robot
Signed-off-by: Sam McNally
---
Changes in v6:
- Removed superfluous #in
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Reviewed-by: Lyude Paul
Signed-off-by: Sam McNally
---
(no changes since v4)
Changes in v4:
- Changed logging to use drm_dbg_kms()
- Added self
for the self-tests.
Add self-tests for CONNECTION_STATUS_NOTIFY and RESOURCE_STATUS_NOTIFY.
Reviewed-by: Lyude Paul
Signed-off-by: Sam McNally
---
(no changes since v5)
Changes in v5:
- Set mock device name to more clearly attribute error/debug logging to
the self-test, in particular for
value is not checked.
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Reviewed-by: Hans Verkuil
Signed-off-by: Sam McNally
---
(no changes since v4)
Changes in v4:
- Removed use of work queues
- Updated checks of aux.transf
for the self-tests.
Add self-tests for CONNECTION_STATUS_NOTIFY and RESOURCE_STATUS_NOTIFY.
Signed-off-by: Sam McNally
---
Changes in v5:
- Set mock device name to more clearly attribute error/debug logging to
the self-test, in particular for cases where failures are expected
Changes in v4
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Signed-off-by: Sam McNally
---
(no changes since v4)
Changes in v4:
- Changed logging to use drm_dbg_kms()
- Added self-test
drivers/gpu/drm
otify parse length fail 2
1
[ 25.163730] [drm_dp_mst_helper] expected parse failure: [drm]
*ERROR* Got unknown request 0x23 (REMOTE_I2C_WRITE)
>
> On Tue, 2021-05-18 at 22:35 +1000, Sam McNally wrote:
> Up requests are decoded by drm_dp_sideband_parse_req(), which operates
> on a drm
value is not checked.
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Reviewed-by: Hans Verkuil
Signed-off-by: Sam McNally
---
Changes in v4:
- Removed use of work queues
- Updated checks of aux.transfer to accept aux.is_r
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Signed-off-by: Sam McNally
---
Changes in v4:
- Changed logging to use drm_dbg_kms()
- Added self-test
drivers/gpu/drm/drm_dp_mst_topology.c
-off-by: Sam McNally
---
Changes in v4:
- New in v4
drivers/gpu/drm/drm_dp_mst_topology.c | 54 ++-
.../gpu/drm/drm_dp_mst_topology_internal.h| 4 +
.../drm/selftests/test-drm_dp_mst_helper.c| 147 --
3 files changed, 190 insertions(+), 15 deletions(-)
diff
On Tue, 2 Feb 2021 at 09:03, Lyude Paul wrote:
>
> On Wed, 2020-09-23 at 12:13 +1000, Sam McNally wrote:
> > From: Hans Verkuil
> >
> > These are required for the CEC MST support.
> >
> > Signed-off-by: Hans Verkuil
> > Signed-off-by: Sam McN
On Thu, 4 Feb 2021 at 21:42, Hans Verkuil wrote:
>
> On 23/09/2020 04:13, Sam McNally wrote:
> > With DP v2.0 errata E5, CEC tunneling can be supported through an MST
> > topology.
> >
> > There are some minor differences for CEC tunneling through an MST
> > t
On Thu, 4 Feb 2021 at 21:19, Hans Verkuil wrote:
>
> On 01/02/2021 23:13, Ville Syrjälä wrote:
> > On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam McNally wrote:
> >> From: Hans Verkuil
> >>
> >> For adapters behind an MST hub use the correct AUX channel
this series if it wasn't for the fact that I do not have any hardware to
> test
> this with.
>
> Regards,
>
> Hans
>
> On 01/02/2021 22:56, Lyude Paul wrote:
> > On Wed, 2020-09-23 at 12:13 +1000, Sam McNally wrote:
> >> Sink event notify messages a
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++-
include/drm
held preclude HPD handling, are deferred to avoid
remote DPCD access which would block until HPD handling is performed
or a timeout
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Reviewed-by: Hans Verkuil
Signed-off-by
From: Hans Verkuil
For adapters behind an MST hub use the correct AUX channel.
Signed-off-by: Hans Verkuil
[sa...@chromium.org: rebased, removing redundant changes]
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 36
From: Hans Verkuil
These are required for the CEC MST support.
Signed-off-by: Hans Verkuil
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++
include/drm/drm_dp_mst_helper.h | 4
2 files changed, 6 insertions(+), 4 deletions
sysfs created by drm_connector"), creating sysfs ddc links to the
associated i2c device for MST DP connectors.
If the connector is created and registered before the i2c device, create
the link when registering the i2c device; otherwise, create the link
after registering the connector.
Signed-o
held preclude HPD handling, are deferred to avoid
remote DPCD access which would block until HPD handling is performed
or a timeout
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Signed-off-by: Sam McNally
---
Changes
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++-
include/drm
From: Hans Verkuil
These are required for the CEC MST support.
Signed-off-by: Hans Verkuil
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++
include/drm/drm_dp_mst_helper.h | 4
2 files changed, 6 insertions(+), 4 deletions
From: Hans Verkuil
For adapters behind an MST hub use the correct AUX channel.
Signed-off-by: Hans Verkuil
[sa...@chromium.org: rebased, removing redundant changes]
Signed-off-by: Sam McNally
---
(no changes since v1)
drivers/gpu/drm/drm_dp_mst_topology.c | 36
On Tue, 8 Sep 2020 at 18:08, Hans Verkuil wrote:
>
> Hi Sam,
>
> On 01/09/2020 08:22, Sam McNally wrote:
> > With DP v2.0 errata E5, CEC tunneling can be supported through an MST
> > topology.
>
> Oh wow, this is finally supported in the spec. Very nice to see this
On Tue, 8 Sep 2020 at 18:41, Hans Verkuil wrote:
>
> On 01/09/2020 08:22, Sam McNally wrote:
> > From: Hans Verkuil
> >
> > Signed-off-by: Hans Verkuil
> > [sa...@chromium.org:
> > - rebased
> > - removed polling-related changes
> > - moved
On Wed, 2 Sep 2020 at 04:12, Lyude Paul wrote:
>
> Super minor nitpicks:
>
> On Tue, 2020-09-01 at 16:22 +1000, Sam McNally wrote:
> > From: Hans Verkuil
> >
> > Signed-off-by: Hans Verkuil
> > [sa...@chromium.org:
> > - rebased
> > - removed p
From: Hans Verkuil
Signed-off-by: Hans Verkuil
[sa...@chromium.org:
- rebased
- removed polling-related changes
- moved the calls to drm_dp_cec_(un)set_edid() into the next patch
]
Signed-off-by: Sam McNally
---
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
drivers/gpu/drm
held preclude HPD handling, are deferred to avoid
remote DPCD access which would block until HPD handling is performed
or a timeout
Register and unregister for all MST connectors, ensuring their
drm_dp_aux_cec struct won't be accessed uninitialized.
Signed-off-by: Sam McNally
---
driver
From: Hans Verkuil
For adapters behind an MST hub use the correct AUX channel.
Signed-off-by: Hans Verkuil
[sa...@chromium.org: rebased, removing redundant changes]
Signed-off-by: Sam McNally
---
drivers/gpu/drm/drm_dp_mst_topology.c | 36 +++
1 file changed, 36
Sink event notify messages are used for MST CEC IRQs. Add parsing
support for sink event notify messages in preparation for handling MST
CEC IRQs.
Signed-off-by: Sam McNally
---
drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++-
include/drm/drm_dp_mst_helper.h | 14
From: Hans Verkuil
These are required for the CEC MST support.
Signed-off-by: Hans Verkuil
Signed-off-by: Sam McNally
---
drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++
include/drm/drm_dp_mst_helper.h | 4
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers
Thanks for the feedback.
On Sat, 15 Aug 2020 at 01:00, Imre Deak wrote:
>
> On Wed, Jul 29, 2020 at 04:15:28PM +1000, Sam McNally wrote:
> > As of commit d8bd15b37d32 ("drm/dp_mst: Fix the DDC I2C device
> > registration of an MST port"), DP MST DDC I2C devices are
eated and registered before the i2c device, create
the link when registering the i2c device; otherwise, create the link
during late connector registration.
Signed-off-by: Sam McNally
---
drivers/gpu/drm/drm_dp_mst_topology.c | 29 +--
1 file changed, 27 insertions(+),
r, so this is sufficient.
For i2c transfers meeting the above criteria, generate and send a remote
i2c write message for each transaction. Add the trivial remote i2c write
reply parsing support so remote i2c write acks bubble up correctly.
Signed-off-by: Sam McNally
---
drivers/gp
37 matches
Mail list logo
