Re: [PATCH 00/12] ARM: davinci: da850-evm: remove more legacy GPIO calls

2019-07-01 Thread Sekhar Nori
Hi Lee, Daniel, Jingoo, On 25/06/19 10:04 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is another small step on the path to liberating davinci from legacy > GPIO API calls and shrinking the davinci GPIO driver by not having to > support the base GPIO number anymore. > > T

Re: [PATCH v4 0/5] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-22 Thread Sekhar Nori
On Monday 07 August 2017 11:09 PM, David Lechner wrote: > ARM: dts: da850-lego-ev3: Add node for LCD display > ARM: davinci_all_defconfig: enable tinydrm and ST7586 Queuing these two patches (4/5 and 5/5) through davinci tree. Thanks, Sekhar ___ dr

[PATCH] ARM: davinci_all_defconfig: enable dumb vga-dac drm bridge

2017-01-03 Thread Sekhar Nori
On Friday 25 November 2016 02:43 PM, Bartosz Golaszewski wrote: > This enables the dumb-vga-dac driver by default for davinci boards. > > The driver is needed for tilcdc support on da850-lcdk board. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/configs/davinci_all_defconfig | 2 ++ >

[PATCH v7 3/5] drm: bridge: add support for TI ths8135

2017-01-03 Thread Sekhar Nori
On Tuesday 03 January 2017 10:56 AM, Archit Taneja wrote: > Hi Sekhar, > > On 1/2/2017 4:38 PM, Sekhar Nori wrote: >> Hi Archit, >> >> On Wednesday 14 December 2016 10:35 AM, Archit Taneja wrote: >>> >>> >>> On 12/13/2016 03:39 PM, Bartosz G

[PATCH v7 5/5] ARM: dts: da850: specify the maximum pixel clock rate for tilcdc

2017-01-02 Thread Sekhar Nori
On Tuesday 13 December 2016 03:39 PM, Bartosz Golaszewski wrote: > At maximum CPU frequency of 300 MHz the maximum pixel clock frequency > is 37.5 MHz[1]. We must filter out any mode for which the calculated > pixel clock rate would exceed this value. > > Specify the max-pixelclock property for th

[PATCH v7 4/5] ARM: dts: da850-lcdk: add the vga-bridge node

2017-01-02 Thread Sekhar Nori
On Wednesday 14 December 2016 03:24 PM, Tomi Valkeinen wrote: > On 13/12/16 12:09, Bartosz Golaszewski wrote: >> Add the vga-bridge node to the board DT together with corresponding >> ports and vga connector. This allows to retrieve the edid info from >> the display automatically. >> >> Signed-off-

[PATCH v7 3/5] drm: bridge: add support for TI ths8135

2017-01-02 Thread Sekhar Nori
Hi Archit, On Wednesday 14 December 2016 10:35 AM, Archit Taneja wrote: > > > On 12/13/2016 03:39 PM, Bartosz Golaszewski wrote: >> THS8135 is a configurable video DAC, but no configuration is actually >> necessary to make it work. >> >> For now use the dumb-vga-dac driver to support it. > > Qu

[PATCH v7 1/5] ARM: dts: da850: rename the display node label

2017-01-02 Thread Sekhar Nori
On Wednesday 14 December 2016 03:27 PM, Tomi Valkeinen wrote: > On 13/12/16 12:09, Bartosz Golaszewski wrote: >> The tilcdc node name is 'display' as per the ePAPR 1.1 recommendation. >> The label is also 'display', but change it to 'lcdc' to make it clear >> what the underlying hardware is. >> >>

[PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node

2016-12-06 Thread Sekhar Nori
On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: > 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen : >> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>> Add the dumb-vga-dac node to the board DT together with corresponding >>> ports and vga connector. This allows to retrieve the edid inf

[PATCH v2 2/2] ARM: dts: da850-lcdk: specify the maximum pixel clock rate for tilcdc

2016-11-29 Thread Sekhar Nori
On Monday 28 November 2016 05:45 PM, Bartosz Golaszewski wrote: > Due to memory throughput constraints any display mode for which the > pixel clock rate exceeds the recommended value of 37500 KHz must be > filtered out. I think there might be more reasons than memory throughput constraints for the

[PATCH] ARM: dts: da850: specify the maximum bandwidth for tilcdc

2016-11-28 Thread Sekhar Nori
On Monday 28 November 2016 01:12 PM, Tomi Valkeinen wrote: > On 28/11/16 07:24, Sekhar Nori wrote: >> On Friday 25 November 2016 09:07 PM, Bartosz Golaszewski wrote: >>> It has been determined that the maximum resolution supported correctly >>> by tilcdc rev1 on da850 So

[PATCH] ARM: dts: da850: enable the memctrl and mstpri nodes per board

2016-11-28 Thread Sekhar Nori
On Thursday 24 November 2016 03:01 PM, Bartosz Golaszewski wrote: > Currently the memory controller and master priorities drivers are > enabled in da850.dtsi. For boards for which there are no settings > defined, this makes these drivers emit error messages. > > Disable the nodes in da850.dtsi and

[PATCH] ARM: dts: da850: specify the maximum bandwidth for tilcdc

2016-11-28 Thread Sekhar Nori
On Friday 25 November 2016 09:07 PM, Bartosz Golaszewski wrote: > It has been determined that the maximum resolution supported correctly > by tilcdc rev1 on da850 SoCs is 800x600 at 60. Due to memory throughput > constraints we must filter out higher modes. > > Specify the max-bandwidth property f

[PATCH v4 0/2] da8xx: fix section mismatch in new drivers

2016-11-24 Thread Sekhar Nori
On Wednesday 23 November 2016 07:09 PM, Bartosz Golaszewski wrote: > Sekhar noticed there's a section mismatch in the da8xx-mstpri and > da8xx-ddrctl drivers. This is caused by calling > of_flat_dt_get_machine_name() which has an __init annotation. > > This series makes the drivers drop the call a

[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-24 Thread Sekhar Nori
On Thursday 24 November 2016 04:18 AM, David Lechner wrote: > On 11/23/2016 04:32 PM, Kevin Hilman wrote: >> David Lechner writes: >> >>> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: 2016-11-22 23:23 GMT+01:00 David Lechner : > On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:

[PATCH v3 1/3] bus: da8xx-mstpri: drop the call to of_flat_dt_get_machine_name()

2016-11-23 Thread Sekhar Nori
Hi Bartosz, On Wednesday 23 November 2016 04:36 PM, Bartosz Golaszewski wrote: > In order to avoid a section mismatch use a locally implemented routine > instead of of_flat_dt_get_machine_name() when printing the error > message. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/bus/da8xx-

[PATCH 1/3] of: base: add support to get machine compatible string

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 05:37 PM, Sudeep Holla wrote: >> So, the if(!of_node_get()) is just an expensive NULL pointer check. I >> think >> it is better to be explicit about it by not using of_node_get/put() at >> all. >> How about: >> > > Are we planning to use this in any time sensitive pat

[PATCH 1/3] of: base: add support to get machine compatible string

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 03:35 PM, Sudeep Holla wrote: > > > On 23/11/16 07:49, Sekhar Nori wrote: >> On Tuesday 22 November 2016 09:16 PM, Sudeep Holla wrote: >>> Hi Sekhar, >>> >>> On 22/11/16 15:06, Sekhar Nori wrote: >>>> Hi Sudeep,

[PATCH 1/3] of: base: add support to get machine compatible string

2016-11-23 Thread Sekhar Nori
On Tuesday 22 November 2016 09:16 PM, Sudeep Holla wrote: > Hi Sekhar, > > On 22/11/16 15:06, Sekhar Nori wrote: >> Hi Sudeep, >> >> On Tuesday 22 November 2016 04:23 PM, Sudeep Holla wrote: >>> >>> >>> On 22/11/16 10:41, Bartosz Golaszews

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Sekhar Nori
On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: > Please note that the compatible property might contain several strings, not > just > a single string. So I guess the best thing to do is to use of_property_read_string_index() and print the sting at index 0. Thanks, Sekhar

[PATCH 1/3] of: base: add support to get machine compatible string

2016-11-22 Thread Sekhar Nori
Hi Sudeep, On Tuesday 22 November 2016 04:23 PM, Sudeep Holla wrote: > > > On 22/11/16 10:41, Bartosz Golaszewski wrote: >> Add a function allowing to retrieve the compatible string of the root >> node of the device tree. >> > > Rob has queued [1] and it's in -next today. You can reuse that if

[PATCH 1/3] of: base: add support to get machine compatible string

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 04:36 PM, Sudeep Holla wrote: > > > On 22/11/16 10:57, Bartosz Golaszewski wrote: >> 2016-11-22 11:53 GMT+01:00 Sudeep Holla : >>> >>> >>> On 22/11/16 10:41, Bartosz Golaszewski wrote: Add a function allowing to retrieve the compatible string of the root

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Sekhar Nori
Hi Frank, On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: > On 11/21/16 08:33, Sekhar Nori wrote: >> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >>> +static int da8xx_ddrctl_probe(struct platform_device *pdev) >>> +{ >>> + const s

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > +static int da8xx_ddrctl_probe(struct platform_device *pdev) > +{ > + const struct da8xx_ddrctl_config_knob *knob; > + const struct da8xx_ddrctl_setting *setting; > + struct device_node *node; > + struct resource *res;

[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-16 Thread Sekhar Nori
On Tuesday 15 November 2016 04:30 PM, Bartosz Golaszewski wrote: > Add the nodes for the MSTPRI configuration and DDR2/mDDR memory > controller drivers to da850.dtsi. > > Signed-off-by: Bartosz Golaszewski Applied to v4.10/dt Thanks, Sekhar

[PATCH 2/2] ARM: davinci_all_defconfig: enable the mstpri and ddrctl drivers

2016-11-15 Thread Sekhar Nori
On Monday 14 November 2016 11:02 PM, Bartosz Golaszewski wrote: > With the da8xx memory controller and master peripheral priority > drivers merged and corresponding device tree changes in place we can > now enable appropriate options by default. > > Signed-off-by: Bartosz Golaszewski Applied to

[PATCH 1/2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-15 Thread Sekhar Nori
On Monday 14 November 2016 11:02 PM, Bartosz Golaszewski wrote: > Add the nodes for the MSTPRI configuration and DDR2/mDDR memory > controller drivers to da850.dtsi. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/boot/dts/da850.dtsi | 9 + > 1 file changed, 9 insertions(+) > >

[PATCH v2 2/5] ARM: bus: da8xx-mstpri: new driver

2016-11-11 Thread Sekhar Nori
On Wednesday 09 November 2016 11:54 PM, Rob Herring wrote: > On Mon, Oct 31, 2016 at 03:45:35PM +0100, Bartosz Golaszewski wrote: >> Create the driver for the da8xx master peripheral priority >> configuration and implement support for writing to the three >> Master Priority registers on da850 SoCs.

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-11 Thread Sekhar Nori
On Wednesday 09 November 2016 11:54 PM, Rob Herring wrote: > On Mon, Oct 31, 2016 at 03:45:34PM +0100, Bartosz Golaszewski wrote: >> Create a new driver for the da8xx DDR2/mDDR controller and implement >> support for writing to the Peripheral Bus Burst Priority Register. >> >> Signed-off-by: Bartos

[PATCH v2 0/5] ARM: da850: new drivers for better LCDC support

2016-11-08 Thread Sekhar Nori
+ Arnd, Olof On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > This series adds two new drivers in order to better support the LCDC > rev1 present on the da850 boards. > > The first patch adds a new memory driver which allows to write to the > DDR2/mDDR memory controller present on

[PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node

2016-11-01 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > The tilcdc driver is not yet ready for working together with the > dumb-vga-dac drm bridge. While the work on enabling drm_bridge > support in tilcdc continues, enable the VGA connector on da850-lcdk > with the following workaround: u

[PATCH v2 2/5] ARM: bus: da8xx-mstpri: new driver

2016-11-01 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > Create the driver for the da8xx master peripheral priority > configuration and implement support for writing to the three > Master Priority registers on da850 SoCs. > > Signed-off-by: Bartosz Golaszewski Reviewed-

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-01 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > Create a new driver for the da8xx DDR2/mDDR controller and implement > support for writing to the Peripheral Bus Burst Priority Register. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Sekhar Nori Thanks, Sekhar

[PATCH 2/2] ARM: bus: da8xx-mstpri: new driver

2016-10-31 Thread Sekhar Nori
On Monday 31 October 2016 03:24 PM, Bartosz Golaszewski wrote: > 2016-10-31 10:52 GMT+01:00 Sekhar Nori : >> Hi Bartosz, >> >> On Monday 31 October 2016 03:10 PM, Bartosz Golaszewski wrote: >>> 2016-10-31 5:30 GMT+01:00 Rob Herring : >>>> On Wed,

[PATCH 2/2] ARM: bus: da8xx-mstpri: new driver

2016-10-31 Thread Sekhar Nori
Hi Bartosz, On Monday 31 October 2016 03:10 PM, Bartosz Golaszewski wrote: > 2016-10-31 5:30 GMT+01:00 Rob Herring : >> On Wed, Oct 26, 2016 at 07:35:55PM +0200, Bartosz Golaszewski wrote: >>> Create the driver for the da8xx master peripheral priority >>> configuration and implement support for wr

[PATCH 2/3] ARM: bus: da8xx-syscfg: new driver

2016-10-21 Thread Sekhar Nori
On Friday 21 October 2016 02:55 PM, Tomi Valkeinen wrote: > On 20/10/16 22:39, Kevin Hilman wrote: > >> However, after our discussion on IRC, we'll respin this without the DT >> bindings at all. Next version will just use static configuration data >> in the drivers/bus driver based on SoC compati

[PATCH 2/2] ARM: dts: da850: add a node for the LCD controller

2016-10-20 Thread Sekhar Nori
On Thursday 20 October 2016 03:51 PM, Tomi Valkeinen wrote: > On 20/10/16 13:07, Sekhar Nori wrote: > >> Per me, compatible property is an ordered list precisely for the reason >> that things should continue to "work" with as closely matched driver as >> possibl

[PATCH 2/2] ARM: dts: da850: add a node for the LCD controller

2016-10-20 Thread Sekhar Nori
On Monday 17 October 2016 07:31 PM, Bartosz Golaszewski wrote: > 2016-10-17 14:29 GMT+02:00 Tomi Valkeinen : >> On 17/10/16 14:40, Laurent Pinchart wrote: >>> Hello, >>> >>> On Monday 17 Oct 2016 10:33:58 Tomi Valkeinen wrote: >>>> On 17/10/16 10:1

[PATCH 2/2] ARM: dts: da850: add a node for the LCD controller

2016-10-17 Thread Sekhar Nori
On Monday 17 October 2016 11:26 AM, Tomi Valkeinen wrote: > On 15/10/16 20:42, Sekhar Nori wrote: > >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>> index f79e1b9..32908ae 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >&

[PATCH 2/2] ARM: dts: da850: add a node for the LCD controller

2016-10-15 Thread Sekhar Nori
d the commit description > - changed the dt node name to a generic one > - added a da850-specific compatible string > - removed the tilcdc,panel node > - moved the pins definitions to da850.dtsi as suggested by > Sekhar Nori (was in: da850-lcdk.dts)] > Signed-off-by: Bartosz Gol

[PATCH v2] drm: tilcdc: add a da850-specific compatible string

2016-10-01 Thread Sekhar Nori
On Friday 30 September 2016 07:22 PM, Bartosz Golaszewski wrote: > Due to some potential tweaks for the da850 LCDC (for example: the > required memory bandwith settings) we need a separate compatible > for the IP present on the da850 boards. > > Suggested-by: Sekhar Nori > Sign

[PATCH] drm: tilcdc: add a da850-specific compatible string

2016-09-30 Thread Sekhar Nori
On Friday 30 September 2016 06:30 PM, Bartosz Golaszewski wrote: > Due to some potential tweaks for the da850 LCDC (for example: the > required memory bandwith settings) we need a separate compatible > for the IP present on the da850 boards. > > Suggested-by: Sekhar Nori > Sign

[PATCH] drm/tilcdc: free disp_clk when CONFIG_CPU_FREQ=n

2015-08-07 Thread Sekhar Nori
disp_clk is allocated irrespective of CPU_FREQ support so it must be freed irrespective of it. Fixes: b478e336b3e7 ("drm/tilcdc: Fix the error path in tilcdc_load()") Signed-off-by: Sekhar Nori --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Sekhar Nori
Hi Rob, On Monday, December 17, 2012, Rob Clark wrote: > On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark gmail.com> > wrote: > >> I'm not very enthusiastic about adding ti-lcdc specific panel/chip > >> drivers. It's not really a big deal if it's only kernel code, but you > >> add device-tree bindings

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Sekhar Nori
Hi Rob, On Monday, December 17, 2012, Rob Clark wrote: > On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark > > wrote: > >> I'm not very enthusiastic about adding ti-lcdc specific panel/chip > >> drivers. It's not really a big deal if it's only kernel code, but you > >> add device-tree bindings also, whi