Re: [PATCH] drm: Remove unused function rcar_cmm_write

2024-06-19 Thread Sergey Shtylyov
On 6/19/24 10:54 AM, Jiapeng Chong wrote: > The function are defined in the rcar_cmm.c file, but not called s/are/is/. > elsewhere, so delete the unused function. Anywhere, maybe? > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function > 'rcar_cmm_read'. > > Report

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-19 Thread Sergey Shtylyov
kernel on overflow. >>>> Might be architecture-depended too, but let's assume it >>>> can become zero, >>>> >>>>> It is necessary to prevent division by zero like in >>>>> fb_var_to_videomode(). >>>

Re: [PATCH AUTOSEL 6.5 35/52] fbdev: core: syscopyarea: fix sloppy typing

2023-10-30 Thread Sergey Shtylyov
On 10/30/23 1:53 AM, Sasha Levin wrote: > From: Sergey Shtylyov > > [ Upstream commit e8e4a470b677511f9d1ad4f3cef32adc1d9a60ca ] > > In sys_copyarea(), the local variable bits_per_line is needlessly typed as > *unsigned long* -- which is a 32-bit type on the 32-bit arches a

Re: [PATCH AUTOSEL 6.5 34/52] fbdev: core: cfbcopyarea: fix sloppy typing

2023-10-30 Thread Sergey Shtylyov
Hello! On 10/30/23 1:53 AM, Sasha Levin wrote: > From: Sergey Shtylyov > > [ Upstream commit 7f33df94cf0156f64eee9509bd9b4a178990f613 ] > > In cfb_copyarea(), the local variable bits_per_line is needlessly typed as > *unsigned long* -- which is a 32-bit type on the 32-bit a

[PATCH v2 2/2] video: fbdev: core: syscopyarea: fix sloppy typing

2023-10-13 Thread Sergey Shtylyov
a 32-bit *unsigned int* type should still be enough to store the # of bits per line. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov --- drivers/video/fbdev/core/syscopyarea.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v2 0/2] Fix sloppy typing in the FB area copying routines

2023-10-13 Thread Sergey Shtylyov
riable's value is derived from the __u32 typed fb_fix_screeninfo::line_length field (multiplied by 8u) and a 32-bit *unsigned int* type should still be enough to store the # of bits per line. Sergey Shtylyov (2): video: fbdev: core: cfbcopyarea: fix sloppy typing video: fbdev: core:

[PATCH v2 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-10-13 Thread Sergey Shtylyov
a 32-bit *unsigned int* type should still be enough to store the # of bits per line. Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov --- drivers/video/fbdev/core/cfbcopyarea.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-09-19 Thread Sergey Shtylyov
ace static >> analysis tool. >> >> Signed-off-by: Sergey Shtylyov >> Cc: sta...@vger.kernel.org >> --- >>   drivers/video/fbdev/core/cfbcopyarea.c | 5 +++-- >>   1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/fbd

[PATCH 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-09-18 Thread Sergey Shtylyov
variables -- which might be overflowed as well; declaring them as *unsigned long* should fix that too... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov Cc: sta...@vger.kernel.org --- drivers/video/fbdev/core

[PATCH 2/2] video: fbdev: core: syscopyarea: fix sloppy typing

2023-09-18 Thread Sergey Shtylyov
variables -- which might be overflowed as well; declaring them as *unsigned long* should fix that too... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Signed-off-by: Sergey Shtylyov Cc: sta...@vger.kernel.org --- drivers/video/fbdev/core

[PATCH 0/2] Fix sloppy typing in the area copy

2023-09-18 Thread Sergey Shtylyov
source files in question, so I decided to just CC sta...@vger.kernel.org, without the Fixes tags... Sergey Shtylyov (2): video: fbdev: core: cfbcopyarea: fix sloppy typing video: fbdev: core: syscopyarea: fix sloppy typing drivers/video/fbdev/core/cfbcopyarea.c | 5 +++-- drivers/video/fbdev/c

Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait

2023-01-09 Thread Sergey Shtylyov
On 1/9/23 6:33 AM, Byungchul Park wrote: > Makes Dept able to track dependencies by PG_{locked,writeback} waits. > > Signed-off-by: Byungchul Park > --- > mm/filemap.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/mm/filemap.c b/mm/filemap.c > index c4d4ace..b013a5b 100

Re: [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-20 Thread Sergey Shtylyov
Hello! On 10/20/22 1:37 PM, Thomas Zimmermann wrote: > Don't set struct drm_mode_config.output_poll_changed. It's used to > inform the fbdev console about conncetor changes. But as ingenic Connector. :-) > uses generic fbdev emulation, the console is being informed by the > DRM client helper

Re: [PATCH v2 1/3] media: vsp1: add premultiplied alpha support

2022-08-10 Thread Sergey Shtylyov
Hello! On 8/10/22 11:37 AM, Takanari Hayama wrote: > To support DRM blend mode in R-Car DU driver, we must be able to pass > a plane with the premultiplied alpha. Adding a new property to > vsp1_du_atomic_config allows the R-Car DU driver to pass the > premultiplied alpha plane. > > Signed-off-b

Re: [PATCH RFC v6 16/21] dept: Distinguish each work from another

2022-05-04 Thread Sergey Shtylyov
Hello! On 5/4/22 11:17 AM, Byungchul Park wrote: > Workqueue already provides concurrency control. By that, any wait in a > work doesn't prevents events in other works with the control enabled. > Thus, each work would better be considered a different context. > > So let Dept assign a different c

[PATCH v2 2/2] platform: make platform_get_irq_byname_optional() optional

2022-02-13 Thread Sergey Shtylyov
like: ret = platform_get_irq_byname_optional(...); if (ret < 0) return ret; if (ret > 0) ...we get an IRQ... Signed-off-by: Sergey Shtylyov --- Changes in version 2: - added the error check using dev_err_probe() to platform_get_irq_byname_opti

[PATCH 2/2] platform: make platform_get_irq_byname_optional() optional

2022-01-12 Thread Sergey Shtylyov
like: ret = platform_get_irq_byname_optional(...); if (ret < 0) return ret; if (ret > 0) ...we get an IRQ... Signed-off-by: Sergey Shtylyov --- drivers/base/platform.c | 13 ++--- drivers/gpu/drm/lima/lima_devic