Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-08-31 Thread Sidong Yang
On Mon, Aug 31, 2020 at 11:39:10AM +, Simon Ser wrote: > On Saturday, August 29, 2020 4:06 PM, Sidong Yang wrote: > > > Currently vkms module doesn't support gamma function for userspace. so igt > > subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling

[PATCH] drm/vkms: add support for gamma_set interface

2020-08-29 Thread Sidong Yang
tting gamma size. it pass the test after this patch. Cc: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c

[PATCH v3] drm/vkms: avoid warning in vkms_get_vblank_timestamp

2020-08-28 Thread Sidong Yang
692] ? tomoyo_file_ioctl+0x19/0x20 [106444.471694] __x64_sys_ioctl+0x96/0xd0 [106444.471697] do_syscall_64+0x37/0x80 [106444.471699] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Cc: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Melissa Wen Signed-off-by: Sidong Yang --- v3:

[PATCH v2] drm/vkms: avoid warning in vkms_get_vblank_timestamp

2020-08-26 Thread Sidong Yang
692] ? tomoyo_file_ioctl+0x19/0x20 [106444.471694] __x64_sys_ioctl+0x96/0xd0 [106444.471697] do_syscall_64+0x37/0x80 [106444.471699] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Signed-off-by: Sidong Yang --- v2: - modify commit message to make it a bit easier to understand. --- drivers/gpu

Re: [PATCH] drm/vkms: fix warning in vkms_get_vblank_timestamp

2020-08-26 Thread Sidong Yang
On Wed, Aug 26, 2020 at 05:49:54PM -0300, Melissa Wen wrote: Hi Melissa! Thanks for review. > Hi Sidong, > > Thanks for this patch. > > The code looks good to me; however, I see some issues in the patch > format and commit message. Please, see inline comments. > > On

[PATCH] drm/vkms: replace deprecated functions in vkms_driver

2020-08-26 Thread Sidong Yang
creating vkms_gem_object, vkms_gem_funcs is used for drm_gem_object.funcs. Cc: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Melissa Wen Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_drv.c | 8 drivers/gpu/drm/vkms/vkms_drv.h | 4 drivers/gpu/drm/vkms

[PATCH] drm/vkms: fix warning in vkms_get_vblank_timestamp

2020-08-25 Thread Sidong Yang
From: Sidong Yang , Haneen Mohammed When vkms_get_vblank_timestamp() is called very first time without enabling vblank before, vblank time has just intial value and it makes warning message. this patch prevents warning message by setting vblank time to current time. Cc: Daniel Vetter Cc

Re: [PATCH] drm/vkms: Use alpha value to blend values.

2020-08-25 Thread Sidong Yang
On Mon, Aug 24, 2020 at 11:15:01PM -0400, Rodrigo Siqueira wrote: > Hi Sidong, > > Thanks a lot for your patch and effort to improve VKMS. > > On 08/18, Sidong Yang wrote: > > I wrote this patch for TODO list in vkms documentation. > > > > Use alpha value to b

[PATCH] drm/vkms: Use alpha value to blend values.

2020-08-18 Thread Sidong Yang
I wrote this patch for TODO list in vkms documentation. Use alpha value to blend source value and destination value Instead of just overwrite with source value. Cc: Rodrigo Siqueira Cc: Haneen Mohammed Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 14

Re: [PATCH] drm/vkms: modify sequence disable/plane/enable in commit_tail

2020-08-07 Thread Sidong Yang
On Tue, Aug 04, 2020 at 11:33:51AM +0200, dan...@ffwll.ch wrote: > On Sat, Aug 01, 2020 at 04:30:23PM -0300, Melissa Wen wrote: > > On Wed, Jul 29, 2020 at 12:22 PM Sidong Yang wrote: > > > > > > This patch modifies function call sequence in commit tail. This is for &g

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-01 Thread Sidong Yang
On Fri, Jul 31, 2020 at 08:33:25PM +0200, Daniel Vetter wrote: > On Fri, Jul 31, 2020 at 6:47 PM Melissa Wen wrote: > > > > On 07/31, Sidong Yang wrote: > > > On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote: > > > > On Thu, Jul 30, 2020 at

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Sidong Yang
> > > > > > > On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > > > > > > > > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen > > > > > wrote: > > > > > > > > > > > > On 07/25, Daniel Vetter

[PATCH] drm/vkms: modify sequence disable/plane/enable in commit_tail

2020-07-29 Thread Sidong Yang
Cc: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_crtc.c | 5 + drivers/gpu/drm/vkms/vkms_drv.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/v

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-28 Thread Sidong Yang
On Sun, Jul 26, 2020 at 12:26:08PM +0200, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > > > No, this very first warning continues (only once) :( > > > > From here (drm_crtc_vblank_on): > > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-24 Thread Sidong Yang
On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > On 07/22, dan...@ffwll.ch wrote: > > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > > This patch adds a missing drm_crtc_vblank_put op to the pair > > >

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-20 Thread Sidong Yang
On Wed, Jul 15, 2020 at 06:08:44PM +0200, Daniel Vetter wrote: > On Wed, Jul 15, 2020 at 5:57 PM Melissa Wen wrote: > > > > On 07/15, Sidong Yang wrote: > > > On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > > > > On Tue, Jul 14, 2020 at

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-15 Thread Sidong Yang
7:20 AM Melissa Wen > > > > wrote: > > > > > > > > > > On 07/13, Daniel Vetter wrote: > > > > > > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > > > > > > > On 07/02, Daniel Vetter wrote: > > > &

[PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-01 Thread Sidong Yang
there is an error when igt test is run continuously. vkms_atomic_commit_tail() need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of vblank events. without this code, next atomic commit will not enable vblank and raise timeout error. Signed-off-by: Sidong Yang --- drivers

[PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Sidong Yang
ff-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 32 +++- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c index 4af2f19480f4..9d2a765ca1fb 100644 --- a/drivers/gpu/drm

Re: [PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-05-31 Thread Sidong Yang
On Sun, May 24, 2020 at 07:42:25AM +1000, David Airlie wrote: > On Sun, May 24, 2020 at 2:02 AM Sidong Yang wrote: > > > > Hi, Dave. > > > > I'm a newbie kernel developer interested in qxl driver. And I want to > > participate in > > contributing for Q

[PATCH] Documentation: Fix typo error in todo.rst

2020-05-28 Thread Sidong Yang
Change wrong function name drm_modest_lock_all() to drm_modeset_lock_all() Signed-off-by: Sidong Yang --- Documentation/gpu/todo.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 658b52f7ffc6..436489b53fea

[PATCH] drm/kms: Optimize compute_crc(), blend()

2020-05-28 Thread Sidong Yang
oping horizontally and increase it. It's better than calculating in every pixels. Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 32 +++- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drive

[PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-05-23 Thread Sidong Yang
k_all with helper function DRM_MODESET_LOCK_ALL_BEGIN/END. Signed-off-by: Sidong Yang --- drivers/gpu/drm/qxl/qxl_display.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 10

[PATCH] drm: Replace deprecated function in drm_crtc_helper

2020-05-20 Thread Sidong Yang
Replace deprecated function drm_modeset_lock/unlock_all with helper function DRM_MODESET_LOCK_ALL_BEGIN/END. Signed-off-by: Sidong Yang --- drivers/gpu/drm/drm_crtc_helper.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2] drm/vkms: Use alpha value to blend values.

2019-09-04 Thread Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value. Signed-off-by: Sidong Yang --- v1 -> v2: * Move variables to tighter scope. drivers/gpu/drm/vkms/vkms_composer.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) d

Re: [PATCH] drm/vkms: Use alpha value to blend values.

2019-09-04 Thread Sidong Yang
On Mon, Sep 02, 2019 at 03:28:58PM +0300, Ville Syrjälä wrote: > On Sat, Aug 31, 2019 at 06:25:46PM +0100, Sidong Yang wrote: > > Use alpha value to blend source value and destination value Instead of > > just overwrite with source value. > > > > Signed-off-by: Sidong

[PATCH] drm/vkms: Use alpha value to blend values.

2019-09-01 Thread Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value. Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b

[PATCH] drm/vkms: Use alpha value to blend values.

2019-08-31 Thread Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value. Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b

[PATCH] drm/msm: drop use of drmP.h

2019-08-27 Thread Sidong Yang
Drop use of deprecated drmP.h header file. Remove drmP.h includes and add some include headers for function or struct that used in code. Signed-off-by: Sidong Yang --- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 3 +++ drivers/gpu

Re: [PATCH] drm/arm: drop use of drmP.h

2019-08-18 Thread Sidong Yang
On Sat, Aug 17, 2019 at 06:35:49PM +0200, Sam Ravnborg wrote: > Hi Sidong > > On Sat, Aug 17, 2019 at 08:41:15AM +0100, Sidong Yang wrote: > > Drop use of deprecated drmP.h header file. > > Remove drmP.h includes and add some include headers for function or > &g

[PATCH] drm/arm: drop use of drmP.h

2019-08-17 Thread Sidong Yang
Drop use of deprecated drmP.h header file. Remove drmP.h includes and add some include headers for function or struct that used in code. --- drivers/gpu/drm/arm/hdlcd_crtc.c| 2 +- drivers/gpu/drm/arm/hdlcd_drv.c | 6 +- drivers/gpu/drm/arm/malidp_crtc.c | 4 +++- drivers/gpu/drm/arm

[PATCH] drm/vboxvideo: Avoid double check buffer_overflow in vbva_write()

2019-04-08 Thread Sidong Yang
In vbva_write(), We do not need to double check available chunk size if chunk is smaller than available buffer. Put the second if clause in the first if clause and avoid check twice. Signed-off-by: Sidong Yang --- drivers/gpu/drm/vboxvideo/vbva_base.c | 14 +++--- 1 file changed, 7