Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API

2024-05-23 Thread Simon Horman
[ resending as I mangled the previous attempt , sorry ] + Joe Perches On Wed, May 22, 2024 at 04:39:57PM -0700, Alexey Makhalov wrote: > Hi Simon, apologize for long delay > > On 5/11/24 8:02 AM, Simon Horman wrote: > > > diff --git a/arch/x86/include/asm/vmware.h b/ar

[no subject]

2024-05-23 Thread Simon Horman
5/11/24 8:02 AM, Simon Horman wrote: > > > diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h > > > > ... > > > > > +static inline > > > +unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1, > > > +

Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API

2024-05-11 Thread Simon Horman
On Mon, May 06, 2024 at 02:53:00PM -0700, Alexey Makhalov wrote: > Introduce vmware_hypercall family of functions. It is a common > implementation to be used by the VMware guest code and virtual > device drivers in architecture independent manner. > > The API consists of vmware_hypercallX and

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-07 Thread Simon Horman
On Thu, Apr 04, 2024 at 12:17:26PM -0700, Easwar Hariharan wrote: > On 4/2/2024 1:29 AM, Simon Horman wrote: > > On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > >>

Re: [PATCH v3 13/15] sh: Move defines needed for suppressing warning backtraces

2024-04-05 Thread Simon Horman
Prototype was for HAVE_BUG_FUNCTION() instead > > Move the defines above the kerneldoc entry for _EMIT_BUG_ENTRY > to make kerneldoc happy. > > Reported-by: Simon Horman > Cc: Simon Horman > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Signed-o

Re: [RFC PATCH net-next v8 06/14] page_pool: convert to use netmem

2024-04-03 Thread Simon Horman
On Tue, Apr 02, 2024 at 05:20:43PM -0700, Mina Almasry wrote: > Abstrace the memory type from the page_pool so we can later add support > for new memory types. Convert the page_pool to use the new netmem type > abstraction, rather than use struct page directly. > > As of this patch the netmem

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-02 Thread Simon Horman
rs of > I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > in the specification. > > Compile tested, no functionality changes intended > > [1]: > https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ > > Signed-off-by: Easwar Hariharan Reviewed-by: Simon Horman

Re: [RFC PATCH net-next v7 04/14] netdev: support binding dma-buf to netdevice

2024-03-28 Thread Simon Horman
On Thu, Mar 28, 2024 at 11:55:23AM -0700, Mina Almasry wrote: > On Thu, Mar 28, 2024 at 11:28 AM Simon Horman wrote: > > > > On Tue, Mar 26, 2024 at 03:50:35PM -0700, Mina Almasry wrote: > > > Add a netdev_dmabuf_binding struct which represents the > > > dma-buf-

Re: [RFC PATCH net-next v7 04/14] netdev: support binding dma-buf to netdevice

2024-03-28 Thread Simon Horman
On Tue, Mar 26, 2024 at 03:50:35PM -0700, Mina Almasry wrote: > Add a netdev_dmabuf_binding struct which represents the > dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to > rx queues on the netdevice. On the binding, the dma_buf_attach > & dma_buf_map_attachment will occur.

Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces

2024-03-27 Thread Simon Horman
On Wed, Mar 27, 2024 at 08:10:51AM -0700, Guenter Roeck wrote: > On 3/27/24 07:44, Simon Horman wrote: > > On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote: > > > Add name of functions triggering warning backtraces to the __bug_table > > > objec

Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces

2024-03-27 Thread Simon Horman
On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote: > Add name of functions triggering warning backtraces to the __bug_table > object section to enable support for suppressing WARNING backtraces. > > To limit image size impact, the pointer to the function name is only added > to the

Re: [PATCH] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-02-27 Thread Simon Horman
On Mon, Feb 26, 2024 at 06:48:25PM +0100, Julien Panis wrote: > Hello Simon, > > Thank you for the review. > > On 2/26/24 18:25, Simon Horman wrote: > > On Fri, Feb 23, 2024 at 12:01:37PM +0100, Julien Panis wrote: > > > This patch adds XDP (eXpress Data

Re: [PATCH] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-02-26 Thread Simon Horman
On Fri, Feb 23, 2024 at 12:01:37PM +0100, Julien Panis wrote: > This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW > Ethernet driver. The following features are implemented: > - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP, XDP_ABORTED) > - NETDEV_XDP_ACT_REDIRECT (XDP_REDIRECT) >

Re: [PATCH v4 2/6] x86/vmware: Introduce VMware hypercall API

2024-01-03 Thread Simon Horman
On Thu, Dec 28, 2023 at 11:24:17AM -0800, Alexey Makhalov wrote: > From: Alexey Makhalov > > Introduce vmware_hypercall family of functions. It is a common > implementation to be used by the VMware guest code and virtual > device drivers in architecture independent manner. > > The API consists

Re: [net-next v1 15/16] net: add devmem TCP documentation

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:46PM -0800, Mina Almasry wrote: > Signed-off-by: Mina Almasry > --- > Documentation/networking/devmem.rst | 270 > 1 file changed, 270 insertions(+) > create mode 100644 Documentation/networking/devmem.rst > > diff --git

Re: [net-next v1 14/16] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:45PM -0800, Mina Almasry wrote: > Add an interface for the user to notify the kernel that it is done > reading the devmem dmabuf frags returned as cmsg. The kernel will > drop the reference on the frags to make them available for re-use. > > Signed-off-by: Willem de

Re: [PATCH v2 3/4] drm/stm: dsi: expose DSI PHY internal clock

2023-12-08 Thread Simon Horman
On Mon, Dec 04, 2023 at 11:11:12AM +0100, Raphael Gallais-Pou wrote: ... > @@ -514,18 +675,40 @@ static int dw_mipi_dsi_stm_probe(struct platform_device > *pdev) > dsi->lane_max_kbps *= 2; > } > > - dw_mipi_dsi_stm_plat_data.base = dsi->base; > -

Re: [PATCH 4/6] input/vmmouse: Use vmware_hypercall API

2023-11-24 Thread Simon Horman
On Wed, Nov 22, 2023 at 03:30:49PM -0800, Alexey Makhalov wrote: > Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. > Eliminate arch specific code. No functional changes intended. > > Signed-off-by: Alexey Makhalov Hi Alexey, it is not strictly related to this patch, but I notice

Re: [V10 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-08-27 Thread Simon Horman
On Fri, Aug 25, 2023 at 04:38:39PM +0800, Evan Quan wrote: > Due to electrical and mechanical constraints in certain platform designs > there may be likely interference of relatively high-powered harmonics of > the (G-)DDR memory clocks with local radio module frequency bands used > by Wifi

Re: [PATCH V8 2/9] drivers core: add ACPI based WBRF mechanism introduced by AMD

2023-08-11 Thread Simon Horman
On Thu, Aug 10, 2023 at 03:37:56PM +0800, Evan Quan wrote: > AMD has introduced an ACPI based mechanism to support WBRF for some > platforms with AMD dGPU + WLAN. This needs support from BIOS equipped > with necessary AML implementations and dGPU firmwares. > > For those systems without the ACPI

Re: [PATCH V8 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-11 Thread Simon Horman
On Thu, Aug 10, 2023 at 03:38:00PM +0800, Evan Quan wrote: > With WBRF feature supported, as a driver responding to the frequencies, > amdgpu driver is able to do shadow pstate switching to mitigate possible > interference(between its (G-)DDR memory clocks and local radio module > frequency bands

Re: [PATCH v3 05/49] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-28 Thread Simon Horman
On Thu, Jul 27, 2023 at 04:04:18PM +0800, Qi Zheng wrote: > Currently, the shrinker instances can be divided into the following three > types: > > a) global shrinker instance statically defined in the kernel, such as >workingset_shadow_shrinker. > > b) global shrinker instance statically

Re: [PATCH v3 04/49] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations

2023-07-28 Thread Simon Horman
On Thu, Jul 27, 2023 at 04:04:17PM +0800, Qi Zheng wrote: > The debugfs_remove_recursive() will wait for debugfs_file_put() to return, > so the shrinker will not be freed when doing debugfs operations (such as > shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there > is no

Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-06-30 Thread Simon Horman
On Fri, Jun 30, 2023 at 06:32:32PM +0800, Evan Quan wrote: ... > diff --git a/include/linux/wbrf.h b/include/linux/wbrf.h > new file mode 100644 > index ..3ca95786cef5 > --- /dev/null > +++ b/include/linux/wbrf.h > @@ -0,0 +1,65 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > +

Re: [PATCH net-next v7 08/11] net: bcmasp: Add support for ethtool driver stats

2023-06-15 Thread Simon Horman
On Wed, Jun 14, 2023 at 03:30:17PM -0700, Justin Chen wrote: ... > +static void bcmasp_update_mib_counters(struct bcmasp_intf *intf) > +{ > + int i; > + > + for (i = 0; i < BCMASP_STATS_LEN; i++) { > + const struct bcmasp_stats *s; > + u32 offset, val; > +

Re: [PATCH v9 2/4] lib/ref_tracker: improve printing stats

2023-06-02 Thread Simon Horman
On Fri, Jun 02, 2023 at 12:21:34PM +0200, Andrzej Hajda wrote: > In case the library is tracking busy subsystem, simply > printing stack for every active reference will spam log > with long, hard to read, redundant stack traces. To improve > readabilty following changes have been made: Hi

Re: [PATCH net-next v4 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-05-24 Thread Simon Horman
d-off-by: Justin Chen > Reviewed-by: Andrew Lunn Reviewed-by: Simon Horman

Re: [PATCH net-next v4 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:45PM -0700, Justin Chen wrote: > Add mdio compat string for ASP 2.0 ethernet driver. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > Reviewed-by: Andrew Lunn Reviewed-by: Simon Horman

Re: [PATCH net-next v4 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:42PM -0700, Justin Chen wrote: > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Acked-by: Conor Dooley > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen Reviewed-by: Simon Horman

Re: [PATCH net-next v4 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers

2023-05-24 Thread Simon Horman
On Tue, May 23, 2023 at 02:53:47PM -0700, Justin Chen wrote: > Add maintainers entry for ASP 2.0 Ethernet driver. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen Reviewed-by: Simon Horman

Re: [PATCH net-next v4 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-24 Thread Simon Horman
; > - Wake-on-LAN using magic packets > - basic ethtool operations (link, counters, message level) > - MAC destination address filtering (promiscuous, ALL_MULTI, etc.) > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen Hi Justin, Reviewed-by: Simon Horman As I

Re: [PATCH net-next v3 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-22 Thread Simon Horman
On Fri, May 19, 2023 at 02:19:41PM -0700, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN

Re: [PATCH net-next v3 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-22 Thread Simon Horman
On Fri, May 19, 2023 at 02:19:41PM -0700, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN

Re: [PATCH 06/10] pcmcia: Add SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:02PM +0700, Bagas Sanjaya wrote: > Add SPDX identifier on remaining files untouched during previous > rounds of SPDX conversion while replacing boilerplate notice if any. Reviewed-by: Simon Horman

Re: [PATCH 09/10] udf: Replace license notice with SPDX identifier

2023-05-11 Thread Simon Horman
-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH 10/10] include: synclink: Replace GPL license notice with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:06PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL license notice with appropriate SPDX > identifier, which is GPL 1.0+. > > Signed-off-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:04PM +0700, Bagas Sanjaya wrote: > Many watchdog drivers's source files has already SPDX license > identifier, while some remaining doesn't. > > Convert notices on remaining files to SPDX identifier. Reviewed-by: Simon Horman

Re: [PATCH 05/10] net: ethernet: i825xx: Replace GPL boilerplate with SPDX identifier

2023-05-11 Thread Simon Horman
ald Becker > Cc: Michael Hipp > Cc: Simon Horman > Signed-off-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH 01/10] agp/amd64: Remove GPL distribution notice

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:57PM +0700, Bagas Sanjaya wrote: > There is already SPDX tag which does the job, so remove the redundant > notice. > > Cc: Christophe JAILLET > Signed-off-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH 07/10] drivers: staging: wlan-ng: Remove GPL/MPL boilerplate

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:03PM +0700, Bagas Sanjaya wrote: > Remove the license boilerplate as there is already SPDX license > identifier which fulfills the same intention as the boilerplate. Reviewed-by: Simon Horman

Re: [PATCH 03/10] net: bonding: Add SPDX identifier to remaining files

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:59PM +0700, Bagas Sanjaya wrote: > Previous batches of SPDX conversion missed bond_main.c and bonding_priv.h > because these files doesn't mention intended GPL version. Add SPDX identifier > to these files, assuming GPL 1.0+. Reviewed-by: Simon Horman

Re: [PATCH 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:58PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL notice boilerplate on dsp_* with SPDX identifier > for GPL 1.0+. These files missed previous SPDX conversion batches > due to not specifying GPL version. Reviewed-by: Simon Horman

Re: [PATCH 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:00PM +0700, Bagas Sanjaya wrote: > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. Reviewed-by: Simon Horman

Re: [PATCH v2 net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-03 Thread Simon Horman
On Tue, May 02, 2023 at 02:26:53PM -0700, Justin Chen wrote: > On Tue, May 2, 2023 at 12:44 PM Simon Horman > wrote: > > > > On Wed, Apr 26, 2023 at 11:54:29AM -0700, Justin Chen wrote: ... > > > +static void bcmasp_update_mib_counters(struct bcmasp_intf *priv) &g

Re: [PATCH v2 net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-02 Thread Simon Horman
On Wed, Apr 26, 2023 at 11:54:29AM -0700, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN

Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-05 Thread Simon Horman
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote: > Enable yamllint to check the prefered commenting style of requiring a fwiiw: prefered -> preferred > space after a comment character '#'. Fix the cases in the tree which > have a warning with this enabled. Most cases just need a

Re: [PATCH] net: tun: Remove redundant null checks before kfree

2022-11-30 Thread Simon Horman
+ Thierry Reding, linux-tegra, dri-devel On Tue, Nov 29, 2022 at 04:43:29PM +0800, zys.zlj...@gmail.com wrote: > From: Yushan Zhou > > Fix the following coccicheck warning: > ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: > NULL check before some freeing functions is not needed. > >

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Simon Horman
On Fri, Sep 13, 2019 at 10:30:45AM +0200, Geert Uytterhoeven wrote: > On Fri, Sep 13, 2019 at 10:21 AM Simon Horman wrote: > > On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: > > > On 11.09.2019 22:25, Kieran Bingham wrote: > > > > Add direct

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Simon Horman
differences as the need arises. My recollection is that this scheme has been adopted for non-versioned Renesas IP blocks since June 2015 and uses of this scheme well before that. > > Signed-off-by: Kieran Bingham Reviewed-by: Simon Horman > [...] > > MBR, Sergei >

Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

2019-06-19 Thread Simon Horman
On Wed, Jun 19, 2019 at 08:08:09AM +, Fabrizio Castro wrote: > Hi Laurent, > > Thank you for your feedback! > > > From: linux-renesas-soc-ow...@vger.kernel.org > > On Behalf Of Laurent Pinchart > > Sent: 18 June 2019 17:44 > > Subject: Re: [PATCH 1/3] dt-bindings: display: renesas: Add

Re: [PATCH v3 08/10] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1

2019-06-12 Thread Simon Horman
On Wed, Jun 12, 2019 at 01:21:24PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Thu, Jun 06, 2019 at 10:51:09AM +0200, Simon Horman wrote: > > On Thu, Jun 06, 2019 at 10:59:57AM +0300, Laurent Pinchart wrote: > > > On Mon, Jun 03, 2019 at 01:40:45PM +0200, Simon Hor

Re: [PATCH v3 08/10] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1

2019-06-06 Thread Simon Horman
On Thu, Jun 06, 2019 at 10:59:57AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Mon, Jun 03, 2019 at 01:40:45PM +0200, Simon Horman wrote: > > On Tue, May 28, 2019 at 05:12:32PM +0300, Laurent Pinchart wrote: > > > Add the new renesas,companion property to

Re: [PATCH v3 08/10] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1

2019-06-03 Thread Simon Horman
On Tue, May 28, 2019 at 05:12:32PM +0300, Laurent Pinchart wrote: > Add the new renesas,companion property to the LVDS0 node to point to the > companion LVDS encoder LVDS1. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi > Tested-by: Jacopo Mondi Hi Laurent, is this patch

Re: [PATCH 3/3] drm: rcar-du: Remove unused prototypes

2019-03-16 Thread Simon Horman
On Thu, Mar 14, 2019 at 10:04:20PM +, Kieran Bingham wrote: > The CRTC suspend and resume functions have been replaced, but the > prototypes were not removed. > > Remove the redundant definitions. > > Signed-off-by: Kieran Bingham Reviewe

Re: [PATCH 1/3] drm: fix subtle spelling error in drm_crtc_state

2019-03-16 Thread Simon Horman
On Thu, Mar 14, 2019 at 10:04:18PM +, Kieran Bingham wrote: > The drm_crtc_state documentation contains a subtle misspelling of the > word subtle. Correct it. > > Signed-off-by: Kieran Bingham Reviewed-by: Simon Horman ___ dri-devel

Re: [PATCH 2/3] drm: rcar-du: crtc: make local functions static

2019-03-16 Thread Simon Horman
by: Kieran Bingham Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder

2019-02-25 Thread Simon Horman
On Fri, Feb 15, 2019 at 01:44:43PM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Wed, Jan 23, 2019 at 11:03:04AM +0100, Simon Horman wrote: > > On Wed, Jan 23, 2019 at 11:55:52AM +0200, Laurent Pinchart wrote: > > > On Wed, Jan 23, 2019 at 09:56:57AM +0100, Simon Hor

Re: [PATCH v2 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder

2019-01-24 Thread Simon Horman
Hi Laurent, On Wed, Jan 23, 2019 at 11:55:52AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Wed, Jan 23, 2019 at 09:56:57AM +0100, Simon Horman wrote: > > On Wed, Jan 23, 2019 at 12:54:04AM +0200, Laurent Pinchart wrote: > > > The LVDS1 encoder must supply

Re: [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings

2019-01-24 Thread Simon Horman
gt; > Reviewed-by: Laurent Pinchart > > and taken in my tree. Reviewed-by: Simon Horman > > --- > > Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/de

Re: [PATCH v2 5/6] arm64: dts: renesas: r8a77990: ebisu: Enable LVDS1 encoder

2019-01-24 Thread Simon Horman
> Changes since v1: > > - Add a comment in the DT to explain why the LVDS1 encoder needs to be > enabled. Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman ___ dr

Re: [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support

2019-01-24 Thread Simon Horman
On Tue, Jan 22, 2019 at 07:07:51PM +0200, Laurent Pinchart wrote: > Hi Biju, > > Thank you for the patch. > > On Tue, Jan 22, 2019 at 03:25:48PM +, Biju Das wrote: > > Add du node to r8a7744 SoC DT. Boards that want to enable the DU > > need to specify the output topology. > > > >

Re: [PATCH v2 6/6] arm64: dts: renesas: r8a77995: draak: Enable LVDS1 encoder

2019-01-24 Thread Simon Horman
> Changes since v1: > > - Add a comment in the DT to explain why the LVDS1 encoder needs to be > enabled. Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman ___ dr

Re: [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support

2019-01-24 Thread Simon Horman
On Tue, Jan 22, 2019 at 03:25:47PM +, Biju Das wrote: > The LVDS encoders on RZ/G1N SoC is similar to RZ/G1M. Add support for > RZ/G1N (R8A7744) SoC to the LVDS encoder driver. > > Signed-off-by: Biju Das Reviewed-by: Simon Horman > --- > drivers/gpu/drm/rcar-du/rcar

Re: [PATCH] dt-bindings: display: renesas: lvds: Document r8a774c0 bindings

2018-12-18 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:20:54PM +, Fabrizio Castro wrote: > The RZ/G2E (r8a774c0) supports two LVDS channels. Extend the binding to > support them. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman ___ dri-devel mail

Re: [PATCH] drm: rcar-du: lvds: add R8A774C0 support

2018-12-18 Thread Simon Horman
ne for R-Car E3. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

2018-12-18 Thread Simon Horman
m: shmobile: Perform initialization/cleanup at > probe/remove time") > Signed-off-by: YueHaibing Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dt-bindings: display: renesas: du: Document r8a774c0 bindings

2018-12-18 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:20:45PM +, Fabrizio Castro wrote: > Document the RZ/G2E (a.k.a. r8a774c0) SoC in the R-Car DU bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman ___ dri-devel mailing list

Re: [PATCH 4/5] arm64: dts: renesas: r8a77995: draak: Add backlight

2018-12-13 Thread Simon Horman
On Mon, Dec 10, 2018 at 02:33:08PM +0200, Laurent Pinchart wrote: > Hi Geert, > > On Monday, 10 December 2018 14:30:22 EET Geert Uytterhoeven wrote: > > On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven wrote: > > > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart wrote: > > >> Add the backlight

Re: [PATCH 4/5] arm64: dts: renesas: r8a77995: draak: Add backlight

2018-12-06 Thread Simon Horman
Hi Laurent, On Tue, Dec 04, 2018 at 06:57:10PM +0200, Laurent Pinchart wrote: > Hi Simon, > > Could you please consider taking this patch in your tree ? It's independent > from the rest of the series. sure, applied for v4.21. > > On Sunday, 25 November 2018 16:40:30 EET Laurent Pinchart

Re: [PATCH] drm: rcar-du: Fix DU3 start/stop on M3-N

2018-11-27 Thread Simon Horman
nt Pinchart Thanks Laurent, I have confirmed that with this patch applied on top of renesas-devel-20181123-v4.20-rc3 Salvator-XS / M3-N ES1.0 boots to user-space when the kernel is compiled using renesas_defconfig. Tested-by: Simon Horman Without this patch applied the boot log looks this: Startin

Re: [PATCH 1/5] drm: rcar-du: Replace EXT_CTRL_REGS feature flag with generation check

2018-11-27 Thread Simon Horman
; generation checks to replace the feature flag. > > Signed-off-by: Laurent Pinchart Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] arm64: dts: renesas: r8a77965: Add LVDS support

2018-10-18 Thread Simon Horman
On Thu, Oct 18, 2018 at 12:17:14PM +0100, Kieran Bingham wrote: > Hi Laurent, > > On 18/10/18 01:41, Laurent Pinchart wrote: > > The M3-N (r8a77965) platform has oneLVDS encoder connected to the DU. > > s/oneLVDS/one LVDS/ > > > Add the corresponding DT node and wire it up. > > > >

Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X

2018-10-18 Thread Simon Horman
On Mon, Sep 24, 2018 at 11:08:51AM +0200, Simon Horman wrote: > On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote: > > The iwg23s board comes with the SiI9022ACNU HDMI transmitter, > > this patch makes sure the corresponding driver gets built. > > > > Sig

Re: [RESEND PATCH] drm/rcar-du: Replace drm_dev_unref with drm_dev_put

2018-10-01 Thread Simon Horman
mann Reviewed-by: Simon Horman > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 0954ecd2f943..476d4d427044 10

Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X

2018-09-25 Thread Simon Horman
ello Simon, > > a patch for the multi_v7_defconfig will be sent at a later stage. Thanks Fabrizio, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman > > Thanks, > Fab > > arch/arm/configs/shmobile_defconfig | 1

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-23 Thread Simon Horman
On Wed, Sep 19, 2018 at 04:11:36PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 19 September 2018 11:35:07 EEST Simon Horman wrote: > > On Mon, Sep 17, 2018 at 11:59:32AM +0300, Laurent Pinchart wrote: > > > On Monday, 17 September 2018 11:54:04 EES

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-20 Thread Simon Horman
On Mon, Sep 17, 2018 at 11:59:32AM +0300, Laurent Pinchart wrote: > On Monday, 17 September 2018 11:54:04 EEST Laurent Pinchart wrote: > > Hi Simon, > > > > On Monday, 17 September 2018 11:47:15 EEST Laurent Pinchart wrote: > > > On Monday, 17 September 2018 11

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-18 Thread Simon Horman
On Mon, Sep 17, 2018 at 09:50:55AM +0200, Simon Horman wrote: > On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > > The R8A77990 (E3) platform has one RGB output and two LVDS outputs > > connected to the DU. Add the DT nodes for the DU, LVDS encoders and >

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-18 Thread Simon Horman
On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > The R8A77990 (E3) platform has one RGB output and two LVDS outputs > connected to the DU. Add the DT nodes for the DU, LVDS encoders and > supporting VSP and FCP. > > Signed-off-by: Laurent Pinchart > Tested-by: Jacopo Mondi >

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-18 Thread Simon Horman
On Mon, Sep 17, 2018 at 11:38:43AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 17 September 2018 10:50:55 EEST Simon Horman wrote: > > On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > > > The R8A77990 (E3) platform has one RGB out

Re: [PATCH v2 12/16] arm64: dts: renesas: r8a77990: Add I2C device nodes

2018-09-18 Thread Simon Horman
On Fri, Sep 14, 2018 at 12:10:42PM +0300, Laurent Pinchart wrote: > From: Takeshi Kihara > > Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > tree. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Jacopo Mondi > Tested-by: Jacopo Mondi > --- >

Re: [PATCH 12/16] arm64: dts: renesas: r8a77990: Add I2C device nodes

2018-09-07 Thread Simon Horman
On Wed, Sep 05, 2018 at 04:53:26PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Tuesday, 4 September 2018 17:49:53 EEST jacopo mondi wrote: > > On Tue, Sep 04, 2018 at 04:32:32PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart wrote: > > >> From:

Re: [PATCH 1/2] drm: rcar-du: convert to SPDX identifiers

2018-08-23 Thread Simon Horman
gt; Signed-off-by: Kuninori Morimoto > Acked-by: Laurent Pinchart Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] MAINTAINERS: Update tree location for the Renesas DRM drivers

2018-08-23 Thread Simon Horman
On Mon, Aug 20, 2018 at 01:14:13AM +0300, Laurent Pinchart wrote: > The fbdev git tree referenced in the MAINTAINERS file doesn't exist > anymore. Update the location to point to the new git tree. > > Signed-off-by: Laurent Pinchart Reviewed-by:

Re: [PATCH 2/2] drm: shmobile: convert to SPDX identifiers

2018-08-23 Thread Simon Horman
On Wed, Aug 22, 2018 at 01:57:34AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > Acked-by: Laurent Pinchart R

Re: [PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions

2018-08-23 Thread Simon Horman
extending across the 80-char boundary on RCAR_DU_FEATURE_EXT_CTRL_REGS > > To preserve formatting - this warning has been ignored. Reviewed-by: Simon Horman > > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) &g

Re: [PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put

2018-07-18 Thread Simon Horman
mann Reviewed-by: Simon Horman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings

2018-06-06 Thread Simon Horman
On Mon, Jun 04, 2018 at 10:04:59PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU > hardware seems the same as in the R-Car V3M (R8A77970). > > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman > > --- >

Re: [PATCH 5/5] arm64: dts: renesas: r8a77995-draak: add X12 input dot clock

2018-05-23 Thread Simon Horman
On Sun, May 20, 2018 at 11:58:36AM +0300, Laurent Pinchart wrote: > Hi Ulrich, > > Thank you for the patch. > > On Wednesday, 16 May 2018 11:38:22 EEST Simon Horman wrote: > > On Tue, May 15, 2018 at 02:20:40PM +0200, Ulrich Hecht wrote: > > > 74.25 M

Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support

2018-05-18 Thread Simon Horman
On Wed, May 16, 2018 at 11:59:32AM +0300, Sergei Shtylyov wrote: > Hello! > > On 5/16/2018 10:54 AM, Simon Horman wrote: > > > > Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. > > > > > > Signed-off-by: Ulric

Re: [PATCH 4/5] arm64: dts: renesas: r8a77995-draak: add HDMI output

2018-05-17 Thread Simon Horman
++ > 1 file changed, 80 insertions(+) This looks fine but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+rene...@verge.net.au> ___ dri-devel mailing list dri-devel@lists.freedesktop.

Re: [PATCH 5/5] arm64: dts: renesas: r8a77995-draak: add X12 input dot clock

2018-05-17 Thread Simon Horman
e changed, 11 insertions(+) This looks fine but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+rene...@verge.net.au> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/5] drm: rcar-du: Add r8a77995 device support

2018-05-17 Thread Simon Horman
by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du

Re: [PATCH 3/5] arm64: dts: renesas: r8a77995: Add LVDS support

2018-05-17 Thread Simon Horman
.com> > [uli: moved lvds* into the soc node, added PM domains, resets] > Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com> This looks fine but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+rene...@verge.net.au> __

Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support

2018-05-17 Thread Simon Horman
On Tue, May 15, 2018 at 02:20:37PM +0200, Ulrich Hecht wrote: > Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. > > Signed-off-by: Ulrich Hecht > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [PATCH] drm: rcar-du: disable dtc graph-endpoint warnings on DT overlays

2018-05-16 Thread Simon Horman
t; > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-...@vger.kernel.org > Signed-off-by: Rob Herring <r...@kernel.org> Acked-by: Simon Horman <horms+rene...@verge.net.au> > --- > This needs to go thru my tree because it is dependent on the dtc update > t

Re: [PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-05-01 Thread Simon Horman
this patches I would like patch #1 to go > through fbdev tree and patch #2 to go through drm tree. Once they > are both upstream (v4.18) I will apply patch #3 to fbdev tree. Nice to see this cleanup, thanks. Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI

2018-05-01 Thread Simon Horman
On Sat, Apr 28, 2018 at 12:34:26AM +0300, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 27 April 2018 19:57:21 EEST Kieran Bingham wrote: > > The DU1 external dot clock is provided by the fixed frequency clock > > generator X21, while the DU0 and DU3 clocks are

Re: [PATCH v2 08/11] arm64: dts: r8a77965: Populate the DU instance placeholder

2018-05-01 Thread Simon Horman
On Fri, Apr 27, 2018 at 05:57:19PM +0100, Kieran Bingham wrote: > The DU entity node has been previously added but only as a placeholder. > Populate the node with the properties to use the device. > > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent

  1   2   >