RE: [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-15 Thread Sripada, Radhakrishna
gt; https://patchwork.freedesktop.org/series/125356/.  Reading from a > shadowed register will avoid any needless references(without a wake) to > the MMIO space. Shouldn't hurt to make this change for all gens IMO. The proposed usage looks accurate for the issue described. Reviewed-by: Radhak

RE: [PATCH] drm/i915: Zap some empty lines

2023-09-20 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Tvrtko > Ursulin > Sent: Wednesday, September 20, 2023 2:27 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Bhadane, Dnyaneshwar > ; Sripada, Radhakrishn

RE: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement

2023-09-06 Thread Sripada, Radhakrishna
Hi Rodrigo/Andi, > -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, September 6, 2023 7:38 PM > To: Andi Shyti > Cc: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/

RE: [PATCH] drm/i915: Avoid GGTT flushing on non-GGTT paths of i915_vma_pin_iomap

2023-07-24 Thread Sripada, Radhakrishna
Ursulin, Tvrtko ; Sripada, Radhakrishna > ; sta...@vger.kernel.org > Subject: [PATCH] drm/i915: Avoid GGTT flushing on non-GGTT paths of > i915_vma_pin_iomap > > From: Tvrtko Ursulin > > Commit 4bc91dbde0da ("drm/i915/lmem: Bypass aperture when lmem is > available"

RE: [PATCH] drm/i915: Use the i915_vma_flush_writes helper

2023-07-21 Thread Sripada, Radhakrishna
per > > From: Tvrtko Ursulin > > We can use the existing helper in flush_write_domain() and save some lines > of code. > LGTM, Radhakrishna Sripada --Radhakrishna(RK) Sripada > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/i915_gem_domain.c

RE: [PATCH v11 0/8] drm/i915/pxp: Add MTL PXP Support

2023-05-11 Thread Sripada, Radhakrishna
Thank you for the patches and the reviews. Pushed. - Radhakrishna(RK) Sripada > -Original Message- > From: dri-devel On Behalf Of Alan > Previn > Sent: Thursday, May 11, 2023 4:18 PM > To: intel-...@lists.freedesktop.org > Cc: Teres Alexis, Alan Previn ; Ursulin, > Tvrtko ; Juston Li ;

RE: [PATCH v3] drm/i915/mtl: Disable stolen memory backed FB for A0

2023-04-04 Thread Sripada, Radhakrishna
> -Original Message- > From: Das, Nirmoy > Sent: Tuesday, April 4, 2023 11:14 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; > Auld, Matthew ; Andi Shyti > ; Ceraolo Spurio, Daniele > ; De Marchi, Lucas &

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-06 Thread Sripada, Radhakrishna
> -Original Message- > From: Andi Shyti > Sent: Friday, March 3, 2023 7:24 PM > To: Sripada, Radhakrishna > Cc: Andi Shyti ; intel-...@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org; Tvrtko Ursulin ; > Andi Shyti ; Patelczyk, Maciej > ; Wajdecz

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles. Shouldn't we be using gt instead of tile in our usage? With s/tile/gt/g, Reviewed-by: Radhakrishna Sripada > -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent:

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent: Wednesday, March 1, 2023 3:03 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Tvrtko Ursulin ; Andi Shyti > ; Patelczyk, Maciej ; Andi > Shyti ; Wajdeczko, Michal > > Subject:

RE: [PATCH] drm/i915/xelpmp: Consider GSI offset when doing MCR lookups

2023-02-15 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Matt > Roper > Sent: Monday, February 13, 2023 4:19 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH] drm/i915/xelpmp: Consider GSI offset when doing MCR > lookups > > MCR range tables

RE: [Intel-gfx] [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-11 Thread Sripada, Radhakrishna
Nikula > Cc: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org; De Marchi, Lucas ; dri- > de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use graphics ver, rel info for > media on > old platforms > > On Tue, Oct 11, 2022 at 01:10:26PM +0300, J

RE: [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-11 Thread Sripada, Radhakrishna
Hi Jani, > -Original Message- > From: Jani Nikula > Sent: Tuesday, October 11, 2022 12:28 AM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; De Marchi, Lucas > ; Roper, Matthew D

RE: [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-10-03 Thread Sripada, Radhakrishna
> -Original Message- > From: De Marchi, Lucas > Sent: Thursday, September 29, 2022 5:11 PM > To: Sripada, Radhakrishna > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH v4.1] drm/i915/mtl: Define engine context layouts &

RE: [PATCH v3 07/14] drm/i915: Use a DRM-managed action to release the PCI bridge device

2022-09-09 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Matt > Roper > Sent: Tuesday, September 6, 2022 4:49 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH v3 07/14] drm/i915: Use a DRM-managed action to release the > PCI bridge device > >

RE: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Sripada, Radhakrishna
Hi Lucas/Matt, > -Original Message- > From: De Marchi, Lucas > Sent: Wednesday, September 7, 2022 3:21 PM > To: Roper, Matthew D > Cc: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vivi, Rodrigo > > Subject: Re:

RE: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Sripada, Radhakrishna
Hi Jani, > -Original Message- > From: Jani Nikula > Sent: Thursday, September 1, 2022 12:58 AM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read >

RE: [PATCH 5/8] drm/i915: Rename and expose common GT early init routine

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 5/8] drm/i915: Rename and exp

RE: [PATCH 4/8] drm/i915: Prepare more multi-GT initialization

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > ; Iddamsetty, Aravind > > Subject: [PATCH 4/8] d

RE: [PATCH 3/8] drm/i915: Use managed allocations for extra uncore objects

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 3/8] drm/i915: Use managed allo

RE: [PATCH 2/8] drm/i915: Only hook up uncore->debug for primary uncore

2022-08-30 Thread Sripada, Radhakrishna
Hi Matt, > -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 2/8] drm/i915: On

RE: [PATCH 1/8] drm/i915: Move locking and unclaimed check into mmio_debug_{suspend,resume}

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 1/8] drm/i915: Move loc