Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-03-13 Thread Sundaresan, Sujaritha
On 3/13/2022 5:38 PM, Andi Shyti wrote: Hi Michal, [...] +static ssize_t punit_req_freq_mhz_show(struct device *dev, + struct device_attribute *attr, + char *buff) +{ + struct intel_gt *gt =

Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-02-17 Thread Sundaresan, Sujaritha
On 2/17/2022 7:45 AM, Andi Shyti wrote: Hi, I forgot to add some note to this patch... [...] +static ssize_t throttle_reason_status_show(struct device *dev, + struct device_attribute *attr, + char *buff) +{ +

Re: [PATCH v2 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-12 Thread Sundaresan, Sujaritha
On 1/12/2022 2:20 PM, Andi Shyti wrote: The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those

Re: [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-12 Thread Sundaresan, Sujaritha
On 1/11/2022 4:15 AM, Andi Shyti wrote: The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those

Re: [Intel-gfx] [PATCH] drm/i915/guc: Request RP0 before loading firmware

2021-12-21 Thread Sundaresan, Sujaritha
On 12/21/2021 10:11 AM, Ewins, Jon wrote: On 12/20/2021 3:52 PM, Sundaresan, Sujaritha wrote: On 12/16/2021 3:30 PM, Vinay Belgaumkar wrote: By default, GT (and GuC) run at RPn. Requesting for RP0 before firmware load can speed up DMA and HuC auth as well. In addition to writing to 0xA008

Re: [Intel-gfx] [PATCH] drm/i915/guc: Request RP0 before loading firmware

2021-12-20 Thread Sundaresan, Sujaritha
On 12/16/2021 3:30 PM, Vinay Belgaumkar wrote: By default, GT (and GuC) run at RPn. Requesting for RP0 before firmware load can speed up DMA and HuC auth as well. In addition to writing to 0xA008, we also need to enable swreq in 0xA024 so that Punit will pay heed to our request. SLPC will

RE: [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses

2021-12-16 Thread Sundaresan, Sujaritha
-Original Message- From: dri-devel On Behalf Of Andi Shyti Sent: Tuesday, December 14, 2021 11:34 AM To: Intel GFX ; DRI Devel Cc: Winiarski, Michal ; Andi Shyti ; De Marchi, Lucas ; Chris Wilson ; Andi Shyti Subject: [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT

Re: [Intel-gfx] [PATCH v8 12/16] drm/i915/display: Use to_gt() helper for GGTT accesses

2021-12-16 Thread Sundaresan, Sujaritha
On 12/14/2021 11:33 AM, Andi Shyti wrote: From: Michał Winiarski GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Use to_gt() for all i915->ggtt accesses to help with the future refactoring. Signed-off-by: Michał

Re: [Intel-gfx] [PATCH v8 13/16] drm/i915/gt: Use to_gt() helper for GGTT accesses

2021-12-16 Thread Sundaresan, Sujaritha
On 12/14/2021 11:33 AM, Andi Shyti wrote: From: Michał Winiarski GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Use to_gt() for all i915->ggtt accesses to help with the future refactoring. Signed-off-by: Michał

Re: [Intel-gfx] [PATCH v8 14/16] drm/i915/selftests: Use to_gt() helper for GGTT accesses

2021-12-16 Thread Sundaresan, Sujaritha
On 12/14/2021 11:33 AM, Andi Shyti wrote: From: Michał Winiarski GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Use to_gt() for all i915->ggtt accesses to help with the future refactoring. Signed-off-by: Michał

Re: [Intel-gfx] [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt

2021-12-16 Thread Sundaresan, Sujaritha
On 12/14/2021 11:33 AM, Andi Shyti wrote: The reference to the GGTT from the private date is not used anymore. Remove it. -Quick spellcheck for "data". Suggested-by: Matt Roper Signed-off-by: Andi Shyti Cc: Michał Winiarski --- drivers/gpu/drm/i915/gt/intel_gt.c| 7 +--

Re: [PATCH] drm/i915/gt: make a gt sysfs group and move power management files

2021-10-14 Thread Sundaresan, Sujaritha
On 10/13/2021 5:08 PM, Andi Shyti wrote: From: Andi Shyti The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power

Re: [PATCH v5 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-06-23 Thread Sundaresan, Sujaritha
On 6/16/2021 11:43 PM, Dale B Stimson wrote: As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon

Re: [PATCH v4 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-06-02 Thread Sundaresan, Sujaritha
On 6/1/2021 5:42 PM, Dale B Stimson wrote: On 2021-06-01 14:39:11, Sundaresan, Sujaritha wrote: Date: Tue, 1 Jun 2021 14:39:11 -0700 From: "Sundaresan, Sujaritha" To: Dale B Stimson , intel-...@lists.freedesktop.org, dri-devel@lists.freedesktop.org CC: Jon Ewins , Jani Nikula

Re: [PATCH v4 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-06-01 Thread Sundaresan, Sujaritha
On 5/27/2021 5:44 PM, Dale B Stimson wrote: As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon