Re: [PATCH 0/4] drm/amd/display: Update Display Core unit tests

vuhfrzrnuzt6lwjfm5fuozxlgqsco3qb5rfzyf6mil5ms@2svqtlcncyjj/ Kind regards, Tales > > [WHY] > > 1. The single test suite in the file > test/kunit/dc/dml/calcs/bw_fixed_test.c, which tests some static > functions defined in the dc/basics/bpw_fixed.

[PATCH] drm/amd/display: remove unneeded defines from bios parser

Removes DEFINEs that should have been removed after they were introduced to ObjectID.h by the commit abea57d70e90 ("drm/amdgpu: Add BRACKET_LAYOUT_ENUMs to ObjectID.h") Signed-off-by: Tales Aparecida --- .../drm/amd/display/dc/bios/bios_parser2.c| 19 --- 1 file c

Re: [PATCH] drm/amd/display: remove unreachable code

; } - - *RequiredSlots = dml_ceil(DesiredBPP / MaxLinkBPP * 64, 1); - - return BPP_INVALID; } // TruncToValidBPP double dml32_RequiredDTBCLK( Seems correct. Reviewed-by: Tales Aparecida I feel like RequiredSlots is not actually used anywhere in the code, just passed around

Re: [PATCH 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

y technical mistakes. So, regarding readability and rendering htmldocs, apart from the nits I've raised, this whole series is Reviewed-by: Tales Aparecida Thanks for the patch series, Melissa, Tales Aparecida

Re: [PATCH 3/4] drm/amd/display: add doc entries for MPC blending configuration

f blending chain for DWB output * * Parameters: @@ -264,7 +325,9 @@ struct mpc_funcs { int dpp_id, int mpcc_id); - /* + /** + * @remove_mpcc_from_secondary: +* * Remove a specified DPP from the 'secondary' MPC tree. * * Parameters: Thanks for the patch, Tales Aparecida

Re: [PATCH 2/4] Documentation/amdgpu/display: add DC color caps info

le instance - + uint16_t num_3dluts : 3; + uint16_t shared_3d_lut:1; struct rom_curve_caps ogam_rom_caps; }; +/** + * struct dc_color_caps - color pipes capabilities for DPP and MPC hw blocks + * @dpp: color pipes caps for DPP + * @mpc: color pipes caps for MPC + */ struct dc_color_caps { struct dpp_color_caps dpp; struct mpc_color_caps mpc; Again, thanks for the documentation patch! Kind regards, Tales Aparecida

Re: [PATCH 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

u are here? prepartion -> preparation * - * Returns 0 on success. + * Returns: + * 0 on success. + * ENOMEM if mem allocation fails. */ int amdgpu_dm_update_plane_color_mgmt(struct dm_crtc_state *crtc, struct dc_plane_state *dc_plane_state) Thanks for creating more documentation! Kind regards, Tales

Re: [PATCH 0/4] KUnit tests for RGB565 conversion

sted with "./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests --arch=x86_64", "... --arch=i386" and baremetal on x86_64 to be sure; everything looks fine, but I feel like some patches could be squashed, though. Tested-by: Tales L. Aparecida Inspiring work, José, keep it up! Best regards, Tales

Re: [PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

Hi Bagas Sanjaya, Em sáb., 16 de abr. de 2022 às 02:47, Bagas Sanjaya escreveu: > On 4/16/22 02:50, Tales Lelo da Aparecida wrote: > > To make sure maintainers of amdgpu drivers are aware of any changes > > in their documentation, add its entry to MAINTAINERS. > >

[PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

To make sure maintainers of amdgpu drivers are aware of any changes in their documentation, add its entry to MAINTAINERS. Signed-off-by: Tales Lelo da Aparecida --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d54b9f15ffce..b3594b2a09de 100644

[PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

Add missing acronyms to the amdgppu glossary. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/gpu

[PATCH 0/2] Update AMDGPU glossary and MAINTAINERS

I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file. [0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Tales Lelo da Aparecida (2

[PATCH] drm/amd/display: make hubp1_wait_pipe_read_start() static

It's a local function, let's make it static. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/displa

[PATCH v2 2/2] drm/vkms: return early if compose_plane fails

Do not exit quietly from compose_plane. If any plane has an invalid map, propagate the error value upwards. While here, add log messages for the invalid index. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/vkms/vkms_composer.c | 30 ++-- 1 file changed, 20

[PATCH v2 1/2] drm/vkms: check plane_composer->map[0] before using it

Fix a copypasta error. The caller of compose_plane() already checks primary_composer->map. In contrast, plane_composer->map is never verified here before handling. Fixes: 7938f4218168 ("dma-buf-map: Rename to iosys-map") Reviewed-by: André Almeida Signed-off-by: Tales Lelo da A

[PATCH v2 0/2] drm/vkms: check plane_composer->map[0] before using it

Hi, this is a follow-up of my last patch. Thanks for the reviews! Changes from v1: Edit the first commit message as suggested by Melissa and add a commit to enhance the error handling (André) Tales Lelo da Aparecida (2): drm/vkms: check plane_composer->map[0] before using it drm/v

[PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it

Fix a copypasta error, which resulted in checking repeatedly if the primary_composer->map[0] was null, instead of checking each plane_composer while composing planes. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 0/1] drm/vkms: check plane_composer->map[0] before using it

Hello, I'm interested in collaborating with VKMS, please let me know if there's anything that I could better. Tales Lelo da Aparecida (1): drm/vkms: check plane_composer->map[0] before using it drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+