Re: [PATCH] drm/tegra: fix a possible null pointer dereference

2024-05-31 Thread Thierry Reding
On Fri May 31, 2024 at 3:56 PM CEST, Huai-Yuan Liu wrote: > In malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but > no check is performed. Before calling __drm_atomic_helper_crtc_reset, > mw_state should be checked to prevent possible null pointer dereferene. Please check that

Re: [PATCH] docs: document python version used for compilation

2024-05-31 Thread Thierry Reding
On Fri May 31, 2024 at 9:33 AM CEST, Geert Uytterhoeven wrote: > Hi Thierry, > > On Thu, May 30, 2024 at 7:07 PM Thierry Reding > wrote: > > Alternatively, maybe Kconfig could be taught about build dependencies? > > git grep "depends on \$(" -- "*Kconf*&qu

Re: [BUG] Build failure and alleged fix for next-20240523

2024-05-30 Thread Thierry Reding
On Thu May 30, 2024 at 6:55 PM CEST, Paul E. McKenney wrote: > On Fri, May 24, 2024 at 12:57:58PM -0700, Abhinav Kumar wrote: > > Hello > > > > On 5/24/2024 12:55 PM, Paul E. McKenney wrote: > > > Hello! > > > > > > I get the following allmodconfig build error on x86 in next-20240523: > > > > >

Re: [PATCH] docs: document python version used for compilation

2024-05-30 Thread Thierry Reding
On Fri May 10, 2024 at 10:04 PM CEST, Rob Clark wrote: > On Fri, May 10, 2024 at 3:09 AM Jani Nikula wrote: > > > > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote: > > > Em Fri, 10 May 2024 11:08:38 +0300 > > > Jani Nikula escreveu: > > > > > >> On Thu, 09 May 2024, Dmitry Baryshkov > > >>

Re: [PATCH] docs: document python version used for compilation

2024-05-30 Thread Thierry Reding
On Thu May 9, 2024 at 6:48 PM CEST, Jonathan Corbet wrote: > Dmitry Baryshkov writes: > > > The drm/msm driver had adopted using Python3 script to generate register > > header files instead of shipping pre-generated header files. Document > > the minimal Python version supported by the script. >

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-30 Thread Thierry Reding
On Wed May 8, 2024 at 1:04 AM CEST, Abhinav Kumar wrote: > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
On Fri Apr 26, 2024 at 5:32 PM CEST, Thierry Reding wrote: > From: Thierry Reding > > > On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > > Add support for Tegra Security Engine which can accelerates various > > crypto algorithms. The Engine has two separate inst

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
From: Thierry Reding On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > Add support for Tegra Security Engine which can accelerates various > crypto algorithms. The Engine has two separate instances within for > AES and HASH algorithms respectively. > > The driver regis

Re: [PATCH] gpu: host1x: mipi: Benefit from devm_clk_get_prepared()

2024-04-19 Thread Thierry Reding
ough whatever tree is most appropriate for this ongoing work: Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH 3/4] gpu: host1x: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/host1x/dev.c | 6 ++ > 1 file changed,

Re: [PATCH 0/4] gpu: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
this thread completed in > one go), I think with how drm maintenace works, it's best if the patches > are picked up by their individual maintainers. I guess that's: > > - Frank Binns + Matt Coster for imagination > > - Chun-Kuang Hu + Philipp Zabel for mediatek > > - Thierry Reding

Re: [PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-04-08 Thread Thierry Reding
On Wed Apr 3, 2024 at 12:07 PM CEST, Jon Hunter wrote: > Hi Thierry, > > On 15/03/2024 11:25, Jon Hunter wrote: > > > > On 14/03/2024 15:49, Thierry Reding wrote: > >> From: Thierry Reding > >> > >> The host1x devices are virtual compound devices

[PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-03-14 Thread Thierry Reding
From: Thierry Reding The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently still need those for legacy support on old

[PATCH] drm: Remove drm_num_crtcs() helper

2024-02-27 Thread Thierry Reding
From: Thierry Reding The drm_num_crtcs() helper determines the number of CRTCs by iterating over the list of CRTCs that have been registered with the mode config. However, we already keep track of that number in the mode config's num_crtcs field, so we can simply retrieve the value from

Re: [PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-26 Thread Thierry Reding
On Mon Feb 26, 2024 at 1:08 PM CET, Robert Foss wrote: > On Mon, Feb 26, 2024 at 12:36 PM Javier Martinez Canillas > wrote: > > > > Thomas Zimmermann writes: > > > > > Hi > > > > > > Am 23.02.24 um 16:03 schrieb Thierry Reding: > > >>

[PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-23 Thread Thierry Reding
From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. v2: - add comments explaining how this situation can come about - clear DRIVER_MODESET and DRIVER_ATOMIC feature bits Signed-off-by: Thierry

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-22 Thread Thierry Reding
On Thu Feb 22, 2024 at 2:05 AM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, secure world applications may need to access host1x > during suspend/resume, and rely on the kernel to keep Host1x out > of reset during the suspend cycle. As such, as a quirk, > skip asserting

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-19 Thread Thierry Reding
On Mon Feb 19, 2024 at 3:18 AM CET, Mikko Perttunen wrote: > On 2/16/24 19:02, Thierry Reding wrote: > > On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > >> From: Mikko Perttunen > >> > >> On Tegra186, other software components may rely on the ke

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-19 Thread Thierry Reding
drivers/phy/ti/phy-da8xx-usb.c | 2 +- > drivers/phy/ti/phy-gmii-sel.c | 2 +- > drivers/phy/xilinx/phy-zynqmp.c| 2 +- > drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +- > include/linux/phy/phy.h

Re: [PATCH][next] gpu: host1x: remove redundant assignment to variable space

2024-02-16 Thread Thierry Reding
On Thu Feb 15, 2024 at 11:43 PM CET, Colin Ian King wrote: > The variable space is being initialized with a value that is never read, > it is being re-assigned later on. The initialization is redundant and > can be removed. Also merge two declaration lines together. > > Cleans up clang scan build

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-16 Thread Thierry Reding
On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, other software components may rely on the kernel to > keep Host1x operational even during suspend. As such, as a quirk, > skip asserting Host1x's reset on Tegra186. This all sounds a bit vague.

Re: [PATCH] gpu: host1x: bus: make host1x_bus_type const

2024-02-14 Thread Thierry Reding
On Tue Feb 13, 2024 at 3:44 PM CET, Ricardo B. Marliere wrote: > Since commit d492cc2573a0 ("driver core: device.h: make struct > bus_type a const *"), the driver core can properly handle constant > struct bus_type, move the host1x_bus_type variable to be a constant > structure as well, placing it

Re: [PATCH 0/6] drm/tegra: Fix some error handling paths

2023-12-14 Thread Thierry Reding
On Sat, Sep 02, 2023 at 05:22:07PM +0200, Christophe JAILLET wrote: > Most of the patches are retated to tegra_output_probe() and missing > tegra_output_remove(). Others are things spotted while writting the serie. > > > Patches 1, 3, 4 are verbose, but some functions called in the probe can >

Re: [PATCH] drm/tegra: dpaux: Fix PM disable depth imbalance in tegra_dpaux_probe

2023-12-14 Thread Thierry Reding
On Wed, Oct 04, 2023 at 10:10:55PM +0800, Zhang Shurong wrote: > The pm_runtime_enable function increases the power disable depth, > which means that we must perform a matching decrement on the error > handling path to maintain balance within the given context. > Additionally, we need to address

Re: [PATCH v2] drm/tegra: include drm/drm_edid.h only where needed

2023-12-14 Thread Thierry Reding
On Wed, Dec 13, 2023 at 12:19:51PM +0200, Jani Nikula wrote: > Reduce the need for rebuilds when drm_edid.h is modified by including it > only where needed. > > v2: Fix build (kernel test robot ) > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tegra/drm.h| 2 +- >

Re: [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node

2023-12-14 Thread Thierry Reding
On Tue, Oct 24, 2023 at 08:07:38AM +, Chen Ni wrote: > Add check for the return value of of_find_device_by_node() and return > the error if it fails in order to avoid NULL pointer dereference. > > Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support") > Signed-off-by: Chen Ni > ---

Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-13 Thread Thierry Reding
rt for generic power-domains") > Signed-off-by: Brian Masney > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v4 000/115] pwm: Fix lifetime issues for pwm_chips

2023-12-11 Thread Thierry Reding
On Fri, Dec 08, 2023 at 07:50:33PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Fri, Dec 08, 2023 at 04:41:39PM +0100, Thierry Reding wrote: > > On Wed, Dec 06, 2023 at 12:43:14PM +0100, Uwe Kleine-König wrote: > > > This series is based on Thierry's for-next

Re: [PATCH v4 000/115] pwm: Fix lifetime issues for pwm_chips

2023-12-08 Thread Thierry Reding
because it's got the driver and internals much more cleanly separated. Going forward I think it would be easier to apply all the ref-counting on top of that because we only need to keep the PWM framework-internal data structure alive after a PWM chip has gone away. Thierry From 72ea79887d96850f9

[PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

2023-12-08 Thread Thierry Reding
From: Thierry Reding Commit 12c9b05da918 ("drm/nouveau/imem: support allocations not preserved across suspend") uses container_of() to cast from struct nvkm_memory to struct nvkm_instobj, assuming that all instance objects are derived from struct nvkm_instobj. For the gk20a fam

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-12-05 Thread Thierry Reding
On Tue, Nov 28, 2023 at 09:58:41PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > > Merging > > > === > > > I propose to tak

Re: [PATCH 08/10] iommu/tegra: Use tegra_dev_iommu_get_stream_id() in the remaining places

2023-12-01 Thread Thierry Reding
On Wed, Nov 29, 2023 at 03:26:03PM -0400, Jason Gunthorpe wrote: > On Wed, Nov 29, 2023 at 05:23:13PM +0100, Thierry Reding wrote: > > > diff --git a/drivers/memory/tegra/tegra186.c > > > b/drivers/memory/tegra/tegra186.c > > > index 533f85a4b2bdb7..3e4fbe94dd6

Re: [PATCH 08/10] iommu/tegra: Use tegra_dev_iommu_get_stream_id() in the remaining places

2023-11-29 Thread Thierry Reding
t; > Suggested-by: Thierry Reding > Signed-off-by: Jason Gunthorpe > --- > drivers/dma/tegra186-gpc-dma.c | 8 +++- > drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c | 7 ++- > drivers/memory/tegra/tegra186.c | 12 ++-- > 3

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-11-28 Thread Thierry Reding
ng DTS. > 3. No drivers are affected by this change. > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect >follow up patchsets. > > [...] Applied, thanks! [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC commit: 5d67b8f81b9d5985

Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-24 Thread Thierry Reding
On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote: > In order to introduce a pwm api which can be used from atomic context, > we will need two functions for applying pwm changes: > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > int pwm_apply_atomic(struct pwm

[PATCH v2 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-01 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer device tree bindings document the power-domains property, so make sure that simplefb supports it. This ensures that the power domains remain enabled as long as simplefb is active. v2: - remove unnecessary call to simplefb_detach_genpds() since that's

[PATCH v2 1/2] fbdev/simplefb: Support memory-region property

2023-11-01 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer bindings specify that the "memory-region" property can be used as an alternative to the "reg" property to define the framebuffer memory used by the display hardware. Implement support for this in the simplefb driver. Reviewed-by: H

[PATCH v2 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-11-01 Thread Thierry Reding
From: Thierry Reding Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow

Re: [PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-01 Thread Thierry Reding
On Thu, Oct 26, 2023 at 02:50:27PM +0200, Hans de Goede wrote: > Hi, > > Thank you for your patches. > > On 10/11/23 16:38, Thierry Reding wrote: > > From: Thierry Reding > > > > The simple-framebuffer device tree bindings document the power-domains > &g

Re: [PATCH 1/2] gpu: host1x: Correct allocated size for contexts

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:59:09PM +0300, Mikko Perttunen wrote: > From: Johnny Liu > > Original implementation over allocates the memory size for the > contexts list. The size of memory for the contexts list is based > on the number of iommu groups specified in the device tree. > > Fixes:

Re: [PATCH] gpu: host1x: Syncpoint interrupt sharding

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:40:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Support sharded syncpoint interrupts on Tegra234+. This feature > allows specifying one of eight interrupt lines for each syncpoint > to lower processing latency of syncpoint threshold > interrupts. > >

Re: [PATCH 1/3] gpu: host1x: Add locking in channel allocation

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:15:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Add locking around channel allocation to avoid race conditions. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/channel.c | 7 +++ > drivers/gpu/host1x/channel.h | 3 +++ > 2 files

[PATCH 1/2] fbdev/simplefb: Support memory-region property

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer bindings specify that the "memory-region" property can be used as an alternative to the "reg" property to define the framebuffer memory used by the display hardware. Implement support for this in the simplefb driver. Signed-of

[PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer device tree bindings document the power-domains property, so make sure that simplefb supports it. This ensures that the power domains remain enabled as long as simplefb is active. Signed-off-by: Thierry Reding --- drivers/video/fbdev/simplefb.c | 93

[PATCH 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-10-11 Thread Thierry Reding
From: Thierry Reding Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow

[PATCH] drm/simpledrm: Fix power domain device link validity check

2023-10-11 Thread Thierry Reding
From: Thierry Reding We need to check if a link is non-NULL before trying to delete it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c

Re: (subset) [PATCH v3 0/5] Support bridge/connector by Tegra HDMI

2023-10-10 Thread Thierry Reding
From: Thierry Reding On Mon, 07 Aug 2023 17:35:10 +0300, Svyatoslav Ryhel wrote: > This patch adds support for the bridge/connector attached to the > HDMI output, allowing to model the hardware properly. It keeps > backwards compatibility with existing bindings and is required >

Re: [PATCH -next] drm/tegra: Remove two unused function declarations

2023-10-10 Thread Thierry Reding
On Wed, Aug 09, 2023 at 11:02:26AM +0800, Yue Haibing wrote: > Commit 776dc3840367 ("drm/tegra: Move subdevice infrastructure to host1x") > removed the implementation but not the declaration. > > Signed-off-by: Yue Haibing > --- > drivers/gpu/drm/tegra/drm.h | 3 --- > 1 file changed, 3

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Thierry Reding
On Tue, Oct 10, 2023 at 03:22:56PM +0200, Thierry Reding wrote: > On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: > > Return -ENOMEM if tegra_bo_mmap() fails. > > > > Signed-off-by: Sui Jingfeng > > --- > > drivers/gpu/drm/tegra/gem.c | 2 ++

Re: [PATCH 2/2] drm/tegra: Remove surplus else after return

2023-10-10 Thread Thierry Reding
On Mon, Jun 26, 2023 at 10:33:31PM +0800, Sui Jingfeng wrote: > else is not generally useful after return > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/tegra/gem.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Applied, thanks. Thierry signature.asc

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Thierry Reding
On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: > Return -ENOMEM if tegra_bo_mmap() fails. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/tegra/gem.c | 2 ++ > 1 file changed, 2 insertions(+) Sorry, this fell through the cracks. I think it'd be better if tegra_bo_mmap()

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Thierry Reding
On Thu, Aug 31, 2023 at 10:04:29AM +0200, Daniel Vetter wrote: > On Thu, 31 Aug 2023 at 08:33, Mikko Perttunen wrote: > > > > On 8/30/23 13:19, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 25.08.23 um 15:22 schrieb Thierry Reding: > > >>

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Thierry Reding
On Wed, Aug 30, 2023 at 08:13:04AM +0200, Javier Martinez Canillas wrote: > Thierry Reding writes: > > Hello Thierry, > > > From: Thierry Reding > > > > Tegra DRM doesn't support display on Tegra234 and later, so make sure > > not to remove any existing f

[PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-25 Thread Thierry Reding
From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Thierry Reding
On Thu, Aug 24, 2023 at 01:01:24PM +0100, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > On Thu, 24 Aug 2023, Thierry Reding wrote: > > > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote: > > >> When converting from int to string,

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Thierry Reding
e I wouldn't expect this to ever exceed anything like 32 or 64, so 8 characters is already generous. Thierry > > Signed-off-by: Lee Jones > --- > Cc: Thierry Reding > Cc: Mikko Perttunen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jonathan Hunter > Cc: P

Re: [PATCH v3 0/5] Add JDI LPM102A188A display panel support

2023-08-16 Thread Thierry Reding
On Mon, Aug 07, 2023 at 02:33:00PM +0100, Diogo Ivo wrote: > Hello, > > These patches add support for the JDI LPM102A188A display panel, > found in the Google Pixel C. > > Patch 1 adds the DT bindings for the panel. > > Patch 2 adds the panel driver, which is based on the downstream > kernel

Re: (subset) [PATCH v3 0/5] Add JDI LPM102A188A display panel support

2023-08-16 Thread Thierry Reding
From: Thierry Reding On Mon, 07 Aug 2023 14:33:00 +0100, Diogo Ivo wrote: > These patches add support for the JDI LPM102A188A display panel, > found in the Google Pixel C. > > Patch 1 adds the DT bindings for the panel. > > Patch 2 adds the panel driver, which is based

Re: [PATCH v2 0/2] Support bridge/connector by Tegra HDMI

2023-07-27 Thread Thierry Reding
On Thu, Jul 27, 2023 at 07:24:56PM +0300, Svyatoslav Ryhel wrote: > > > 27 липня 2023 р. 18:09:22 GMT+03:00, Thierry Reding > написав(-ла): > >On Sun, Jun 18, 2023 at 11:50:44AM +0300, Svyatoslav Ryhel wrote: > >> This patch adds support for the bridge/connecto

Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node

2023-07-27 Thread Thierry Reding
On Thu, Jul 27, 2023 at 07:26:28PM +0300, Svyatoslav Ryhel wrote: > > > 27 липня 2023 р. 18:11:15 GMT+03:00, Thierry Reding > написав(-ла): > >On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote: > >> All ASUS Transformers have micro-HDMI connector dir

Re: (subset) [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS

2023-07-27 Thread Thierry Reding
From: Thierry Reding On Wed, 26 Jul 2023 20:48:55 +0200, Thierry Reding wrote: > From: Thierry Reding > > The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct > bindings file. > > Applied, thanks! [3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Ch

Re: (subset) [PATCH 1/3] dt-bindings: display: panel: Move Chunghwa CLAA070WP03XG to LVDS

2023-07-27 Thread Thierry Reding
From: Thierry Reding On Wed, 26 Jul 2023 20:50:08 +0200, Thierry Reding wrote: > From: Thierry Reding > > The Chunghwa CLAA070WP03XG is an LVDS panel, so move it to the correct > bindings file. > > Applied, thanks! [3/3] ARM: tegra: Provide specific compatible string

Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node

2023-07-27 Thread Thierry Reding
On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote: > All ASUS Transformers have micro-HDMI connector directly available. > After Tegra HDMI got bridge/connector support, we should use connector > framework for proper HW description. > > Tested-by: Andreas Westman Dorcsak # ASUS TF

Re: [PATCH v2 0/2] Support bridge/connector by Tegra HDMI

2023-07-27 Thread Thierry Reding
On Sun, Jun 18, 2023 at 11:50:44AM +0300, Svyatoslav Ryhel wrote: > This patch adds support for the bridge/connector attached to the > HDMI output, allowing to model the hardware properly. It keeps > backwards compatibility with existing bindings and is required > by devices which have a simple or

[PATCH 3/3] ARM: tegra: Provide specific compatible string for Nexus 7 panel

2023-07-26 Thread Thierry Reding
From: Thierry Reding panel-lvds alone is not a valid compatible string and we always need a specific compatible string as well. Nexus 7 can come with one of (at least) two panels, so pick one of them as the specific compatible string. Signed-off-by: Thierry Reding --- .../nvidia/tegra30-asus

[PATCH 1/3] dt-bindings: display: panel: Move Chunghwa CLAA070WP03XG to LVDS

2023-07-26 Thread Thierry Reding
From: Thierry Reding The Chunghwa CLAA070WP03XG is an LVDS panel, so move it to the correct bindings file. Signed-off-by: Thierry Reding --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ .../devicetree/bindings/display/panel/panel-simple.yaml | 2 -- 2 files

[PATCH 2/3] dt-bindings: display: panel: Document Hydis HV070WX2-1E0

2023-07-26 Thread Thierry Reding
From: Thierry Reding The Hydis HV070WX2-1E0 is a 7" WXGA (800x1280) TFT LCD LVDS panel that is one of the variants used on Google Nexus 7. Signed-off-by: Thierry Reding --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall

2023-07-26 Thread Thierry Reding
From: Thierry Reding The LVDS bindings require a specific compatible string in addition to the generic "panel-lvds". Add the HannStar HSD101PWW2 which is used on a similar device (ASUS TF201) and seems to work fine with slightly modified timings in DT. Suggested-by: Svyatoslav Ryhel

[PATCH 2/3] drm/panel: Relax porches for HannStar HSD101PWW2

2023-07-26 Thread Thierry Reding
From: Thierry Reding The porch maximum values for the HannStar HSD101PWW2 are unusually small. Make them a bit larger to allow a more flexibility when overriding the timings in device tree. Unfortunately the datasheet doesn't list porch limits in detail, so this is a bit of guesswork. Signed

[PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS

2023-07-26 Thread Thierry Reding
From: Thierry Reding The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct bindings file. Signed-off-by: Thierry Reding --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ .../devicetree/bindings/display/panel/panel-simple.yaml | 2 -- 2 files

Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-07-21 Thread Thierry Reding
From: Thierry Reding On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote: > Convert TI LP855X backlight controller bindings from TXT to YAML and, > while we're at it, rework some of the code related to PWM handling. > Also correct existing DTS files to avoid introducing new dtb_check

Re: [PATCH v3 2/2] gpu: host1x: Stop open-coding of_device_uevent()

2023-07-21 Thread Thierry Reding
On Thu, Jun 22, 2023 at 11:32:14PM +0200, Miquel Raynal wrote: > There is apparently no reasons to open-code of_device_uevent() besides: > - The helper receives a struct device while we want to use the of_node > member of the struct device *parent*. > - of_device_uevent() could not be called by

Re: [PATCH] gpu/host1x: Explicitly include correct DT includes

2023-07-21 Thread Thierry Reding
On Fri, Jul 14, 2023 at 11:45:49AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-21 Thread Thierry Reding
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thierry Reding
On Thu, Jul 13, 2023 at 05:39:36PM +0200, Uwe Kleine-König wrote: > On Thu, Jul 13, 2023 at 10:41:45AM -0400, Sean Paul wrote: > > On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König > > > But even with the one-patch-per-rename approach I'd consider the > > > renaming a net win, because ease of

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thierry Reding
Shortening the absurdly long recipient list, Google won't let me send this otherwise. On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated

Re: [PATCH 12/18] drm/tegra: dpaux: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Thierry Reding
On Fri, Jul 07, 2023 at 03:20:28PM +0800, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/tegra/dpaux.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c

Re: [PATCH v3 05/12] drm/tegra: Store pointer to vmap'ed framebuffer in screen_buffer

2023-07-07 Thread Thierry Reding
r I/O memory. > > Suggested-by: Thierry Reding > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v3 04/12] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-07 Thread Thierry Reding
ff-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Acked-by: Maxime Ripard > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v3 03/12] drm/tegra: Use fbdev DMA helpers

2023-07-07 Thread Thierry Reding
rtinez Canillas > Acked-by: Maxime Ripard > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/Kconfig | 2 +- > drivers/gpu/drm/tegra/fbdev.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v2 04/11] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thierry Reding
ff-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Acked-by: Maxime Ripard > Cc: Thierry Reding > Cc: Mikko Perttunen > --- > drivers/gpu/drm/tegra/fbdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tegra/fbdev.c b

Re: [PATCH v2 0/2] Enable GPU on Smaug

2023-06-08 Thread Thierry Reding
From: Thierry Reding On Tue, 16 May 2023 09:28:27 +0100, Diogo Ivo wrote: > This patch series enables the use of the GM20B GPU in the > Google Pixel C. > > Patch 1 adds the needed regulator DT node for the GPU. > > Patch 2 enables the GPU in the DT. > > [...] Appli

Re: [PATCH v5 09/13] drm/tegra: Use regular fbdev I/O helpers

2023-06-01 Thread Thierry Reding
tly within each DRM fbdev emulation, > we can eventually remove DRM's wrapper functions entirely. > > v4: > * use initializer macros for struct fb_ops > v2: > * use FB_SYS_HELPERS option > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc

Re: [GIT PULL] drm/tegra: Changes for v6.4-rc1

2023-04-06 Thread Thierry Reding
On Thu, Apr 06, 2023 at 03:55:10PM +0200, Daniel Vetter wrote: > On Thu, Apr 06, 2023 at 04:18:46PM +0300, Mikko Perttunen wrote: > > On 4/6/23 16:09, Daniel Vetter wrote: > > > On Thu, Apr 06, 2023 at 02:14:04PM +0200, Thierry Reding wrote: > > > > Hi Dave, Daniel,

[GIT PULL] drm/tegra: Changes for v6.4-rc1

2023-04-06 Thread Thierry Reding
Lee Jones (1): drm/tegra: dc: Remove set but unused variable 'state' Mikko Perttunen (1): gpu: host1x: Don't rely on dma_fence_wait_timeout return value Nur Hussein (1): drm/tegra: Avoid potential 32-bit integer overflow Thierry Reding (1): MAINTAINERS: Add Mikko

Re: [PATCH] drm/tegra : Avoid potential integer overflow of 32 bit int

2023-04-06 Thread Thierry Reding
From: Thierry Reding On Thu, 6 Apr 2023 04:25:59 +0800, Nur Hussein wrote: > In tegra_sor_compute_config(), the 32-bit value mode->clock > is multiplied by 1000, and assigned to the u64 variable pclk. > We can avoid a potential 32-bit integer overflow by casting > mode->clock t

Re: [PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-04-05 Thread Thierry Reding
From: Thierry Reding On Thu, 30 Mar 2023 10:36:00 +0200, Thomas Zimmermann wrote: > Convert tegra's fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in tegra is

Re: [PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-04-05 Thread Thierry Reding
On Thu, Mar 30, 2023 at 10:36:00AM +0200, Thomas Zimmermann wrote: > Convert tegra's fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in tegra is now just > another DRM

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Thierry Reding
On Wed, Apr 05, 2023 at 10:50:37AM +0200, Hans Verkuil wrote: [...] > Note that this driver will stay in staging since it still fails when I try to > capture from two sensors at the same time: syncpoint errors start appearing > in that case. I think there are locking issues. I think I have someone

Re: [PATCH 3/8] drm/aperture: Remove primary argument

2023-04-05 Thread Thierry Reding
; Cc: Javier Martinez Canillas > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Deepak Rawat > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Emma Anholt > Cc: Helge Deller &g

Re: [PATCH] dt-bindings: arm: nvidia: Drop unneeded quotes

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Fri, 31 Mar 2023 13:21:59 -0500, Rob Herring wrote: > Cleanup bindings dropping unneeded quotes. Once all these are fixed, > checking for this can be enabled in yamllint. > > Applied, thanks! [1/1] dt-bindings: arm: nvidia: Drop unneeded quotes

Re: [PATCH] gpu: host1x: Don't rely on dma_fence_wait_timeout return value

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Wed, 1 Mar 2023 15:51:06 +0200, Mikko Perttunen wrote: > From: Mikko Perttunen > > dma_fence_wait_timeout (along with a host of other jiffies-based > timeouting functions) returns zero both in case of timeout and when > the wait completes during the la

Re: (subset) [PATCH v2 RESEND 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Mon, 28 Nov 2022 16:28:49 +, Diogo Ivo wrote: > In cases where the DSI module is left on by the bootloader > some panels may fail to initialize if the enable register is not cleared > before the panel's initialization sequence is sent,

Re: [PATCH v2] drm/tegra: sor: Make use of the helper function dev_err_probe()

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Fri, 17 Sep 2021 10:07:41 +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > And using dev_err_probe() can

Re: [PATCH 00/12] drm/tegra: Convert to platform remove callback returning void

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Wed, 22 Mar 2023 18:02:11 +0100, Uwe Kleine-König wrote: > this series adapts the platform drivers below drivers/gpu/drm/tegra to > use the .remove_new() callback. Compared to the traditional .remove() > callback .remove_new() returns no value. This is a g

Re: (subset) [PATCH 09/37] drm/tegra/dc: Remove set but unused variable 'state'

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Fri, 17 Mar 2023 08:16:50 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/tegra/dc.c: In function > ‘tegra_crtc_calculate_memory_bandwidth’: > drivers/gpu/drm/tegra/dc.c:2384:38: warning: variable

Re: [PATCH] drm/tegra: allow compile test on !ARM v2

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Wed, 22 Mar 2023 11:39:15 +0100, Christian König wrote: > This compile tests on x86 just perfectly fine. > > v2: fix missing include complained by kernel test robot > > Applied, thanks! [1/1] drm/tegra: allow compile test on !ARM

Re: [PATCH] drm/tegra: plane: Improve use of dev_err_probe()

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Thu, 16 Sep 2021 15:37:21 +0800, Cai Huoqing wrote: > Return dev_err_probe() directly, because the return value of > dev_err_probe() is the appropriate error code, and it can > reduce code size, simplify the code. > > Applied, thanks! [1/1] drm/tegra:

Re: [PATCH] drm/tegra: dsi: Make use of the helper function dev_err_probe()

2023-04-04 Thread Thierry Reding
From: Thierry Reding On Thu, 16 Sep 2021 18:56:40 +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > And using dev_err_probe() can

[PATCH] MAINTAINERS: Add Mikko as backup maintainer for Tegra DRM

2023-04-04 Thread Thierry Reding
From: Thierry Reding Mikko has been involved as the primary author of the host1x driver and has volunteered to help out with maintenance. Signed-off-by: Thierry Reding --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7bfa5228d1ea

  1   2   3   4   5   6   7   8   9   10   >