[PATCH] drm/msm/dsi: prevent unintentional integer overflow in dsi_pll_28nm_clk_recalc_rate()

2021-09-29 Thread Tim Gardner
long. Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: linux-arm-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedr...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/gpu/drm

[PATCH] drm/msm: prevent NULL dereference in msm_gpu_crashstate_capture()

2021-09-29 Thread Tim Gardner
vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedr...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/dr

[PATCH][next] nvidiafb: Use strscpy() to prevent buffer overflow.

2021-09-27 Thread Tim Gardner
trscpy() which will silence the warning and prevent any future buffer overflows should the names used to identify the channel become much longer. Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tim Gardner --- d

Re: [PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer()

2021-09-24 Thread Tim Gardner
On 9/24/21 9:26 AM, Tim Gardner wrote: Coverity complains of an unused return code: CID 120459 (#1 of 1): Unchecked return value (CHECKED_RETURN) 7. check_return: Calling regmap_bulk_write without checking return value (as is done elsewhere 199 out of 291 times). 204regmap_bulk_write

[PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer()

2021-09-24 Thread Tim Gardner
Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: linux-...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/bridge

Re: [PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-21 Thread Tim Gardner
On 9/20/21 8:07 PM, Karol Herbst wrote: On Mon, Sep 20, 2021 at 8:17 PM Tim Gardner wrote: Coverity complains of a resource leak in ga102_chan_new(): CID 119637 (#7 of 7): Resource leak (RESOURCE_LEAK) 13. leaked_storage: Variable chan going out of scope leaks the storage it points

[PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-20 Thread Tim Gardner
: David Airlie Cc: Daniel Vetter Cc: Karol Herbst Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tim Gardner --- .../gpu/drm/nouveau/nvkm/engine/fifo/ga102.c | 20 --- 1 file changed, 13 insertions(+), 7

[PATCH v2] drm/i915: use strscpy() to avoid buffer overrun

2021-09-16 Thread Tim Gardner
Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/i915/i915_gpu_error.c | 6 +++--- 1 file changed, 3

Re: [Intel-gfx] [PATCH] drm/i915: zero fill vma name buffer

2021-09-16 Thread Tim Gardner
On 9/16/21 4:43 AM, Jani Nikula wrote: On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: On 15/09/2021 20:23, Tim Gardner wrote: In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length

[PATCH] drm/i915: zero fill vma name buffer

2021-09-15 Thread Tim Gardner
using strncpy(). Zero fill the name buffer to guarantee ASCII string NULL termination. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-b

[PATCH] drm/i915/gem: Avoid NULL dereference in __i915_gem_object_lock()

2021-08-18 Thread Tim Gardner
rigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +

Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
On 05/02/2014 12:30 PM, Tim Gardner wrote: > On 05/02/2014 11:21 AM, Alex Deucher wrote: >> On Fri, May 2, 2014 at 12:40 PM, Tim Gardner >> wrote: >>> I've bisected a resume regression on a Lenovo x120e to >>> 177cf92de4aa97ec1435987e91696ed8b5023130 (drm/cr

Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
On 05/02/2014 11:21 AM, Alex Deucher wrote: > On Fri, May 2, 2014 at 12:40 PM, Tim Gardner > wrote: >> I've bisected a resume regression on a Lenovo x120e to >> 177cf92de4aa97ec1435987e91696ed8b5023130 (drm/crtc-helpers: fix dpms on >> logic). Everything works fine

Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
causing this laptop to resume to a black screen wherein the platform appears to be locked up (no console, no network). See attached bisect log and lspci. The BIOS version is 1.15. rtg -- Tim Gardner tim.gardner at canonical.com -- next part -- # bad

[PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure

2013-08-01 Thread Tim Gardner
ERROR: "__divdi3" [drivers/gpu/drm/radeon/radeon.ko] undefined! make[3]: *** [__modpost] Error 1 gcc version 4.8.1 Cc: David Airlie Cc: Alex Deucher Signed-off-by: Tim Gardner --- drivers/gpu/drm/radeon/si_dpm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure

2013-08-01 Thread Tim Gardner
ERROR: __divdi3 [drivers/gpu/drm/radeon/radeon.ko] undefined! make[3]: *** [__modpost] Error 1 gcc version 4.8.1 Cc: David Airlie airl...@linux.ie Cc: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/gpu/drm/radeon/si_dpm.c |2 +- 1

[PATCH linux-next] drm/radeon: Avoid NULL pointer dereference from atom_index_iio() allocation failure

2013-02-11 Thread Tim Gardner
ve Airlie Cc: "Christian K?nig" Cc: Jerome Glisse Cc: dri-devel at lists.freedesktop.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/radeon/atom.c |9 +++-- drivers/gpu/drm/radeon/radeon_device.c |9 - 2 files changed, 15 insertions(+), 3 deletions(-) diff

[PATCH linux-next] drm/radeon: Avoid NULL pointer dereference from atom_index_iio() allocation failure

2013-02-11 Thread Tim Gardner
: Michel Dänzer michel.daen...@amd.com Cc: Dave Airlie airl...@redhat.com Cc: Christian König christian.koe...@amd.com Cc: Jerome Glisse jgli...@redhat.com Cc: dri-devel@lists.freedesktop.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/gpu/drm/radeon/atom.c |9

[PATCH v2 3.7-rc8] ttm: Fix possible _manager memory allocation oops

2012-12-08 Thread Tim Gardner
Airlie airl...@linux.ie Cc: Dave Airlie airl...@redhat.com Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Zhao Yakui yakui.z...@intel.com Cc: David Howells dhowe...@redhat.com Cc: dri-devel@lists.freedesktop.org Cc: sta...@vger.kernel.org # 3.5+ Signed-off-by: Tim Gardner tim.gard

[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-08 Thread Tim Gardner
the kernel stack. Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- V2 - spaces around '*', use kmalloc instead of kzalloc(). Missed error return that would have orphaned memory. drivers

[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-07 Thread Tim Gardner
the kernel stack. Cc: Daniel Vetter Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Signed-off-by: Tim Gardner --- V2 - spaces around '*', use kmalloc instead of kzalloc(). Missed error return that would have orphaned memory. drivers/gpu/drm/i915/intel_display.c | 22

[PATCH v2 3.7-rc8] ttm: Fix possible _manager memory allocation oops

2012-12-07 Thread Tim Gardner
Airlie Cc: Dave Airlie Cc: "Paul E. McKenney" Cc: Zhao Yakui Cc: David Howells Cc: dri-devel at lists.freedesktop.org Cc: stable at vger.kernel.org # 3.5+ Signed-off-by: Tim Gardner --- This patch applies to stable 3.5 and newer. V2 - kobject_put(&_manager->kobj)

[PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-07 Thread Tim Gardner
the kernel stack, especially if struct drm_display_mode ever grows significantly. Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/gpu/drm/i915/intel_display.c | 18

Re: [PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops

2012-12-07 Thread Tim Gardner
)) { kobject_put(_manager-kobj); + kfree(_manager); _manager = NULL; I don;t think this is, since the kobject_put shuold free it. kobject_put only frees memory referenced by kobj, but not the memory pointed at by _manager. rtg -- Tim Gardner

[PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops

2012-12-06 Thread Tim Gardner
ct_put shuold free it. > kobject_put only frees memory referenced by kobj, but not the memory pointed at by _manager. rtg -- Tim Gardner tim.gardner at canonical.com

[PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-06 Thread Tim Gardner
the kernel stack, especially if struct drm_display_mode ever grows significantly. Cc: Daniel Vetter Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/i915/intel_display.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions

[PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops

2012-12-06 Thread Tim Gardner
dereference '_manager'. (kzalloc returns null) Cc: David Airlie Cc: Dave Airlie Cc: "Paul E. McKenney" Cc: Zhao Yakui Cc: David Howells Cc: dri-devel at lists.freedesktop.org Cc: stable at vger.kernel.org # 3.5+ Signed-off-by: Tim Gardner --- This patch applies to stable 3.5 and newer.

[PATCH 3.7-rc8] drm: Fix possible EDID memory allocation oops

2012-12-06 Thread Tim Gardner
'. (drm_property_create_blob returns null) drm_property_create_blob() calls kzalloc() which can return NULL. Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org Cc: sta...@vger.kernel.org # 3.0+ Signed-off-by: Tim Gardner tim.gard...@canonical.com --- This bug actually exists

[PATCH 3.7-rc8] drm: Fix possible EDID memory allocation oops

2012-12-05 Thread Tim Gardner
ptr'. (drm_property_create_blob returns null) drm_property_create_blob() calls kzalloc() which can return NULL. Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Cc: stable at vger.kernel.org # 3.0+ Signed-off-by: Tim Gardner --- This bug actually exists in the original com

drm/vmwgfx: add MODULE_DEVICE_TABLE so vmwgfx loads at boot

2012-09-06 Thread Tim Gardner
://bugs.launchpad.net/ubuntu/oneiric/+source/linux/+bug/1039157/comments/31 for confirmation. I think it should also be 'Cc: stable at vger.kernel.org'. It applies as far back as 2.6.32 with minor context differences. rtg -- Tim Gardner tim.gardner at canonical.com

drm/vmwgfx: add MODULE_DEVICE_TABLE so vmwgfx loads at boot

2012-09-06 Thread Tim Gardner
://bugs.launchpad.net/ubuntu/oneiric/+source/linux/+bug/1039157/comments/31 for confirmation. I think it should also be 'Cc: sta...@vger.kernel.org'. It applies as far back as 2.6.32 with minor context differences. rtg -- Tim Gardner tim.gard...@canonical.com ___ dri

3.4-rc7 backlight regression on Dell XPS M1710

2012-05-17 Thread Tim Gardner
On 05/17/2012 12:20 AM, Ben Skeggs wrote: > On Thu, May 17, 2012 at 10:30 AM, Ben Skeggs wrote: >> Am Mittwoch, den 16.05.2012, 12:17 -0600 schrieb Tim Gardner: >>> commit b99da31ed8521eb78d5d6930f3128f8ecdb75fae causes the backlight in >>> my Dell XPS M1710 to sto

Re: 3.4-rc7 backlight regression on Dell XPS M1710

2012-05-17 Thread Tim Gardner
On 05/17/2012 12:20 AM, Ben Skeggs wrote: On Thu, May 17, 2012 at 10:30 AM, Ben Skeggsbske...@redhat.com wrote: Am Mittwoch, den 16.05.2012, 12:17 -0600 schrieb Tim Gardner: commit b99da31ed8521eb78d5d6930f3128f8ecdb75fae causes the backlight in my Dell XPS M1710 to stop working. Symptoms

3.4-rc7 backlight regression on Dell XPS M1710

2012-05-16 Thread Tim Gardner
>TAbort- SERR- Kernel driver in use: nouveau Kernel modules: nouveau, nvidiafb rtg -- Tim Gardner tim.gardner at canonical.com -- next part -- # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 3.4.0-rc6 Kernel Configuration # CONFIG_64BI