Re: [PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-29 Thread Tzung-Bi Shih
On Mon, Sep 16, 2024 at 01:00:24PM +0200, Javier Martinez Canillas wrote: > This is v4 of a fix to prevent both coreboot and sysfb drivers to register > a platform device to setup a system framebuffer. It has been converted to > a series since contains changes for both drivers, to prevent build iss

Re: [PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-19 Thread Tzung-Bi Shih
On Mon, Sep 16, 2024 at 01:00:24PM +0200, Javier Martinez Canillas wrote: > The patches have only been compiled tested because I don't have access to > a coreboot machine. Please let me know if you plan to merge both patches > through the chrome-platforms tree or if you prefer to get merged through

Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-15 Thread Tzung-Bi Shih
On Fri, Sep 13, 2024 at 11:32:29PM +0200, Javier Martinez Canillas wrote: > @@ -27,8 +28,10 @@ static int framebuffer_probe(struct coreboot_device *dev) > int i; > u32 length; > struct lb_framebuffer *fb = &dev->framebuffer; > + const struct screen_info *si = &screen_info; >

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-06 Thread Tzung-Bi Shih
On Wed, Sep 04, 2024 at 02:45:36PM -0700, Stephen Boyd wrote: > Quoting Tzung-Bi Shih (2024-09-04 02:36:45) > > On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > > > +static void cros_typec_inject_hpd(struct cros_typec_data *typec, > > > +

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-04 Thread Tzung-Bi Shih
On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > +static void cros_typec_inject_hpd(struct cros_typec_data *typec, > + struct ec_response_usb_pd_mux_info *resp, > + struct cros_typec_port *port) > +{ [...] > + /* > +

Re: [PATCH v4 17/18] platform/chrome: cros_ec_typec: Support DP muxing

2024-09-04 Thread Tzung-Bi Shih
gt; Cc: Benson Leung > Cc: Tzung-Bi Shih > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd Reviewed-by: Tzung-Bi Shih

Re: [PATCH v4 16/18] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-09-04 Thread Tzung-Bi Shih
edrivers connected to it over something like i2c and DP/USB from the AP > is wired directly to those ICs, not the EC. > > [...] > > Cc: Prashant Malani > Cc: Benson Leung > Cc: Tzung-Bi Shih > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd Reviewed-by: Tzung-Bi Shih

Re: [PATCH v3 15/17] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-26 Thread Tzung-Bi Shih
On Fri, Aug 23, 2024 at 01:47:23PM -0700, Stephen Boyd wrote: > Quoting Tzung-Bi Shih (2024-08-22 07:35:13) > > On Mon, Aug 19, 2024 at 03:38:29PM -0700, Stephen Boyd wrote: > > > +struct cros_typec_dp_bridge { > > > + struct cros_typec_data *typ

Re: [PATCH v3 16/17] platform/chrome: cros_ec_typec: Support DP muxing

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:30PM -0700, Stephen Boyd wrote: > @@ -671,6 +674,20 @@ static int cros_typec_configure_mux(struct > cros_typec_data *typec, int port_num, > if (port->mux_flags == resp.flags && port->role == pd_ctrl->role) > return 0; > > + dp_enabled = resp.

Re: [PATCH v3 15/17] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:29PM -0700, Stephen Boyd wrote: > +struct cros_typec_dp_bridge { > + struct cros_typec_data *typec_data; > + struct drm_dp_typec_bridge_dev *dev; > +}; It looks like structs are all defined in cros_ec_typec.h. I think this struct definition can be also moved

Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:27PM -0700, Stephen Boyd wrote: > -title: Google Chrome OS EC(Embedded Controller) Type C port driver. > +title: Google Chrome OS Embedded Controller (EC) USB type-c port driver Given that it gets chance to modify, how about s/Chrome OS/ChromeOS/?

Re: [PATCH] drm/bridge: anx7625: Prevent endless probe loop

2023-05-23 Thread Tzung-Bi Shih
> Reported-by: "kernelci.org bot" > Signed-off-by: Nícolas F. R. A. Prado Tested-by: Tzung-Bi Shih The patch can fix the "login" test failures observed on mt8183-kukui-jacuzzi-juniper-sku16 and mt8192-asurada-spherion-r0 in kernelci[1]. [1]: https://linux.kernelci.or

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-11-30 Thread Tzung-Bi Shih
return 0; > } > > state->enabled = (ret > 0); > @@ -212,6 +212,8 @@ static void cros_ec_pwm_get_state(struct pwm_chip *chip, > struct pwm_device *pwm, > state->duty_cycle = channel->duty_cycle; > else > state->duty_cycle = ret; > + > + return 0; > } For the cros-ec part: Reviewed-by: Tzung-Bi Shih

Re: [PATCH 1/6] ASoC: hdmi-codec: add PCM trigger operator

2022-11-24 Thread Tzung-Bi Shih
On Thu, Nov 24, 2022 at 1:52 PM Allen-KH Cheng (程冠勳) wrote: > We would want to confirm with you as we work on the hdmi-codec for the > mt8186. > > Do you have any plan to continue working on this series? We may take > over as well. No (from testing's perspective). Please take over it as you requ

Re: [PATCH 2/2] dt-bindings: sound: rt1015p: correct indentation

2021-08-19 Thread Tzung-Bi Shih
ected 4 but > > found 6 (indentation) > > > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Rob Herring Acked-by: Tzung-Bi Shih

Re: [PATCH v2 2/3] drm/mediatek: support HDMI jack status reporting

2020-02-13 Thread Tzung-Bi Shih
On Thu, Feb 13, 2020 at 9:57 AM CK Hu wrote: > I'm not only consider the race condition of plugged_cb and codec_dev. I > also care about the atomic of mtk_cec_hpd_high() and hdmi->plugged_cb(). > If these two function is not an atomic operation, below is an example of > problem: > > > 1. Thread A

Re: [PATCH v9 5/6] ARM: dts: rockchip: Add HDMI support to rk3288-veyron-analog-audio

2019-10-31 Thread Tzung-Bi Shih
Mark, This series has 6 patches. We noticed you have merged the first 4 patches (includes the DT binding one: https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/157668.html). There are 2 DTS patches are still on the list: - [PATCH v9 5/6] ARM: dts: rockchip: Add HDMI support to r

[PATCH 0/6] ASoC: mediatek: mt8183: support DP audio

2019-10-23 Thread Tzung-Bi Shih
roject.org/pipermail/alsa-devel/2019-September/155302.html to report jack status (from DRM to ASoC). Allen Chen (1): drm: bridge: it6505: bridge to hdmi-codec Tzung-Bi Shih (5): ASoC: hdmi-codec: add PCM trigger operator ASoC: dt-bindings: mt8183: add a property "mediatek,hdmi-codec&

[PATCH 6/6] ASoC: mediatek: mt8183: support HDMI jack reporting

2019-10-23 Thread Tzung-Bi Shih
Support HDMI jack reporting. Signed-off-by: Tzung-Bi Shih --- sound/soc/mediatek/Kconfig| 3 ++- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 20 ++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/Kconfig b/sound/soc

[PATCH 2/6] drm: bridge: it6505: bridge to hdmi-codec

2019-10-23 Thread Tzung-Bi Shih
ff-by: Tzung-Bi Shih --- drivers/gpu/drm/bridge/ite-it6505.c | 152 1 file changed, 152 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 5e046f677343..1d19184d2056 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c

[PATCH 1/6] ASoC: hdmi-codec: add PCM trigger operator

2019-10-23 Thread Tzung-Bi Shih
HDMI codec may be also interested in PCM triggers. Add PCM trigger operator. Signed-off-by: Tzung-Bi Shih --- include/sound/hdmi-codec.h| 13 + sound/soc/codecs/hdmi-codec.c | 31 +++ 2 files changed, 44 insertions(+) diff --git a/include/sound/hdmi

[PATCH 4/6] ASoC: mediatek: mt8183: use hdmi-codec

2019-10-23 Thread Tzung-Bi Shih
Add DAI link to use hdmi-codec. Signed-off-by: Tzung-Bi Shih --- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c b/sound/soc/mediatek/mt8183/mt8183

[PATCH 5/6] drm: bridge: it6505: report connector status

2019-10-23 Thread Tzung-Bi Shih
When a connector connected or disconnected, report the jack status. Signed-off-by: Tzung-Bi Shih --- drivers/gpu/drm/bridge/ite-it6505.c | 39 +++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm

[PATCH 3/6] ASoC: dt-bindings: mt8183: add a property "mediatek, hdmi-codec"

2019-10-23 Thread Tzung-Bi Shih
Add an optional property "mediatek,hdmi-codec". Signed-off-by: Tzung-Bi Shih --- .../bindings/sound/mt8183-mt6358-ts3a227-max98357.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt b/Doc

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-07-17 Thread Tzung-Bi Shih
ice > ASoC: rockchip_max98090: Add dai_link for HDMI > ASoC: rockchip_max98090: Add HDMI jack support > LGTM. Reviewed-by: Tzung-Bi Shih

Re: [PATCH v4 5/5] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-16 Thread Tzung-Bi Shih
On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/rockchip/rockchip_max98090.c > b/sound/soc/rockchip/rockchip_max98090.c > index c82948e383da..c81c4acda917 100644 > --- a/sound/soc/rockchip/rockchip_max98090.c > +++ b/sound/soc/rockchip/rockchip_max98090.c > +stat

Re: [PATCH v4 4/5] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-16 Thread Tzung-Bi Shih
On Tue, Jul 16, 2019 at 7:58 PM Cheng-Yi Chiang wrote: > > diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig > index b43657e6e655..d610b553ea3b 100644 > --- a/sound/soc/rockchip/Kconfig > +++ b/sound/soc/rockchip/Kconfig > @@ -40,9 +40,10 @@ config SND_SOC_ROCKCHIP_MAX98090 >

Re: [PATCH v4 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-16 Thread Tzung-Bi Shih
On Tue, Jul 16, 2019 at 7:57 PM Cheng-Yi Chiang wrote: > > Change the Kconfig of DRM_DW_HDMI so it selects SND_SOC_HDMI_CODEC. > This is for the typedef of hdmi_codec_plugged_cb to be used in dw-hdmi.c. Not sure why you select SND_SOC_HDMI_CODEC in this patch. To have definition of hdmi_codec_plu

Re: [PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-15 Thread Tzung-Bi Shih
On Fri, Jul 12, 2019 at 6:58 PM Russell King - ARM Linux admin wrote: > > On Fri, Jul 12, 2019 at 06:04:39PM +0800, Cheng-Yi Chiang wrote: > > Add an op in hdmi_codec_ops so codec driver can register callback > > function to handle plug event. > > > > Driver in DRM can use this callback function t

Re: [PATCH 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-05 Thread Tzung-Bi Shih
On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > diff --git a/sound/soc/rockchip/rockchip_max98090.c > b/sound/soc/rockchip/rockchip_max98090.c > index c5fc24675a33..195309d1225a 100644 > --- a/sound/soc/rockchip/rockchip_max98090.c > +++ b/sound/soc/rockchip/rockchip_max98090.c > static

Re: [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-05 Thread Tzung-Bi Shih
On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h > index 63b5756f463b..f523c590984e 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h > +++ b/drivers/gpu/drm/bridg

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-05 Thread Tzung-Bi Shih
On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h > index 7fea496f1f34..26c02abb8eba 100644 > --- a/include/sound/hdmi-codec.h > +++ b/include/sound/hdmi-codec.h > @@ -47,6 +47,9 @@ struct hdmi_codec_params { > int