[PATCH v1] fbdev: aty: remove CONFIG_PM container

: use generic power management") Signed-off-by: Vaibhav Gupta Reported-by: kernel test robot --- drivers/video/fbdev/aty/atyfb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h index a7833bc98225..551372f9b

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

On Mon, Sep 07, 2020 at 09:55:59AM +0200, Daniel Vetter wrote: > On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote: > > Linux Kernel Mentee: Remove Legacy Power Management. > > > > The original goal of the patch series is to upgrade the power management >

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

Please review this patch-series. Thank you Vaibhav Gupta ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 --- dr

Re: [PATCH v1 2/2] fbdev: radeonfb:use generic power management

___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Linux-kernel-mentees] [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

On Mon, Sep 07, 2020 at 08:48:10AM +0200, Greg KH wrote: > On Mon, Sep 07, 2020 at 12:03:47PM +0530, Vaibhav Gupta wrote: > > > > Why did you send empty emails out? > > greg k-h I was trying to re-ping the patches. Guess it went empty. I will send pa

Re: [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1 2/2] fbdev: radeonfb:use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/radeon_base.c | 10 +--- drivers/video/fbdev/aty/radeon_pm.c | 36 +-- drivers/video/fbdev/aty/radeonfb.h| 3 +-- 3 files changed, 35 insertions(+), 14 deletions(-) diff --git a/drivers/

[PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

. It also affected the "#ifdef CONFIG_PPC_OF" container (line 1943-2510). >From the current snapshot of radeon_pm.c, remove: 1434 | #if defined(CONFIG_PM) and, 2213 | #endif This removes the redundant CONFIG_PM directive as well as fixes the CONFIG_PPC (earlier CONFIG_PPC_O

[PATCH v3 00/12] video: fbdev: use generic power management

job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v3 07/12] fbdev: savagefb: use generic power management

e() which in turn call savagefb_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "savagefb_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/savage/savagefb_

[PATCH v3 08/12] fbdev: cyber2000fb: use generic power management

Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. This way we can remove the legacy .suspend & .resume bindings from "lxfb_driver". Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 02/12] fbdev: lxfb: use generic power management

by binding the callback with only "lxfb_pm_ops.suspend" in the new framework. This also avoids the step of checking "if (state.event == PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h

[PATCH v3 03/12] fbdev: via-core: use generic power management

voids the step of checking "if (state.event != PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed, 16 insertions(+), 25 deleti

[PATCH v3 06/12] fbdev: nvidia: use generic power management

e() which in turn call nvidiafb_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "nvidiafb_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/nvidia/nvidia.c

[PATCH v3 12/12] fbdev: arkfb: use generic power management

by binding the callback with only ".suspend" and ".poweroff" in the "ark_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 11/12] fbdev: s3fb: use generic power management

by binding the callback with only ".suspend" and ".poweroff" in the "s3_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/

[PATCH v3 04/12] fbdev: aty: use generic power management

ernate() which in turn call atyfb_pci_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "atyfb_pci_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/atyfb_ba

[PATCH v3 09/12] fbdev: i740fb: use generic power management

by binding the callback with only ".suspend" and ".poweroff" in the "i740fb_pm_ops" const variable. This also avoids the step of checking "if (state.event == PM_EVENT_FREEZE)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/v

[PATCH v3 01/12] fbdev: gxfb: use generic power management

by binding the callback with only "gxfb_pm_ops.suspend" in the new framework. This also avoids the step of checking "if (state.event == PM_EVENT_SUSPEND)" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h

[PATCH v3 05/12] fbdev: aty128fb: use generic power management

i_hibernate() which in turn call aty128_pci_suspend_late() by passing appropriate value for "pm_message_t" type parameter. - Bind the callbacks in "struct dev_pm_ops" type variable "aty128_pci_pm_ops". Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/

[PATCH v3 10/12] fbdev: vt8623fb: use generic power management

by binding the callback with only ".suspend" and ".poweroff" in the "vt8623_pci_pm_ops" const variable. This also avoids the step of checking "state.event == PM_EVENT_FREEZE" every time the callback is invoked. Signed-off-by: Vaibhav Gupta --- drivers/v

Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management

On Sun, Aug 16, 2020 at 10:16:01PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Tue, Aug 11, 2020 at 12:27:12AM +0530, Vaibhav Gupta wrote: > > Drivers should do only device-specific jobs. But in general, drivers using > > legacy PCI PM framework for .suspend()/.resume() ha

Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management

On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote: > > Drivers should do only device-specific jobs. But in general, drivers using > > legacy PCI PM framework for .suspend()/.resume() ha

[PATCH v2 09/12] fbdev: i740fb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

On Mon, Aug 10, 2020 at 06:54:58PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > On Mon, Aug 10, 2020 at 03:09:48PM +0530, Vaibhav Gupta wrote: > > On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > > > Hi Vaibhav > > > > > > On Wed, Aug 05, 2020 a

[PATCH v2 06/12] fbdev: nvidia: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 04/12] fbdev: aty: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 00/12] video: fbdev: use generic power management

job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v2 11/12] fbdev: s3fb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 07/12] fbdev: savagefb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 03/12] fbdev: via-core: use generic power management

to remove the unnecessary call to via_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed,

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states them

[PATCH v2 05/12] fbdev: aty128fb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 02/12] fbdev: lxfb: use generic power management

this helps us to remove the unnecessary call to lxfb_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h | 5 drivers/video/fbdev/geode/lxfb_core.c | 37 +++---

[PATCH v2 01/12] fbdev: gxfb: use generic power management

this helps us to remove the unnecessary call to gxfb_suspend() in the event of Freeze and Hibernate, as the function does nothing in their case. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h | 5 drivers/video/fbdev/geode/gxfb_core.c | 36 ++---

[PATCH v2 12/12] fbdev: arkfb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 10/12] fbdev: vt8623fb: use generic power management

handle them. Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav Gupta

[PATCH v2 08/12] fbdev: cyber2000fb: use generic power management

Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/cyber2000fb.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 42d37bed518a..d45355b9a58c 100644 --- a/drivers/video/fbdev/cyber2000fb.c

[PATCH v1 11/12] fbdev: s3fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/s3fb.c | 39 -- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 60c424fae988..5c74253e7b2c 100644 --- a/driv

[PATCH v1 2/2] fbdev: radeonfb:use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/radeon_base.c | 10 +--- drivers/video/fbdev/aty/radeon_pm.c | 36 +-- drivers/video/fbdev/aty/radeonfb.h| 3 +-- 3 files changed, 35 insertions(+), 14 deletions(-) diff --git a/drivers/

[PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

. It also affected the "#ifdef CONFIG_PPC_OF" container (line 1943-2510). >From the current snapshot of radeon_pm.c, remove: 1434 | #if defined(CONFIG_PM) and, 2213 | #endif This removes the redundant CONFIG_PM directive as well as fixes the CONFIG_PPC (earlier CONFIG_PPC_O

[PATCH v1 07/12] fbdev: savagefb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/savage/savagefb_driver.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c ind

[PATCH v1 08/12] fbdev: cyber2000fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/cyber2000fb.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 42d37bed518a..d45355b9a58c 100644 --- a/driv

[PATCH v1 06/12] fbdev: nvidia: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/nvidia/nvidia.c | 64 - 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index c24de9107958..3a1a4330e0

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

On Wed, Aug 05, 2020 at 03:19:01PM -0500, Bjorn Helgaas wrote: > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also &

[PATCH v1 03/12] fbdev: via-core: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/via/via-core.c | 39 -- include/linux/via-core.h | 2 -- 2 files changed, 16 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/via/via-core.c b/drivers/video/fbdev/via/v

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 --- dr

[PATCH v1 10/12] fbdev: vt8623fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/vt8623fb.c | 41 ++ 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/vt8623fb.c b/drivers/video/fbdev/vt8623fb.c index 7b3eef1b893f..c488e0117758 100644 ---

[PATCH v1 09/12] fbdev: i740fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/i740fb.c | 40 +++- 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index c65ec7386e87..8d7f06fc8a5a 100644 ---

[PATCH v1 02/12] fbdev: lxfb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/lxfb.h | 5 drivers/video/fbdev/geode/lxfb_core.c | 37 +++ drivers/video/fbdev/geode/lxfb_ops.c | 4 --- 3 files changed, 20 insertions(+), 26 deletions(-) diff --git a/drivers/vi

[PATCH v1 12/12] fbdev: arkfb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/arkfb.c | 41 +++-- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index 11ab9a153860..6a4114db0dfd 100644 --- a/driv

[PATCH v1 00/12] video: fbdev: use generic power management

job. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav

[PATCH v1 04/12] fbdev: aty: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/atyfb_base.c | 50 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b0ac895e5ac9..a24d5bf6ad

[PATCH v1 05/12] fbdev: aty128fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/aty/aty128fb.c | 51 -- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c index d05d4195acad..dd7762fea0

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 --- dr

[PATCH v1 01/12] fbdev: gxfb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/video/fbdev/geode/gxfb.h | 5 drivers/video/fbdev/geode/gxfb_core.c | 36 ++ drivers/video/fbdev/geode/suspend_gx.c | 4 --- 3 files changed, 20 insertions(+), 25 deletions(-) diff --git a/driv

Re: [PATCH net-next] ksz884x: mark pcidev_suspend() as __maybe_unused

dev_suspend(struct device *dev_d) > { > int i; > struct platform_info *info = dev_get_drvdata(dev_d); > This is a necessary fix. Thanks ! --Vaibhav Gupta ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel