[PATCH v2] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-06-07 Thread Vasily Khoruzhick
il driver load if no display hw present.") Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/337 Signed-off-by: Vasily Khoruzhick --- v2: drop extra checks in nouveau_display_hpd_work() and nouveau_connector_hpd() drivers/gpu/drm/nouveau/dispnv04/disp.c | 2 +- drivers/gpu/drm/nouv

Re: [PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-06-07 Thread Vasily Khoruzhick
On Thu, Jun 6, 2024 at 6:37 PM Dave Airlie wrote: > > readding original poster Thanks, Dave! Ben, please keep me on CC, since I'm not subscribed to either nouveau or dri-devel mailing lists. > On Wed, 29 May 2024 at 09:57, Ben Skeggs wrote: > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_c

[PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-05-28 Thread Vasily Khoruzhick
il driver load if no display hw present.") Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/337 Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/nouveau/dispnv04/disp.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau/nouveau_connector.c

Re: [PATCH v1 6/6] drm/lima: improve some pp debug messages

2024-01-17 Thread Vasily Khoruzhick
On Tue, Jan 16, 2024 at 7:12 PM Erico Nunes wrote: > > Make the messages more consistent by showing the pp name. > > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > drivers/gpu/drm/lima/lima_pp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH v1 5/6] drm/lima: remove guilty drm_sched context handling

2024-01-17 Thread Vasily Khoruzhick
; application going. > > Other similar embedded GPU drivers don't make use of the guilty context > flag. Now that there are reliability improvements to the lima timeout > recovery handling, drop the guilty contexts to let the application keep > running in this case. > > Si

Re: [PATCH v1 4/6] drm/lima: handle spurious timeouts due to high irq latency

2024-01-17 Thread Vasily Khoruzhick
it users. > > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > drivers/gpu/drm/lima/lima_sched.c | 32 ++- > drivers/gpu/drm/lima/lima_sched.h | 2 ++ > 2 files changed, 29 insertions(+), 5 deletions(-) > > diff --git a/drivers/

Re: [PATCH v1 3/6] drm/lima: set bus_stop bit before hard reset

2024-01-17 Thread Vasily Khoruzhick
r lockups which cause the entire gpu to hang. It looks like Mali driver is doing the same, so it totally makes sense. > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > drivers/gpu/drm/lima/lima_pp.c | 13 + > 1 file changed, 13 insertions(+) > >

Re: [PATCH v1 2/6] drm/lima: reset async_reset on pp hard reset

2024-01-17 Thread Vasily Khoruzhick
t; debug, as it blames a reset timeout on the next application to submit a > job. > Reset the async_reset flag when doing the hard reset so that we don't > get that message. > > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > drivers/gpu/drm/li

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-17 Thread Vasily Khoruzhick
lance happens because lima_sched_pipe_task_done() already calls > lima_pm_idle for this case if there was no error. > Check the error flag in the timeout handler to ensure we can never run > into this case. > > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > driv

Re: [Lima] [PATCH] drm/lima: fix sched context destroy

2023-06-06 Thread Vasily Khoruzhick
uot;drm/scheduler: rework entity flush, kill and fini") > Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick > --- > drivers/gpu/drm/lima/lima_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/lima/lima_sched.c &

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-05-21 Thread Vasily Khoruzhick
On Thu, May 19, 2022 at 6:40 AM Torsten Duwe wrote: > > On Wed, 18 May 2022 09:53:58 -0700 > Vasily Khoruzhick wrote: > > > On Thu, Apr 28, 2022 at 8:58 AM Torsten Duwe wrote: > > > > power on the eDP bridge? Could there be any leftovers from that > > > m

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-05-18 Thread Vasily Khoruzhick
On Thu, Apr 28, 2022 at 8:58 AM Torsten Duwe wrote: > > On Mon, 18 Apr 2022 17:25:57 -0700 > Vasily Khoruzhick wrote: > > > On Sun, Apr 17, 2022 at 11:52 AM Vasily Khoruzhick > > wrote: > > > > The change looks good to me, but I'll need some time to

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-04-18 Thread Vasily Khoruzhick
On Sun, Apr 17, 2022 at 11:52 AM Vasily Khoruzhick wrote: > > On Sun, Apr 17, 2022 at 9:15 AM Torsten Duwe wrote: > > > > Align the power-up sequence with the known-good procedure documented in [1]: > > un-swap dvdd12 and dvdd25, and allow a little extra time for them

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-04-17 Thread Vasily Khoruzhick
On Sun, Apr 17, 2022 at 9:15 AM Torsten Duwe wrote: > > Align the power-up sequence with the known-good procedure documented in [1]: > un-swap dvdd12 and dvdd25, and allow a little extra time for them to settle > before de-asserting reset. Hi Torsten, Interesting find! I tried to fix the issue s

Re: [PATCH] drm/lima: fix warning when CONFIG_DEBUG_SG=y & CONFIG_DMA_API_DEBUG=y

2021-10-30 Thread Vasily Khoruzhick
gt; > Reported-by: Roman Stratiienko Reviewed-by: Vasily Khoruzhick > Signed-off-by: Qiang Yu > --- > drivers/gpu/drm/lima/lima_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/lima/lima_device.c > b/drivers/gpu/drm/lima/lima_device.c > inde

Re: [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-19 Thread Vasily Khoruzhick
On Wed, Sep 15, 2021 at 1:47 AM Jani Nikula wrote: > > On Tue, 14 Sep 2021, Vasily Khoruzhick wrote: > > On Tue, Sep 14, 2021 at 3:31 PM Jani Nikula > > wrote: > >> > >> On Tue, 14 Sep 2021, Lyude Paul wrote: > >> > On Tue, 2021-09-14 at 12:09

Re: [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Vasily Khoruzhick
On Tue, Sep 14, 2021 at 3:31 PM Jani Nikula wrote: > > On Tue, 14 Sep 2021, Lyude Paul wrote: > > On Tue, 2021-09-14 at 12:09 +0300, Jani Nikula wrote: > >> On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: > >> > Panel in my Dell XPS 7590, that uses I

[PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-13 Thread Vasily Khoruzhick
sometimes it's too bright, I wasn't able to find a system). I don't have access to the spec, so I'm not sure if it's expected behavior or a quirk for particular device. Delay was chosen by experiment: it works with 100ms, but fails with anything lower than 75ms. Signed-off-

Re: [Lima] LIMA kernel bug - help!

2021-06-04 Thread Vasily Khoruzhick
On Thu, Jun 3, 2021 at 11:51 PM Linus Walleij wrote: > > Hi Qiang, Hey Linus, > I am using Lima on the ST-Ericsson U8500 SoC. It is one > of the very earliest versions of MALI 400 MP. It mostly works > on the mobile phones I have using PostmarkeOS and > the Phosh UI (Wayland with MESA), but now

Re: [PATCH v5 1/4] drm/i915: Keep track of pwm-related backlight hooks separately

2021-01-12 Thread Vasily Khoruzhick
intel_pwm_setup_backlight() instead of > indirection > * Don't move intel_dp_aux_init_bcklight_funcs() call to bottom of > intel_panel_init_backlight_funcs() quite yet > v3: > * Reuse intel_panel_bl_funcs() for pwm_funcs > * Explain why we drop lpt_get_backlight() > >

Re: [RFC v2 1/8] drm/i915/dp: Program source OUI on eDP panels

2020-10-16 Thread Vasily Khoruzhick
Add careful parameter to intel_edp_init_source_oui() to avoid > re-writing the source OUI if it's already been set during driver > initialization > > Signed-off-by: Lyude Paul > Cc: thay...@noraisin.net > Cc: Vasily Khoruzhick Hi Lyude, Sorry for a late reply. Whole s

Re: [PATCH v2 00/10] drm/lima: add suspend/resume support

2020-04-21 Thread Vasily Khoruzhick
misc-next, no need to respin whole patchset > drm/lima: add pm resume/suspend ops > drm/lima: enable runtime pm Besides that, series is: Reviewed-by: Vasily Khoruzhick > drivers/gpu/drm/lima/lima_bcast.c| 25 +++- > drivers/gpu/drm/lima/lima_bcast.h| 2 + >

[PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector

2020-03-29 Thread Vasily Khoruzhick
8089 ("drm/bridge: Add Analogix anx6345 support") Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/anal

Re: [PATCH] drm/lima: add trace point for tasks

2020-03-17 Thread Vasily Khoruzhick
On Mon, Mar 16, 2020 at 6:41 PM Qiang Yu wrote: > Not concrete reason, as the comment, trace point when > dma_fence_signal act as the task completion event, so not add duplicate > one. I see. Patch is: Reviewed-by: Vasily Khoruzhick Regard

Re: [PATCH] drm/lima: add trace point for tasks

2020-03-14 Thread Vasily Khoruzhick
On Sat, Mar 7, 2020 at 5:55 AM Qiang Yu wrote: > > track lima task start which can be combined with > dma_fence_signal to identify task execution time. > > example command to record: > > trace-cmd record -i \ > -e "lima:lima_task_submit" -e "lima:lima_task_run" \ > -e "*fence:*fence_signaled"

Re: [PATCH 0/5] drm/lima: add error debug functionality

2020-03-14 Thread Vasily Khoruzhick
On Fri, Feb 21, 2020 at 6:43 PM Qiang Yu wrote: > > Save task error state when it fail and export to user by > sysfs as a binary file which can be dumped and replayed > by lima_dump tool at: > https://gitlab.freedesktop.org/lima/lima_dump With v2 of Patch 3, series is: Revi

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-03-05 Thread Vasily Khoruzhick
On Thu, Mar 5, 2020 at 7:28 AM Enric Balletbo i Serra wrote: > > Hi Vasily, CC: Icenowy and Ondrej > > Would you mind to check which firmware version is running the anx7688 in > PinePhone, I think should be easy to check with i2c-tools. Icenowy, Ondrej, can you guys please check anx7688 firmware

Re: [PATCH 3/5] drm/lima: save task info dump when task fail

2020-03-03 Thread Vasily Khoruzhick
On Fri, Feb 21, 2020 at 6:43 PM Qiang Yu wrote: > > Save all information to start a task which can be exported to user > for debug usage. Dump file data format is specified in lima_dump.h Looks like lima_sched.c is missing #include so kbuild bot complains > Signed-off-by: Qiang Yu > --- > dri

Re: [PATCH v2 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

2020-02-26 Thread Vasily Khoruzhick
On Wed, Feb 26, 2020 at 12:10 AM Vasily Khoruzhick wrote: > > From: Samuel Holland This patch can be dropped since equivalent was merged: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6726ca1a2d531f5a6efc1f785b15606ce837c4dc > We don't need to pass '

[PATCH v2 0/6] Add LCD support for Pine64 Pinebook 1080p

2020-02-26 Thread Vasily Khoruzhick
ies and @0 suffix of endpoints in sun50i-a64-pinebook.dts Icenowy Zheng (1): arm64: allwinner: a64: enable LCD-related hardware for Pinebook Samuel Holland (1): drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick (4): drm/bridge: anx6345: don't print error message

[PATCH v2 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2020-02-26 Thread Vasily Khoruzhick
This commit adds support for the NewEast Optoelectronics CO., LTD WJFH116008A 11.6" 1920x1080 TFT LCD panel. Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/panel/panel-simple.c | 48 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/panel/

[PATCH v2 2/6] drm/bridge: anx6345: don't print error message if regulator is not ready

2020-02-26 Thread Vasily Khoruzhick
We don't want to print scary message if devm_regulator_get() returns -EPROBE_DEFER Reviewed-by: Laurent Pinchart Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gp

[PATCH v2 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook

2020-02-26 Thread Vasily Khoruzhick
From: Icenowy Zheng Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and eDP panel input. The bridge is controlled via I2C that's connected to R_I2C bus. Enable all this hardware in device tree. Reviewed-by: Laurent Pinchart Signed-off-by: Icenowy Zheng Signed-off-by: V

[PATCH v2 4/6] dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible

2020-02-26 Thread Vasily Khoruzhick
This commit adds compatible for NewEast Optoelectronics WJFH116008A panel to panel-simple binding Reviewed-by: Laurent Pinchart Signed-off-by: Vasily Khoruzhick --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v2 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2020-02-26 Thread Vasily Khoruzhick
Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD Signed-off-by: Vasily Khoruzhick --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree

[PATCH v2 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

2020-02-26 Thread Vasily Khoruzhick
From: Samuel Holland We don't need to pass '-supply' suffix to devm_regulator_get() Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") Reviewed-by: Laurent Pinchart Signed-off-by: Samuel Holland Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm

Re: [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 6:17 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:08AM -0800, Vasily Khoruzhick wrote: > > From: Icenowy Zheng > > > > Pinebook has an ANX6345 bridge connected to

Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 5:56 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote: > > Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD > > > >

Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 1:35 AM Sam Ravnborg wrote: > > Hi Vasily > > On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote: > > Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD > > > > Signed-off-by: Vasily Khoruzhick > > --- &g

Re: [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 5:59 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:07AM -0800, Vasily Khoruzhick wrote: > > This commit adds support for the NewEast Optoelectronics CO., LTD > > WJFH1

Re: [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe()

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 5:53 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:04AM -0800, Vasily Khoruzhick wrote: > > devm_regulator_get() returns either a dummy regulator or -EPROBE_DEFER, > > w

Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2020-02-20 Thread Vasily Khoruzhick
On Thu, Feb 20, 2020 at 1:21 PM Sam Ravnborg wrote: > > Hi Laurent. > > > > + "^neweast,.*": > > > +description: Guangdong Neweast Optoelectronics CO., LT > > > > Google only returns two hits for this name, beside the ones related to > > this patch series. Are you sure this is the correct com

[PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2020-02-20 Thread Vasily Khoruzhick
Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD Signed-off-by: Vasily Khoruzhick --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree

[PATCH 0/6] Add LCD support for Pine64 Pinebook 1080p

2020-02-20 Thread Vasily Khoruzhick
14169/ [2] https://patchwork.kernel.org/patch/11277765/ Icenowy Zheng (1): arm64: allwinner: a64: enable LCD-related hardware for Pinebook Samuel Holland (1): drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick (4): drm/bridge: anx6345: Clean up error handling in probe()

[PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe()

2020-02-20 Thread Vasily Khoruzhick
devm_regulator_get() returns either a dummy regulator or -EPROBE_DEFER, we don't need to print scary message in either case. Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --

[PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook

2020-02-20 Thread Vasily Khoruzhick
From: Icenowy Zheng Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and eDP panel input. The bridge is controlled via I2C that's connected to R_I2C bus. Enable all this hardware in device tree. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick --- ..

[PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2020-02-20 Thread Vasily Khoruzhick
This commit adds support for the NewEast Optoelectronics CO., LTD WJFH116008A 11.6" 1920x1080 TFT LCD panel. Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/panel/panel-simple.c | 47 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/panel/

[PATCH 4/6] dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible

2020-02-20 Thread Vasily Khoruzhick
This commit adds compatible for NewEast Optoelectronics WJFH116008A panel to panel-simple binding Signed-off-by: Vasily Khoruzhick --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

2020-02-20 Thread Vasily Khoruzhick
From: Samuel Holland We don't need to pass '-supply' suffix to devm_get_regulator() Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") Signed-off-by: Samuel Holland Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c

[PATCH] drm/lima: fix recovering from PLBU out of memory

2020-02-14 Thread Vasily Khoruzhick
t;) Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/lima/lima_gp.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/lima/lima_gp.c b/drivers/gpu/drm/lima/lima_gp.c index d1e7826c2d74..325604262def 100644 --- a/drivers/gpu/drm/lima/lima_gp.c +++ b/drive

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Vasily Khoruzhick
On Fri, Feb 14, 2020 at 2:20 PM Enric Balletbo Serra wrote: > > Hi Vasily, > > Missatge de Vasily Khoruzhick del dia dv., 14 de > febr. 2020 a les 23:17: > > > > On Fri, Feb 14, 2020 at 1:53 PM Enric Balletbo Serra > > wrote: > > > > > > Hi Vas

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Vasily Khoruzhick
On Fri, Feb 14, 2020 at 1:53 PM Enric Balletbo Serra wrote: > > Hi Vasily, > > Missatge de Vasily Khoruzhick del dia dv., 14 de > febr. 2020 a les 22:36: > > > > On Thu, Feb 13, 2020 at 6:54 AM Enric Balletbo i Serra > > wrote: > > > > > > From

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Vasily Khoruzhick
On Thu, Feb 13, 2020 at 6:54 AM Enric Balletbo i Serra wrote: > > From: Nicolas Boichat > > ANX7688 is a HDMI to DP converter (as well as USB-C port controller), > that has an internal microcontroller. > > The only reason a Linux kernel driver is necessary is to reject > resolutions that require

Re: [PATCH 0/5] drm/lima: add heap buffer support

2020-01-26 Thread Vasily Khoruzhick
On Thu, Jan 16, 2020 at 5:12 AM Qiang Yu wrote: > > Support heap buffer allocation which can grow the back memory > size when GP has an out of memory interrupt so that user don't > need to allocate a very large buffer at the beginning. Whole series: Reviewed-by: Vasily Khoruz

Re: [linux-sunxi] [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab

2020-01-10 Thread Vasily Khoruzhick
On Fri, Jan 10, 2020 at 7:54 AM Icenowy Zheng wrote: > > PineTab is a 10.1" tablet by Pine64 with Allwinner A64 inside. > > It includes the following peripherals: > > USB: > - A microUSB Type-B port connected to the OTG-capable USB PHY of > Allwinner A64. The ID pin is connected to a GPIO of the A

Re: [PATCH] drm/lima: use drm_sched_fault for error task handling

2020-01-02 Thread Vasily Khoruzhick
gt; > Signed-off-by: Qiang Yu LGTM in general. Reviewed-by: Vasily Khoruzhick Erico, Andreas, could you test this patch on actual hardware? I'll have pretty limited access to the hardware for next few weeks, so I won't be able to test it myself. > ---

Re: [Lima] [PATCH v4 0/3] drm/lima: simplify driver by using more drm helpers

2019-10-13 Thread Vasily Khoruzhick
rs > drm/lima: use drm_gem_(un)lock_reservations > drm/lima: add __GFP_NOWARN flag to all dma_alloc_wc LGTM, whole series: Reviewed-by: Vasily Khoruzhick > drivers/gpu/drm/lima/Kconfig | 1 + > drivers/gpu/drm/lima/Makefile | 4 +- > drivers/gpu/drm

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2019-09-15 Thread Vasily Khoruzhick
On Sun, Sep 15, 2019 at 2:18 PM Mark Brown wrote: > > Hi all, Hi Mark, > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/lima/lima_gem.c > > between commit: > > 21670bd78a25001cf8e ("drm/lima: fix lima_gem_wait() return value") > > from the drm-misc-fixes tree

Re: [Lima] [PATCH] drm/lima: fix lima_gem_wait() return value

2019-09-09 Thread Vasily Khoruzhick
think it still needs "Fixes: " tag. Qiang, can you add it at your side or you want me to resend the patch? > > Heiko > > > On Sun, Sep 8, 2019 at 10:48 AM Vasily Khoruzhick > > wrote: > > > > > > drm_gem_reservation_object_wait() returns 0 if it s

[PATCH] drm/lima: fix lima_gem_wait() return value

2019-09-07 Thread Vasily Khoruzhick
drm_gem_reservation_object_wait() returns 0 if it succeeds and -ETIME if it timeouts, but lima driver assumed that 0 is error. Cc: sta...@vger.kernel.org Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/lima/lima_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH v3 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-07-22 Thread Vasily Khoruzhick
On Mon, Jul 22, 2019 at 8:12 AM Torsten Duwe wrote: > > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > for portable devices. > > Add a binding document for it. I believe you'll have to convert it to yaml format. > > Signed-off-by: Icenowy Zhen

Re: [PATCH v3 5/7] drm/bridge: Add Analogix anx6345 support

2019-07-22 Thread Vasily Khoruzhick
a configuration usually seen in eDP applications. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily Khoruzhick > Signed-off-by: Torsten Duwe > --- > drivers/gpu/drm/bridge/analogix/Kconfig| 12 + > drivers/gpu/drm/bridge/analogix/Makefile | 1

Re: [PATCH v2 0/7] Add anx6345 DP/eDP bridge for Olimex Teres-I

2019-07-22 Thread Vasily Khoruzhick
On Mon, Jul 22, 2019 at 8:04 AM Torsten Duwe wrote: > > ANX6345 LVTTL->eDP video bridge, driver with device tree bindings. > > Changes from v2: > > * use SPDX-IDs throughout > > * removed the panel output again, as it was not what Maxime had in mind. > At least the Teres-I does very well without

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-15 Thread Vasily Khoruzhick
On Fri, Jul 12, 2019 at 1:15 PM Maxime Ripard wrote: > > On Wed, Jul 10, 2019 at 03:11:04PM -0700, Vasily Khoruzhick wrote: > > On Wed, Jul 10, 2019 at 4:40 AM Maxime Ripard > > wrote: > > > > > > There's another issue: if we introduce edp-connector w

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-10 Thread Vasily Khoruzhick
On Wed, Jul 10, 2019 at 4:40 AM Maxime Ripard wrote: > > On Tue, Jul 09, 2019 at 01:30:18PM -0700, Vasily Khoruzhick wrote: > > On Tue, Jul 9, 2019 at 1:55 AM Maxime Ripard > > wrote: > > > > > > On Mon, Jul 08, 2019 at 05:49:21PM -0700, Vasily Khoruzhick wro

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-09 Thread Vasily Khoruzhick
On Tue, Jul 9, 2019 at 1:55 AM Maxime Ripard wrote: > > On Mon, Jul 08, 2019 at 05:49:21PM -0700, Vasily Khoruzhick wrote: > > > > Maybe instead of edp-connector one would introduce integrator's specific > > > > connector, for example with compatible "o

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-08 Thread Vasily Khoruzhick
On Mon, Jul 1, 2019 at 2:58 AM Maxime Ripard wrote: > > Hi! > > On Fri, Jun 28, 2019 at 12:39:32PM +0200, Andrzej Hajda wrote: > > On 12.06.2019 17:20, Maxime Ripard wrote: > > >> I am not sure if I understand whole discussion here, but I also do not > > >> understand whole edp-connector thing. >

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-04 Thread Vasily Khoruzhick
On Tue, Jun 4, 2019 at 5:23 AM Torsten Duwe wrote: > > Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and > the I2C controlling signals are connected to I2C0 bus. eDP output goes > to an Innolux N116BGE panel. > > Enable it in the device tree. > > Signed-off-by: Icenowy Zheng >

Re: [PATCH 6/6] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-23 Thread Vasily Khoruzhick
On Wed, May 22, 2019 at 11:54 PM Torsten Duwe wrote: > > From: Icenowy Zheng > > Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and > the I2C controlling signals are connected to I2C0 bus. eDP output goes > to an Innolux N116BGE panel. > > Enable it in the device tree. > > Sign

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-17 Thread Vasily Khoruzhick
On Fri, May 17, 2019 at 2:47 AM Torsten Duwe wrote: > > On Fri, May 17, 2019 at 11:08:45AM +0200, Maxime Ripard wrote: > > > > > > So for all current practical purposes, we can assume the Teres-I panel > > > to be powered properly and providing valid EDID; nothing to worry about > > > in software.

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-16 Thread Vasily Khoruzhick
On Thu, May 16, 2019 at 9:49 AM Torsten Duwe wrote: > > On Thu, May 16, 2019 at 09:06:41AM -0700, Vasily Khoruzhick wrote: > > > > Driver can talk to the panel over AUX channel only after t1+t3, t1 is > > up to 10ms, t3 is up to 200ms. > > This is after power-on.

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-16 Thread Vasily Khoruzhick
On Thu, May 16, 2019 at 8:48 AM Torsten Duwe wrote: > > On Wed, May 15, 2019 at 08:08:57AM -0700, Vasily Khoruzhick wrote: > > On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > > > > > It does comply with the bindings. The ports are all optional. > &

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-15 Thread Vasily Khoruzhick
On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > On Tue, 14 May 2019 10:48:40 -0700 > Vasily Khoruzhick wrote: > > > > + anx6345: anx6345@38 { > > > + compatible = "analogix,anx6345"; > > > + reg = <0

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-14 Thread Vasily Khoruzhick
On Tue, May 14, 2019 at 9:03 AM Torsten Duwe wrote: > > From: Icenowy Zheng > > TERES-I has an ANX6345 bridge connected to the RGB666 LCD output, and > the I2C controlling signals are connected to I2C0 bus. > > Enable it in the device tree. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Torst

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-26 Thread Vasily Khoruzhick
ce kernel 5.0 > > > > - use drm syncobj to replace native fence > > > > - move buffer object GPU va map into kernel > > > > - reserve syscall argument space for future info > > > > - remove kernel gem modifier > > > > - switch TTM back to GE

Re: [RFC PATCH] drm/sun4i: Implement gamma correction

2019-03-14 Thread Vasily Khoruzhick
On Thu, Mar 14, 2019 at 8:42 AM Maxime Ripard wrote: > > Hi Vasily, > > On Wed, Mar 13, 2019 at 07:58:38PM -0700, Vasily Khoruzhick wrote: > > Add support for gamma corretion to sun4i TCON driver. Its LUT has 256 > > entries and can be updated only when gamm

[RFC PATCH] drm/sun4i: Implement gamma correction

2019-03-13 Thread Vasily Khoruzhick
Add support for gamma corretion to sun4i TCON driver. Its LUT has 256 entries and can be updated only when gamma correction is disabled. Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 15 ++ drivers/gpu/drm/sun4i/sun4i_tcon.c | 33

Re: [PATCH v3 10/11] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2019-03-06 Thread Vasily Khoruzhick
On Fri, Feb 22, 2019 at 10:37 AM Rob Herring wrote: > There is not any simple panel binding really. This originated I think > from a 'simple-panel' compatible that was originally attempted. What we > have is a collection of common properties for panels which panel > bindings can use. And we have

Re: [PATCH 0/4] drm/sun4i: rgb: Relax the pixel clock check

2019-03-05 Thread Vasily Khoruzhick
hat you think, > Maxime With last patch fixed (s/DEFINE/#define), for whole series: Tested-by: Vasily Khoruzhick # tested on pinebook > Maxime Ripard (4): > drm/sun4i: Move the panel pointer from the TCON to the encoders > drm/sun4i: rgb: Store the bridge pointer > drm/sun4i: Mo

Re: [PATCH v3 06/11] drm/sun4i: rgb: Add DT property to disable strict clock rate check

2019-02-20 Thread Vasily Khoruzhick
On Tue, Feb 19, 2019 at 12:56 AM Maxime Ripard wrote: > > On Mon, Feb 18, 2019 at 11:33:05AM -0800, Vasily Khoruzhick wrote: > > On Mon, Feb 18, 2019 at 10:26 AM Rob Herring wrote: > > > > > > On Thu, Feb 14, 2019 at 09:09:52PM -0800, Vasily Khoruzhick wrote: >

Re: [PATCH v3 06/11] drm/sun4i: rgb: Add DT property to disable strict clock rate check

2019-02-20 Thread Vasily Khoruzhick
On Wed, Feb 20, 2019 at 2:33 AM Maxime Ripard wrote: > > On Tue, Feb 19, 2019 at 07:44:56AM -0800, Vasily Khoruzhick wrote: > > On Tue, Feb 19, 2019 at 12:56 AM Maxime Ripard > > Maxime, thanks for your patch but it doesn't work for me. Pinebook > > needs 1% tol

Re: [PATCH v3 10/11] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2019-02-19 Thread Vasily Khoruzhick
On Tue, Feb 19, 2019 at 6:54 AM Rob Herring wrote: > > I believe using eDP connector binding wouldn't help much in my case > > and it won't improve accuracy of hardware description while adding > > unnecessary code duplication (edp-connector will be pretty much > > simple-panel). > > > > Since cu

Re: [PATCH v3 06/11] drm/sun4i: rgb: Add DT property to disable strict clock rate check

2019-02-19 Thread Vasily Khoruzhick
On Tue, Feb 19, 2019 at 12:56 AM Maxime Ripard wrote: > > On Mon, Feb 18, 2019 at 11:33:05AM -0800, Vasily Khoruzhick wrote: > > On Mon, Feb 18, 2019 at 10:26 AM Rob Herring wrote: > > > > > > On Thu, Feb 14, 2019 at 09:09:52PM -0800, Vasily Khoruzhick wrote: >

Re: [PATCH v3 06/11] drm/sun4i: rgb: Add DT property to disable strict clock rate check

2019-02-18 Thread Vasily Khoruzhick
On Mon, Feb 18, 2019 at 10:26 AM Rob Herring wrote: > > On Thu, Feb 14, 2019 at 09:09:52PM -0800, Vasily Khoruzhick wrote: > > Clock rate check that was added in commit bb43d40d7c83 ("drm/sun4i: rgb: > > Validate the clock rate") prevents some panel and bridges from w

Re: [PATCH v3 10/11] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2019-02-18 Thread Vasily Khoruzhick
On Mon, Feb 18, 2019 at 10:33 AM Rob Herring wrote: > > On Thu, Feb 14, 2019 at 09:09:56PM -0800, Vasily Khoruzhick wrote: > > This commit adds support for the NewEast Optoelectronics CO., LTD > > WJFH116008A 11.6" 1920x1080 TFT LCD panel. > > > &g

Re: [PATCH v3 08/11] drm/panel: simple: Add BOE HB140WX1-501 panel support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
On Sat, Feb 16, 2019 at 12:43 PM Sam Ravnborg wrote: > > Hi Vasily. Hi Sam, > On Thu, Feb 14, 2019 at 09:09:54PM -0800, Vasily Khoruzhick via dri-devel > wrote: > > This commit adds support for the BOE HB140WX1-501 14" WXGA TFT LCD > > panel. > > &

Re: [linux-sunxi] [PATCH v3 05/11] drm/bridge: Add Analogix anx6345 support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
On Fri, Feb 15, 2019 at 12:23 AM Priit Laes wrote: > > + err = anx6345_tx_initialization(anx6345); > > + if (err) { > > + DRM_ERROR("Failed transmitter initialization: %d\n", err); > > + goto err_poweroff; > > You can move the whole err_poweroff section from below

Re: [PATCH v3 05/11] drm/bridge: Add Analogix anx6345 support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
On Fri, Feb 15, 2019 at 1:13 AM Andrzej Hajda wrote: Hi Andrzej, Thanks for review! > > +#include > Do you need this header? I'll drop it. > > +#include > > drmP.h is/should be deprecated. Same here > > +struct anx6345_platform_data { > > + struct regulator *dvdd12; > > + struct r

[PATCH v3 09/11] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

2019-02-16 Thread Vasily Khoruzhick via dri-devel
Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD Signed-off-by: Vasily Khoruzhick --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree

[PATCH v3 02/11] drm/bridge: split some definitions of ANX78xx to dedicated headers

2019-02-16 Thread Vasily Khoruzhick via dri-devel
-off-by: Vasily Khoruzhick --- .../drm/bridge/analogix/analogix-anx78xx.h| 464 +- .../drm/bridge/analogix/analogix-i2c-dptx.h | 248 ++ .../bridge/analogix/analogix-i2c-txcommon.h | 237 + 3 files changed, 490 insertions(+), 459 deletions(-) create mode

[PATCH v3 08/11] drm/panel: simple: Add BOE HB140WX1-501 panel support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
This commit adds support for the BOE HB140WX1-501 14" WXGA TFT LCD panel. Signed-off-by: Vasily Khoruzhick --- .../display/panel/boe,hb140wx1-501.txt| 7 + drivers/gpu/drm/panel/panel-simple.c | 26 +++ 2 files changed, 33 insertions(+) create mode 1

[PATCH v3 01/11] drm/bridge: move ANA78xx driver to analogix subdirectory

2019-02-16 Thread Vasily Khoruzhick via dri-devel
From: Icenowy Zheng As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/Kconfig

[PATCH v3 07/11] arm64: allwinner: a64: add pinmux for RGB666 LCD

2019-02-16 Thread Vasily Khoruzhick via dri-devel
From: Icenowy Zheng Allwinner A64's TCON0 can output RGB666 LCD signal. Add its pinmux. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/allw

[PATCH v3 00/11] Analogix ANX6345 RGB-(e)DP bridge support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
: add pinmux for RGB666 LCD arm64: allwinner: a64: enable LCD-related hardware for Pinebook Vasily Khoruzhick (4): drm/sun4i: rgb: Add DT property to disable strict clock rate check drm/panel: simple: Add BOE HB140WX1-501 panel support dt-bindings: Add Guangdong Neweast Optoelectronics CO

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-16 Thread Vasily Khoruzhick via dri-devel
On Thu, Feb 14, 2019 at 12:38 PM Rob Herring wrote: > > On Thu, Feb 14, 2019 at 2:04 PM Vasily Khoruzhick wrote: > > > > On Tue, Feb 5, 2019 at 2:24 AM Thierry Reding > > wrote: > > > > > > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wr

[PATCH v3 05/11] drm/bridge: Add Analogix anx6345 support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/Kconfig | 11 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + .../drm/bridge/analogix/analogix-anx6345.c| 845 ++ .../drm/bridge/analogix/analogix-i2c-dptx.c | 2 +- .../drm/bridge/analogix/analogix

[PATCH v3 10/11] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support

2019-02-16 Thread Vasily Khoruzhick via dri-devel
This commit adds support for the NewEast Optoelectronics CO., LTD WJFH116008A 11.6" 1920x1080 TFT LCD panel. Signed-off-by: Vasily Khoruzhick --- .../display/panel/neweast,wjfh116008a.txt | 7 drivers/gpu/drm/panel/panel-simple.c | 39 +++ 2 files change

[PATCH v3 04/11] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-02-16 Thread Vasily Khoruzhick via dri-devel
From: Icenowy Zheng The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices. Add a binding document for it. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick --- .../bindings/display/bridge/anx6345.txt | 56 +++ 1 file

[PATCH v3 03/11] drm/bridge: extract some Analogix I2C DP common code

2019-02-16 Thread Vasily Khoruzhick via dri-devel
From: Icenowy Zheng Some code can be shared within different DP bridges by Analogix. Extract them to a new module. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/Kconfig | 4 + drivers/gpu/drm/bridge/analogix/Makefile | 2

[PATCH v3 06/11] drm/sun4i: rgb: Add DT property to disable strict clock rate check

2019-02-16 Thread Vasily Khoruzhick via dri-devel
DT property to disable strict clock rate check Signed-off-by: Vasily Khoruzhick --- .../devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++ drivers/gpu/drm/sun4i/sun4i_rgb.c| 5 + drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 +++

  1   2   >