Re: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

Reviewed-by: Vinay Simha BN On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek wrote: > Function for reading from i2c device register displays error message even > if reading ends correctly. Add return to avoid falling through into > the fail label. > > Signed-off-by: Jiri Vanek > --- >

Re: [PATCH 2/2] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation

Reviewed-by: Vinay Simha BN On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek wrote: > Use the same PCLK divide option (divide DSI clock to generate pixel clock) > which is set to LVDS Configuration Register (LVCFG) also for a VSync delay > calculation. Without this change an auxiliary variable could

Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS

Reviewed-by: Vinay Simha BN Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display/panel used. On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek wrote: > Fixed wrong register shift for single/dual link LVDS output. > > Tested-by: Jiri Vanek > Signed-off-by:

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

Robert, What is R-b tag? On Tue, Jan 4, 2022 at 7:21 PM Robert Foss wrote: > > Jiri: Are you able to test this patch? > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N wrote: > > > > Robert,

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

. Without this fix it > does not work at all. > > út 4. 1. 2022 v 14:51 odesílatel Robert Foss napsal: >> >> Jiri: Are you able to test this patch? >> >> Vinay: Could you supply a R-b tag, if you feel that it is warranted? >> >> On Tue, 14 Dec 2021 at 0

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

Robert, I do not have the hardware to test this feature. Sorry for the late response. On Thu, Nov 18, 2021 at 8:20 PM Robert Foss wrote: > + Zhen & Vinay > > This patch looks good in itself, but I would like to see a tested by > tag. At the very least testing for regression in single-link LVDS

Re: [PATCH RESEND v2] drm/bridge/tc358775: Fixes bus formats read

Laurent, Please review the patch, so that we can push the input_format to the mainline, which completes the overall features handled wrt bridge. On Thu, Dec 17, 2020 at 10:39 AM Vinay Simha B N wrote: > Laurent, > > Please review the patch, so that we can push the inp

Re: [PATCH RESEND v2] drm/bridge/tc358775: Fixes bus formats read

Laurent, Please review the patch, so that we can push the input_format to the mainline, which completes the overall features handled wrt bridge. On Sun, Nov 8, 2020 at 3:47 PM Sam Ravnborg wrote: > Hi Laurent, > > On Thu, Oct 22, 2020 at 12:15:47PM +0530, Vinay Simha BN wrote: > > -

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

laurent, Please review or give some feedback. On Tue, Aug 25, 2020 at 7:57 PM Vinay Simha B N wrote: > laurent, > > Please review or give some feedback. > > On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N > wrote: > > > > laurent, > > > > The cod

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

laurent, Please review or give some feedback. On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N wrote: > > laurent, > > The code sequence was a problem. *num_inputs_fmts = > ARRAY_SIZE(tc_lvds_in_bus_fmts); should come first and then allocate > the kcalloc. > &

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

Thanks Sam. On Sun, Aug 23, 2020 at 8:35 PM Sam Ravnborg wrote: > > On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > > passing zero to 'PTR_ERR' > > > > Reported-by: kernel test robot > > Signed-off-by: Vinay Simha BN > > Applied to drm-misc-next - thanks. > > Sam > >

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_inputs_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); So, internally in the drm pipeline get set the input format based on the output formats? On Wed, Aug 12, 2020 at 10:45 PM Vinay Simha B N wr

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

t chosen? Since dsi->format = MIPI_DSI_FMT_RGB888 is used does it chooses MEDIA_BUS_FMT_RBG888_1X24 by the drm pipeline On Wed, Aug 12, 2020 at 6:48 PM Laurent Pinchart wrote: > > Hi Vinay, > > On Wed, Aug 12, 2020 at 06:07:52PM +0530, Vinay Simha B N wrote: > > On Wed, Aug

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

sam/laurent, [PATCH] drm/bridge/tc358775: Fixes bus formats read is on top of drm-misc-next. On Wed, Aug 12, 2020 at 7:50 AM Vinay Simha B N wrote: > > Sam, > > I will look into this and send the patch ASAP. > > On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wro

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_input_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); On Wed, Aug 12, 2020 at 8:25 PM Vinay Simha B N wrote: > > laurent, > > Video data input format : RGB666 loosely packed 24 bits per pix

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

laurent, please see the reply inline below. On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > - bus formats read from drm_bridge_state.output_bus_cfg.format > > and

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Sam, I will look into this and send the patch ASAP. On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wrote: > Hi Vinay. > > > > > > > If Laurent or others identify further things to improve we can take > > > it in-tree. > > > > Just one thing, please see below. > > > > > > > >> +

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

Sam, Thanks. On Mon, Aug 10, 2020 at 11:08 PM Sam Ravnborg wrote: > Hi Vinay. > > On Wed, Jul 29, 2020 at 06:01:21PM +0530, Vinay Simha B N wrote: > > Hi All, > > > > Please Review the patch > > > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN > w

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Hi All, Please Review the patch On Wed, Jul 29, 2020 at 6:01 PM Vinay Simha B N wrote: > Hi All, > > Please Review the patch > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > >> This driver is tested with two panels individually with Apq8016-IFC6

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

Hi All, Please Review the patch On Wed, Jul 29, 2020 at 6:01 PM Vinay Simha B N wrote: > Hi All, > > Please Review the patch > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > >> - license modified to (GPL-2.0-only OR BSD-2-Clause) >> - single-link

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

Hi All, Please Review the patch On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > - license modified to (GPL-2.0-only OR BSD-2-Clause) > - single-link and dual-link lvds description and > examples are added > - proper indentation > - VESA/JEIDA formats picked from panel-lvds dts > -

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Hi All, Please Review the patch On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > This driver is tested with two panels individually with Apq8016-IFC6309 > board > > https://www.inforcecomputing.com/products/single-board-computers-sbc/qualcomm-snapdragon-410-inforce-6309-micro-sbc > > 1.

Re: [PATCH v7 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Andrzej, Please suggest. In general it should be in the reverse-order RESX then STBY, But As per the spec Datasheet Power off sequence is this Page 149, Section Power Supply On and Off Sequence regulators STBY RESX

Re: [PATCH v6 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

sam, I will change to "GPL-2.0-only OR BSD-2-Clause", i thought running dt_binding_check is enough for .yaml. On Fri, Jul 3, 2020 at 8:36 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Thu, Jul 02, 2020 at 06:06:33PM +0530, Vinay Simha BN wrote: > > Signed-off-by: Vinay Simha BN > > > > --- > >

Re: [PATCH v5 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

sam, I rechecked, but did not find any indents are too spaced. This is taken from a working dts tree. I had given two examples for a purpose. One for single lvds configuration single link mode, another is for dual lvds configurations dual-link mode and port mappings. On Wed, Jul 1, 2020 at 2:49

Re: [PATCH v4] display/drm/bridge: TC358775 DSI/LVDS driver

Neil, yaml is the v3 version, there was no change , so i had not created v4 for yaml [PATCH v3 2/2] display/drm/bridge: TC358775 DSI/LVDS driver On Mon, Jun 29, 2020 at 2:08 PM Neil Armstrong wrote: > > Hi, > > On 21/06/2020 17:38, Vinay Simha BN wrote: > > Signed-off-by: Vinay Simha BN > > >

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

of panel/lvds.yaml or panel/panel-common.yaml and panel/advantech,idk-2121wr.yaml in my yaml file. On Tue, Mar 17, 2020 at 7:57 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Tue, Mar 17, 2020 at 12:25:42PM +0530, Vinay Simha B N wrote: > > sam, > > > > i need some inp

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

hi emil, On Wed, May 13, 2020 at 3:17 PM Emil Velikov wrote: > > Hi Vinay, > > On Thu, 7 May 2020 at 17:18, Emil Velikov wrote: > > > > On Thu, 7 May 2020 at 13:29, Vinay Simha B N wrote: > > > > > > Emil, > > > > > > Reply in

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

Emil, Reply inline On Tue, 5 May 2020 at 9:35 PM, Emil Velikov wrote: > From: Emil Velikov > > The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently > using the generic write. This does not look right. > > Perhaps some platforms don't distinguish between the two writers? > >

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

Documentation/devicetree/bindings/display/bridge/toshiba-tc358775.yaml is there any tool available similar to scripts/checkpatch.pl -f , for yaml files? On Sun, Mar 15, 2020 at 8:54 PM Vinay Simha B N wrote: > > rob, > > i do not get the error when running 'make dt_binding_check' i

Re: [PATCH v1 12/36] dt-bindings: display: convert jdi,lt070me05000 to DT Schema

sam, Reviewed-by: Vinay Simha BN Thanks. On Sun, Mar 15, 2020 at 7:14 PM Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg > Cc: Vinay Simha BN > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/jdi,lt070me05000.txt| 31 - >

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

}; }; }; On Thu, Mar 12, 2020 at 8:01 PM Laurent Pinchart wrote: > > Hi Vinay, > > On Wed, Mar 11, 2020 at 03:30:48PM +0530, Vinay Simha B N wrote: > > Laurent Pinchart, > > > > if we want to set to jeida-18 data mapping, > > do we need to set DATA3 with "

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

rob, i do not get the error when running 'make dt_binding_check' in my build environment Documentation/devicetree/bindings/display/bridge/toshiba-tc358775.yaml is there any tool available similar to scripts/checkpatch.pl -f , for yaml files? On Thu, Mar 12, 2020 at 8:47 PM Rob Herring wrote:

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

Laurent Pinchart, if we want to set to jeida-18 data mapping, do we need to set DATA3 with "Logic 0" LVI_L0 ? Please see reply inline. On Fri, Mar 6, 2020 at 7:02 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Fri, Mar 06, 2020 at 06:06

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

hi andrzej, I had a doubt In the tc358764 driver,VP_CTRL, VP_CTRL_VSDELAY(15) is hardcoded to 15, but this has to be dynamic based on the resolution of panel used? Please see the reply inline. On Tue, Mar 3, 2020 at 8:39 PM Andrzej Hajda wrote: > > On 27.02.2020 15:03, Vinay Simha BN wrote: >

Re: drm bridge control from another driver

mit/8ee2b9104fa56765320d4846086d91b8271f5609 please suggest. On Mon, Feb 18, 2019 at 8:49 PM Vinay Simha B N wrote: > added the temperature alert irq handler in adv driver , in the irq > calling schedule_work(>hpd_work); , initially in the > adv7511_detect , if we set status = connector_status_disconnected; l

Re: drm dsi2hdmi bridge - temperature sensor

rob, hpd works in kernel 5.0.0-rc6, i.e postboot if we connect hdmi display comes(apq8016). added the temperature alert_handler in adv7511_drv.c in adv7511_detect , i had set status = connector_status_disconnected; , since display should not come initially, but when irq calls

Re: drm bridge control from another driver

PM Andrzej Hajda wrote: > On 13.02.2019 15:31, Vinay Simha B N wrote: > > > > > > On Wed, Feb 13, 2019 at 7:44 PM Andrzej Hajda > <mailto:a.ha...@samsung.com>> wrote: > > > > On 13.02.2019 14:40, Vinay Simha B N wrote: > > > And

Re: drm dsi2hdmi bridge - temperature sensor

goes down and may not be operated later. > > Rob > > > > > > > BR, > > -R > > > > On Thu, Feb 14, 2019 at 7:32 AM Vinay Simha B N > wrote: > > > > > > rob, > > > > > > i am not getting much inputs in the freenode /

Re: drm bridge control from another driver

On Wed, Feb 13, 2019 at 7:44 PM Andrzej Hajda wrote: > On 13.02.2019 14:40, Vinay Simha B N wrote: > > Andrzej/Daniel, > > > > please suggest any input on the scenario for temperature control and > > dsi bridge enable/disable. > > > > On Mon,

Re: drm bridge control from another driver

Andrzej/Daniel, please suggest any input on the scenario for temperature control and dsi bridge enable/disable. On Mon, Feb 11, 2019 at 2:41 PM Vinay Simha B N wrote: > dsi2hdmi(adv7511) chip operating temperature range is -10 degC to +85 > degC. We want to enable/disable the bridge onl

Re: drm bridge control from another driver

/disable the bridge. Any suggestion what is the better way to handle this scenario? regards, vinaysimha On Mon, Feb 11, 2019 at 2:10 PM Daniel Vetter wrote: > On Mon, Feb 11, 2019 at 09:32:54AM +0100, Andrzej Hajda wrote: > > On 11.02.2019 07:52, Vinay Simha B N wrote:

drm bridge control from another driver

hi, is it possible to control the drm bridge from another driver in irq handler(enable/disable the bridge)? is there a way to control the "dpms force off" and "dpms force on" in the interrupt handler? -- regards, vinaysimha ___ dri-devel mailing list

Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

hi, Could you please give some feedback or review comments for this patch On 3/14/17, Vinay Simha BN wrote: > 4 macros already defined in hdmi.h, > which is not required to redefine in hdmi_audio.c > > Signed-off-by: Vinay Simha BN > --- >