Re: [PATCH v2 2/2] drm/amdpgu: Use VRAM domain in UVD IB test

[AMD Official Use Only] From: dri-devel on behalf of Pan, Xinhui Sent: Monday, September 6, 2021 9:10 AM To: amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander ; che...@uniontech.com Subject: [PATCH

Re: [PATCH] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

[AMD Official Use Only - Internal Distribution Only] Hi Jiapeng, /* 0 - Fine grained DPM, 1 - Discrete DPM */ - return dpm_desc->SnapToDiscrete == 0 ? true : false; + return !(dpm_desc->SnapToDiscrete == 0); the code logic is wrong, the '!' is not needed. Best Regards,

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

thanks, Reviewed-by: Kevin Wang Regards, Kevin > 在 2021年2月19日，06:49，Nathan Chancellor 写道： > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > variable 'structure_size' is used uninitialized whenever switch default > is taken [-Wsometimes-uninitialized] >

Re: [PATCH] drm/amd/pm: Remove unnecessary conversion to bool

[AMD Official Use Only - Internal Distribution Only] if possible, please correct the same issue in navi10_ppt.c Reviewed-by: Kevin Wang Best Regards, Kevin From: Jiapeng Chong Sent: Sunday, February 7, 2021 4:49 PM To: Deucher, Alexander Cc: Koenig, Christian

Re: [RFC PATCH 0/3] add ttm trace event support

[AMD Official Use Only - Internal Distribution Only] thanks comments. I will refine these patches, then send out review later. Best Regards, Kevin From: Christian König Sent: Thursday, January 28, 2021 3:46 PM To: Wang, Kevin(Yang) ; dri-devel

Re: [PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

[AMD Official Use Only - Internal Distribution Only] thanks. Reviewed-by: Kevin Wang Best Regads, Kevin From: Dan Carpenter Sent: Wednesday, May 20, 2020 9:08 PM To: Deucher, Alexander ; Wang, Kevin(Yang) Cc: Koenig, Christian ; David Airlie ; Daniel Vetter

Re: [radeon-alex:amd-19.50 1794/2680] cc1: fatal error: dkms/config/config.h: No such file or directory

dri-devel@lists.freedesktop.org ; Gui, Jack ; Xu, Feifei ; Wang, Kevin(Yang) ; Zhang, Yifan1 Subject: [radeon-alex:amd-19.50 1794/2680] cc1: fatal error: dkms/config/config.h: No such file or directory Hi Flora, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git

Re: linux-next: build failure after merge of the tip tree

. Peter Anvin; Peter Zijlstra; Dave Airlie; DRI Cc: Linux Next Mailing List; Linux Kernel Mailing List; Wang, Kevin(Yang); Deucher, Alexander Subject: linux-next: build failure after merge of the tip tree Hi all, After merging the tip tree, today's linux-next build (x86_64 allmodconfig) failed like

Re: [PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions

vin From: Saurav Girepunje Sent: Tuesday, October 29, 2019 5:19 PM To: Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; airl...@linux.ie ; dan...@ffwll.ch ; StDenis, Tom ; xywang.s...@sjtu.edu.cn ; Xiao, Jack ; s...@ravnborg.org ; Wang, Kevin(Y

Re: [PATCH] drm/ttm: fix handling in ttm_bo_add_mem_to_lru

Reviewed-by: Kevin Wang Best Regards, Kevin From: Christian König Sent: Thursday, October 10, 2019 7:26 PM To: dri-devel@lists.freedesktop.org ; Wang, Kevin(Yang) ; Zhang, Hawking Subject: [PATCH] drm/ttm: fix handling in ttm_bo_add_mem_to_lru We should

Re: [PATCH] drm/amd/powerplay: Fix error handling in smu_init_fb_allocations()

thanks correct it. Reviewed-by: Kevin Wang Best Regards, Kevin From: Dan Carpenter Sent: Monday, October 7, 2019 5:02 PM To: Rex Zhu ; Wang, Kevin(Yang) Cc: Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel

Re: [PATCH] drm/amd/powerplay: unlock on error in smu_resume()

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Dan Carpenter Sent: Monday, October 7, 2019 5:04 PM To: Rex Zhu ; Quan, Evan Cc: Zhou, David(ChunMing) ; David Airlie ; kernel-janit...@vger.kernel.org ; amd-...@lists.freedesktop.org ;

Re: [PATCH] drm/amd/powerplay: Remove unnecessary comparison statement

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Austin Kim Sent: Monday, September 9, 2019 12:31 PM To: Deucher, Alexander ; airl...@linux.ie ; dan...@ffwll.ch Cc: Zhou, David(ChunMing) ; amd-...@lists.freedesktop.org ;

Re: [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks

From: Alex Deucher Sent: Friday, August 2, 2019 2:53 AM To: Colin King Cc: Wang, Kevin(Yang) ; Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-gfx list ; Maling list - DRI developers

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

From: amd-gfx on behalf of Colin King Sent: Thursday, August 1, 2019 4:39 PM To: Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-...@lists.freedesktop.org ;