[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-24 Thread Wu Fengguang
On Thu, Nov 24, 2011 at 03:26:49AM +0800, Keith Packard wrote: > On Wed, 23 Nov 2011 16:29:58 +0800, Wu Fengguang > wrote: > > > What I need is a hot plug hook that knows whether the monitor is > > plugged or removed, which is only possible if the hook is called > >

Re: [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-24 Thread Wu Fengguang
On Thu, Nov 24, 2011 at 03:26:49AM +0800, Keith Packard wrote: > On Wed, 23 Nov 2011 16:29:58 +0800, Wu Fengguang > wrote: > > > What I need is a hot plug hook that knows whether the monitor is > > plugged or removed, which is only possible if the hook is called > >

[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-23 Thread Wu Fengguang
On Wed, Nov 23, 2011 at 02:25:14AM +0800, Keith Packard wrote: > On Tue, 22 Nov 2011 15:40:55 +0800, Wu Fengguang > wrote: > > > So the v3 patch will behave equally well on KMS console, gnome desktop > > and bare X. Shall we just use it, or go back and use the original &

Re: [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-23 Thread Wu Fengguang
On Wed, Nov 23, 2011 at 02:25:14AM +0800, Keith Packard wrote: > On Tue, 22 Nov 2011 15:40:55 +0800, Wu Fengguang > wrote: > > > So the v3 patch will behave equally well on KMS console, gnome desktop > > and bare X. Shall we just use it, or go back and use the original &

[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-22 Thread Wu Fengguang
te_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDI

[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-22 Thread Wu Fengguang
On Tue, Nov 22, 2011 at 12:55:43AM +0800, Keith Packard wrote: > On Mon, 21 Nov 2011 14:37:49 +0800, Wu Fengguang > wrote: > > On monitor hot plug/unplug, update ELD and set/clear SDVO_AUDIO_ENABLE > > or DP_AUDIO_OUTPUT_ENABLE accordingly. So that the audio driver will &g

Re: [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-22 Thread Wu Fengguang
te_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDI

Re: [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Tue, Nov 22, 2011 at 12:55:43AM +0800, Keith Packard wrote: > On Mon, 21 Nov 2011 14:37:49 +0800, Wu Fengguang > wrote: > > On monitor hot plug/unplug, update ELD and set/clear SDVO_AUDIO_ENABLE > > or DP_AUDIO_OUTPUT_ENABLE accordingly. So that the audio driver will &g

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Mon, Nov 21, 2011 at 04:47:38PM +0800, Takashi Iwai wrote: > At Mon, 21 Nov 2011 09:58:09 +0800, > Wu Fengguang wrote: > > > > On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > > > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > > intel.c

[PATCH 3/3 v3] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

Re: [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Mon, Nov 21, 2011 at 04:47:38PM +0800, Takashi Iwai wrote: > At Mon, 21 Nov 2011 09:58:09 +0800, > Wu Fengguang wrote: > > > > On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > > > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > > > wro

[PATCH 3/3 v3] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

[PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-20 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

Re: [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-20 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-19 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

Re: [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-18 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-18 Thread Wu Fengguang
However when in X, ->mode_set won't be called at all. Only ->get_modes and ->detect are called... Thanks, Fengguang On Wed, Nov 16, 2011 at 09:35:48PM +0800, Wu Fengguang wrote: > Sorry forgot to remove this left over chunk... > > Note that I've not yet got the h

Re: [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-18 Thread Wu Fengguang
However when in X, ->mode_set won't be called at all. Only ->get_modes and ->detect are called... Thanks, Fengguang On Wed, Nov 16, 2011 at 09:35:48PM +0800, Wu Fengguang wrote: > Sorry forgot to remove this left over chunk... > > Note that I've not yet got the h

[PATCH 3/3 v2] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu Signed-off-by: Wu Fengguang --- drivers/gpu/drm

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
Sorry forgot to remove this left over chunk... Note that I've not yet got the hardware to test the DisplayPort part of this patch, but should be able to do so this week. > --- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16 > 20:54:27.0 +0800 > +++ linux/drivers/gpu/drm/i915

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
An embedded and charset-unspecified text was scrubbed... Name: eld-hot-removal URL:

[PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD

2011-11-16 Thread Wu Fengguang
An embedded and charset-unspecified text was scrubbed... Name: no-extra-eld-passing URL:

[PATCH 1/3] drm/i915: fix ELD writing for SandyBridge

2011-11-16 Thread Wu Fengguang
An embedded and charset-unspecified text was scrubbed... Name: sandybridge-eld-fix URL:

[PATCH 0/3] HDMI ELD fixes for 3.2

2011-11-16 Thread Wu Fengguang
Keith, Here are 3 fixes on HDMI/ELD audio. The third one adds a ->hot_remove hook to drm_connector_funcs. Please review. [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD [PATCH 3/3] drm/i915: hot removal notification to HDMI

[PATCH 3/3 v2] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu Signed-off-by: Wu Fengguang --- drivers/gpu/drm

Re: [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
Sorry forgot to remove this left over chunk... Note that I've not yet got the hardware to test the DisplayPort part of this patch, but should be able to do so this week. > --- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16 > 20:54:27.0 +0800 > +++ linux/drivers/gpu/drm/i915

[PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu Signed-off-by: Wu Fengguang --- drivers/gpu/drm

[PATCH 1/3] drm/i915: fix ELD writing for SandyBridge

2011-11-16 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h |6 +++--- drivers/gpu/drm/i915/intel_display.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) --- linux.orig/drivers/gpu/drm/i915

[PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD

2011-11-16 Thread Wu Fengguang
The ELD may or may not change when switching the video mode. If unchanged, don't trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Reported-by: Nick Bowler Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c |

[PATCH 0/3] HDMI ELD fixes for 3.2

2011-11-16 Thread Wu Fengguang
Keith, Here are 3 fixes on HDMI/ELD audio. The third one adds a ->hot_remove hook to drm_connector_funcs. Please review. [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD [PATCH 3/3] drm/i915: hot removal notification to HDMI

Linux 3.2-rc1

2011-11-10 Thread Wu Fengguang
7;t trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c | 51 ++--- 1 file changed, 46 insertions(+), 5 deletions(-) --- linux.orig/drivers/gpu/drm/i915/i

Re: Linux 3.2-rc1

2011-11-10 Thread Wu Fengguang
o driver. This avoids disturbing the user with repeated printks. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c | 51 ++--- 1 file changed, 46 insertions(+), 5 deletions(-) --- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-10 17:23:04.0

Linux 3.2-rc1

2011-11-09 Thread Wu Fengguang
On Wed, Nov 09, 2011 at 03:40:19PM +0800, Takashi Iwai wrote: > At Tue, 8 Nov 2011 12:23:30 -0800, > Linus Torvalds wrote: > > > > Hmm, I don't know what caused this to trigger, but I'm adding both the > > i915 people and the HDA people to the cc, and they can fight to the > > death about this in

Re: Linux 3.2-rc1

2011-11-09 Thread Wu Fengguang
On Wed, Nov 09, 2011 at 03:40:19PM +0800, Takashi Iwai wrote: > At Tue, 8 Nov 2011 12:23:30 -0800, > Linus Torvalds wrote: > > > > Hmm, I don't know what caused this to trigger, but I'm adding both the > > i915 people and the HDA people to the cc, and they can fight to the > > death about this in

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote: > On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang > wrote: > > On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > > > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang > > intel.com> wrote: &g

[PATCH 2/2 v2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: Paul Menzel CC: Pierre-Louis Bossart Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 drivers/gpu/drm/i915/intel_display.c | 131 +++

[PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
I'd like to do more cleanups: > + int aud_cntl_st; > + int aud_cntrl_st2; s/aud_cntrl_st2/aud_cntl_st2/ > + if (IS_IVYBRIDGE(connector->dev)) { > + hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A; > + aud_cntl_st = GEN7_AUD_CNTRL_ST_A; > + aud_cntrl_st2 = G

[PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
Jeremy Bush CC: Christopher White CC: Pierre-Louis Bossart CC: Paul Menzel Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 drivers/gpu/drm/i915/intel_display.c | 131 - drivers/gpu/drm/

[PATCH 1/2] drm: support routines for HDMI/DP ELD

2011-09-05 Thread Wu Fengguang
ggs Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 +++ include/drm/drm_edid.h |9 + 2 files changed, 180 insertions(+) --- linux-next.orig/include/drm/drm_crtc.h 2011-09-04 09:42:19.0 +0800 +++ linux-next/include/drm/drm_c

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 06:57:23PM +0800, James Cloos wrote: > >>>>> "WF" == Wu Fengguang writes: > > WF> ... If only the stereo playback capability is reported, the user > WF> won't be able to start 8-channel playback; if the 8-channel ELD is

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang > wrote: > > Changes from v4: remove a debug call to dump_stack(). > > Thanks to Bossart for catching this! > > --- > > > > Add ELD support fo

[Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
nd happily accept both Fengguang and Wu :) > Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang: > > Changes from v4: remove a debug call to dump_stack(). > > Thanks to Bossart for catching this! > > His first name is Pierre-Louis. I do not know how you address people a

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-05 Thread Wu Fengguang
On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote: > On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang > wrote: > > On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > > > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang > > > wrote: > >

[PATCH 2/2 v2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: Paul Menzel CC: Pierre-Louis Bossart Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 drivers/gpu/drm/i915/intel_display.c | 131 +++

Re: [PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
I'd like to do more cleanups: > + int aud_cntl_st; > + int aud_cntrl_st2; s/aud_cntrl_st2/aud_cntl_st2/ > + if (IS_IVYBRIDGE(connector->dev)) { > + hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A; > + aud_cntl_st = GEN7_AUD_CNTRL_ST_A; > + aud_cntrl_st2 = G

[PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Jeremy Bush CC: Christopher White CC: Pierre-Louis Bossart CC: Paul Menzel Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 drivers/gpu/drm/i915/intel_display.c | 131 - drivers/gpu/drm/

[PATCH 1/2] drm: support routines for HDMI/DP ELD

2011-09-04 Thread Wu Fengguang
ggs Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 +++ include/drm/drm_edid.h |9 + 2 files changed, 180 insertions(+) --- linux-next.orig/include/drm/drm_crtc.h 2011-09-04 09:42:19.0 +0800 +++ linux-next/include/drm/drm_c

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 06:57:23PM +0800, James Cloos wrote: > >>>>> "WF" == Wu Fengguang writes: > > WF> ... If only the stereo playback capability is reported, the user > WF> won't be able to start 8-channel playback; if the 8-channel ELD is

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang > wrote: > > Changes from v4: remove a debug call to dump_stack(). > > Thanks to Bossart for catching this! > > --- > > > > Add ELD support fo

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
nd happily accept both Fengguang and Wu :) > Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang: > > Changes from v4: remove a debug call to dump_stack(). > > Thanks to Bossart for catching this! > > His first name is Pierre-Louis. I do not know how you address people a

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Ben Skeggs Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 +++

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-03 Thread Wu Fengguang
Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Ben Skeggs Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i915_reg.h | 25 +++

[PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
Keith: this version completes the IvyBridge support :) Bossart: hotplug is working fine now, with some minor issues: - on G45, monitor hot removal is not handled at all in i915_driver_irq_handler(). I'll leave it as a future TODO. - on IvyBridge, _repeated_ plug/unplug will trigger [ 1183.6

[PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
ill find invalid ELD data and hence rightfully abort, even when it sees the ELD_valid indicator. Thanks to Zhenyu and Bossart for a lot of valuable help and testing. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Ben Skeg

Re: [PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
Keith: this version completes the IvyBridge support :) Bossart: hotplug is working fine now, with some minor issues: - on G45, monitor hot removal is not handled at all in i915_driver_irq_handler(). I'll leave it as a future TODO. - on IvyBridge, _repeated_ plug/unplug will trigger [ 1183.6

[PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
ill find invalid ELD data and hence rightfully abort, even when it sees the ELD_valid indicator. Thanks to Zhenyu and Bossart for a lot of valuable help and testing. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Ben Skeg

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Wu Fengguang
On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > wrote: > > > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > > > > the drm_encoder object is there, however encoder-&g

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-05 Thread Wu Fengguang
On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote: > On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang > wrote: > > > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(), > > > > the drm_encoder object is there, however encoder-&g

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Wu Fengguang
> On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang > wrote: > > > 1) intel_write_eld() is not called at all > >It seems we need to call intel_write_eld() in other places besides > >inside ->mode_set(). Is ->detect() the right place to do so? In > >

Re: [PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-04 Thread Wu Fengguang
> On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang > wrote: > > > 1) intel_write_eld() is not called at all > >It seems we need to call intel_write_eld() in other places besides > >inside ->mode_set(). Is ->detect() the right place to do so? In > >

[PATCH v3] pass ELD to HDMI/DP audio driver

2011-08-01 Thread Wu Fengguang
Hi Jesse, > On Wed, 29 Jun 2011 21:10:13 +0800 > Wu Fengguang wrote: > > > Update: according to the spec, limit max a/v latencies to 500ms and > > avoid overflowing the ELD field Aud_Synch_Delay[7:0]. > > > > Thanks to Pierre for pointing this out! > >

[PATCH v2] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
LD_valid bit for ALL the three ports. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h

[PATCH] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
> This patch is tested OK on G45/HDMI and IbexPeak/HDMI. DisplayPort is > tested on several IbexPeak and Sandybridge boxes, however not working, > possibly due to hardware/monitor problems. FYI, here is an example ELD dump in G45/HDMI. wfg at slim ~% cat /proc/asound/card0/eld\#1.0 monitor_presen

[PATCH] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
ree ports. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i9

[PATCH v2] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
LD_valid bit for ALL the three ports. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h

Re: [PATCH] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
> This patch is tested OK on G45/HDMI and IbexPeak/HDMI. DisplayPort is > tested on several IbexPeak and Sandybridge boxes, however not working, > possibly due to hardware/monitor problems. FYI, here is an example ELD dump in G45/HDMI. wfg@slim ~% cat /proc/asound/card0/eld\#1.0 monitor_present

[PATCH] pass ELD to HDMI/DP audio driver

2011-06-29 Thread Wu Fengguang
ree ports. CC: Zhao Yakui CC: Wang Zhenyu CC: Jeremy Bush CC: Christopher White CC: "Bossart, Pierre-louis" Signed-off-by: Wu Fengguang --- drivers/gpu/drm/drm_edid.c | 171 + drivers/gpu/drm/i915/i915_drv.h |2 drivers/gpu/drm/i915/i9