Re: [PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-17 Thread Xinliang Liu
> > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index f12a868..f4e49e0 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -5694,7 +5694,7 @@ F: drivers/gpu/drm/gma500/ > > > >

Re: [PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-12 Thread Xinliang Liu
Hi, On Tue, 11 Aug 2020 at 16:25, Tian Tao wrote: > > Remove Rongrong Zou and change tiantao as hisilicon DRM maintainer. > > Signed-off-by: Tian Tao Thanks Tian Tao, Tian Tao now is actively maintaining hibmc driver. Happy to hear this. Acked-by: Xinliang Liu -Xinliang > ---

Re: [PATCH] drm/hisilicon/hibmc: Move drm_fbdev_generic_setup() down to avoid the splat

2020-07-09 Thread Xinliang Liu
Hi Zenghui, Thanks for fixing this. Applied to drm-misc-fixes. Best, -Xinliang On Mon, 6 Jul 2020 at 22:53, Zenghui Yu wrote: > > The HiSilicon hibmc driver triggers a splat at boot time as below > > [ 14.137806] [ cut here ] > [ 14.142405] hibmc-drm :0a:00.0: Dev

Re: [PATCH] drm: kirin: Revert change to add register connect helper functions

2020-04-13 Thread Xinliang Liu
his patch reverts the change as suggested by Daniel. > > [1]: > https://lore.kernel.org/lkml/CAKMK7uHr5U-pPsxdQ4MpfK5v8iLjphDFug_3VTiUAf06nhS=y...@mail.gmail.com/ > > Cc: Xu YiPing > Cc: Rongrong Zou > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Chen Feng > Cc: David Air

Re: [PATCH 2/4] drm/hisilicon: Code cleanup for hibmc_drv_vdac

2020-04-02 Thread Xinliang Liu
Hi Tao, On Fri, 6 Mar 2020 at 11:44, Tian Tao wrote: > > code cleanup for hibmc_drv_vdac.c, no actual function changes. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 49 > > 1 file changed, 16 inser

Re: [PATCH 1/4] drm/hisilicon: Enforce 128-byte stride alignment to fix the hardware limitation

2020-04-02 Thread Xinliang Liu
esolution under 16bpp. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie Thanks for the patch. Acked-by: Xinliang Liu Applied to drm-misc. -Xinliang > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 9 + > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_

Re: [PATCH] drm: kirin: Revert "Fix for hikey620 display offset problem"

2020-03-05 Thread Xinliang Liu
raoches to avoid this, but none has yet > been successful and the cure here is worse then the original > disease, so revert this for now. Sorry to hear that. Then it seems such underflow errors can't be recovered via reset. Anyway, for this patch Acked-by: Xinliang Liu And applied to d

Re: [PATCH] drm: kirin: Revert "Fix for hikey620 display offset problem"

2020-03-05 Thread Xinliang Liu
On Wed, 4 Mar 2020 at 17:28, Xinliang Liu wrote: > > On Wed, 4 Mar 2020 at 00:32, John Stultz wrote: > > > > This reverts commit ff57c6513820efe945b61863cf4a51b79f18b592. > > > > With the commit ff57c6513820 ("drm: kirin: Fix for hikey620 > > disp

Re: [PATCH v2] drm/hisilicon: Fixed pcie resource conflict between drm and firmware

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Mon, 24 Feb 2020 at 14:02, Tian Tao wrote: > use the drm_fb_helper_remove_conflicting_pci_framebuffer to remove > the framebuffer initialized by fireware/bootloader to avoid resource > conflict. > > Signed-off-by: Tian Tao > > --- > v2: use

Re: [PATCH v2] drm/hisilicon: Add the mode_valid function

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Wed, 8 Jan 2020 at 17:41, Tian Tao wrote: > add mode_valid function, we can make sure the resolution is valid. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > Reviewed-by: Thomas Zimmermann > > --- > v2: declare hibmc_crtc_mode

Re: [PATCH] drm/hisilicon: Enable the shadowfb for hibmc

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Sat, 11 Jan 2020 at 11:09, Tian Tao wrote: > set the prefer_shadow as 1,so we use the shadowfb to acceleration. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- > 1 file

Re: [PATCH] drm/hisilicon: fixed the wrong resolution configurations

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Fri, 3 Jan 2020 at 11:55, Tian Tao wrote: > The maximum resolution supported by hibmc is 1920 * 1200 instead of > 1920 * 1440, this patch fixed this problem > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisi

Re: [PATCH] drm/hisilicon: Add new clock/resolution configurations

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Tue, 31 Dec 2019 at 14:43, Tian Tao wrote: > Add the three new pll config for corresponding resolution 1440x900 and > 1600x900, 640x480 for hibmc > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc

Re: [PATCH] drm/hisilicon: Set preferred mode resolution and maximum resolution

2020-02-25 Thread Xinliang Liu
On Wed, 19 Feb 2020 at 10:52, Tian Tao wrote: > set the preferred mode resolution to 1024 * 768 and maximum > resolution to 1920 * 1200. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 10 +- > 1 file changed, 9 insert

Re: [PATCH] drm/hisilicon: Set preferred mode resolution and maximum resolution

2020-02-25 Thread Xinliang Liu
On Tue, 25 Feb 2020 at 10:19, Xinliang Liu wrote: > > > On Wed, 19 Feb 2020 at 10:52, Tian Tao wrote: > >> set the preferred mode resolution to 1024 * 768 and maximum >> resolution to 1920 * 1200. >> >> Signed-off-by: Tian Tao >> Signed-off-by: Gong ju

Re: [PATCH] MAINTAINERS: Update myself email address

2020-02-21 Thread Xinliang Liu
On Fri, 21 Feb 2020 at 02:22, Daniel Vetter wrote: > On Thu, Feb 20, 2020 at 07:21:41PM +0100, Daniel Vetter wrote: > > On Thu, Feb 20, 2020 at 09:03:28AM +, Xinliang Liu wrote: > > > Update myself email address. > > > Add John Stultz as a reviewer. Thanks John. &

[PATCH] MAINTAINERS: Update myself email address

2020-02-21 Thread Xinliang Liu
Update myself email address. Add John Stultz as a reviewer. Thanks John. Update git tree to drm-misc Signed-off-by: Xinliang Liu --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 978766c6715e..befc3c0afc75 100644 --- a

Re: [PATCH] drm/hisilicon: Fixed pcie resource conflict using the general API

2020-02-21 Thread Xinliang Liu
Hi tao, Are you sending a wrong patch? Function hibmc_remove_framebuffers is added by your prior reviewing patch. Please send patch based on drm-misc-next branch[1] or linux-next. Thanks, -Xinliang [1] https://anongit.freedesktop.org/git/drm-misc.git On Fri, 21 Feb 2020 at 13:56, Tian Tao wrote

Re: [PATCH] drm/hisilicon/hibmc: add gamma_set function

2020-02-13 Thread Xinliang Liu
On Mon, 23 Dec 2019 at 15:50, Zhihui Chen wrote: > add gamma_set function, and we can also use it to adjust the brightness of > the > display. > > Signed-off-by: Zhihui Chen > Thanks for the patch. Acked-by: Xinliang Liu Applied to drm-misc-next. > --- > ...

Re: [PATCH] drm/hisilicon/hibmc: add DPMS on/off function

2020-02-13 Thread Xinliang Liu
On Fri, 20 Dec 2019 at 10:31, Zhihui Chen wrote: > add DPMS function to turn on/off signal of monitor > > Signed-off-by: Zhihui Chen > Thanks for the patch. Acked-by: Xinliang Liu Applied to drm-misc-next. > --- > drivers/gpu/drm/hisilicon/hibmc/hib

Re: [PATCH] drm/hisilicon/hibmc: fix 'xset dpms force off' fail

2020-02-13 Thread Xinliang Liu
On Fri, 20 Dec 2019 at 10:30, Zhihui Chen wrote: > both crtc_state->adjusted_mode.hdisplay and > crtc_state->adjusted_mode.vdisplay are 0 when switch dpms off, > return -EINVAL cause switch dpms off fail. > > Signed-off-by: Zhihui Chen > Thanks for the patch. Acked-by:

Re: [PATCH] drm/hisilicon: Checked the resolution is valid before connector

2019-12-31 Thread Xinliang Liu
Hi tiantao, Thanks for the patches. I see you sent two patches about resolution. Could you just send them as a series? Xinliang On Sat, 28 Dec 2019 at 08:59, Tian Tao wrote: > In the previous version, the callback function mode_valid of > drm_connector_helper_funcs directly returned MODE_OK. No

Re: [PATCH 0/3] HiBMC driver fixes

2018-09-27 Thread Xinliang Liu
On Wed, 26 Sep 2018 at 17:54, John Garry wrote: > > On 26/09/2018 10:41, Xinliang Liu wrote: > > On Wed, 26 Sep 2018 at 16:46, John Garry wrote: > >> > >> On 26/09/2018 04:00, Xinliang Liu wrote: > >>> Thanks John, good addressing! > >>>

Re: [GIT PULL] drm-hisilicon-next-2018-09-26

2018-09-27 Thread Xinliang Liu
On Thu, 27 Sep 2018 at 08:58, Dave Airlie wrote: > > On Wed, 26 Sep 2018 at 15:58, Xinliang Liu wrote: > > > > Hi Dave, > > A few changes for 4.20. Please pull. > > - A crash fix founded in recent linux-next from John Garry > > - One sparse warning fix from S

Re: [PATCH 0/3] HiBMC driver fixes

2018-09-26 Thread Xinliang Liu
On Wed, 26 Sep 2018 at 16:46, John Garry wrote: > > On 26/09/2018 04:00, Xinliang Liu wrote: > > Thanks John, good addressing! > > The root cause as you said, our hibmc previous frame buffer format > > depth setting is wrong which does not pass the new fo

[GIT PULL] drm-hisilicon-next-2018-09-26

2018-09-25 Thread Xinliang Liu
Hi Dave, A few changes for 4.20. Please pull. - A crash fix founded in recent linux-next from John Garry - One sparse warning fix from Souptick Joarder - Some xxx_unref cleanup from Thomas Zimmermann Thanks, Xinliang The following changes since commit 36c9c3c91128e2b892c9be0dd9ee9bd82cbe82ad:

Re: [PATCH] drm/hisilicon: Replace drm_dev_unref with drm_dev_put

2018-09-25 Thread Xinliang Liu
rry for late reply. Reviewed-by: Xinliang Liu Applied to hisilicon-drm-next. Thanks, Xinliang > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 8 > 2 files changed, 6 insertions(+), 6 deletions(-) &g

Re: [PATCH] drm/hisilicon: Replace ttm_bo_unref with ttm_bo_put

2018-09-25 Thread Xinliang Liu
hout clearing the pointer. > > The current behaviour of cleaning the pointer is kept in the calling code, > but should be removed if not required in a later patch. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Xinliang Liu Applied to hisilicon-drm-next. Thanks, Xinliang > --

Re: [PATCH 0/3] HiBMC driver fixes

2018-09-25 Thread Xinliang Liu
Thanks John, good addressing! The root cause as you said, our hibmc previous frame buffer format depth setting is wrong which does not pass the new format sanity checking drm_mode_legacy_fb_format. For this series, Reviewed-by: Xinliang Liu Applied to hisilicon-drm-next. Thanks, Xinliang On

Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()

2018-09-25 Thread Xinliang Liu
o use > > > drm_mode_config_helper_suspend/resume(). > > > > > > Fixed one sparse warning by making hibmc_drm_interrupt > > > static. > > > > > > Signed-off-by: Ajit Negi > > > Signed-off-by: Souptick Joarder > > > Reviewed-b

Re: [Ask for help] ATI HD 7470 card on arm64 platform

2017-12-10 Thread Xinliang Liu
On 7 December 2017 at 19:11, Michel Dänzer wrote: > On 2017-12-07 10:35 AM, Xinliang Liu wrote: >> Hi, >> >> We are trying ATI HD 7470 card on arm64 platform D05 with kernel 4.1.40. >> But it failed with kernel log: >> radeon 0005:01:00: ring 0 stalled for more th

Re: [Ask for help] ATI HD 7470 card on arm64 platform

2017-12-07 Thread Xinliang Liu
cc z.liuxinli...@hisilicon.com On 7 December 2017 at 17:54, Xinliang Liu wrote: > Thanks Christian, > > add tangyongqian in the loop. > > On 7 December 2017 at 17:40, Christian König wrote: >> Hi Xinliang, >> >> please provide the output of lspci and the conten

Re: [Ask for help] ATI HD 7470 card on arm64 platform

2017-12-07 Thread Xinliang Liu
Thanks Christian, add tangyongqian in the loop. On 7 December 2017 at 17:40, Christian König wrote: > Hi Xinliang, > > please provide the output of lspci and the content of /proc/iomem will privide these info asap. > > Thanks, > Christian. > > > Am 07.12.2017 um

[Ask for help] ATI HD 7470 card on arm64 platform

2017-12-07 Thread Xinliang Liu
Hi, We are trying ATI HD 7470 card on arm64 platform D05 with kernel 4.1.40. But it failed with kernel log: radeon 0005:01:00: ring 0 stalled for more than 1msec radeon 0005:01:00: GPU lockup (current fence id 0x0001 last fence id 0x0002 on ring0) radeon 0005:01:00: rin

[GIT PULL] drm-hisilicon-next

2017-10-31 Thread Xinliang Liu
Hi Dave, One fix for next. Best, Xinliang The following changes since commit 62884cd386b876638720ef88374b31a84ca7ee5f: drm: Add four ioctls for managing drm mode object leases [v7] (2017-10-25 16:31:30 +1000) are available in the git repository at: g...@github.com:xin3liang/linux.git tags/

Re: [PATCH v4 03/10] drm/hisilicon/kirin: Use drm_gem_fb_create()

2017-09-27 Thread Xinliang Liu
On 24 September 2017 at 20:26, Noralf Trønnes wrote: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Xinliang Liu > Cc: Rongrong Zou > Cc: Xinwei Kong > Cc: Chen Feng > Signed-off-by: Noralf Trønn

Re: [GIT PULL] drm-hisilicon-next

2017-08-29 Thread Xinliang Liu
On 29 August 2017 at 21:57, Daniel Vetter wrote: > On Tue, Aug 29, 2017 at 11:54 AM, Xinliang Liu > wrote: >> Hi Dave, >> >> On 29 August 2017 at 16:32, Daniel Vetter wrote: >>> On Tue, Aug 29, 2017 at 10:46:33AM +0800, Xinliang Liu wrote: >>>> H

Re: [GIT PULL] drm-hisilicon-next

2017-08-29 Thread Xinliang Liu
Hi Dave, On 29 August 2017 at 16:32, Daniel Vetter wrote: > On Tue, Aug 29, 2017 at 10:46:33AM +0800, Xinliang Liu wrote: >> Hi Dave, >> One fix for next. >> Sorry for late pull request. If it can't catch this round, will resend >> on next round. > > drm-m

[GIT PULL] drm-hisilicon-next

2017-08-28 Thread Xinliang Liu
Hi Dave, One fix for next. Sorry for late pull request. If it can't catch this round, will resend on next round. Best, Xinliang The following changes since commit 7846b12fe0b5feab5446d892f41b5140c1419109: Merge branch 'drm-vmwgfx-next' of git://people.freedesktop.org/~syeh/repos_linux into d

Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

2017-08-28 Thread Xinliang Liu
Hi Daniel, On 28 August 2017 at 16:51, Daniel Vetter wrote: > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 15 August 2017 at 22:14, Peter Griffin wrote: >> >> > This patch fixes the following soft lockup: >> > BU

Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

2017-08-28 Thread Xinliang Liu
gt; ​​Thanks Peter, This patch looks good to me. Reviewed-by: Xinliang Liu ​ @Sean, could you please help to apply to drm-misc if others has no more comments, thanks. Thanks, Xinliang ​ > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ > 1

Re: [PATCH v5] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

2017-08-28 Thread Xinliang Liu
make > sure we are validating the mode clock that will eventually be > used. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Sean Paul > Cc: David Airlie > Cc: Rob Clark > Cc: Xinliang Liu > Cc: Xinliang Liu > Cc: Rongrong Zou > Cc: Xinwei Kon

Re: [PATCH v3 10/23] drm: hibmc: use vblank hooks in struct drm_crtc_funcs

2017-02-15 Thread Xinliang Liu
ned-off-by: Shawn Guo > Cc: Xinliang Liu Thanks Shawn for the rework patches, For the hibmc, Reviewed-by: Xinliang Liu Thanks, -xinliang > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 20 > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 22

Re: [PATCH v3 11/23] drm: kirin: use vblank hooks in struct drm_crtc_funcs

2017-02-15 Thread Xinliang Liu
ned-off-by: Shawn Guo > Cc: Xinliang Liu Thanks Shawn for the rework patches, For the kirin, Reviewed-by: Xinliang Liu Thanks, -xinliang > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff

[PATCH v7 0/7] Add DRM driver for Hisilicon Hibmc

2016-11-17 Thread Xinliang Liu
Hi Rongrong, Thanks for your hard work. For this whole series patches: Reviewed-by: Xinliang Liu Thanks, -xinliang On 16 November 2016 at 21:43, Rongrong Zou wrote: > This patch set adds a new drm driver for Hisilicon Hibmc. Hibmc is a > BMC SoC with a display controller intergrated, u

[PATCH v3 1/9] drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver

2016-10-18 Thread Xinliang Liu
On 14 October 2016 at 22:33, Benjamin Gaignard wrote: > Just by curiosity, why using "old" TTM instead of GEM ? any particular > reasons ? >From the linux kernel DRM mm doc[1] it says: "GEM has simpler initialization and execution requirements than 25 TTM, but has no video RAM management capabi

[PATCH] drm/hisilicon: Don't set drm_device->platformdev

2016-09-01 Thread Xinliang Liu
s is the 2nd attempt after the first one failed and had to be > reverted again in > > commit 9cd2e854d61ccfa51686f3ed7b0c917708fc641f > Author: Daniel Vetter > Date: Wed Aug 17 13:59:40 2016 +0200 > > Revert "drm/hisilicon: Don't set drm_device->platformd

[PATCH 2/2] drm/hisilicon: Make it compile again

2016-09-01 Thread Xinliang Liu
Hi, On 26 August 2016 at 10:28, Rob Clark wrote: > On Thu, Aug 25, 2016 at 9:48 PM, Xinliang Liu > wrote: >> On 17 August 2016 at 19:11, Daniel Vetter wrote: >>> On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote: >>>> Hi, >>>> &

[PATCH 2/2] drm/hisilicon: Make it compile again

2016-08-26 Thread Xinliang Liu
On 17 August 2016 at 19:11, Daniel Vetter wrote: > On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 17 August 2016 at 18:17, Daniel Vetter wrote: >> > I just broke the build :( >> > >> > Note that the cleanup function i

[PATCH 2/2] drm/hisilicon: Make it compile again

2016-08-17 Thread Xinliang Liu
bit, but otherwise it's perfectly fine. Because this driver is written for ARM64 SoCs. Thanks, -xinliang > > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Chen Feng > Cc: Sean Paul > Fixes: d25bcfb8c2e1 ("drm/hisilicon: Don't set drm_device->platformdev") > Sign

[PATCH 07/21] drm/hisilicon: Don't set drm_device->platformdev

2016-08-17 Thread Xinliang Liu
rin_dc_ops really > wants to operate on the platform_device, not something else. Also > bonus points for implementing abstraction, and then storing the vfunc > in a global variable. > > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Archit Taneja > Reviewed-by: Sean Paul > S

[PATCH -next] drm/hisilicon: Fix error handling of ade_power_up()

2016-07-26 Thread Xinliang Liu
On 19 July 2016 at 19:30, Wei Yongjun wrote: > From: Wei Yongjun > > Fix the reset_control_deassert() fail and clk_prepare_enable() fail > error handling of ade_power_up(). > > Signed-off-by: Wei Yongjun Applied, thanks. -xinliang > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 10

[PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

2016-07-18 Thread Xinliang Liu
On 13 July 2016 at 20:43, wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Hi, thanks. This patch had already appli

[PATCH -next] drm/hisilicon: Remove redundant dev_err call in ade_dts_parse()

2016-07-18 Thread Xinliang Liu
Hi, thanks. This patch had already applied to drm-hisilicon-next. On 13 July 2016 at 20:44, wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- > dr

[PATCH -next] drm/hisilicon: Fix non static symbol warning

2016-07-18 Thread Xinliang Liu
On 13 July 2016 at 20:43, wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:107:5: warning: > symbol 'ade_get_channel_formats' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Thanks, applied to drm-hisi

[GIT PULL] drm-hisilicon-next

2016-07-04 Thread Xinliang Liu
f handling (2016-07-04 18:49:21 +0800) Wei Yongjun (1): drm/hisilicon: Fix return value check in ade_dts_parse() Xinliang Liu (1): drm/hisilicon: Fix ADE vblank on/off handling Zoltan Kuscsik (1): drm/hisilicon:

[PATCH v8 02/10] drm/hisilicon: Add hisilicon kirin drm master driver

2016-06-30 Thread Xinliang Liu
On 13 April 2016 at 20:15, Emil Velikov wrote: > Hi Xinliang, > > On 11 April 2016 at 09:55, Xinliang Liu wrote: > >> +static int kirin_drm_connectors_register(struct drm_device *dev) >> +{ >> + struct drm_connector *connector; >> + st

[PATCH] drm/hisilicon: Fix ADE vblank on/off handling

2016-06-30 Thread Xinliang Liu
Vblank turn on should be called in crtc's enable callback. And turn off called in crtc's disable callback. Thanks to Daniel Vetter, this bug is reported by him. Reported-by: Daniel Vetter Signed-off-by: Xinliang Liu --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 ++ 1 file

[PATCH] arm64: dts: Add HDMI node for hi6220-hikey

2016-06-30 Thread Xinliang Liu
Add adv7533 HDMI DT node for HiKey board. And this patch depends on the hikey display dts patch[1] and adv7533 support patch[2]. [1] https://patchwork.kernel.org/patch/9189287/ [2] http://www.spinics.net/lists/linux-arm-msm/msg21305.html Signed-off-by: Xinliang Liu --- arch/arm64/boot/dts

[PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI

2016-06-29 Thread Xinliang Liu
Hi, On 22 June 2016 at 20:59, Thierry Reding wrote: > On Wed, Jun 22, 2016 at 08:54:02AM +0800, Guodong Xu wrote: >> On 21 June 2016 at 21:34, Thierry Reding wrote: >> > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote: >> >> From: Guod

[PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-22 Thread Xinliang Liu
On 21 June 2016 at 15:19, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 3:32 AM, Xinliang Liu > wrote: >> My understanding is that drm_crtc_arm_vblank_event work together with >> drm_crtc_handle_vblank (called in vblank interrupt). >> Arm the event first in somewhere

[PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI

2016-06-22 Thread Xinliang Liu
From: Guodong Xu Add select HISI_KIRIN_DW_DSI to Kconfig. The DRM driver depends on dsi sub-driver. v2: Add myself Signed-off-by, becuase others give me the right to forward the patch. Signed-off-by: Zoltan Kuscsik Signed-off-by: Xinliang Liu --- drivers/gpu/drm/hisilicon/kirin/Kconfig

[PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI

2016-06-22 Thread Xinliang Liu
On 22 June 2016 at 08:54, Guodong Xu wrote: > On 21 June 2016 at 21:34, Thierry Reding wrote: >> On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote: >>> From: Guodong Xu >>> >>> Add select HISI_KIRIN_DW_DSI to Kconfig. >>> The DRM driver

[PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI

2016-06-22 Thread Xinliang Liu
Hi, On 21 June 2016 at 21:34, Thierry Reding wrote: > On Mon, Jun 20, 2016 at 11:59:03AM +0800, Xinliang Liu wrote: >> From: Guodong Xu >> >> Add select HISI_KIRIN_DW_DSI to Kconfig. >> The DRM driver depends on dsi sub-driver. >> >> Signed-off-by: Zol

[PATCH] arm64: dts: Add display subsystem DT nodes for hi6220-hikey

2016-06-21 Thread Xinliang Liu
Add ade and dsi DT nodes for hikey board. The binding docs were acked by Rob Herring in this thread: https://lists.freedesktop.org/archives/dri-devel/2016-March/102135.html Signed-off-by: Xinliang Liu --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 8 arch/arm64/boot/dts/hisilicon

[PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-21 Thread Xinliang Liu
On 17 June 2016 at 20:24, Daniel Vetter wrote: > On Fri, Jun 17, 2016 at 04:38:06PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 17 June 2016 at 15:23, Daniel Vetter wrote: >> > On Fri, Jun 17, 2016 at 10:09:50AM +0800, Xinliang Liu wrote: >> >> Hi Dani

[PATCH] drm/hisilicon: add select HISI_KIRIN_DW_DSI

2016-06-20 Thread Xinliang Liu
From: Guodong Xu Add select HISI_KIRIN_DW_DSI to Kconfig. The DRM driver depends on dsi sub-driver. Signed-off-by: Zoltan Kuscsik --- drivers/gpu/drm/hisilicon/kirin/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon

[PATCH 4/7] drm/hisilicon: Remove redundant calls to drm_connector_register_all()

2016-06-20 Thread Xinliang Liu
ter_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Chen Feng &g

[PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

2016-06-20 Thread Xinliang Liu
Hi, On 18 June 2016 at 02:29, wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Applied to drm-hisilicon-next. Than

[PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-17 Thread Xinliang Liu
Hi, On 17 June 2016 at 15:23, Daniel Vetter wrote: > On Fri, Jun 17, 2016 at 10:09:50AM +0800, Xinliang Liu wrote: >> Hi Daniel, >> >> I have tested your David's drm-next branch[1] which including this patch. >> In most time it is ok. But when switching modes

[PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-17 Thread Xinliang Liu
nuke the dummy functions. > > v2: Be more robust and either arm, when the CRTC is on, or just send > the event out right away. > > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Archit Taneja > Signed-off-by: Daniel Vetter Acked-by: Xinliang Liu >

[PATCH 26/27] drm/hisilicon: Use lockless gem BO free callback

2016-06-12 Thread Xinliang Liu
Hi, On 31 May 2016 at 01:53, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Xinliang Liu > Cc: Xinwei Kong > Signed-off-by: Daniel Vetter Reviewed-by: Xinliang Liu > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > 1 file

[PATCH 26/27] drm/hisilicon: Use lockless gem BO free callback

2016-05-31 Thread Xinliang Liu
Hi, thanks for your patch. On 31 May 2016 at 01:53, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Xinliang Liu > Cc: Xinwei Kong > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > 1 file

[path v2 0/7] Add DRM driver for Hisilicon Hibmc

2016-05-30 Thread Xinliang Liu
Hi Rongrong, It seems that you haven't run the checkpatch script. Please run this script to check your patches before you send them. Like bellow: $ cd yourkerneldir $ ./scripts/checkpatch.pl --strict yourpatches Thanks, -xinliang On 29 May 2016 at 17:40, Rongrong Zou wrote: > This patch set add

[path v2 7/7] drm/hisilicon/hibmc: Add maintainer for Hibmc DRM

2016-05-30 Thread Xinliang Liu
Maintained > +F: drivers/gpu/drm/hisilicon/hibmc Please add a "/" ad the end of this line. And move this part into DRM DRIVERS FOR HISILICON Thanks, -xinliang > + > DRM DRIVERS FOR HISILICON > M: Xinliang Liu > R: Xinwei Kong > -- > 1.9.1 >

[PATCH v3 7/7] dt-bindings: drm/bridge: Update bindings for ADV7533

2016-05-17 Thread Xinliang Liu
On 17 May 2016 at 11:43, Archit Taneja wrote: > > > On 05/16/2016 05:31 PM, Laurent Pinchart wrote: >> >> Hi Archit, >> >> On Friday 22 Apr 2016 11:10:18 Archit Taneja wrote: >>> >>> On 04/22/2016 04:02 AM, Laurent Pinchart wrote: On Wednesday 09 Mar 2016 16:27:18 Archit Taneja wrote: >>

[GIT PULL 2nd] drm-hisilicon-next for 4.7

2016-05-11 Thread Xinliang Liu
-hisilicon-next for you to fetch changes up to 1658437704d9f41eae2946774bdf2966245f: drm/hisilicon: Fix DRM_INFO printed issue (2016-05-11 19:05:36 +0800) Daniel Vetter (1): drm/hisilicon: Use drm_connector_register_all Xi

[PATCH] drm/hisilicon: Use drm_connector_register_all

2016-05-10 Thread Xinliang Liu
Hi Daniel, Thank you for your patch. On 6 May 2016 at 16:28, Daniel Vetter wrote: > Also, the unbind function is totally not sufficient, and it's calling > the deprecated drm_put_dev. Please look at what other drivers are > doing and fix things up. > > Cc: Xinliang Li

[PATCH 2/3] drm/hisilicon: Make kirin_drm_unbind sufficient

2016-05-10 Thread Xinliang Liu
On 9 May 2016 at 14:44, Daniel Vetter wrote: > On Mon, May 09, 2016 at 10:32:07AM +0800, Xinliang Liu wrote: >> Remove deprecated drm_put_dev. >> Clean up everything needed in unbind. >> Thanks to Daniel Vetter, this issue is reported by him. >> >> Signed-off

[PATCH 1/3] drm/hisilicon: Use drm_connector_register_all

2016-05-09 Thread Xinliang Liu
On 9 May 2016 at 14:43, Daniel Vetter wrote: > On Mon, May 09, 2016 at 10:32:06AM +0800, Xinliang Liu wrote: >> Use drm_connector_register_all helper to register connectors. >> Thanks to Daniel Vetter, this patch is raised by him. >> >> Signed-off-by: Xinliang Liu >

[PATCH 3/3] drm/hisilicon: Fix no DRM_INFO is printed issue

2016-05-09 Thread Xinliang Liu
reports to me this issue. Signed-off-by: Xinliang Liu Reported-by: Juha Leppänen --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

[PATCH 2/3] drm/hisilicon: Make kirin_drm_unbind sufficient

2016-05-09 Thread Xinliang Liu
Remove deprecated drm_put_dev. Clean up everything needed in unbind. Thanks to Daniel Vetter, this issue is reported by him. Signed-off-by: Xinliang Liu Reported-by: Daniel Vetter --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH 1/3] drm/hisilicon: Use drm_connector_register_all

2016-05-09 Thread Xinliang Liu
Use drm_connector_register_all helper to register connectors. Thanks to Daniel Vetter, this patch is raised by him. Signed-off-by: Xinliang Liu Signed-off-by: Daniel Vetter --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 31 + 1 file changed, 1 insertion(+), 30

[PATCH 0/3] A few fixes for 4.7

2016-05-09 Thread Xinliang Liu
These fixes are found and fixed recently when hisilicon pull request for 4.7 is merged into drm-next. Thanks to Daniel Vetter and Juha Leppänen, who point out the things to be fixed. Xinliang Liu (3): drm/hisilicon: Use drm_connector_register_all drm/hisilicon: Make kirin_drm_unbind

[PATCH] drm/hisilicon: Use drm_connector_register_all

2016-05-08 Thread Xinliang Liu
nks, -xinliang > > Cc: Xinliang Liu > Cc: Xinwei Kong > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 31 > + > 1 file changed, 1 insertion(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/hisi

[GIT PULL v3] drm-hisilicon-next for 4.7

2016-05-04 Thread Xinliang Liu
On 4 May 2016 at 15:24, Dave Airlie wrote: > On 29 April 2016 at 18:40, Xinliang Liu wrote: >> Hi Dave, >> >> v3: >> This driver should only work on arm64 system. >> So add ARM64 depends on to the Kconfig in this commit: >> 23e7b2ab9a8f drm/hisilicon

[PATCH v3 0/7] drm/i2c: adv7511: ADV7533 support

2016-05-03 Thread Xinliang Liu
33 > > .../bindings/display/bridge/adi,adv7511.txt| 25 +- > drivers/gpu/drm/i2c/adv7511.c | 539 > +---- > 2 files changed, 476 insertions(+), 88 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > This patch set is Tested-by: Xinliang Liu Thanks -xinliang

[GIT PULL v3] drm-hisilicon-next for 4.7

2016-04-29 Thread Xinliang Liu
20 display subsystem ---- Xinliang Liu (10): drm/hisilicon: Add device tree binding for hi6220 display subsystem drm/hisilicon: Add hisilicon kirin drm master driver drm/hisilicon: Add crtc driver for ADE drm/hisilicon:

[GIT PULL v2] drm-hisilicon-next for 4.7

2016-04-28 Thread Xinliang Liu
Xinliang Liu (10): drm/hisilicon: Add device tree binding for hi6220 display subsystem drm/hisilicon: Add hisilicon kirin drm master driver drm/hisilicon: Add crtc driver for ADE drm/hisilicon: Add plane driver for ADE drm/hisilicon: Add vblank driver for

[GIT PULL] drm-hisilicon-next-2016-04-18 for 4.7

2016-04-28 Thread Xinliang Liu
Xinliang Liu (10): drm/hisilicon: Add device tree binding for hi6220 display subsystem drm/hisilicon: Add hisilicon kirin drm master driver drm/hisilicon: Add crtc driver for ADE drm/hisilicon: Add plane driver for ADE

[GIT PULL] drm-hisilicon-next-2016-04-18 for 4.7

2016-04-27 Thread Xinliang Liu
On 27 April 2016 at 07:43, Dave Airlie wrote: > On 19 April 2016 at 19:03, Xinliang Liu wrote: >> Hi Dave, >> >> This is the first pull request from drm-hisilicon and for 4.7. >> >> The patches add new hisilicon drm driver. >> >> The patches were r

[GIT PULL] drm-hisilicon-next-2016-04-18 for 4.7

2016-04-19 Thread Xinliang Liu
ADE - Add plane driver for ADE - Add crtc driver for ADE - Add hisilicon kirin drm master driver - Add device tree binding for hi6220 display subsystem ---- Xinliang Liu (10): drm/hisilicon: Add device tree binding for hi6220 display

[PATCH v3 0/7] drm/i2c: adv7511: ADV7533 support

2016-04-19 Thread Xinliang Liu
On 18 April 2016 at 17:48, Archit Taneja wrote: > Hi, > > > On 04/17/2016 05:01 PM, Xinliang Liu wrote: >> >> Hi Archit, >> Thank you for the patches. >> >> On 9 March 2016 at 18:57, Archit Taneja wrote: >>> >>> ADV7533 is a DSI to HDMI

[PATCH v3 0/7] drm/i2c: adv7511: ADV7533 support

2016-04-17 Thread Xinliang Liu
Hi Archit, Thank you for the patches. On 9 March 2016 at 18:57, Archit Taneja wrote: > ADV7533 is a DSI to HDMI encoder chip. It's like ADV7511, but with an > additional DSI RX block that takes in DSI video mode output. > > Trying to get this driver merged has had some challenges: > > - ADV7533 h

[PATCH v8 02/10] drm/hisilicon: Add hisilicon kirin drm master driver

2016-04-14 Thread Xinliang Liu
Hi Emil, On 13 April 2016 at 20:15, Emil Velikov wrote: > Hi Xinliang, > > On 11 April 2016 at 09:55, Xinliang Liu wrote: > >> +static int kirin_drm_connectors_register(struct drm_device *dev) >> +{ >> + struct drm_connector *connector; >> + st

[PATCH v8 10/10] MAINTAINERS: Add maintainer for hisilicon DRM driver

2016-04-14 Thread Xinliang Liu
On 13 April 2016 at 19:54, Emil Velikov wrote: > Hi Xinliang, > > On 11 April 2016 at 09:55, Xinliang Liu wrote: >> Add maintainer and reviewer for hisilicon DRM driver. >> >> v8: None. >> v7: None. >> v6: None. >> v5: None. >> v4: >> - Ad

[PATCH v8 00/10] Add DRM Driver for HiSilicon Kirin hi6220 SoC

2016-04-13 Thread Xinliang Liu
On 13 April 2016 at 00:08, Daniel Vetter wrote: > On Mon, Apr 11, 2016 at 04:55:33PM +0800, Xinliang Liu wrote: >> This patch set adds a new drm driver for HiSilicon Kirin hi6220 SoC. >> Current testing and support board is Hikey board which is one of Linaro >> 96boards

[PATCH v8 10/10] MAINTAINERS: Add maintainer for hisilicon DRM driver

2016-04-11 Thread Xinliang Liu
Add maintainer and reviewer for hisilicon DRM driver. v8: None. v7: None. v6: None. v5: None. v4: - Add Chen Feng as Designated reviewer. v3: First version. Signed-off-by: Xinliang Liu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v8 09/10] drm/hisilicon: Add support for external bridge

2016-04-11 Thread Xinliang Liu
Add support for external HDMI bridge. v8: None. v7: None. v6: None. v5: None. v4: None. v3: - Fix a typo: s/exteranl/external. v2: - Remove abtraction layer. Signed-off-by: Xinliang Liu Signed-off-by: Xinwei Kong Reviewed-by: Archit Taneja --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

[PATCH v8 08/10] drm/hisilicon: Add designware dsi host driver

2016-04-11 Thread Xinliang Liu
Add DesignWare dsi host driver for hi6220 SoC. v8: None. v7: None. v6: None. v5: None. v4: None. v3: None. v2: - Remove abtraction layer. Signed-off-by: Xinliang Liu Signed-off-by: Xinwei Kong Reviewed-by: Archit Taneja --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 50

  1   2   3   >