RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-05-03 Thread Zeng, Oak
> -Original Message- > From: Jason Gunthorpe > Sent: Friday, May 3, 2024 12:28 PM > To: Zeng, Oak > Cc: Thomas Hellström ; Daniel Vetter > ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; Brost, Matthew ; > Welty, Brian ; Ghimiray

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-05-03 Thread Zeng, Oak
> -Original Message- > From: Jason Gunthorpe > Sent: Friday, May 3, 2024 9:38 AM > To: Zeng, Oak > Cc: Thomas Hellström ; Daniel Vetter > ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; Brost, Matthew ; > Welty, Brian ; Ghimiray

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-05-02 Thread Zeng, Oak
address range before we call hmm range fault, because the migration codes need to look up cpu vma anyway. what is the point of the first hmm_range fault? Oak > -Original Message- > From: Thomas Hellström > Sent: Thursday, May 2, 2024 11:02 AM > To: Jason Gunthorpe > Cc: Danie

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-24 Thread Zeng, Oak
. Currently we don't know. 3) whether driver can look up cpu vma. I think we need this for data migration purpose. See also comments inline. > -Original Message- > From: Jason Gunthorpe > Sent: Wednesday, April 24, 2024 9:49 AM > To: Zeng, Oak > Cc: dri-devel@lists.

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-23 Thread Zeng, Oak
). But the main concern you raised is not addressed yet. I need to further make sure I understand your concerns, See inline. > -Original Message- > From: Jason Gunthorpe > Sent: Tuesday, April 9, 2024 1:24 PM > To: Zeng, Oak > Cc: dri-devel@lists.freedes

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-09 Thread Zeng, Oak
t: Friday, April 5, 2024 2:02 PM > To: Zeng, Oak > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Brost, > Matthew ; thomas.hellst...@linux.intel.com; > Welty, Brian ; Ghimiray, Himal Prasad > ; Bommu, Krishnaiah > ; Vishwanathapura, Niranjana > ; Leon Romano

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-05 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Jason > Gunthorpe > Sent: Friday, April 5, 2024 8:37 AM > To: Zeng, Oak > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Brost, > Matthew ; thomas.hellst...@linux.intel.com; > Welty,

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-04 Thread Zeng, Oak
Hi Jason, > -Original Message- > From: Jason Gunthorpe > Sent: Thursday, April 4, 2024 8:39 PM > To: Zeng, Oak > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Brost, > Matthew ; thomas.hellst...@linux.intel.com; > Welty, Brian ; Ghimiray, H

RE: Making drm_gpuvm work across gpu devices

2024-03-07 Thread Zeng, Oak
Hello all, Since I didn't get a reply for this one, I assume below are agreed. But feel free to let us know if you don't agree. Thanks, Oak -Original Message- From: dri-devel On Behalf Of Zeng, Oak Sent: Thursday, February 29, 2024 1:23 PM To: Christian König ; Daniel Vetter ; David

RE: Making drm_gpuvm work across gpu devices

2024-02-29 Thread Zeng, Oak
it can also be used by other vendors. Thomas and me still have open questions to Christian. We will follow up. Thanks all for this discussion. Regards, Oak > -Original Message- > From: Christian König > Sent: Thursday, February 1, 2024 3:52 AM > To: Zeng, Oak ; Daniel Ve

RE: Making drm_gpuvm work across gpu devices

2024-02-29 Thread Zeng, Oak
be anything in the range of [0~2^57-1]. This design requirement is quite simple and clean. I don’t see how to solve this with userfaultfd/on demand mirroring. Regards, Oak From: Christian König Sent: Thursday, February 29, 2024 4:41 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter

RE: Making drm_gpuvm work across gpu devices

2024-02-28 Thread Zeng, Oak
The mail wasn’t indent/preface correctly. Manually format it. From: Christian König mailto:christian.koe...@amd.com>> Sent: Tuesday, February 27, 2024 1:54 AM To: Zeng, Oak mailto:oak.z...@intel.com>>; Danilo Krummrich mailto:d...@redhat.com>>; Dave Airlie mailto:airl...@re

RE: Making drm_gpuvm work across gpu devices

2024-02-27 Thread Zeng, Oak
From: Christian König Sent: Tuesday, February 27, 2024 1:54 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling ; jgli...@redhat.com Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Bommu, Krishnaiah ; Ghimiray, Himal Prasad

RE: Making drm_gpuvm work across gpu devices

2024-02-23 Thread Zeng, Oak
. It looks like you were talking of 1). Were you? Oak From: Christian König Sent: Wednesday, January 24, 2024 3:33 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Bommu

RE: Making drm_gpuvm work across gpu devices

2024-01-31 Thread Zeng, Oak
Fixed one typo: GPU VA != GPU VA should be GPU VA can != CPU VA > -Original Message- > From: Zeng, Oak > Sent: Wednesday, January 31, 2024 3:17 PM > To: Daniel Vetter ; David Airlie > Cc: Christian König ; Thomas Hellström > ; Brost, Matthew > ; Felix Kuehling ;

RE: Making drm_gpuvm work across gpu devices

2024-01-31 Thread Zeng, Oak
4 4:15 AM > To: David Airlie > Cc: Zeng, Oak ; Christian König > ; Thomas Hellström > ; Daniel Vetter ; Brost, > Matthew ; Felix Kuehling > ; Welty, Brian ; dri- > de...@lists.freedesktop.org; Ghimiray, Himal Prasad > ; Bommu, Krishnaiah > ; Gupta, saurabhg ; >

RE: Making drm_gpuvm work across gpu devices

2024-01-30 Thread Zeng, Oak
: Christian König Sent: Tuesday, January 30, 2024 3:40 AM To: Zeng, Oak ; Thomas Hellström ; Daniel Vetter ; Dave Airlie Cc: Brost, Matthew ; Felix Kuehling ; Welty, Brian ; dri-devel@lists.freedesktop.org; Ghimiray, Himal Prasad ; Bommu, Krishnaiah ; Gupta, saurabhg ; Vishwanathapura, Niranjana

RE: re:Making drm_gpuvm work across gpu devices

2024-01-29 Thread Zeng, Oak
(日月) Sent: Monday, January 29, 2024 10:55 PM To: Felix Kuehling ; Christian König ; Daniel Vetter Cc: Brost, Matthew ; thomas.hellst...@linux.intel.com; Welty, Brian ; Ghimiray, Himal Prasad ; dri-devel@lists.freedesktop.org; Gupta, saurabhg ; Danilo Krummrich ; Zeng, Oak ; Bommu, Krishnaiah

RE: Making drm_gpuvm work across gpu devices

2024-01-29 Thread Zeng, Oak
space on modern GPU, why don’t you use different address space on different CPU cores? Regards, Oak From: dri-devel On Behalf Of Christian König Sent: Monday, January 29, 2024 5:20 AM To: Zeng, Oak ; Thomas Hellström ; Daniel Vetter ; Dave Airlie Cc: Brost, Matthew ; Felix Kuehling ; Welty

RE: [PATCH] drm/xe: Fix a build error

2024-01-29 Thread Zeng, Oak
Hi Thomas, My patch was based on drm-tip because I found drm-tip is broken As long as drm-tip can build, I am all good. Thanks, Oak > -Original Message- > From: Thomas Hellström > Sent: Monday, January 29, 2024 3:26 PM > To: Christian König ; Zeng, Oak &

RE: Making drm_gpuvm work across gpu devices

2024-01-29 Thread Zeng, Oak
ce b/t CPU and GPU program. All the codes already merged upstream. See also comments inline to your questions. I will address your other email separately. Regards, Oak From: Christian König Sent: Monday, January 29, 2024 5:11 AM To: Zeng, Oak ; David Airlie Cc: Ghimiray, Himal Prasa

RE: Re: Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-27 Thread Zeng, Oak
Hi Lucas, I encountered this build issue as well. I submitted a fix for drm-tip. Oak > -Original Message- > From: dri-devel On Behalf Of Lucas > De Marchi > Sent: Friday, January 26, 2024 5:23 PM > To: Thomas Hellström > Cc: kher...@redhat.com; michel.daen...@mailbox.org; >

RE: Making drm_gpuvm work across gpu devices

2024-01-26 Thread Zeng, Oak
: Christian König Sent: Friday, January 26, 2024 7:52 AM To: Thomas Hellström ; Daniel Vetter Cc: Brost, Matthew ; Felix Kuehling ; Welty, Brian ; Ghimiray, Himal Prasad ; Zeng, Oak ; Gupta, saurabhg ; Danilo Krummrich ; dri-devel@lists.freedesktop.org; Bommu, Krishnaiah ; Dave Airlie

RE: Making drm_gpuvm work across gpu devices

2024-01-26 Thread Zeng, Oak
> -Original Message- > From: Christian König > Sent: Friday, January 26, 2024 5:10 AM > To: Zeng, Oak ; David Airlie > Cc: Ghimiray, Himal Prasad ; > thomas.hellst...@linux.intel.com; Winiarski, Michal > ; Felix Kuehling ; Welty, > Brian ; S

RE: Making drm_gpuvm work across gpu devices

2024-01-25 Thread Zeng, Oak
> -Original Message- > From: Daniel Vetter > Sent: Thursday, January 25, 2024 1:33 PM > To: Christian König > Cc: Zeng, Oak ; Danilo Krummrich ; > Dave Airlie ; Daniel Vetter ; Felix > Kuehling ; Welty, Brian ; dri- > de...@lists.freedesktop.org; intel...@list

RE: Making drm_gpuvm work across gpu devices

2024-01-25 Thread Zeng, Oak
> -Original Message- > From: Felix Kuehling > Sent: Thursday, January 25, 2024 12:16 PM > To: Zeng, Oak ; Christian König > ; Danilo Krummrich ; Dave > Airlie ; Daniel Vetter ; Shah, Ankur N > ; Winiarski, Michal > Cc: Welty, Brian ; dri-devel@lists.freede

RE: 回复:Making drm_gpuvm work across gpu devices

2024-01-25 Thread Zeng, Oak
Hi Chunming, From: 周春明(日月) Sent: Thursday, January 25, 2024 6:01 AM To: Zeng, Oak ; Christian König ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling ; Shah, Ankur N ; Winiarski, Michal Cc: Brost, Matthew ; thomas.hellst...@linux.intel.com; Welty, Brian ; dri-devel

RE: Making drm_gpuvm work across gpu devices

2024-01-25 Thread Zeng, Oak
Hi Christian, I got a few more questions inline From: Christian König Sent: Wednesday, January 24, 2024 3:33 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Bommu

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
ait for Christian's reply to my previous email. I hope this clarify thing a little. Regards, Oak > -Original Message- > From: dri-devel On Behalf Of David > Airlie > Sent: Wednesday, January 24, 2024 8:25 PM > To: Zeng, Oak > Cc: Ghimiray, Himal Prasad ; > thomas.hel

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
Thank you Felix for sharing. See a few comments inline > -Original Message- > From: Felix Kuehling > Sent: Tuesday, January 23, 2024 3:17 PM > To: Zeng, Oak ; Christian König > ; > Danilo Krummrich ; Dave Airlie ; Daniel > Vetter > Cc: Welty, Brian ; dri-dev

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
4, 2024 3:33 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Bommu, Krishnaiah ; Ghimiray, Himal Prasad ; thomas.hellst...@linux.intel.com; Vishwanathapura, Niranjana ; Br

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
completely from BO. > -Original Message- > From: dri-devel On Behalf Of Zeng, > Oak > Sent: Tuesday, January 23, 2024 10:57 PM > To: Danilo Krummrich ; Christian König > ; Dave Airlie ; Daniel Vetter > ; Felix Kuehling ; Welty, Brian > > Cc: Brost

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
ura, Niranjana > ; Brost, Matthew > ; Gupta, saurabhg > Subject: Re: Making drm_gpuvm work across gpu devices > > Hi Oak, > > On 1/23/24 20:37, Zeng, Oak wrote: > > Thanks Christian. I have some comment inline below. > > > > Danilo, can you also take a loo

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
Thanks Christian. I have some comment inline below. Danilo, can you also take a look and give your feedback? Thanks. > -Original Message- > From: Christian König > Sent: Tuesday, January 23, 2024 6:13 AM > To: Zeng, Oak ; Danilo Krummrich ; > Dave Airlie ; Daniel Vett

Making drm_gpuvm work across gpu devices

2024-01-22 Thread Zeng, Oak
Hi Danilo and all, During the work of Intel's SVM code, we came up the idea of making drm_gpuvm to work across multiple gpu devices. See some discussion here: https://lore.kernel.org/dri-devel/ph7pr11mb70049e7e6a2f40bf6282ecc292...@ph7pr11mb7004.namprd11.prod.outlook.com/ The reason we try to

RE: [PATCH 21/23] drm/xe/svm: GPU page fault support

2024-01-22 Thread Zeng, Oak
> -Original Message- > From: Welty, Brian > Sent: Monday, January 22, 2024 9:06 PM > To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: Bommu, Krishnaiah ; Ghimiray, Himal Prasad > ; thomas.hellst...@linux.intel.com; > Vi

RE: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-30 Thread Zeng, Oak
See inline comments > -Original Message- > From: dri-devel On Behalf Of > zhuweixi > Sent: Thursday, November 30, 2023 5:48 AM > To: Christian König ; Zeng, Oak > ; Christian König ; linux- > m...@kvack.org; linux-ker...@vger.kernel.org; a...@linux-foundation.or

RE: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-29 Thread Zeng, Oak
Hi Weixi, Even though Christian has listed reasons rejecting this proposal (yes they are very reasonable to me), I would open my mind and further explore the possibility here. Since the current GPU driver uses a hmm based implementation (AMD and NV has done this; At Intel we are catching up),

RE: [RFC 03/11] drm: introduce drm evictable LRU

2023-11-03 Thread Zeng, Oak
From: Christian König Sent: Friday, November 3, 2023 5:36 AM To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: thomas.hellst...@linux.intel.com; felix.kuehl...@amd.com; airl...@gmail.com; Welty, Brian Subject: Re: [RFC 03/11] drm: introduce drm evictable LRU

RE: [RFC 03/11] drm: introduce drm evictable LRU

2023-11-02 Thread Zeng, Oak
> -Original Message- > From: Christian König > Sent: Thursday, November 2, 2023 9:24 AM > To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: thomas.hellst...@linux.intel.com; felix.kuehl...@amd.com; > airl...@gmail.com; Welty,

RE: [RFC 02/11] drm: move lru_lock from ttm_device to drm_device

2023-11-02 Thread Zeng, Oak
> -Original Message- > From: Christian König > Sent: Thursday, November 2, 2023 8:53 AM > To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: thomas.hellst...@linux.intel.com; felix.kuehl...@amd.com; > airl...@gmail.com; Welty,

unified LRU for ttm and svm

2023-10-19 Thread Zeng, Oak
Hello all, As a follow up to this thread https://www.spinics.net/lists/dri-devel/msg410740.html, I looked further into the idea of a shared LRU list for both ttm/bo and svm (to achieve a mutual eviction b/t them). I came up a rough design which I think better to align with you before I move

RE: bulk_move in ttm_resource manager

2023-10-04 Thread Zeng, Oak
> -Original Message- > From: Christian König > Sent: Wednesday, October 4, 2023 8:45 AM > To: Thomas Hellström ; Zeng, Oak > > Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: bulk_move in ttm_resource manager > > Am 04.10

bulk_move in ttm_resource manager

2023-10-03 Thread Zeng, Oak
Hi Christian, As a follow up to this thread: https://www.spinics.net/lists/dri-devel/msg410740.html, I started the work of moving the lru out of ttm_resource_manager and make it a common library for both ttm and svm. While look into the details of the bulk_move in ttm resource manager, I

RE: Implement svm without BO concept in xe driver

2023-08-22 Thread Zeng, Oak
> -Original Message- > From: Ruhl, Michael J > Sent: August 22, 2023 7:44 AM > To: Felix Kuehling ; Zeng, Oak ; > Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; > Welty, Brian ; dri-devel@lists.freedesktop.org; > Christian > Köni

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Felix > Kuehling > Sent: August 21, 2023 3:18 PM > To: Zeng, Oak ; Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; > Welty, Brian ; dri-devel@lists.freedesktop.org; > Christia

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
Accidently deleted Brian. Add back. Thanks, Oak > -Original Message- > From: Zeng, Oak > Sent: August 21, 2023 11:07 AM > To: Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; dri-devel@lists.freedesktop.org; intel- > x.

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Dave > Airlie > Sent: August 20, 2023 6:21 PM > To: Zeng, Oak > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; Welty, Brian ; dri- > de...@lists.freedesktop.org; int

RE: Implement svm without BO concept in xe driver

2023-08-18 Thread Zeng, Oak
age- > From: Thomas Hellström > Sent: August 18, 2023 3:36 AM > To: Zeng, Oak ; Dave Airlie ; Felix > Kuehling > Cc: Christian König ; Brost, Matthew > ; maarten.lankho...@linux.intel.com; > Vishwanathapura, Niranjana ; Welty, > Brian ; Philip Yang ; intel- > x...@li

RE: Implement svm without BO concept in xe driver

2023-08-16 Thread Zeng, Oak
> -Original Message- > From: Dave Airlie > Sent: August 16, 2023 6:52 PM > To: Felix Kuehling > Cc: Zeng, Oak ; Christian König > ; Thomas Hellström > ; Brost, Matthew > ; maarten.lankho...@linux.intel.com; > Vishwanathapura, Niranjana ; Welty, > Br

RE: Implement svm without BO concept in xe driver

2023-08-16 Thread Zeng, Oak
with application engineers and they said most applications actually use a mixture of gem_bo create and malloc, so we definitely need to solve this problem. Cheers, Oak > -Original Message- > From: Christian König > Sent: August 16, 2023 2:06 AM > To: Zeng, Oak ; Felix Kuehling ; > T

RE: Implement svm without BO concept in xe driver

2023-08-15 Thread Zeng, Oak
and intel's BO-based/TTM-based vram manager, and the HMM-based vram manager can call into this drm-vram-mgr. Thanks again, Oak > -Original Message- > From: Felix Kuehling > Sent: August 15, 2023 6:17 PM > To: Zeng, Oak ; Thomas Hellström > ; Brost, Matthew > ; Vishwanathapura, N

RE: Implement svm without BO concept in xe driver

2023-08-15 Thread Zeng, Oak
Also + Christian Thanks, Oak From: Intel-xe On Behalf Of Zeng, Oak Sent: August 14, 2023 11:38 PM To: Thomas Hellström ; Brost, Matthew ; Vishwanathapura, Niranjana ; Welty, Brian ; Felix Kuehling ; Philip Yang ; intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject

Implement svm without BO concept in xe driver

2023-08-14 Thread Zeng, Oak
Hi Thomas, Matt and all, This came up when I port i915 svm codes to xe driver. In i915 implementation, we have i915_buddy manage gpu vram and svm codes directly call i915_buddy layer to allocate/free vram. There is no gem_bo/ttm bo concept involved in the svm implementation. In xe driver, we

RE: [RFC PATCH] Documentation/gpu: Add a VM_BIND async draft document.

2023-05-30 Thread Zeng, Oak
Hi Thomas, Thanks for the document. See one question inline. Thanks, Oak > -Original Message- > From: dri-devel On Behalf Of > Thomas Hellström > Sent: May 30, 2023 4:43 AM > To: intel...@lists.freedesktop.org > Cc: Brost, Matthew ; Thomas Hellström > ; linux-ker...@vger.kernel.org;

RE: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-06 Thread Zeng, Oak
Christian said below. Maybe nobody think this is easy? Thanks, Oak > -Original Message- > From: Brost, Matthew > Sent: April 5, 2023 2:53 PM > To: Zeng, Oak > Cc: Christian König ; Vetter, Daniel > ; Thomas Hellström > ; dri-devel@lists.freedesktop.org; intel- > x.

RE: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-05 Thread Zeng, Oak
nal Message- > From: Christian König > Sent: April 5, 2023 3:30 AM > To: Brost, Matthew ; Zeng, Oak > > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; > robdcl...@chromium.org; thomas.hellst...@linux.intel.com; airl...@linux.ie; > l...@asahilina.net; boris

RE: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-04 Thread Zeng, Oak
Hi Matt, Thomas, Some very bold out of box thinking in this area: 1. so you want to use drm scheduler and dma-fence for long running workload. Why you want to do this in the first place? What is the benefit? Drm scheduler is pretty much a software scheduler. Modern gpu has scheduler built at

RE: [Intel-gfx] [RFC v4 06/14] drm/i915/vm_bind: Handle persistent vmas

2022-09-26 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of > Niranjana > Vishwanathapura > Sent: September 21, 2022 3:10 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Hellstrom, Thomas > ; Auld, Matthew ; Vetter, > Daniel ;

RE: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-05 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: C, Ramalingam > Sent: July 5, 2022 5:20 AM > To: Zeng, Oak > Cc: Vishwanathapura, Niranjana ; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel ; christian.koe...@amd.com; Hellstrom, >

RE: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-04 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Intel-gfx On Behalf Of > Niranjana Vishwanathapura > Sent: July 1, 2022 6:51 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Hellstrom, Thomas > ; Auld, Matthew ; > Vetter, Daniel ;

RE: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-28 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Tvrtko Ursulin > Sent: June 28, 2022 4:58 AM > To: Zeng, Oak ; Landwerlin, Lionel G > ; Vishwanathapura, Niranjana > > Cc: Zanoni, Paulo R ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Hell

RE: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-27 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Tvrtko Ursulin > Sent: June 27, 2022 4:30 AM > To: Zeng, Oak ; Landwerlin, Lionel G > ; Vishwanathapura, Niranjana > > Cc: Zanoni, Paulo R ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Hell

RE: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-24 Thread Zeng, Oak
nvalidate all the VA ranges - ugly program. Thanks, Oak > -Original Message- > From: Tvrtko Ursulin > Sent: June 24, 2022 4:32 AM > To: Zeng, Oak ; Landwerlin, Lionel G > ; Vishwanathapura, Niranjana > > Cc: Zanoni, Paulo R ; intel- > g...@lists.freedesktop.org

RE: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: June 23, 2022 7:06 AM > To: Landwerlin, Lionel G ; Vishwanathapura, > Niranjana > Cc: Zanoni, Paulo R ; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; Hellstrom, Thomas >

RE: [PATCH v2 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-20 Thread Zeng, Oak
christian.koe...@amd.com; Brost, Matthew ; > Ursulin, Tvrtko ; Auld, Matthew > ; Landwerlin, Lionel G > ; Zanoni, Paulo R > ; Zeng, Oak > Subject: [PATCH v2 3/3] drm/doc/rfc: VM_BIND uapi definition > > VM_BIND and related uapi definitions > > v2: Reduce the scope to

RE: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: dri-devel On Behalf Of > Zeng, Oak > Sent: June 14, 2022 5:13 PM > To: Vishwanathapura, Niranjana ; > Landwerlin, Lionel G > Cc: Intel GFX ; Wilson, Chris P > ; Hellstrom, Thomas > ; Maling list - DRI developers

RE: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Vishwanathapura, Niranjana > Sent: June 14, 2022 1:02 PM > To: Landwerlin, Lionel G > Cc: Zeng, Oak ; Intel GFX g...@lists.freedesktop.org>; Maling list - DRI developers de...@lists.freedesktop.org>; Hellstrom, Thoma

RE: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-13 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of > Niranjana > Vishwanathapura > Sent: June 10, 2022 1:43 PM > To: Landwerlin, Lionel G > Cc: Intel GFX ; Maling list - DRI developers > de...@lists.freedesktop.org>; Hellstrom, Thomas ; > Wilson, Chris P ; Vetter,

RE: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-06 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Vishwanathapura, Niranjana > Sent: June 2, 2022 4:49 PM > To: Zeng, Oak > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel ; Brost, Matthew ; > Hellstrom, Thomas ; ja...@jlekstrand.n

RE: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-01 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: dri-devel On Behalf Of > Niranjana Vishwanathapura > Sent: May 17, 2022 2:32 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, > Daniel > Cc: Brost, Matthew ; Hellstrom, Thomas > ; ja...@jlekstrand.net;

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-05 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: January 5, 2022 8:44 AM > To: Zeng, Oak ; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; Bloomfield, Jon > ; Vetter, Daniel ; Wilson, > Chris P > Cc: Auld, Matthew &

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-04 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: January 4, 2022 3:29 AM > To: Zeng, Oak ; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org > Cc: Auld, Matthew > Subject: Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma re

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: January 3, 2022 1:58 PM > To: Zeng, Oak ; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org > Cc: Auld, Matthew > Subject: Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma re

RE: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-03 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Thomas > Hellström > Sent: January 3, 2022 7:00 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Thomas Hellström ; Auld, Matthew > > Subject: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the

RE: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend

2021-10-05 Thread Zeng, Oak
Thanks for explanation. This patch is Acked-by: Oak Zeng Regards, Oak > -Original Message- > From: Auld, Matthew > Sent: October 5, 2021 1:07 PM > To: Zeng, Oak ; Thomas Hellström > ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Christian

RE: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend

2021-10-05 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: October 5, 2021 9:48 AM > To: Zeng, Oak ; Auld, Matthew > ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Christian König > > Subject: Re: [Intel-gfx] [PATCH v5 09/

RE: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend

2021-10-04 Thread Zeng, Oak
Hi Matthew/Thomas, See one question inline Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Matthew Auld Sent: September 27, 2021 7:41 AM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Thomas Hellström ; Christian König Subject: [Intel-gfx]

Re: [PATCH v6 05/13] drm/amdkfd: generic type as sys mem on migration to ram

2021-08-16 Thread Zeng, Oak
Regards, Oak On 2021-08-16, 3:53 PM, "amd-gfx on behalf of Sierra Guiza, Alejandro (Alex)" wrote: On 8/15/2021 10:38 AM, Christoph Hellwig wrote: > On Fri, Aug 13, 2021 at 01:31:42AM -0500, Alex Sierra wrote: >> migrate.vma = vma; >> migrate.start =

Re: [PATCH v4 06/13] include/linux/mm.h: helpers to check zone device generic type

2021-07-19 Thread Zeng, Oak
Regards, Oak On 2021-07-17, 3:22 PM, "amd-gfx on behalf of Alex Sierra" wrote: Two helpers added. One checks if zone device page is generic type. The other if page is either private or generic type. Signed-off-by: Alex Sierra --- include/linux/mm.h | 8

Re: [PATCH v2 00/10] Implement multi-GPU DMA mappings for KFD

2021-04-27 Thread Zeng, Oak
This series is Acked-by: Oak Zeng Regards, Oak On 2021-04-21, 9:31 PM, "dri-devel on behalf of Felix Kuehling" wrote: This patch series fixes DMA-mappings of system memory (GTT and userptr) for KFD running on multi-GPU systems with IOMMU enabled. One SG-BO per GPU is

Re: [PATCH v2 08/10] drm/amdgpu: Add DMA mapping of GTT BOs

2021-04-27 Thread Zeng, Oak
Regards, Oak On 2021-04-26, 11:56 PM, "Kuehling, Felix" wrote: Am 2021-04-26 um 8:35 p.m. schrieb Zeng, Oak: > Regards, > Oak > > > > On 2021-04-21, 9:31 PM, "amd-gfx on behalf of Felix Kuehling" wrote: >

Re: [PATCH v2 08/10] drm/amdgpu: Add DMA mapping of GTT BOs

2021-04-26 Thread Zeng, Oak
Regards, Oak On 2021-04-21, 9:31 PM, "amd-gfx on behalf of Felix Kuehling" wrote: Use DMABufs with dynamic attachment to DMA-map GTT BOs on other GPUs. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 2 +

Re: [PATCH v2 06/10] drm/amdgpu: DMA map/unmap when updating GPU mappings

2021-04-26 Thread Zeng, Oak
Regards, Oak On 2021-04-21, 9:31 PM, "dri-devel on behalf of Felix Kuehling" wrote: DMA map kfd_mem_attachments in update_gpuvm_pte. This function is called with the BO and page tables reserved, so we can safely update the DMA mapping. DMA unmap when a BO is unmapped

Re: [PATCH v2 05/10] drm/amdgpu: Add multi-GPU DMA mapping helpers

2021-04-26 Thread Zeng, Oak
As I understand it, when one GPU map another GPU's vram, this vram should also be mapped in iommu page table. Also normal GTT memory (versus userptr) also need to be mapped in iommu. But don't see this code below. I only see you map userptr in iommu. Maybe you map them in iommu not during

Re: [PATCH v2 04/10] drm/amdgpu: Simplify AQL queue mapping

2021-04-22 Thread Zeng, Oak
Regards, Oak On 2021-04-21, 9:31 PM, "amd-gfx on behalf of Felix Kuehling" wrote: Do AQL queue double-mapping with a single attach call. That will make it easier to create per-GPU BOs later, to be shared between the two BO VA mappings on the same GPU. Freeing the

Re: [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static

2021-03-12 Thread Zeng, Oak
[AMD Official Use Only - Internal Distribution Only] Thank you Joarder for the fix. But this has already been fixed in our Alex's drm-next branch. Regards, Oak On 2021-03-12, 5:19 PM, "Souptick Joarder" wrote: Kernel test robot throws below warning ->

RE: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

2021-03-03 Thread Zeng, Oak
: Christian König Sent: Wednesday, March 3, 2021 5:46 AM To: Zeng, Oak ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Daniel Vetter ; Dave Airlie ; Thomas Hellström (Intel) ; dan.j.willi...@intel.com Cc: kbuild-...@lists.01.org; Kuehling, Felix ; Kasiviswanathan, Harish ; Deucher

RE: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

2021-03-02 Thread Zeng, Oak
: Zeng, Oak ; kbuild-...@lists.01.org; Kuehling, Felix ; Kasiviswanathan, Harish ; Deucher, Alexander ; Huang, JinHuiEric ; Koenig, Christian Subject: Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting Hi guys, adding the usual suspects direct. Does anybody of hand know

RE: [PATCH] drm/ttm: fix ttm_bo_unreserve

2019-06-05 Thread Zeng, Oak
Regards, Oak -Original Message- From: Christian König Sent: Wednesday, June 5, 2019 7:25 AM To: Zeng, Oak ; Kuehling, Felix ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Subject: Re: [PATCH] drm/ttm: fix ttm_bo_unreserve Am 04.06.19 um 21:03 schrieb Zeng, Oak

RE: [PATCH] drm/ttm: fix ttm_bo_unreserve

2019-06-04 Thread Zeng, Oak
Regards, Oak -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Tuesday, June 4, 2019 2:47 PM To: Christian König ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Subject: Re: [PATCH] drm/ttm: fix ttm_bo_unreserve On 2019-06-04 11:23, Christian König