[PATCH_V2 5/5] drm: bridge/dw_hdmi: Add jz4780 support

2015-03-09 Thread Zubair Lutfullah Kakakhel
Ingenic JZ4780 hdmi is compatible with dw_hdmi. Signed-off-by: Zubair Lutfullah Kakakhel --- V1 -> V2 Fixed license macro Rebased to 4.0-rc3 --- drivers/gpu/drm/jz4780/Kconfig | 10 ++ drivers/gpu/drm/jz4780/Makefile | 1 + drivers/gpu/drm/jz4780/dw_hdmi-jz4780.c |

[PATCH_V2 4/5] dt-bindings: video: Add jz4780-hdmi binding

2015-03-09 Thread Zubair Lutfullah Kakakhel
Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Signed-off-by: Zubair Lutfullah Kakakhel --- V1 -> V2 Rebased to 4.0-rc3 --- .../bindings/video/ingenic-jz4780-hdmi.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentat

[PATCH_V2 3/5] drm: jz4780: Add DRM driver for Ingenic JZ4780

2015-03-09 Thread Zubair Lutfullah Kakakhel
Add drm driver for the Ingenic JZ4780 SoC. Signed-off-by: Zubair Lutfullah Kakakhel --- V1 -> V2 Fixed Module_License macro Fix in makefile and a #include drm_flip_work Rebased to 4.0-rc3 Removed you should have received a copy of license etc. --- drivers/gpu/drm/Kconfig |

[PATCH_V2 2/5] dt-bindings: video: Add jz4780-lcd binding

2015-03-09 Thread Zubair Lutfullah Kakakhel
Add DT bindings for the LCD controller on the jz4780 SoC Signed-off-by: Zubair Lutfullah Kakakhel --- V1 -> V2 Rebased to 4.0-rc3 --- .../bindings/video/ingenic-jz4780-lcd.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicet

[PATCH_V2 1/5] dt-bindings: video: Add Ingenic jz4780-drm binding

2015-03-09 Thread Zubair Lutfullah Kakakhel
This patch adds a display susbsytem for the Ingenic JZ4780 SoC Signed-off-by: Zubair Lutfullah Kakakhel --- V1 -> V2 Rebased to 4.0-rc3 --- .../devicetree/bindings/video/ingenic-jz4780-drm.txt| 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentat

[PATCH_V2 0/5] drm: jz4780: Add drm driver for Ingenic JZ4780

2015-03-09 Thread Zubair Lutfullah Kakakhel
ork Rebased to v4.0-rc3 Feedback welcome Thank-you ZubairLK Zubair Lutfullah Kakakhel (5): dt-bindings: video: Add Ingenic jz4780-drm binding dt-bindings: video: Add jz4780-lcd binding drm: jz4780: Add DRM driver for Ingenic JZ4780 dt-bindings: video: Add jz4780-hdmi binding drm: bridge/dw_h

[PATCH 5/5] drm: bridge/dw_hdmi: add jz4780 support

2015-03-04 Thread Zubair Lutfullah Kakakhel
Ingenic JZ4780 hdmi is compatible with dw_hdmi. Signed-off-by: Zubair Lutfullah Kakakhel --- drivers/gpu/drm/jz4780/Kconfig | 10 ++ drivers/gpu/drm/jz4780/Makefile | 1 + drivers/gpu/drm/jz4780/dw_hdmi-jz4780.c | 234 include/drm/bridge

[PATCH 4/5] dt-bindings: video: Add jz4780-hdmi binding

2015-03-04 Thread Zubair Lutfullah Kakakhel
Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Signed-off-by: Zubair Lutfullah Kakakhel --- .../bindings/video/ingenic-jz4780-hdmi.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/ingenic

[PATCH 3/5] drm: jz4780: Add DRM driver for Ingenic JZ4780

2015-03-04 Thread Zubair Lutfullah Kakakhel
Add drm driver for the Ingenic JZ4780 SoC. Signed-off-by: Zubair Lutfullah Kakakhel --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/jz4780/Kconfig | 12 + drivers/gpu/drm/jz4780/Makefile | 10 + drivers/gpu/drm/jz4780

[PATCH 2/5] dt-bindings: video: Add jz4780-lcd binding

2015-03-04 Thread Zubair Lutfullah Kakakhel
Add DT bindings for the LCD controller on the jz4780 SoC Signed-off-by: Zubair Lutfullah Kakakhel --- .../bindings/video/ingenic-jz4780-lcd.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/ingenic-jz4780

[PATCH 1/5] dt-bindings: video: Add Ingenic jz4780-drm binding

2015-03-04 Thread Zubair Lutfullah Kakakhel
This patch adds a display susbsytem for the Ingenic JZ4780 SoC Signed-off-by: Zubair Lutfullah Kakakhel --- .../devicetree/bindings/video/ingenic-jz4780-drm.txt| 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/ingenic

[PATCH 0/5] drm: dt: jz4780: Add Ingenic JZ4780 driver

2015-03-04 Thread Zubair Lutfullah Kakakhel
Hi, Here we have 5 patches that add a DRM driver for the LCD controller in the Ingenic JZ4780 SoC. The HDMI Controller in the JZ4780 is by Synopsys and the dw_hdmi driver is used. These patches are based on 4.0-rc2 Feedback welcome Thank-you ZubairLK Zubair Lutfullah Kakakhel (5): dt

[PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-24 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 24/11/14 14:17, Andy Yan wrote: > Hi ZubairLK, Russel King, Greg Kroah-Hartman , Philipp Zabel and Daniel: >Do you have any further opinions or suggestions about the > the current patch set? I have reviewed the patches as much as I could. They look good to me. But I don't know

[PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 11:13, Andy Yan wrote: > > On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: >> >> On 14/11/14 10:37, Andy Yan wrote: >>> On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: >>>> Hi Andy >>>> >>>>

[PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 11:08, Andy Yan wrote: > > On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: >> >> On 14/11/14 10:53, Andy Yan wrote: >>> Hi ZubairLK: >>> Thanks for your review. >>> On 2014年11月14日 18:19, Zubair Lutfullah Kaka

[PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 10:53, Andy Yan wrote: > Hi ZubairLK: >Thanks for your review. > On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: >> Hi Andy, >> >> Nice work on this patch series. Its getting better and better :). >> >> On 14/11/14 03:27, An

[PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
On 14/11/14 10:37, Andy Yan wrote: > > On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: >> Hi Andy >> >> On 14/11/14 03:31, Andy Yan wrote: >>> Rockchip RK3288 hdmi is compatible with dw_hdmi >>> >>> Signed-off-by: Andy Yan >>

[PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Zubair Lutfullah Kakakhel
Hi Andy On 14/11/14 03:31, Andy Yan wrote: > Rockchip RK3288 hdmi is compatible with dw_hdmi > > Signed-off-by: Andy Yan > > --- > > Changes in v10: > - add more display mode support mpll configuration for rk3288 > > Changes in v9: > - move some phy configuration to platform driver > >

[PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Zubair Lutfullah Kakakhel
Hi Andy, Nice work on this patch series. Its getting better and better :). On 14/11/14 03:27, Andy Yan wrote: > hdmi phy clock symbol and transmission termination value > can adjust platform specific to get the best SI ^Is this signal integrity?

[PATCH v9 9/9] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-13 Thread Zubair Lutfullah Kakakhel
On 13/11/14 12:57, Andy Yan wrote: > rk3288 hdmi is compatible with Designware hdmi > > this patch is depend on patch by Mark Yao Add drm > driver for Rockchip Socs > > see https://lkml.org/lkml/2014/10/8/201 > > Signed-off-by: Andy Yan > Signed-off-by: Yakir Yang > > --- > > Changes in

[PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
On 11/11/14 14:46, Andy Yan wrote: > > On 2014年11月11日 22:20, Zubair Lutfullah Kakakhel wrote: >> Hi Andy, >> >> This patch adds the reg-io-width binding. >> >> Hence the binding patch should come before it. >> >do you mean that I should

[PATCH v7 7/7] dt-bindings: add document for dw-hdmi

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, Some minor comments inline. On 11/11/14 12:54, Andy Yan wrote: > Signed-off-by: Andy Yan > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/drm/bridge/dw-hdmi.txt

[PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
On 11/11/14 14:23, Lucas Stach wrote: > Am Dienstag, den 11.11.2014, 14:20 + schrieb Zubair Lutfullah > Kakakhel: >> Hi Andy, >> >> This patch adds the reg-io-width binding. >> >> Hence the binding patch should come before it. >> >> >&

[PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 11/11/14 12:54, Andy Yan wrote: > From: Yakir Yang > > keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Is there a reason for this separation? Keeping encoder in platform files? If yes, then the commit message should explain that. > > Signed-off-by: Andy

[PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, This patch adds the reg-io-width binding. Hence the binding patch should come before it. On 11/11/14 12:53, Andy Yan wrote: > On rockchip rk3288, only word(32-bit) accesses are > permitted for hdmi registers. Byte width accesses (writeb, > readb) generate an imprecise external abort.

[PATCH v7 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-11 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 11/11/14 12:53, Andy Yan wrote: > the original imx hdmi driver is under staging/imx-drm, > which depends on imx-drm, so move the imx hdmi drvier out Spelling mistake. ^'driver' > to drm/bridge and rename imx-hdmi to dw-hdmi

[PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
Hi Andy, A few comments inline. On 08/11/14 05:28, Andy Yan wrote: > imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they > also have some lightly difference, such as phy pll configuration, > register width, 4K support, clk

[PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
On 10/11/14 09:44, Andy Yan wrote: > Hi ZubairLK > On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: >> Nice work. >> >> This patch should move the binding from >> >> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt >> to the locatio

[PATCH V5 3/7] dw-hdmi: make checkpatch happy

2014-11-10 Thread Zubair Lutfullah Kakakhel
Hi Andy, In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c Have these errors come during the previous 2 patches. If yes, then these changes need to be squashed into the previous patches. No patch should add a checkpatch error and then fix it in a later patch. Regards ZubairLK On

[PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Zubair Lutfullah Kakakhel
Nice work. This patch should move the binding from Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt to the location instead of making a new file and leaving the old one in place. And use git format-patch -M to highlight any changes. Regards ZubairLK On 08/11/14 05:32, Andy Yan

[PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Zubair Lutfullah Kakakhel
This one patch does too much to be reviewed easily. One patch is supposed to modify/add one thing at a time in the kernel. Separating platform specific code from imx-drm/imx-hdmi is one thing. Adding support for multi-byte register access is something different. i.e. Something like. 1/3 split

[PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-04 Thread Zubair Lutfullah Kakakhel
Hi Andy, On 04/11/14 13:33, Andy Yan wrote: > imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they > also have some lightly difference, such as phy pll configuration, > register width(imx hdmi register is one byte, but rk3288 is 4

[PATCH 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-04 Thread Zubair Lutfullah Kakakhel
Hi, On 04/11/14 13:39, Andy Yan wrote: > From: Andy yan > > the original imx hdmi driver is under staging/imx-drm, > which depends on imx-drm, so move the imx hdmi drvier out > to drm/bridge and rename imx-hdmi to dw-hdmi > > Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d > --- >

[PATCH 00/72] staging imx-drm new features and fixes

2014-11-03 Thread Zubair Lutfullah Kakakhel
Steve Longerbeam gmail.com> writes: > > Hi, this affects only Freescale imx IPU and imx-drm staging drivers, > except for two patches that affect drm core (patch 53 and 63, see below). > > New features for imx-drm staging driver: > > - Support for multi-display (HDMI and LVDS). > - Support