Re: [PATCH] drm/amdgpu: remove "num_pages" local variable in amdgpu_gtt_mgr_new

2024-04-08 Thread broler Liew
sorry, this patch has format problem. abandon. I send another email use qq mail instead. > > amdgpu_gtt_mgr_new and ttm_range_man_alloc share similar logic, but > "num_pages" in amdgpu_gtt_mgr_new is defined as local variable which > is calculate directly in ttm_range_man_alloc. > >

[PATCH] drm/amdgpu: remove "num_pages" local variable in amdgpu_gtt_mgr_new

2024-04-08 Thread broler Liew
amdgpu_gtt_mgr_new and ttm_range_man_alloc share similar logic, but "num_pages" in amdgpu_gtt_mgr_new is defined as local variable which is calculate directly in ttm_range_man_alloc. Signed-off-by: brolerliew --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread broler Liew
It's very nice of you-all to finger it out that it may crash when it is the last entity in the list. Absolutely I made a mistake about that. But I still cannot understand why we need to restart the selection from the list head when the current entity is removed from rq. In