If you're going to update the other patches to use IS_ERR_OR_NULL() please do so
here too. You can keep my R-b for that change.
Thanks for taking time to review the patch.
I have update the patch set and add this change to v5.
On 2023/7/21 18:24, Liviu Dudau wrote:
Hi Gaosheng,
On Fri, Jul
Thanks for taking time to review this patch.
Maybe we can submit another separate patch to fix ERR_CAST(st), because I'm not
sure which commit should be used as a fixes-tag.
Also, Maybe we should fix ERR_CAST(st) in
komeda_pipeline_get_state_and_set_crtc()
and
196 if (ret)
197 goto err_sysfs_dmabuf;
198
199 return 0;
200
201 err_sysfs_dmabuf:
202 kobject_put(_entry->kobj);
203 dmabuf->sysfs_entry = NULL;
204 return ret;
205 }
Did I miss something?
Thanks.
On 2022/11/24 20:37, Christian König wrote:
Some tips:
Before we call the dma_buf_stats_setup(), we have to finish creating the
file,
otherwise dma_buf_stats_setup() will return -EINVAL, maybe we need to think
about
this when making a new patch.
Hope these tips are useful, thanks!
On 2022/11/24 13:56, Charan Teja Kalla wrote:
Thanks T.J and Christian, thanks everyone for taking time to review this patch.
Charan, actually I don't have a good patch to to fix it, if you can submit
a new patch to solve it, please feel free to do it.
By the way, I'd appreciate it if you could send to me the new patch when you
submit it.
NAK. This path should be returned if it is NON-NULL, otherwise we defer
to of_icc_get() on the parent device. See the code-comment below.
Thanks for taking time to review this patch, how do you think of the following
changes:
diff --git a/drivers/gpu/drm/msm/msm_io_utils.c
