Re: [PATCH v6 5/5] drm/rockchip: support dp training outside dp firmware

Hi Enric, On Wednesday, May 23, 2018 01:06 AM, Enric Balletbo Serra wrote: Lin, 2018-05-22 9:41 GMT+02:00 Enric Balletbo Serra <eballe...@gmail.com>: Hi Lin 2018-05-22 3:08 GMT+02:00 hl <h...@rock-chips.com>: Hi Enric, On Monday, May 21, 2018 11:22 PM, Enric Balletbo Serr

Re: [PATCH v6 5/5] drm/rockchip: support dp training outside dp firmware

Hi Enric, On Monday, May 21, 2018 11:22 PM, Enric Balletbo Serra wrote: Hi Lin, 2018-05-21 11:37 GMT+02:00 Lin Huang : DP firmware uses fixed phy config values to do training, but some boards need to adjust these values to fit for their unique hardware design. So get

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

+ Kishon On Thursday, May 17, 2018 09:51 PM, Sean Paul wrote: On Thu, May 17, 2018 at 05:18:00PM +0800, Lin Huang wrote: DP firmware uses fixed phy config values to do training, but some boards need to adjust these values to fit for their unique hardware design. So get phy config values from

Re: [PATCH 4/4] drm/rockchip: support dp training outside dp firmware

On Monday, May 07, 2018 07:29 PM, Enric Balletbo Serra wrote: Hi Lin, Thanks for the patch. 2018-05-04 10:08 GMT+02:00 Lin Huang : DP firware use fix phy config value to do training, but some s/fiware/firmware/ board need to adjust these value to fit for their

Re: [PATCH 1/4] drm/rockchip: add transfer function for cdn-dp

Hi Enric, On Monday, May 07, 2018 07:27 PM, Enric Balletbo Serra wrote: Hi Lin, I am interested in these patches, could you cc me on newer versions? Thanks. Some comments below. Sure, will cc to you next version. 2018-05-04 10:08 GMT+02:00 Lin Huang : From: Chris

Re: [PATCH 2/4] phy: rockchip-typec: support variable phy config value

On Monday, May 07, 2018 09:59 PM, Enric Balletbo Serra wrote: Hi Lin, Thanks for the patch, apart from the new build warnings introduced some more comments below. 2018-05-04 10:08 GMT+02:00 Lin Huang : the phy config values used to fix in dp firmware, but some boards

Re: [PATCH v4 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

Hi On Tuesday, March 20, 2018 06:20 PM, Emil Velikov wrote: On 20 March 2018 at 06:24, hl <h...@rock-chips.com> wrote: Hi Emil, On Monday, March 19, 2018 09:09 PM, Emil Velikov wrote: On 15 March 2018 at 02:35, hl <h...@rock-chips.com> wrote: Hi Emil, On Wednesday, March

Re: [PATCH v4 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

Hi Emil, On Monday, March 19, 2018 09:09 PM, Emil Velikov wrote: On 15 March 2018 at 02:35, hl <h...@rock-chips.com> wrote: Hi Emil, On Wednesday, March 14, 2018 08:02 PM, Emil Velikov wrote: Hi Lin, On 14 March 2018 at 09:12, Lin Huang <h...@rock-chips.com> wrote: From:

Re: [PATCH v4 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

Hi Emil, On Wednesday, March 14, 2018 08:02 PM, Emil Velikov wrote: Hi Lin, On 14 March 2018 at 09:12, Lin Huang wrote: From: huang lin Refactor Innolux P079ZCA panel driver, let it support multi panel. Change-Id:

Re: [RESEND PATCH v3 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

Hi Thierry Reding, On Monday, March 12, 2018 05:21 PM, Thierry Reding wrote: On Mon, Dec 04, 2017 at 03:17:48PM +0800, Lin Huang wrote: Refactor Innolux P079ZCA panel driver, let it support multi panel. Signed-off-by: Lin Huang --- Changes in v2: - Change regulator

Re: [PATCH] drm/panel: support Innolux P097PFG panel

Hi Emil, On Saturday, December 02, 2017 01:55 AM, Emil Velikov wrote: On 30 November 2017 at 06:13, Lin Huang wrote: Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel, it refactor Innolux P079ZCA panel driver, let it support multi panel, and add support P097PFG panel

Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel

Hi On Friday, December 01, 2017 10:54 AM, Brian Norris wrote: One more comment: On Thu, Nov 30, 2017 at 02:14:40PM +0800, Lin Huang wrote: Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel, it refactor Innolux P079ZCA panel driver, let it support multi panel, and add support P097PFG panel

Re: [PATCH 1/7] drm/rockchip/dsi: correct Feedback divider setting

On Wednesday, September 20, 2017 06:08 PM, John Keeping wrote: On Tue, Sep 19, 2017 at 01:27:40PM -0700, Sean Paul wrote: On Tue, Sep 19, 2017 at 11:19:01AM -0700, Brian Norris wrote: Hi Sean, On Tue, Sep 19, 2017 at 11:00:25AM -0700, Sean Paul wrote: On Mon, Sep 18, 2017 at 05:05:33PM

[PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

Hi On 2016年09月07日 02:55, Sean Paul wrote: > On Tue, Sep 6, 2016 at 2:15 PM, hl wrote: >> Hi Sean, >> >> >> On 2016年09月07日 01:18, Sean Paul wrote: >>> On Mon, Sep 5, 2016 at 1:06 AM, Lin Huang wrote: >>>> when in ddr frequency scalin

[PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

Hi Sean, On 2016年09月07日 01:18, Sean Paul wrote: > On Mon, Sep 5, 2016 at 1:06 AM, Lin Huang wrote: >> when in ddr frequency scaling process, vop can not do enable or >> disable operation, since in dcf we check vop clock to see whether >> vop work. If vop work, dcf do ddr frequency scaling

[PATCH v6 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

Hi Chanwoo Choi, On 2016年08月23日 13:05, Chanwoo Choi wrote: > Hi Lin, > > On 2016년 08월 22일 07:16, hl wrote: >> Hi Chanwoo Choi, >> >> On 2016年08月17日 12:50, Chanwoo Choi wrote: >>> Hi Lin, >>> >>> On 2016년 08

[PATCH v6 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

Hi Chanwoo Choi, On 2016年08月17日 12:50, Chanwoo Choi wrote: > Hi Lin, > > On 2016년 08월 17일 07:36, Lin Huang wrote: >> This patch adds the documentation for rockchip rk3399 dmc driver. >> >> Signed-off-by: Lin Huang >> --- >> Changes in v6: >> -Add more detail in Documentation >> >>

[PATCH v6 8/8] drm/rockchip: Add dmc notifier in vop driver

Hi, On 2016年08月18日 02:14, Sean Paul wrote: > On Tue, Aug 16, 2016 at 3:36 PM, Lin Huang wrote: >> when in ddr frequency scaling process, vop can not do >> enable or disable operation, since dcf will base on vop vblank >> time to do frequency scaling and need to get vop irq if there >>

[PATCH v4 1/7] clk: rockchip: add clock flag parameter when register pll

Hi Heiko, On 2016年08月05日 06:37, Heiko Stuebner wrote: > Am Freitag, 29. Juli 2016, 15:56:55 schrieb Lin Huang: >> From: Heiko Stübner >> >> add clock flag parameter so we can pass specific clock flag >> (like CLK_GET_RATE_NOCACHE etc..)to pll driver. >> >> Signed-off-by: Heiko Stübner

[PATCH v4 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Chanwoo Choi, On 2016年08月02日 12:21, Chanwoo Choi wrote: > Hi Lin, > > On the next version, I'd like you to add the 'linux-pm at vger.kernel.org' > because devfreq is a subsystem of power management. Sure, will do it next version. > On 2016년 08월 02일 10:03, hl wrote

[PATCH v4 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Chanwoo Choi, Thanks for reviewing so carefully. And i have some question: On 2016年08月01日 18:28, Chanwoo Choi wrote: > Hi Lin, > > As I mentioned on patch5, you better to make the documentation as following: > - Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt > And, I add

[PATCH v4 5/7] PM / devfreq: event: support rockchip dfi controller

Hi Chanwoo Choi, On 2016年08月01日 16:08, Chanwoo Choi wrote: > Hi Lin, > > I add the one minor comment for full name of 'DRI'. > > On 2016년 08월 01일 16:41, Chanwoo Choi wrote: >> Hi Lin, >> >> Because you remove the 'RFC' prefix on patch title, >> I think that you better to make the

[PATCH v4 0/7] rk3399 support ddr frequency scaling

Hi Chanwoo Choi, Ah, i am base on https://chromium.googlesource.com/chromiumos/third_party/kernel/v4.4, and forget to rebase on https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git, i will fix it in next version. I am sorry about that. And can you help to review the devfreq

[PATCH v3 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Chanwoo Choi, On 2016年07月25日 14:01, Chanwoo Choi wrote: > Hi Lin, > > I'm glad to support the for dmc ddr clock scaling with devfreq/devfreq-event. > > But, I think that you have to use the standard interface. > As I already mentioned[1] on previous mail, devfreq fwk support > the

[PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service

Hi Heiko, On 2016年07月23日 04:50, Heiko Stübner wrote: > Hi again, > > one bigger thing I noticed only now. > > Am Freitag, 22. Juli 2016, 17:07:14 schrieben Sie: >> diff --git a/drivers/firmware/rockchip_sip.c >> b/drivers/firmware/rockchip_sip.c new file mode 100644 >> index

[PATCH v3 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Paul, On 2016年07月23日 04:24, Paul Gortmaker wrote: > On Fri, Jul 22, 2016 at 5:07 AM, Lin Huang wrote: >> base on dfi result, we do ddr frequency scaling, register >> dmc driver to devfreq framework, and use simple-ondemand >> policy. >> >> Signed-off-by: Lin Huang >> --- >> Changes in

[RFC PATCH v2 6/6] drm/rockchip: Add dmc notifier in vop driver

Hi Chanwoo Choi, On 2016年06月22日 15:11, Chanwoo Choi wrote: > Hi, > > On 2016년 06월 06일 19:13, Lin Huang wrote: >> when in ddr frequency scaling process, vop can not do >> enable or disable operate, since dcf will base on vop vblank >> time to do frequency scaling and need to get vop

[RFC PATCH v1 4/6] PM / devfreq: event: support rockchip dfi controller

Hi Thierry, On 2016年06月04日 00:54, Thierry Reding wrote: > On Fri, Jun 03, 2016 at 05:55:17PM +0800, Lin Huang wrote: > [...] >> +ret = clk_prepare_enable(data->clk); >> +if (ret) { >> +dev_err(>dev, "failed to enable clk: %d\n", ret); >> +

[RFC PATCH v1 4/6] PM / devfreq: event: support rockchip dfi controller

On 2016年06月03日 18:26, Chanwoo Choi wrote: > Hi Lin, > > I add the some comment on below. If you modify it, > You can add my acked-by tag. Looks good to me. Thanks for you reviewing, i will update the code folloiwing your comment. > Acked-by: Chanwoo Choi > > Also, I'd like you to add me

[RFC PATCH v1 3/6] clk: rockchip: rk3399: add ddrc clock support

Hi Heiko, On 2016年06月03日 20:56, Heiko Stübner wrote: > Am Freitag, 3. Juni 2016, 17:55:16 schrieb Lin Huang: >> add ddrc clock setting, so we can do ddr frequency >> scaling on rk3399 platform in future. >> >> Signed-off-by: Lin Huang >> --- >> Changes in v1: >> - remove ddrc source

[RFC PATCH v1 1/6] rockchip: rockchip: add new clock-type for the ddrclk

Hi Heiko, On 2016年06月03日 20:51, Heiko Stübner wrote: > Am Freitag, 3. Juni 2016, 17:55:14 schrieb Lin Huang: >> On new rockchip platform(rk3399 etc), there have dcf controller to >> do ddr frequency scaling, and this controller will implement in >> arm-trust-firmware. We add a special

[RFC PATCH v1 1/6] rockchip: rockchip: add new clock-type for the ddrclk

Hi Heiko, On 2016年06月03日 20:51, Heiko Stübner wrote: > Am Freitag, 3. Juni 2016, 17:55:14 schrieb Lin Huang: >> On new rockchip platform(rk3399 etc), there have dcf controller to >> do ddr frequency scaling, and this controller will implement in >> arm-trust-firmware. We add a special

[RFC PATCH v1 1/6] rockchip: rockchip: add new clock-type for the ddrclk

Hi Shawn, On 2016年06月03日 20:29, Shawn Lin wrote: > Hi Lin, > > It looks good with only a few minor comments. > > On 2016/6/3 17:55, Lin Huang wrote: >> On new rockchip platform(rk3399 etc), there have dcf controller to >> do ddr frequency scaling, and this controller will implement in >>

[RFC PATCH 3/4] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Chanwoo Choi, I just check the devfreq-event framework code, it is good, i will do more dig to see whether it can fit for rk3399 dmc, thank you. On 2016年06月01日 19:47, Chanwoo Choi wrote: > Hi Lin, > > This patch include the two features as following: > - Monitor the ddr load > -

[RFC PATCH 3/4] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

Hi Myungloo Ham, On 2016年06月01日 18:47, MyungJoo Ham wrote: > On Wed, Jun 1, 2016 at 6:35 PM, Lin Huang wrote: >> there is dfi controller on rk3399 platform, it can monitor >> ddr load, register this controller to devfreq framework, and >> default to use simple_ondeamnd policy, and do ddr

[RFC PATCH 2/4] clk: rockchip: rk3399: add ddrc clock support

Hi Doug, On 2016年06月01日 23:46, Heiko Stübner wrote: > Am Mittwoch, 1. Juni 2016, 08:24:48 schrieb Doug Anderson: >> Lin Huang, >> >> On Wed, Jun 1, 2016 at 2:35 AM, Lin Huang wrote: >>> add ddrc clock setting, so we can do ddr frequency >>> scaling on rk3399 platform in future. >>> >>>