[PATCH v11 0/5] Fix degradation problem of alpha blending series

2024-10-08 Thread Jason-JH . Lin
ta Change in v2: Fix build error and typo Change in v1: Add fix patch for OVL unsupport color format settings by driver data --- Jason-JH.Lin (5): drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs drm/mediatek: ovl: Refine ignore_pixel_alpha comment and place

[PATCH v11 2/5] drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement

2024-10-08 Thread Jason-JH . Lin
Refine the comment for ignore_pixel_alpha flag and move it to if(state->fb) statement to make it less conditional. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 +- 1 file changed

[PATCH v11 5/5] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-10-08 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek

[PATCH v11 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-08 Thread Jason-JH . Lin
n OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 34 ++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/d

[PATCH v11 3/5] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-10-08 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH v11 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-08 Thread Jason-JH . Lin
alpha in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 89b439dcf3a6..047cd1796

[PATCH v10 0/5] Fix degradation problem of alpha blending series

2024-10-07 Thread Jason-JH . Lin
ch for OVL unsupport color format settings by driver data --- Jason-JH.Lin (5): drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement drm/mediatek: ovl: Remove the color format comment for ovl_f

[PATCH v10 5/5] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-10-07 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek

[PATCH v10 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-07 Thread Jason-JH . Lin
n OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 34 ++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/d

[PATCH v10 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-07 Thread Jason-JH . Lin
alpha in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 89b439dcf3a6..047cd1796a51 100644 --- a/d

[PATCH v10 3/5] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-10-07 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH v10 2/5] drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement

2024-10-07 Thread Jason-JH . Lin
Refine the comment for ignore_pixel_alpha flag and move it to if(state->fb) statement to make it less conditional. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 +- 1 file changed

[PATCH v9 3/5] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-10-07 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH v9 2/5] drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement

2024-10-07 Thread Jason-JH . Lin
Refine the comment for ignore_pixel_alpha flag and move it to if (state->fb) statement to make it less conditional. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/

[PATCH v9 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-07 Thread Jason-JH . Lin
SoC support the blend_modes. Make the constatnt alpha only enable when having a vliad blend_mode or setting the has_alpha to fix the downgrade issue. Fixes: bc46eb5d5d77 ("drm/mediatek: Support DRM plane alpha in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp

[PATCH v9 0/5] Fix degradation problem of alpha blending series

2024-10-07 Thread Jason-JH . Lin
5: Add fix patch for mtk_plane Change in v4: Add lost cases of mtk_ovl_fmt_convert_with_blend Change in v3: Change MACRO approach to function pointer in driver data Change in v2: Fix build error and typo Change in v1: Add fix patch for OVL unsupport color format settings by driver data --- Jason

[PATCH v9 5/5] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-10-07 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek

[PATCH v9 4/5] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-07 Thread Jason-JH . Lin
onvert() will check the blend_modes to see if premultiplied supported in current platform. If it is not supported, use coverage mode to set it to the supported color formats to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL&q

[PATCH] drm/mediatek: Fix XRGB format breakage for blend_modes unsupported SoCs

2024-10-05 Thread Jason-JH . Lin
supported blend_modes SoC to fix the downgrade issue. Fixes: bc46eb5d5d77 ("drm/mediatek: Support DRM plane alpha in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 28 +++-- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-10-01 Thread Jason Gunthorpe
>bus); I prefer we send these through the iommu tree now so we can make progress. Jason

Re: [PATCH v3 00/19] random: Resolve circular include dependency and include

2024-09-30 Thread Jason A. Donenfeld
Hi Uros, Per your plan, I took this into random.git, and we'll now see if being in next unearths some problems over the next week or two. Jason

[PATCH v8 2/3] drm/mediatek: ovl: Add blend_modes to driver data

2024-09-28 Thread Jason-JH . Lin
onvert() will check the blend_modes to see if premultiplied supported in current platform. If it is not supported, use coverage mode to set it to the supported color formats to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL&q

[PATCH v8 3/3] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-28 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek

[PATCH v8 0/3] Fix degradation problem of alpha blending series

2024-09-28 Thread Jason-JH . Lin
From: Jason-jh Lin Some SoCs not support pre-multiplied pixel formats and extending configuration of OVL pre-multiplied color formats, such as MT8173. Fix the SoC degradation problem by this sreies. --- Change in v8: Remove blend_modes for not supported pre-multiplied SoCs to fix the return

[PATCH v8 1/3] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-09-28 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH v7 1/3] drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert()

2024-09-26 Thread Jason-JH . Lin
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 ---

[PATCH v7 3/3] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-26 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek

[PATCH v7 0/3] Fix degradation problem of alpha blending series

2024-09-26 Thread Jason-JH . Lin
t cases of mtk_ovl_fmt_convert_with_blend Change in v3: Change MACRO approach to function pointer in driver data Change in v2: Fix build error and typo Change in v1: Add fix patch for OVL unsupport color format settings by driver data --- Jason-JH.Lin (3): drm/mediatek: ovl: Remove the color format c

[PATCH v7 2/3] drm/mediatek: ovl: Add blend_modes to driver data

2024-09-26 Thread Jason-JH . Lin
onvert() will check the blend_modes to see if premultiplied supported in current platform. If it is not supported, use coverage mode to set it to the supported color formats to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL&q

[PATCH v6 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-26 Thread Jason-JH . Lin
data to set the blend mode capabilities for different SoCs. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 10 ++ drivers/gpu/drm/mediatek

[PATCH v6 0/2] Fix degradation problem of alpha blending series

2024-09-26 Thread Jason-JH . Lin
in v1: Add fix patch for OVL unsupport color format settings by driver data --- Jason-JH.Lin (2): drm/mediatek: ovl: Add blend_modes to driver data drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm

[PATCH v6 1/2] drm/mediatek: ovl: Add blend_modes to driver data

2024-09-26 Thread Jason-JH . Lin
onvert() will check the blend_modes to see if premultiplied supported in current platform. If it is not supported, use coverage mode to set it to the supported color formats to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL&q

[PATCH v5 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-25 Thread Jason-JH . Lin
capabilities for different SoCs. Fixes: 4225d5d5e779 ("drm/mediatek: Support alpha blending in display driver") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek/mtk_ddp_comp.h

[PATCH v5 1/2] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-25 Thread Jason-JH . Lin
upport OVL_CON_CLRFMT_MAN, and mtk_ovl_fmt_convert is implemented for other SoCs that do not support it to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL") Signed-off-by: Jason-JH.Lin Tested-by: Alper Nebi Yasak Reviewed-by:

[PATCH v5 0/2] Fix degradation problem of alpha blending series

2024-09-25 Thread Jason-JH . Lin
From: Jason-jh Lin Some SoCs not support pre-multiplied pixel formats and extending configuration of OVL pre-multiplied color formats, such as MT8173. Fix the SoC degradation problem by this sreies. --- Change in v5: Add fix patch for mtk_plane Change in v4: Add lost cases of

[PATCH v4] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-23 Thread Jason-JH . Lin
upport OVL_CON_CLRFMT_MAN, and mtk_ovl_fmt_convert is implemented for other SoCs that do not support it to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL") Signed-off-by: Jason-JH.Lin Tested-by: Alper Nebi Yasak Reviewed-by:

[PATCH v3] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-17 Thread Jason-JH . Lin
upport OVL_CON_CLRFMT_MAN, and mtk_ovl_fmt_convert is implemented for other SoCs that do not support it to solve the degradation problem. Fixes: a3f7f7ef4bfe ("drm/mediatek: Support "Pre-multiplied" blending in OVL") Signed-off-by: Jason-JH.Lin Tested-by: Alper Nebi Yasak ---

[PATCH v2] drm/mediatek: ovl: Add fmt_support_man for MT8192 and MT8195

2024-09-15 Thread Jason-JH . Lin
iplied" blending in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 43 - 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-15 Thread Jason Gunthorpe
++--- drivers/gpu/drm/tegra/drm.c| 5 +++-- Now we have the other two but not nouveau? Jason

[PATCH] drm/mediatek: ovl: Add fmt_support_man for MT8192 and MT8195

2024-09-14 Thread Jason-JH . Lin
iplied" blending in OVL") Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 28 ++--- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index

[PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Jason Andryuk
From: Jason Andryuk Probing xen-fbfront faults in video_is_primary_device(). The passed-in struct device is NULL since xen-fbfront doesn't assign it and the memory is kzalloc()-ed. Assign fb_info->device to avoid this. This was exposed by the conversion of fb_is_primary_dev

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
hich is only supported in recent compilers (gcc-14 and > clang-20). Besides compiler support, sparse doesn't know about > __typeof_unqual__, resulting in broken type tracing and hundreds of > sparse errors with C=1 due to unknown keyword. > > So, I think we are not in a hurry and can take the slow and safe path. Okay, sure, that sounds good to me. I'll keep my eyes open for v3 in a few weeks then. Jason

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
or punt it for 6.13? Or did you have a different tree in mind for treewide changes (in which case, I'll send you an ack for the [p]random.h changes). Regards, Jason

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Jason Gunthorpe
On Thu, Sep 05, 2024 at 12:26:31PM -0400, Lyude Paul wrote: > I did take the one patch - but I'm happy to push the others to drm-misc > (provided they all get reviewed. 2/3 seems to be reviewed already but not 3/3) The whole series is acked now, can you pick it up please? Thanks, Jason

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-05 Thread Jason Gunthorpe
On Wed, Sep 04, 2024 at 03:06:07PM -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > Will handle pushing it to drm-misc in just a moment Did you just take this one patch? Who will take the rest of the series for DRM? Jason

Re: [PATCH 1/2] ARM: dma-mapping: Pass device to arm_iommu_create_mapping()

2024-09-04 Thread Jason Gunthorpe
k I did it right, though it has been a decade since I last did this.. Regards, Jason

[PATCH v3 2/2] drm/mediatek: change config_lock from spin_lock to spin_lock_irqsave

2024-08-27 Thread Jason-JH.Lin via B4 Relay
From: "Jason-JH.Lin" Operations within spin_locks are limited to fast memory access and confirmation of minimum lock duration. Although using spin_lock with config_lock seems to ensure shorter hold times, it is safer to use spin_lock_irqsave due to potential deadlocks and nested

[PATCH v3 1/2] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-08-27 Thread Jason-JH.Lin via B4 Relay
From: "Jason-JH.Lin" In mtk_crtc_ddp_config(), mtk_crtc will use some configuration flags to generate instructions to cmdq_handle, such as: state->pending_config mtk_crtc->pending_planes plane_state->pending.config mtk_crtc->pending_async_planes plane_state->pe

[PATCH v3 0/2] Fix missing configuration flags in mtk_crtc_ddp_config

2024-08-27 Thread Jason-JH.Lin via B4 Relay
Signed-off-by: Jason-JH.Lin --- Change in v3: Change config_lock from spin_lock to spin_lock_irqsave Change in v2: Add spin_lock protection for config_updating flag. --- Jason-JH.Lin (2): drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config() drm/mediatek: change

[PATCH v2] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-08-19 Thread Jason-JH.Lin via B4 Relay
From: "Jason-JH.Lin" In mtk_crtc_ddp_config(), mtk_crtc will use some configuration flags to generate instructions to cmdq_handle, such as: state->pending_config mtk_crtc->pending_planes plane_state->pending.config mtk_crtc->pending_async_planes plane_state->pe

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-17 Thread Jason Gunthorpe
;struct device_driver', it is different. I did literally mean struct device_driver. Jason

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-16 Thread Jason Gunthorpe
On Sun, Jul 14, 2024 at 10:18:12AM +, Omer Shpigelman wrote: > On 7/12/24 16:08, Jason Gunthorpe wrote: > > [You don't often get email from j...@ziepe.ca. Learn why this is important > > at https://aka.ms/LearnAboutSenderIdentification ] > > > > On Fri, Jun 28

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-12 Thread Jason Gunthorpe
used notifier chains for this kind of stuff though. Jason

Re: [PATCH v3 00/21] iommu: Refactoring domain allocation interface

2024-07-08 Thread Jason Gunthorpe
c/3b10f25704be > [15/21] iommu/vt-d: Add helper to allocate paging domain > https://git.kernel.org/iommu/c/9e9ba576c259 Great, Lu can you please split the remaining by subsystem and try to get them to go through subsystem trees? Joerg can take the leftovers at rc6/7 or something like that so we can finish this. I think this is enough that Intel and AMD could now assert that dev is non-null? Jason

[PATCH] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-07-03 Thread Jason-JH . Lin
t the beginning of mtk_crtc_update_config() to ensure that these configuration flags won't be changed when the mtk_crtc_ddp_config() is preparing instructions. Fixes: 7f82d9c43879 ("drm/mediatek: Clear pending flag when cmdq packet is done") Signed-off-by: Jason-JH.Lin --- drivers

[PATCH] drm/mediatek: Fix bit depth overwritten for mtk_ovl_set bit_depth()

2024-06-24 Thread Jason-JH . Lin
Refine the value and mask define of bit depth for mtk_ovl_set bit_depth(). Use cmdq_pkt_write_mask() instead of cmdq_pkt_write() to avoid bit depth settings being overwritten. Fixes: fb36c5020c9c ("drm/mediatek: Add support for AR30 and BA30 overlays") Signed-off-by: Jason-JH.Lin --

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-19 Thread Jason Gunthorpe
backs as __always_inline then the compiler should generate the same code as today for arm_lpae_iova_to_phys(). Jason

Re: [PATCH v3 21/21] iommu: Remove iommu_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
g in the way of that. > > Signed-off-by: Lu Baolu > --- > include/linux/iommu.h | 6 -- > drivers/iommu/iommu.c | 36 > 2 files changed, 42 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 20/21] iommu: Remove iommu_present()

2024-06-19 Thread Jason Gunthorpe
> 2 files changed, 31 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 18/21] drm/rockchip: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
mmu_paging_domain_alloc() to retire the former. > > Signed-off-by: Lu Baolu > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 17/21] ARM: dma-mapping: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 15/21] iommu/vt-d: Add helper to allocate paging domain

2024-06-19 Thread Jason Gunthorpe
oid using > iommu_domain_alloc(). > > Signed-off-by: Lu Baolu > --- > drivers/iommu/intel/iommu.c | 87 + > 1 file changed, 78 insertions(+), 9 deletions(-) It seems Ok, but I have some small thoughts Reviewed-by: Jason Gunthorpe > diff --git a

Re: [PATCH v3 13/21] soc/fsl/qbman: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
fsl/qbman/qman_portal.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 12/21] remoteproc: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
-- > drivers/remoteproc/remoteproc_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 11/21] wifi: ath11k: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
; Acked-by: Jeff Johnson > --- > drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 10/21] wifi: ath10k: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
son > --- > drivers/net/wireless/ath/ath10k/snoc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 00/21] iommu: Refactoring domain allocation interface

2024-06-19 Thread Jason Gunthorpe
st I suggest Lu can send patches to the subsystem trees and hope the maintainers merge them. At v6.11-rc5 we declare the remainder unmaintained and you take anything that hasn't been merged so we can finish the iommu core work. Thanks, Jason

Re: [PATCH v3 09/21] media: venus: firmware: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
edia/platform/qcom/venus/firmware.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 08/21] media: nvidia: tegra: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
tegra-vde/iommu.c | 7 --- > 1 file changed, 4 insertions(+), 3 Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 07/21] gpu: host1x: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
> 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 04/21] vhost-vdpa: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
On Mon, Jun 10, 2024 at 04:55:38PM +0800, Lu Baolu wrote: > Replace iommu_domain_alloc() with iommu_paging_domain_alloc(). > > Signed-off-by: Lu Baolu > --- > drivers/vhost/vdpa.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 03/21] vfio/type1: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
On Mon, Jun 10, 2024 at 04:55:37PM +0800, Lu Baolu wrote: > Replace iommu_domain_alloc() with iommu_paging_domain_alloc(). > > Signed-off-by: Lu Baolu > --- > drivers/vfio/vfio_iommu_type1.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 02/21] iommufd: Use iommu_paging_domain_alloc()

2024-06-19 Thread Jason Gunthorpe
t; device pointer along the path. > > Signed-off-by: Lu Baolu > --- > drivers/iommu/iommufd/hw_pagetable.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH v3 01/21] iommu: Add iommu_paging_domain_alloc() interface

2024-06-19 Thread Jason Gunthorpe
igned-off-by: Lu Baolu > --- > include/linux/iommu.h | 6 ++ > drivers/iommu/iommu.c | 20 ++++ > 2 files changed, 26 insertions(+) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-17 Thread Jason Gunthorpe
e said. I'd post the RDMA series assuming that the basic ethernet driver is merged. You don't need to combine basic ethernet with rdma in the same series. Jason

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-12 Thread Jason Gunthorpe
have struct pages. All it says is that the memory is alive according to dmabuf refcounting rules. And the importer obviously don't get to touch the underlying folios, if any. Jason

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-10 Thread Jason Gunthorpe
ecycle. As HCH pushes for pages either come from the allocator and get to use the struct folio or the come from a dmabuf and they don't. That is it, the only two choices. The iouring stuff is trying to confuse the source of the pages with the lifecycle - which is surely convenient, but is why Christoph is opposing it. Jason

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-10 Thread Jason Gunthorpe
On Mon, Jun 10, 2024 at 02:07:01AM +0100, Pavel Begunkov wrote: > On 6/10/24 01:37, David Wei wrote: > > On 2024-06-07 17:52, Jason Gunthorpe wrote: > > > IMHO it seems to compose poorly if you can only use the io_uring > > > lifecycle model with io_uring registered

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Jason Gunthorpe
nds like having a different source of the pages is the less important part. IMHO it seems to compose poorly if you can only use the io_uring lifecycle model with io_uring registered memory, and not with DMABUF memory registered through Mina's mechanism. Jason

Re: [PATCH v2 02/22] iommufd: Use iommu_user_domain_alloc()

2024-06-05 Thread Jason Gunthorpe
On Wed, Jun 05, 2024 at 10:17:07AM +0800, Baolu Lu wrote: > On 6/5/24 12:51 AM, Jason Gunthorpe wrote: > > On Tue, Jun 04, 2024 at 09:51:14AM +0800, Lu Baolu wrote: > > > Replace iommu_domain_alloc() with iommu_user_domain_alloc(). > > > > > > Signed-off-by:

Re: [PATCH v2 02/22] iommufd: Use iommu_user_domain_alloc()

2024-06-04 Thread Jason Gunthorpe
rovided. I'm not sure there is value in having vfio and vdpa call this variation since they won't pass a user_data or flags? Do you imagine there will ever be a difference between what domain_alloc_user(dev, 0, NULL, NULL) returns from domain_alloc_paging(dev) ? That seems like questionable driver behavior to me. Jason

Re: [PATCH v2 15/22] RDMA/usnic: Use iommu_paging_domain_alloc()

2024-06-04 Thread Jason Gunthorpe
> > Signed-off-by: Lu Baolu > --- > drivers/infiniband/hw/usnic/usnic_uiom.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Jason Gunthorpe Jason

Re: [PATCH net-next v10 05/14] netdev: netdevice devmem allocator

2024-06-04 Thread Jason Gunthorpe
line to functions that are static and used only once is always a win since there is no space tradeoff. While this is technically correct, gcc is capable of inlining these automatically without help, and the maintenance issue of removing the inline when a second user appears outweighs the potential value of the hint that tells gcc to do something it would have done anyway. Jason

Re: [PATCH 00/20] iommu: Refactoring domain allocation interface

2024-06-03 Thread Jason Gunthorpe
; > > for their usage. But new drivers should not use it anymore. > > > > does it mean there is still domains allocated via iommu_domain_alloc() > > on VT-d platform? > > I think the drivers mentioned above do not run on x86 platforms, or do > they? usnic does.. What was preventing converting it? Jason

[PATCH RESEND, v6 4/8] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler

2024-05-26 Thread Jason-JH . Lin
executes to the end of command(EOC) instruction. If the CMDQ packet is a loopping command, GCE irq handler can not delete the CMDQ task and disable the GCE thread. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++ include/linux

[PATCH RESEND, v6 8/8] soc: mediatek: mtk-cmdq: Add secure cmdq_pkt APIs

2024-05-26 Thread Jason-JH . Lin
handle. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-cmdq-helper.c | 155 + include/linux/soc/mediatek/mtk-cmdq.h | 71 +++ 2 files changed, 226 insertions(+) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers

[PATCH RESEND, v6 7/8] mailbox: mediatek: Add secure CMDQ driver support for CMDQ driver

2024-05-26 Thread Jason-JH . Lin
: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/mailbox/mtk-cmdq-mailbox.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 025e53549a45..5c606684b07b 100644 --- a/drivers

[PATCH RESEND, v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-26 Thread Jason-JH . Lin
will be set when GCE runs to the end of secure cmdq packet in the secure world. This can reduce the latency of software communication between normal world and secure world. In addition, we can also remove the complex logic after the secure packet done in the secure world. Signed-off-by: Jason

[PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-05-26 Thread Jason-JH . Lin
buffer instead of copying normal command buffer to IWC shared memory. 4. Use SOFTDEP to make cmdq_sec_probe later than OPTEE loaded and then move cmdq_sec_session_init into cmdq_sec_probe(). 5. Remove timeout detection in cmdq_sec_session_send(). Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao

[PATCH RESEND, v6 5/8] mailbox: mediatek: Move reuseable definition to header for secure driver

2024-05-26 Thread Jason-JH . Lin
parameter. That may occur a build error if secure driver header includes the mtk-cmdq-mailbox.h. - function: e.g. cmdq_get_shift_pa(struct mbox_chan *chan). Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/mailbox/mtk-cmdq-mailbox.c | 30 - inclu

[PATCH RESEND, v6 1/8] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id

2024-05-26 Thread Jason-JH . Lin
each cmdq secure pkt. It is used as a secure irq to notify CMDQ driver in the normal world that GCE secure thread has completed a secure cmd buffer in thee secure world. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- include/dt-bindings/gce/mt8195-gce.h | 6 ++ 1 file changed

[PATCH RESEND, v6 3/8] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation

2024-05-26 Thread Jason-JH . Lin
. If there are any overflows, GCE will sent the invalid IRQ to notify CMDQ driver. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-cmdq-helper.c | 36 ++ include/linux/soc/mediatek/mtk-cmdq.h | 42 ++ 2 files

[PATCH RESEND,v6 0/8] Add CMDQ secure driver for SVP

2024-05-26 Thread Jason-JH . Lin
From: Jason-jh Lin For the Secure Video Path (SVP) feature, inculding the memory stored secure video content, the registers of display HW pipeline and the HW configure operations are required to execute in the secure world. So using a CMDQ secure driver to make all display HW registers

[PATCH v6 0/7] Add mediate-drm secure flow for SVP

2024-05-25 Thread Jason-JH . Lin
From: Jason-jh Lin Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/userspace). secure handle - Integer value which acts as reference to 'secure memory'

[PATCH v6 3/7] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2024-05-25 Thread Jason-JH . Lin
() after we change the ioctl to DMA_HEAP_IOCTL_ALLOC. 2. Checking the private data of dmabuf instead of strncmp the exp_name. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- drivers/gpu/drm/mediatek/mtk_gem.c | 85

[PATCH v6 7/7] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2024-05-25 Thread Jason-JH . Lin
in a shared memory, CMDQ driver in the normal world can use it to handle task done in irq handler and CMDQ driver in the secure world will use it to schedule the task slot for each secure thread. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c

[PATCH v6 2/7] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_RESTRICTED flag

2024-05-25 Thread Jason-JH . Lin
feature. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- include/uapi/drm/mediatek_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/drm/mediatek_drm.h b/include/uapi/drm/mediatek_drm.h index 821f7a732365..dee581718d70 100644 --- a/include/uapi/drm

[PATCH v6 5/7] drm/mediatek: Add mtk_ddp_sec_write() to config secure buffer info

2024-05-25 Thread Jason-JH . Lin
buffer information will be used to translate the secure handle to the curresponding secure buffer address and then the secure handle in instruction generated by OVL or OVL_ADPATOR will be replaced to the real address in secure world. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung

[PATCH v6 4/7] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane

2024-05-25 Thread Jason-JH . Lin
Add is_sec flag to identify current mtk_drm_plane is secure. Add mtk_plane_is_sec_fb() to check current drm_framebuffer is secure. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_plane.c | 18 ++ drivers/gpu/drm/mediatek/mtk_plane.h

[PATCH v6 6/7] drm/mediatek: Add secure flow support to mediatek-drm

2024-05-25 Thread Jason-JH . Lin
to the normal flow. TODO: 1. Try to use secure mailbox channel to handle normal and secure flow. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 260 +-- drivers/gpu/drm/mediatek/mtk_crtc.h | 1 + drivers/gpu/drm

  1   2   3   4   5   6   7   8   9   10   >