On 2021-11-24 23:32, Dmitry Baryshkov wrote:
On 04/05/2021 07:35, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-21 16:37:38)
Add checking aux read/write status at both dp_link_parse_sink_count()
and dp_link_parse_sink_status_filed() to avoid long timeout delay if
s/filed/field/
dp aux r
On 2021-11-09 13:38, Kuogee Hsieh wrote:
From: Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped
together within a function and executed not in a symmetric manner.
This increase difficulty of code maintenance and limited code
scalability.
This patch divided the
On 2021-11-09 10:04, Douglas Anderson wrote:
If you happened to try to access `/dev/drm_dp_aux` devices provided by
the MSM DP AUX driver too early at bootup you could go boom. Let's
avoid that by only allowing AUX transfers when the controller is
powered up.
Specifically the crash that was seen
On 2021-10-27 23:38, Stephen Boyd wrote:
Quoting Sankeerth Billakanti (2021-10-27 18:54:48)
DP driver needs a 10 second delay before phy_init so that
the usb combo phy initializes and sets up the necessary
clocks for usb devices such as keyboard and mouse.
eDP controller uses a standalone phy a
On 2021-10-21 11:44, Stephen Boyd wrote:
Quoting Krishna Manikandan (2021-10-20 06:58:53)
From: Sankeerth Billakanti
Add edp controller and phy DT nodes for sc7280.
Signed-off-by: Sankeerth Billakanti
Signed-off-by: Krishna Manikandan
Some comments below
Reviewed-by: Stephen Boyd
Ch
On 2021-10-08 09:44, Bjorn Andersson wrote:
On Fri 08 Oct 09:07 PDT 2021, khs...@codeaurora.org wrote:
On 2021-10-07 15:34, Stephen Boyd wrote:
> Quoting khs...@codeaurora.org (2021-10-07 13:28:12)
> > On 2021-10-07 13:06, Bjorn Andersson wrote:
> > > On Thu 07 Oct 12:51 PDT 2021, khs...@codeau
On 2021-10-07 15:34, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-10-07 13:28:12)
On 2021-10-07 13:06, Bjorn Andersson wrote:
> On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote:
>
>> On 2021-10-06 10:31, Bjorn Andersson wrote:
>> > On Wed 06 Oct 08:37 PDT 2021, khs...@codeaur
On 2021-10-07 13:06, Bjorn Andersson wrote:
On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote:
On 2021-10-06 10:31, Bjorn Andersson wrote:
> On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote:
>
> > On 2021-10-05 19:10, Bjorn Andersson wrote:
> > > On Tue 05 Oct 16:04 PDT 2021, k
On 2021-10-06 10:31, Bjorn Andersson wrote:
On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote:
On 2021-10-05 19:10, Bjorn Andersson wrote:
> On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote:
>
> > On 2021-10-05 15:36, Stephen Boyd wrote:
> > > Quoting Bjorn Andersson (2021-10-0
On 2021-10-05 19:10, Bjorn Andersson wrote:
On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote:
On 2021-10-05 15:36, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-10-05 14:40:38)
> > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote:
> >
> > > Quoting Bjorn Andersson (2021-10-04 19:
On 2021-10-05 15:36, Stephen Boyd wrote:
Quoting Bjorn Andersson (2021-10-05 14:40:38)
On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-10-04 19:37:50)
> > Found in the middle of a patch from Sankeerth was the reduction of the
> > INIT_SETUP timeout from 10s to
On 2021-08-27 10:14, Bjorn Andersson wrote:
On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote:
Quoting Bjorn Andersson (2021-08-25 16:42:31)
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
> index 2c7de43f655a..4a6132c18e57 100644
> --- a/drivers/gpu/drm
On 2021-08-30 09:58, Lyude Paul wrote:
On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote:
On 2021-08-25 09:26, Lyude Paul wrote:
> The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems
> like it
> just hasn't trickled down to linus's branch quite yet.
Hi Stephen B,
On 2021-08-25 09:26, Lyude Paul wrote:
The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems
like it
just hasn't trickled down to linus's branch quite yet.
Hi Stephen B,
Would you mind back porting this patch to V5.10 branch?
It will have lots of helps for us to support displ
On 2021-07-27 15:44, Lyude Paul wrote:
Nice timing, you literally got me as I was 2 minutes away from leaving
work
for the day :P. I will go ahead and push it now.
Hi Lyude,
Had you pushed this patch yet?
We still did not see this patch at msm-nex and v5.10 branch.
Thanks,
BTW - in the futu
On 2021-08-10 12:23, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-08-10 12:18:02)
On 2021-08-10 11:33, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-08-10 08:29:22)
>> Changes in V2:
>> -- correct Fixes text
>> -- drop commit text
>>
>> Fixes: 601f0479c583 ("drm/msm/dp: add logs ac
On 2021-08-10 11:33, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-08-10 08:29:22)
Changes in V2:
-- correct Fixes text
-- drop commit text
Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease
of debugging")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.
On 2021-08-03 12:05, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-08-03 09:25:13)
Currently at dp_pm_resume() is_connected state is decided base on hpd
connection
status only. This will put is_connected in wrongly "true" state at the
scenario
that dongle attached to DUT but without hmdi cable
On 2021-07-30 11:57, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-28 14:30:54)
Currently at dp_pm_resume() is_connected state is decided base on hpd
connection
status only. This will put is_connected in wrongly "true" state at the
scenario
that dongle attached to DUT but without hmdi cable
On 2021-07-22 12:23, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-13 08:54:05)
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c
b/drivers/gpu/drm/msm/dp/dp_panel.c
index 88196f7..0fdb551 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -303,7 +303,12
On 2021-07-27 12:21, Lyude Paul wrote:
On Thu, 2021-07-22 at 15:28 -0700, khs...@codeaurora.org wrote:
It looks like this patch is good to go (mainlined).
Anything needed from me to do?
Thanks,
Do you have access for pushing this patch? If not let me know and I can
go
ahead and push it to d
On 2021-07-22 10:53, Lyude Paul wrote:
On Tue, 2021-07-13 at 15:24 -0700, khs...@codeaurora.org wrote:
On 2021-07-07 01:37, Jani Nikula wrote:
> On Tue, 06 Jul 2021, Kuogee Hsieh wrote:
> > From: Rajkumar Subbiah
> >
> > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
> >
On 2021-07-07 01:37, Jani Nikula wrote:
On Tue, 06 Jul 2021, Kuogee Hsieh wrote:
From: Rajkumar Subbiah
Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
selftests") added some debug code for sideband message tracing. But
it seems to have unintentionally changed the behavi
On 2021-07-08 00:14, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-06 10:20:18)
Response with correct edid checksum saved at connector after corrupted
edid
checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_panel.c |
On 2021-07-08 00:33, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-06 10:20:15)
Reduce link rate and re start link training if link training 1
failed due to loss of clock recovery done to fix Link Layer
CTS case 4.3.1.7. Also only update voltage and pre-emphasis
swing level after link train
On 2021-07-08 00:21, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-06 10:20:20)
Main link symbol locked is achieved at end of link training 2. Some
dongle main link symbol may become unlocked again if host did not end
link training soon enough after completion of link training 2. Host
have t
On 2021-07-08 00:34, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-06 10:20:16)
Aux hardware calibration sequence requires resetting the aux
controller
in order for the new setting to take effect. However resetting the AUX
controller will also clear HPD interrupt status which may accidental
On 2021-07-08 00:03, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-07-06 10:20:14)
DP cable should always connect to DPU during the entire PHY compliance
testing run. Since DP PHY compliance test is executed at irq_hpd event
context, dp_ctrl_off_link_stream() should be used instead of
dp_ctrl_
On 2021-06-01 19:00, Stephen Boyd wrote:
Please add dri-devel@lists.freedesktop.org next time
Quoting Kuogee Hsieh (2021-06-01 16:50:08)
Normal DP suspend operation contains two steps, display off followed
by dp suspend, to complete system wide suspending cycle if display is
up at that time. In
On 2021-05-07 14:25, Stephen Boyd wrote:
Let's look at the irq status bits after a transfer and see if we got a
nack or a defer or a timeout, instead of telling drm layers that
everything was fine, while still printing an error message. I wasn't
sure about NACK+DEFER so I lumped all those various
On 2021-05-24 12:19, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-05-24 09:33:49)
On 2021-05-07 14:25, Stephen Boyd wrote:
> @@ -367,36 +347,38 @@ static ssize_t dp_aux_transfer(struct drm_dp_aux
> *dp_aux,
> }
>
> ret = dp_aux_cmd_fifo_tx(aux, msg);
> -
> if (ret <
On 2021-05-07 14:25, Stephen Boyd wrote:
Let's look at the irq status bits after a transfer and see if we got a
nack or a defer or a timeout, instead of telling drm layers that
everything was fine, while still printing an error message. I wasn't
sure about NACK+DEFER so I lumped all those various
On 2021-05-07 14:25, Stephen Boyd wrote:
We don't need to hold the lock to inspect the message we're going to
transfer, and we don't need to clear the busy flag either. Take the
lock
later and bail out earlier if conditions aren't met.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
On 2021-05-07 14:25, Stephen Boyd wrote:
We don't need to stash away 'isr' in the aux structure to pass to two
functions. Let's use a local variable instead. And we can complete the
completion variable in one place instead of two to simplify the code.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc:
On 2021-05-21 14:57, Stephen Boyd wrote:
Quoting Stephen Boyd (2021-05-07 14:25:02)
Here's a few patches that simplify the aux handling code and bubble up
timeouts and nacks to the upper DRM layers. The goal is to get DRM to
know that the other side isn't there or that there's been a timeout,
in
On 2021-04-29 20:11, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-04-29 10:23:31)
On 2021-04-29 02:26, Stephen Boyd wrote:
> Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
>> On 2021-04-27 17:00, Stephen Boyd wrote:
>> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
>> >>
On 2021-04-29 02:26, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
On 2021-04-27 17:00, Stephen Boyd wrote:
> Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
>> On 2021-04-21 10:26, khs...@codeaurora.org wrote:
>> >>
>> >>> +
>> >>> mutex_unlock(&dp->event
On 2021-04-27 17:00, Stephen Boyd wrote:
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
On 2021-04-21 10:26, khs...@codeaurora.org wrote:
>>
>>> +
>>> mutex_unlock(&dp->event_mutex);
>>>
>>> return 0;
>>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp,
On 2021-04-20 16:38, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-16 10:38:51)
Maybe when the cable is disconnected the DP phy should be shutdown and
some bit in the phy could effectively "cut off" the aux channel and
then
NAKs would start coming through here in the DP controller I/O regi
On 2021-04-20 15:01, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-16 13:27:57)
Some dongle may generate more than one irq_hpd events in a short
period of
time. This patch will treat those irq_hpd events as single one and
service
only one irq_hpd event.
Why is it bad to get multiple irq_
On 2021-04-15 13:06, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-04-15 10:37:29)
On 2021-04-14 14:09, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-04-13 16:11:44)
>> Make sure main link is in connection state before start aux
>> read/write operation to avoid unnecessary long dela
On 2021-04-14 14:22, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-14 14:02:50)
Initialize audio_comp when audio starts and wait for audio_comp at
dp_display_disable(). This will take care of both dongle unplugged
and display off (suspend) cases.
Changes in v2:
-- add dp_display_start_audio
On 2021-04-14 14:09, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-13 16:11:44)
Make sure main link is in connection state before start aux
read/write operation to avoid unnecessary long delay due to
main link had been unplugged.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_a
On 2021-04-13 20:17, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-04-13 16:11:30)
At dongle unplug, dp initializes audio_comp followed by sending
disconnect
event notification to audio and to make sure audio had shutdown
completely
by wait for audio completion notification at display_disable(
On 2021-02-22 08:55, Sean Paul wrote:
On Mon, Feb 22, 2021 at 11:31 AM wrote:
On 2021-02-19 14:46, Stephen Boyd wrote:
> Quoting khs...@codeaurora.org (2021-02-19 08:39:38)
>> On 2021-02-18 15:02, Stephen Boyd wrote:
>> > Quoting Kuogee Hsieh (2021-02-18 12:55:04)
>> >> Allow supported link ra
On 2021-02-19 14:46, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-02-19 08:39:38)
On 2021-02-18 15:02, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-02-18 12:55:04)
>> Allow supported link rate to be limited to the value specified at
>> dtsi. If it is not specified, then link rate
On 2021-02-18 15:02, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-02-18 12:55:04)
Allow supported link rate to be limited to the value specified at
dtsi. If it is not specified, then link rate is derived from dpcd
directly. Below are examples,
link-rate = <162000> for max link rate limited at
On 2021-01-13 16:00, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-01-13 15:44:32)
On 2021-01-13 12:22, Stephen Boyd wrote:
> Quoting khs...@codeaurora.org (2021-01-13 09:44:24)
>> On 2021-01-11 11:55, Stephen Boyd wrote:
>> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
>> >> irq_hpd ev
On 2021-01-13 12:23, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-01-13 09:48:25)
On 2021-01-11 11:54, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-01-07 12:30:25)
>> There is HPD unplug interrupts missed at scenario of an irq_hpd
>> followed by unplug interrupts with around 10 ms
On 2021-01-13 12:22, Stephen Boyd wrote:
Quoting khs...@codeaurora.org (2021-01-13 09:44:24)
On 2021-01-11 11:55, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-01-07 12:30:24)
>> irq_hpd event can only be executed at connected state. Therefore
>> irq_hpd event should be postponed if it happen
On 2021-01-11 11:55, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-01-07 12:30:24)
irq_hpd event can only be executed at connected state. Therefore
irq_hpd event should be postponed if it happened at connection
pending state. This patch also make sure both link rate and lane
Why does it happe
On 2021-01-13 12:25, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-01-13 10:59:58)
Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
Therefore irq_hpd handler should not issues either aux or sw reset
to avoid following unplug interrupt be cleared accidentally.
Kuogee Hsieh (2):
On 2021-01-11 11:54, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-01-07 12:30:25)
There is HPD unplug interrupts missed at scenario of an irq_hpd
followed by unplug interrupts with around 10 ms in between.
Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts,
irq_hpd handler sh
On 2020-11-02 12:59, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-10-30 16:22:53)
DP compo phy have to be enable to start link training. When
link training failed phy need to be disabled so that next
link trainng can be proceed smoothly at next plug in. This
s/trainng/training/
patch de in
On 2020-11-02 11:29, Stephen Boyd wrote:
Subject has a typo in "training".
Quoting Kuogee Hsieh (2020-10-30 16:23:24)
Some dongles, such as Apple, required link training done at irq_hpd
s/required/require/
request instead of plugin request. This patch promote irq_hpd hanlder
s/hanlder/han
On 2020-10-20 15:15, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-10-20 09:59:59)
No need to check LINK_STATuS_UPDATED bit before
LINK_STATUS_UPDATED?
return 6 bytes of link status during link training.
Why?
This patch also fix phy compliance test link rate
conversion error.
How?
On 2020-10-06 00:31, Rajendra Nayak wrote:
On 10/4/2020 3:56 AM, Kuogee Hsieh wrote:
Set link rate by using OPP set rate api so that CX level will be set
accordingly based on the link rate.
Changes in v2:
-- remove dev from dp_ctrl_put() parameters
-- address review comments
This needs to go
On 2020-10-02 19:12, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-10-02 15:09:19)
Connection state is set incorrectly happen at either failure of link
train
or cable plugged in while suspended. This patch fixes these problems.
This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF.
S
On 2020-09-30 09:24, Rajendra Nayak wrote:
On 9/30/2020 1:54 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-09-29 10:10:26)
Set link rate by using OPP set rate api so that CX level will be set
accordingly base on the link rate.
s/base/based/
Signed-off-by: Kuogee Hsieh
---
diff --git
On 2020-09-17 15:44, Stephen Boyd wrote:
We shouldn't be waiting for an event here with a timeout of 100ms when
we're not in the 'timeout' arm of the if condition. Instead we should
be
sleeping in the interruptible state (S) until something happens and we
need to wakeup. Right now this kthread
On 2020-08-18 14:59, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-08-18 14:15:46)
add event thread to execute events serially from event queue. Also
timeout mode is supported which allow an event be deferred to be
executed at later time. Both link and phy compliant tests had been
done success
On 2020-07-20 19:57, Rob Clark wrote:
On Mon, Jul 20, 2020 at 4:32 PM Stephen Boyd
wrote:
Quoting khs...@codeaurora.org (2020-07-20 15:48:13)
> On 2020-07-20 13:18, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2020-07-07 11:41:25)
> >> drivers/gpu/drm/msm/dp/dp_power.c | 32 +-
> >
On 2020-07-20 13:18, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2020-07-07 11:41:25)
add event thread to execute events serially from event queue. Also
timeout mode is supported which allow an event be deferred to be
executed at later time. Both link and phy compliant tests had been
done success
63 matches
Mail list logo
